On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote:
Instead of having DPU-specific defines, switch to the definitions from
the mdp_common.xml.h file. This is the preparation for merged of DPU and
MDP format tables.
Adding MDP_***__ usages in DPU driver is quite confusing.
Can we align to a
(+)
Reviewed-by: Abhinav Kumar
file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Abhinav Kumar
,
Reviewed-by: Abhinav Kumar
On 4/5/2024 11:15 AM, Dmitry Baryshkov wrote:
On Fri, 5 Apr 2024 at 20:35, Abhinav Kumar wrote:
On 3/9/2024 7:09 AM, Dmitry Baryshkov wrote:
Currently the MSM DSI driver looks for the next bridge during
msm_dsi_modeset_init(). If the bridge is not registered at that point,
this might
On 3/28/2024 7:40 AM, Bjorn Andersson wrote:
From: Bjorn Andersson
The dp_audio read and write operations uses members in struct dp_catalog
for passing arguments and return values. This adds unnecessary
complexity to the implementation, as it turns out after detangling the
logic that no
On 4/8/2024 2:12 PM, Dmitry Baryshkov wrote:
On Mon, 8 Apr 2024 at 22:43, Abhinav Kumar wrote:
On 4/7/2024 11:48 AM, Bjorn Andersson wrote:
On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote:
From: Kuogee Hsieh
[..]
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
b
On 4/8/2024 2:13 PM, Dmitry Baryshkov wrote:
On Tue, 9 Apr 2024 at 00:08, Abhinav Kumar wrote:
On 4/8/2024 1:41 PM, Bjorn Andersson wrote:
On Mon, Apr 08, 2024 at 12:43:34PM -0700, Abhinav Kumar wrote:
On 4/7/2024 11:48 AM, Bjorn Andersson wrote:
On Fri, Apr 05, 2024 at 08:15:47PM
On 4/8/2024 1:41 PM, Bjorn Andersson wrote:
On Mon, Apr 08, 2024 at 12:43:34PM -0700, Abhinav Kumar wrote:
On 4/7/2024 11:48 AM, Bjorn Andersson wrote:
On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote:
From: Kuogee Hsieh
[..]
diff --git a/drivers/gpu/drm/msm/dp
On 4/7/2024 11:48 AM, Bjorn Andersson wrote:
On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote:
From: Kuogee Hsieh
[..]
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
b/drivers/gpu/drm/msm/dp/dp_display.c
index d80f89581760..bfb6dfff27e8 100644
--- a/drivers/gpu/drm/msm/dp
Hi Helen
Gentle reminder on this.
If you are okay, we can land it via msm-next tree...
Thanks
Abhinav
On 4/1/2024 1:48 PM, Abhinav Kumar wrote:
After IGT migrating to dynamic sub-tests, the pipe prefixes
in the expected fails list are incorrect. Lets drop those
to accurately match
On 4/8/2024 1:55 AM, Aleksandr Mishin wrote:
In dpu_core_irq_callback_handler() callback function pointer is compared to
NULL,
but then callback function is unconditionally called by this pointer.
Fix this bug by adding conditional return.
Found by Linux Verification Center
- Fix the subject a little as well
Fixes: 542b37efc20e ("drm/msm/dp: Implement hpd_notify()")
Signed-off-by: Kuogee Hsieh
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/
consistently.
changes in v2:
- Fix the commit message to explain the scenario
- Fix the subject a little as well
Fixes: 542b37efc20e ("drm/msm/dp: Implement hpd_notify()")
Signed-off-by: Kuogee Hsieh
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_dis
On 3/28/2024 10:47 PM, Abhinav Kumar wrote:
On 3/28/2024 8:23 PM, Dmitry Baryshkov wrote:
On Fri, 29 Mar 2024 at 04:16, Abhinav Kumar
wrote:
On 3/28/2024 5:10 PM, Dmitry Baryshkov wrote:
On Fri, 29 Mar 2024 at 01:42, Abhinav Kumar
wrote:
On 3/28/2024 3:50 PM, Dmitry Baryshkov
ode
https://gitlab.freedesktop.org/drm/msm/-/commit/be1b7acb9291
Best regards,
--
Abhinav Kumar
On Wed, 06 Mar 2024 11:35:15 -0800, Abhinav Kumar wrote:
> Fix the typo in the name of dp_display_handle_port_status_changed().
>
>
Applied, thanks!
[1/1] drm/msm/dp: fix typo in dp_display_handle_port_status_changed()
(no commit info)
https://gitlab.freedesktop.or
e
> sense.
>
>
Applied, thanks!
[1/1] drm/msm/dpu: make error messages at dpu_core_irq_register_callback() more
sensible
https://gitlab.freedesktop.org/drm/msm/-/commit/8844f467d6a5
Best regards,
--
Abhinav Kumar
sm/-/commit/ee15c8bf5d77
Best regards,
--
Abhinav Kumar
cted
> value directly.
>
> [1] https://patchwork.freedesktop.org/series/119552/#rev2
>
> [...]
Applied, thanks!
[1/5] drm/msm/dpu: don't allow overriding data from catalog
https://gitlab.freedesktop.org/drm/msm/-/commit/4f3b77ae5ff5
Best regards,
--
Abhinav Kumar
but I missed that while migrating to drm_dbg wrappers.
>
>
Applied, thanks!
[1/1] drm/msm: Add newlines to some debug prints
https://gitlab.freedesktop.org/drm/msm/-/commit/c588f7d67044
Best regards,
--
Abhinav Kumar
sm/-/commit/e86750b01a15
Best regards,
--
Abhinav Kumar
On 4/5/2024 11:19 AM, Dmitry Baryshkov wrote:
On Fri, 5 Apr 2024 at 21:17, Abhinav Kumar wrote:
On 4/5/2024 11:16 AM, Dmitry Baryshkov wrote:
On Fri, 5 Apr 2024 at 20:20, Abhinav Kumar wrote:
On 3/9/2024 7:09 AM, Dmitry Baryshkov wrote:
All the bridges that are being used
On 4/5/2024 11:16 AM, Dmitry Baryshkov wrote:
On Fri, 5 Apr 2024 at 20:20, Abhinav Kumar wrote:
On 3/9/2024 7:09 AM, Dmitry Baryshkov wrote:
All the bridges that are being used with the MSM DSI hosts have been
converted to support DRM_BRIDGE_ATTACH_NO_CONNECTOR. Drop the fallback
code
On 3/9/2024 7:09 AM, Dmitry Baryshkov wrote:
Currently the MSM DSI driver looks for the next bridge during
msm_dsi_modeset_init(). If the bridge is not registered at that point,
this might result in -EPROBE_DEFER, which can be problematic that late
during the device probe process. Move next
more?
If not, this LGTM
Reviewed-by: Abhinav Kumar
On 4/3/2024 1:04 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2024-04-03 12:58:50)
On 4/3/2024 12:51 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2024-03-29 12:50:35)
Currently qmp_combo_dp_power_on() always return 0 in regardless of
return value of cfg->configure_dp_phy(). This pa
On 4/3/2024 12:51 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2024-03-29 12:50:35)
Currently qmp_combo_dp_power_on() always return 0 in regardless of
return value of cfg->configure_dp_phy(). This patch propagate
return value of cfg->configure_dp_phy() all the way back to caller.
Is this
-by: Abhinav Kumar
---
drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
index 44a5c62dedad..b14d4e884971 100644
On 3/30/2024 9:49 AM, Marijn Suijten wrote:
On 2024-03-30 05:52:29, Dmitry Baryshkov wrote:
In case of CMD DSI panels, the vblank IRQ can be used outside of
irq_enable/irq_disable pair. This results in the following kind of
Can you clarify when exactly that is? Is it via
m/msm/dpu: stop using raw IRQ indices in the kernel
output")
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Abhinav Kumar
Hi Doug
On 3/29/2024 4:07 PM, Doug Anderson wrote:
Hi,
On Sat, Feb 3, 2024 at 5:47 AM Dmitry Baryshkov
wrote:
Both dp_link_adjust_levels() and dp_ctrl_update_vx_px() limit swing and
pre-emphasis to 2, while the real maximum value for the sum of the
voltage swing and pre-emphasis is 3. Fix
nkmthtclfvmbz-9vol...@mail.gmail.com/
[2]
Link:
https://lore.kernel.org/lkml/20240307093727.1978126-1-colin.i.k...@gmail.com/
[3]
Signed-off-by: Miguel Ojeda
---
LGTM,
Reviewed-by: Abhinav Kumar
Add support for DP in USB3+DP combo phy")
Signed-off-by: Kuogee Hsieh
---
drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
Thanks for the cleanup!
Reviewed-by: Abhinav Kumar
On 3/28/2024 8:23 PM, Dmitry Baryshkov wrote:
On Fri, 29 Mar 2024 at 04:16, Abhinav Kumar wrote:
On 3/28/2024 5:10 PM, Dmitry Baryshkov wrote:
On Fri, 29 Mar 2024 at 01:42, Abhinav Kumar wrote:
On 3/28/2024 3:50 PM, Dmitry Baryshkov wrote:
On Thu, 28 Mar 2024 at 23:21, Abhinav
On 3/28/2024 6:46 PM, Bjorn Andersson wrote:
On Thu, Mar 28, 2024 at 02:21:14PM -0700, Abhinav Kumar wrote:
On 3/28/2024 1:58 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2024-03-28 13:24:34)
+ Johan and Bjorn for FYI
On 3/28/2024 1:04 PM, Kuogee Hsieh wrote:
For internal HPD case
On 3/28/2024 5:10 PM, Dmitry Baryshkov wrote:
On Fri, 29 Mar 2024 at 01:42, Abhinav Kumar wrote:
On 3/28/2024 3:50 PM, Dmitry Baryshkov wrote:
On Thu, 28 Mar 2024 at 23:21, Abhinav Kumar wrote:
On 3/28/2024 1:58 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2024-03-28 13:24:34
On 3/28/2024 3:50 PM, Dmitry Baryshkov wrote:
On Thu, 28 Mar 2024 at 23:21, Abhinav Kumar wrote:
On 3/28/2024 1:58 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2024-03-28 13:24:34)
+ Johan and Bjorn for FYI
On 3/28/2024 1:04 PM, Kuogee Hsieh wrote:
For internal HPD case
On 3/28/2024 2:07 PM, Kuogee Hsieh wrote:
Currently qmp_combo_dp_power_on() always return 0 in regardless of
return value of cfg->configure_dp_phy(). This patch propagate
return value of cfg->configure_dp_phy() all the way back to caller.
This is good. But I am also thinking if we should
On 3/28/2024 1:58 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2024-03-28 13:24:34)
+ Johan and Bjorn for FYI
On 3/28/2024 1:04 PM, Kuogee Hsieh wrote:
For internal HPD case, hpd_event_thread is created to handle HPD
interrupts generated by HPD block of DP controller. It converts
HPD
().
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_display.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Fixes: 542b37efc20e ("drm/msm/dp: Implement hpd_notify()")
Looks right to me,
Reviewed-by: Abhinav Kumar
t;drm/msm/dpu: Add X1E80100 support")
I cross-checked all the entries and this looks right.
Thanks for fixing this.
Reviewed-by: Abhinav Kumar
On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote:
Generate DRM/MSM headers on the fly during kernel build. This removes a
need to push register changes to Mesa with the following manual
synchronization step. Existing headers will be removed in the following
commits (split away to ease reviews).
On 3/26/2024 3:25 PM, Dmitry Baryshkov wrote:
On Wed, 27 Mar 2024 at 00:19, Abhinav Kumar wrote:
On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote:
Import the gen_headers.py script from Mesa, commit FIXME. This script
will be used to generate MSM register files on the fly during
compilation
On 3/26/2024 2:52 PM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 23:39, Abhinav Kumar wrote:
On 3/22/2024 3:56 PM, Dmitry Baryshkov wrote:
In order to stop patching the mdp5 headers, import definitions for the
writeback blocks. This part is extracted from the old Rob's patch.
Co
On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote:
Import the gen_headers.py script from Mesa, commit FIXME. This script
will be used to generate MSM register files on the fly during
compilation.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/registers/gen_header.py | 957
/dsi/mmss_cc.xml.h | 131 --
1 file changed, 131 deletions(-)
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/hdmi/qfprom.xml.h | 61 ---
1 file changed, 61 deletions(-)
Reviewed-by: Abhinav Kumar
On 3/22/2024 3:56 PM, Dmitry Baryshkov wrote:
In order to stop patching the mdp5 headers, import definitions for the
writeback blocks. This part is extracted from the old Rob's patch.
Co-developed-by: Rob Clark
Signed-off-by: Rob Clark
Signed-off-by: Dmitry Baryshkov
---
On 3/26/2024 12:47 PM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 21:32, Abhinav Kumar wrote:
On 3/26/2024 12:10 PM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar wrote:
On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 20:05, Miguel
On 3/26/2024 12:10 PM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar wrote:
On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda
wrote:
Hi,
In today's next, I got:
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6
On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda
wrote:
Hi,
In today's next, I got:
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable
'out' set but not used [-Werror,-Wunused-but-set-variable]
`out` seems to be there since
--
2 files changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Abhinav Kumar
On 3/13/2024 6:10 PM, Dmitry Baryshkov wrote:
The max_per_pipe_ib is a constant across all CRTCs and is read from the
catalog. Drop corresponding calculations and read the value directly at
icc_set_bw() time.
Suggested-by: Konrad Dybcio
Signed-off-by: Dmitry Baryshkov
---
On 3/13/2024 6:10 PM, Dmitry Baryshkov wrote:
Currently debugfs provides separate 'modes' to override calculated
MDP_CLK rate and interconnect bandwidth votes. Change that to allow
overriding individual values (e.g. one can override just clock or just
average bandwidth vote).
I am not
On 3/19/2024 3:25 PM, Dmitry Baryshkov wrote:
On Tue, 19 Mar 2024 at 23:35, Abhinav Kumar wrote:
On 3/19/2024 1:43 PM, Dmitry Baryshkov wrote:
On Tue, 19 Mar 2024 at 22:34, Abhinav Kumar wrote:
On 3/13/2024 6:10 PM, Dmitry Baryshkov wrote:
Move perf mode handling for the bandwidth
On 3/21/2024 11:09 AM, Dmitry Baryshkov wrote:
On Thu, 21 Mar 2024 at 19:36, Abhinav Kumar wrote:
On 3/21/2024 8:43 AM, Dmitry Baryshkov wrote:
On Fri, 23 Feb 2024 at 22:48, Abhinav Kumar wrote:
On 2/22/2024 3:43 AM, Dmitry Baryshkov wrote:
The DPU driver provides support for 4:2
On 3/21/2024 8:43 AM, Dmitry Baryshkov wrote:
On Fri, 23 Feb 2024 at 22:48, Abhinav Kumar wrote:
On 2/22/2024 3:43 AM, Dmitry Baryshkov wrote:
The DPU driver provides support for 4:2:0 planar YCbCr plane formats.
Extend it to also support 4:2:2 and 4:4:4 plat formats.
I checked
On 3/19/2024 1:43 PM, Dmitry Baryshkov wrote:
On Tue, 19 Mar 2024 at 22:34, Abhinav Kumar wrote:
On 3/13/2024 6:10 PM, Dmitry Baryshkov wrote:
Move perf mode handling for the bandwidth to
_dpu_core_perf_crtc_update_bus() rather than overriding per-CRTC data
and then aggregating known
On 3/19/2024 1:16 PM, Dmitry Baryshkov wrote:
On Tue, 19 Mar 2024 at 21:02, Abhinav Kumar wrote:
On 3/19/2024 11:35 AM, Dmitry Baryshkov wrote:
On Tue, 19 Mar 2024 at 20:15, Douglas Anderson wrote:
In response to my patch removing the "wait for HPD" logic at the
beginning
On 3/13/2024 6:10 PM, Dmitry Baryshkov wrote:
Move perf mode handling for the bandwidth to
_dpu_core_perf_crtc_update_bus() rather than overriding per-CRTC data
and then aggregating known values.
Note, this changes the fix_core_ab_vote. Previously it would be
multiplied per the CRTC number,
struct drm_crtc *crtc with the opening braces?
With that fixed,
Reviewed-by: Abhinav Kumar
+ struct dpu_core_perf_params perf = { 0 };
+ int i, ret = 0;
+ u64 avg_bw;
+
+ if (!kms->num_paths)
+ return 0;
+
+ dpu_core_perf_aggregate(crtc->dev, dpu_
On 3/19/2024 11:35 AM, Dmitry Baryshkov wrote:
On Tue, 19 Mar 2024 at 20:15, Douglas Anderson wrote:
In response to my patch removing the "wait for HPD" logic at the
beginning of the MSM DP transfer() callback [1], we had some debate
about what the "This is an optional function" meant in
catalog.
Fixes: abda0d925f9c ("drm/msm/dpu: Mark various data tables as const")
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Thanks for the fix,
Reviewed-by: Abhinav Kumar
On 3/19/2024 11:15 AM, Doug Anderson wrote:
Hi,
On Tue, Mar 19, 2024 at 10:27 AM Dmitry Baryshkov
wrote:
On Tue, 19 Mar 2024 at 19:13, Abhinav Kumar wrote:
On 3/18/2024 5:55 PM, Dmitry Baryshkov wrote:
On Tue, 19 Mar 2024 at 02:19, Abhinav Kumar wrote:
+bjorn, johan as fyi
gra's transfer() callback. For now, I've left wait_hpd_asserted() as
optional and described the old/deprecated way things used to work
before wait_hpd_asserted().
include/drm/display/drm_dp_helper.h | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
Thanks for the change,
Reviewed-by: Abhinav Kumar
On 3/18/2024 5:55 PM, Dmitry Baryshkov wrote:
On Tue, 19 Mar 2024 at 02:19, Abhinav Kumar wrote:
+bjorn, johan as fyi for sc8280xp
On 3/15/2024 2:36 PM, Douglas Anderson wrote:
Before the introduction of the wait_hpd_asserted() callback in commit
841d742f094e ("drm/dp
On 3/18/2024 12:37 PM, Doug Anderson wrote:
Hi,
On Mon, Mar 18, 2024 at 12:26 PM Stephen Boyd wrote:
Quoting Douglas Anderson (2024-03-15 14:36:32)
This is a no-op change to just fix a typo in the name of a static function.
Signed-off-by: Douglas Anderson
---
Changes in v2:
- ("Fix
+bjorn, johan as fyi for sc8280xp
On 3/15/2024 2:36 PM, Douglas Anderson wrote:
Before the introduction of the wait_hpd_asserted() callback in commit
841d742f094e ("drm/dp: Add wait_hpd_asserted() callback to struct
drm_dp_aux") the API between panel drivers and DP AUX bus drivers was
that it
y: Douglas Anderson
---
(no changes since v1)
drivers/gpu/drm/msm/dp/dp_aux.c | 5 +++--
drivers/gpu/drm/msm/dp/dp_catalog.c | 7 ---
drivers/gpu/drm/msm/dp/dp_catalog.h | 3 ++-
3 files changed, 9 insertions(+), 6 deletions(-)
Reviewed-by: Abhinav Kumar
Douglas Anderson
---
Changes in v2:
- Don't look at the HPD line directly; have dp_display call us.
drivers/gpu/drm/msm/dp/dp_aux.c | 20
drivers/gpu/drm/msm/dp/dp_aux.h | 1 +
drivers/gpu/drm/msm/dp/dp_display.c | 4
3 files changed, 25 insertions(+)
Reviewed-by: Abhinav Kumar
On 3/15/2024 8:57 AM, Johan Hovold wrote:
On Thu, Mar 14, 2024 at 09:30:57AM -0700, Abhinav Kumar wrote:
On 3/14/2024 8:38 AM, Johan Hovold wrote:
On Wed, Mar 13, 2024 at 10:24:08AM -0700, Abhinav Kumar wrote:
Perhaps I'm missing something in the race that you are trying to
describe
On 3/14/2024 8:38 AM, Johan Hovold wrote:
On Wed, Mar 13, 2024 at 10:24:08AM -0700, Abhinav Kumar wrote:
On 3/13/2024 1:18 AM, Johan Hovold wrote:
Right, but your proposed fix would not actually fix anything and judging
from the sparse commit message and diff itself it is clearly only
On 3/12/2024 5:13 PM, Douglas Anderson wrote:
As documented in the description of the transfer() function of
"struct drm_dp_aux", the transfer() function can be called at any time
regardless of the state of the DP port. Specifically if the kernel has
the DP AUX character device enabled and
not automatically enable
external displays when receiving a hotplug notification.
Thanks for the fixes. Both look right to me.
I will pick up both of them for -fixes
Reviewed-by: Abhinav Kumar
Fixes: 5814b8bf086a ("drm/msm/dp: incorporate pm_runtime framework into DP
driver"
ntime framework into DP
driver")
Cc: sta...@vger.kernel.org # 6.8
Cc: Kuogee Hsieh
Signed-off-by: Johan Hovold
Reviewed-by: Abhinav Kumar
On 3/13/2024 1:18 AM, Johan Hovold wrote:
On Tue, Mar 12, 2024 at 10:39:46AM -0700, Abhinav Kumar wrote:
On 3/12/2024 9:59 AM, Johan Hovold wrote:
Heh. This is getting ridiculous. I just tried running with this patch
and it again breaks hotplug detect in a VT console and in X (where I
On 3/12/2024 9:59 AM, Johan Hovold wrote:
On Tue, Mar 12, 2024 at 05:41:23PM +0100, Johan Hovold wrote:
On Tue, Mar 12, 2024 at 11:09:11AM +0100, Johan Hovold wrote:
On Fri, Mar 08, 2024 at 01:45:32PM -0800, Abhinav Kumar wrote:
@@ -466,6 +466,8 @@ static int dp_display_notify_disconnect
On 3/11/2024 6:43 AM, Johan Hovold wrote:
On Sat, Mar 09, 2024 at 05:30:17PM +0100, Johan Hovold wrote:
On Fri, Mar 08, 2024 at 09:50:17AM -0800, Abhinav Kumar wrote:
On 3/8/2024 4:43 AM, Johan Hovold wrote:
For this last remaining reset with the stacktrace you have mentioned
below, I do
-send-email-quic_khs...@quicinc.com/
Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable
and disable")
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_display.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/
Hi Johan
On 3/8/2024 4:43 AM, Johan Hovold wrote:
Hi Abhinav, Rob, Dmitry and Kuogee,
On Tue, Feb 27, 2024 at 02:33:48PM +0100, Johan Hovold wrote:
Since 6.8-rc1 I have seen (and received reports) of hard resets of the
Lenovo ThinkPad X13s after connecting and disconnecting an external
On 3/6/2024 11:52 AM, Dmitry Baryshkov wrote:
On Wed, 6 Mar 2024 at 21:50, Abhinav Kumar wrote:
There are cases where the userspace might still send another
frame after the HPD disconnect causing a modeset cycle after
a disconnect. This messes the internal state machine of MSM DP driver
-send-email-quic_khs...@quicinc.com/
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_display.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
b/drivers/gpu/drm/msm/dp/dp_display.c
index 068d44eeaa07..e00092904ccc 100644
Fix the typo in the name of dp_display_handle_port_status_changed().
Fixes: c58eb1b54fee ("drm/msm/dp: fix connect/disconnect handled at irq_hpd")
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On 3/4/2024 5:06 AM, Dmitry Baryshkov wrote:
On Wed, 28 Feb 2024 at 21:47, Abhinav Kumar wrote:
dpu_kms seems unused while initializing DSI, HDMI and DP through
their respective _dpu_kms_initialize_* functions.
Hence lets drop the parameter altogether.
Signed-off-by: Abhinav Kumar
.
Suggested-by: AngeloGioacchino Del Regno
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/panel/panel-truly-nt35597.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Abhinav Kumar
Following the pattern of other interfaces, lets align writeback
as well by dropping the dpu_kms parameter in its _dpu_kms_initialize_*
function.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff
dpu_kms seems unused while initializing DSI, HDMI and DP through
their respective _dpu_kms_initialize_* functions.
Hence lets drop the parameter altogether.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 15 ++-
1 file changed, 6 insertions(+), 9
On 2/28/2024 5:28 AM, Johan Hovold wrote:
On Wed, Feb 28, 2024 at 01:08:04PM +0200, Dmitry Baryshkov wrote:
On Wed, 28 Feb 2024 at 11:50, Johan Hovold wrote:
On Tue, Feb 27, 2024 at 02:11:56PM -0800, Abhinav Kumar wrote:
On 2/27/2024 2:08 PM, Dmitry Baryshkov wrote:
This reverts commit
or the change itself,
Reviewed-by: Abhinav Kumar
pm_runtime_resume_and_get() and return an
error if resume fails.
Fixes: e2969ee30252 ("drm/msm/dp: move of_dp_aux_populate_bus() to eDP probe()")
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/dp/dp_aux.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Abhinav Kumar
On 2/25/2024 11:57 AM, Abhinav Kumar wrote:
On 2/25/2024 6:12 AM, Dmitry Baryshkov wrote:
In order to debug commit_done timeouts, capture the devcoredump state
when the first timeout occurs after the encoder has been enabled.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp
On 2/25/2024 12:52 PM, Dmitry Baryshkov wrote:
On Sun, 25 Feb 2024 at 21:49, Abhinav Kumar wrote:
On 2/25/2024 6:12 AM, Dmitry Baryshkov wrote:
Stop multiplexing several events via the dpu_encoder_wait_for_event()
function. Split it into two distinct functions two allow separate
On 2/25/2024 12:57 PM, Dmitry Baryshkov wrote:
On Sun, 25 Feb 2024 at 21:44, Abhinav Kumar wrote:
On 2/25/2024 6:12 AM, Dmitry Baryshkov wrote:
We have several reports of vblank timeout messages. However after some
debugging it was found that there might be different causes
On 2/25/2024 6:12 AM, Dmitry Baryshkov wrote:
In order to debug commit_done timeouts, capture the devcoredump state
when the first timeout occurs after the encoder has been enabled.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 9 +
1 file
On 2/25/2024 6:12 AM, Dmitry Baryshkov wrote:
Stop multiplexing several events via the dpu_encoder_wait_for_event()
function. Split it into two distinct functions two allow separate
handling of those events.
I understand the idea but would handling of those events be really distinct?
Like
On 2/25/2024 6:12 AM, Dmitry Baryshkov wrote:
We have several reports of vblank timeout messages. However after some
debugging it was found that there might be different causes to that.
To allow us to identify the DPU block that gets stuck, include the
actual CTL_FLUSH value into the timeout
On 2/22/2024 3:43 AM, Dmitry Baryshkov wrote:
The DPU driver provides support for 4:2:0 planar YCbCr plane formats.
Extend it to also support 4:2:2 and 4:4:4 plat formats.
I checked myself and also internally on this. On sm8250, the DPU planes
do not support YUV444 and YUV422 (and the
On 2/23/2024 11:35 AM, Rodrigo Vivi wrote:
On Fri, Feb 23, 2024 at 09:47:11AM -0800, Abhinav Kumar wrote:
CC Dmitry
Hi Rodrigo
On 2/23/2024 9:00 AM, Rodrigo Vivi wrote:
On Fri, Feb 23, 2024 at 08:50:06AM -0700, Jeffrey Hugo wrote:
With the x86_64_defconfig I see the following when
: Daniel Vetter
Cc: Dmitry Baryshkov
Cc: Abhinav Kumar
Cc: Maxime Ripard
Cc: Maarten Lankhorst
Cc: Thomas Zimmermann
Signed-off-by: Rodrigo Vivi
Reviewed-by: Abhinav Kumar
101 - 200 of 2044 matches
Mail list logo
