Re: [PATCH v2 01/12] dt-bindings: media: Convert MediaTek mt8173-mdp bindings to DT schema

2025-09-18 Thread Chen-Yu Tsai
On Fri, Sep 12, 2025 at 2:06 PM Krzysztof Kozlowski wrote: > > On Thu, Sep 11, 2025 at 12:09:50PM -0300, Ariel D'Alessandro wrote: > > Convert the existing text-based DT bindings for MediaTek MT8173 Media Data > > Path to a DT schema. > > > > Signed-off-by: Ariel D'Alessandro > > --- > > .../bin

Re: [PATCH RFC 05/10] mailbox: add MediaTek GPUEB IPI mailbox

2025-09-11 Thread Chen-Yu Tsai
On Fri, Sep 12, 2025 at 12:48 PM Chia-I Wu wrote: > > On Fri, Sep 5, 2025 at 3:24 AM Nicolas Frattaroli > wrote: > > > > The MT8196 SoC uses an embedded MCU to control frequencies and power of > > the GPU. This controller is referred to as "GPUEB". > > > > It communicates to the application proce

Re: [RFC PATCH 0/2] drm/panthor: initial mt8196 support

2025-09-04 Thread Chen-Yu Tsai
On Thu, Sep 4, 2025 at 7:20 PM Nicolas Frattaroli wrote: > > Hi, > > On Thursday, 4 September 2025 00:55:02 Central European Summer Time Chia-I Wu > wrote: > > MediaTek MT8196 has Mali-G925-Immortalis, for which panthor gained > > support recently. But the soc also requires custom ASN hash to be

Re: [PATCH drm-next v2] drm/bridge: it6505: Use SHA-1 library instead of crypto_shash

2025-09-03 Thread Chen-Yu Tsai
pto_shash commit: e339a73737d365dc88e1994d561112ef2c21ad88 Best regards, -- Chen-Yu Tsai

Re: [PATCH drm-next v2] drm/bridge: it6505: Use SHA-1 library instead of crypto_shash

2025-08-25 Thread Chen-Yu Tsai
On Thu, Aug 21, 2025 at 7:56 PM Eric Biggers wrote: > > Instead of using the "sha1" crypto_shash, simply call the sha1() library > function. This is simpler and faster. > > Signed-off-by: Eric Biggers Reviewed-by: Chen-Yu Tsai

Re: [PATCH] drm/bridge: it6505: select REGMAP_I2C

2025-08-11 Thread Chen-Yu Tsai
anks! [1/1] drm/bridge: it6505: select REGMAP_I2C commit: 21b137f651cf9d981e22d2c60a2a8105f50a6361 Best regards, -- Chen-Yu Tsai

Re: [PATCH 35/38] arm64: dts: mediatek: mt8195-cherry: Move VBAT-supply to Tomato R1/R2

2025-07-24 Thread Chen-Yu Tsai
On Thu, Jul 24, 2025 at 4:41 PM AngeloGioacchino Del Regno wrote: > > Move the VBAT supply to mt8195-cherry-tomato-{r1,r2} as this power > supply is named like that only for the Realtek RT5682i codec. > > Signed-off-by: AngeloGioacchino Del Regno > Reviewed-by: Chen-Yu Tsai

Re: [PATCH 36/38] arm64: dts: mediatek: mt8195-cherry: Add missing regulators to rt5682

2025-07-24 Thread Chen-Yu Tsai
s because the VIO18 LDO is already powered > on because it's assigned as AVDD supply anyway. > > Signed-off-by: AngeloGioacchino Del Regno > Confirmed this matches the schematic. Reviewed-by: Chen-Yu Tsai

Re: [PATCH 03/38] dt-bindings: mailbox: mediatek, gce-mailbox: Make clock-names optional

2025-07-24 Thread Chen-Yu Tsai
Stop requiring to specify clock-names on all non-MT8195 GCEs. > > Signed-off-by: AngeloGioacchino Del Regno > Reviewed-by: Chen-Yu Tsai BTW, I see that the cmdq driver has support for sub-nodes which was never actually used, possibly originally intended for the MT8188.

Re: [PATCH 28/38] arm64: dts: mediatek: mt8173: Fix pinctrl node names and cleanup

2025-07-24 Thread Chen-Yu Tsai
}; > }; > > - mmc1_pins_uhs: mmc1 { > - pins_cmd_dat { > + spi_pins_a: spi0-pins { > + pins-bus { > + pinmux = , > + , > + , > + ; > + }; > + }; > + > + mmc1_pins_uhs: mmc1-uhs-pins { Wrong order? > + pins-cmd-dat { > pinmux = , > , > , [...] Once fixed, Reviewed-by: Chen-Yu Tsai

Re: [PATCH 33/38] arm64: dts: mediatek: mt8183-kukui: Move DSI panel node to machine dtsis

2025-07-24 Thread Chen-Yu Tsai
t are specific to the tablet design. > Signed-off-by: AngeloGioacchino Del Regno > Reviewed-by: Chen-Yu Tsai > --- > .../dts/mediatek/mt8183-kukui-jacuzzi.dtsi| 5 > .../dts/mediatek/mt8183-kukui-kakadu.dtsi | 27 ++ >

Re: [PATCH 22/38] arm64: dts: mediatek: Fix node name for SYSIRQ controller on all SoCs

2025-07-24 Thread Chen-Yu Tsai
is commit brings no functional changes, but fixes a dtbs_check > warning. > > Signed-off-by: AngeloGioacchino Del Regno > Reviewed-by: Chen-Yu Tsai > --- > arch/arm64/boot/dts/mediatek/mt6755.dtsi | 2 +- > arch/arm64/boot/dts/mediatek/mt6779.dtsi | 2 +- > arch/arm

Re: [PATCH 02/38] dt-bindings: display: mediatek, dp: Allow DisplayPort AUX bus

2025-07-24 Thread Chen-Yu Tsai
oacchino Del Regno > Reviewed-by: Chen-Yu Tsai

Re: [PATCH 01/38] dt-bindings: display: mediatek: dpi: Allow specifying resets

2025-07-24 Thread Chen-Yu Tsai
On Thu, Jul 24, 2025 at 4:39 PM AngeloGioacchino Del Regno wrote: > > Even though the DPI IP has a reset bit on all MediaTek SoCs, it > is optional, and has always been unused until MT8195; specifically: > on older SoCs, like MT8173, the reset bit is located in MMSYS, and > on newer SoCs, like MT8

Re: [PATCH] drm/bridge: it6505: select REGMAP_I2C

2025-07-23 Thread Chen-Yu Tsai
;drm/bridge: add it6505 driver") > Signed-off-by: Chia-I Wu Reviewed-by: Chen-Yu Tsai Somehow I botched my previous reply. > --- > drivers/gpu/drm/bridge/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/dr

Re: [PATCH v2 01/12] dt-bindings: allwinner: Add TCON_TOP_LCD clock defines

2025-07-21 Thread Chen-Yu Tsai
Hi. On Sun, Jul 20, 2025 at 4:51 PM Ryan Walklin wrote: > > The Allwinner H700 exposes RGB and LVDS pins as well as a HDMI > connector. This requires additional clocks for the TCON_TOP as per the > T507 datasheet (which shares the same die). > > Acked-by: Rob Herring (Arm) > Signed-off-by: Ryan

Re: (subset) [PATCH v2 0/3] arm64: sunxi: a523: Enable Mali GPU

2025-07-15 Thread Chen-Yu Tsai
nxi/dt-for-6.17 in local tree, thanks! [2/3] arm64: dts: allwinner: a523: add Mali GPU node commit: 3d99e0dc888727a21b45ca64ff7b0cddbd17dd16 [3/3] arm64: dts: allwinner: a523: enable Mali GPU for all boards commit: d96d9ac8d2f197f31ea3de931dde1a217950f4ad Best regards, -- Chen-Yu Tsai

Re: (subset) [PATCH 0/5] sunxi: Various minor V3s clock/pinctrl fixes

2025-07-03 Thread Chen-Yu Tsai
3s: Fix CSI SCLK clock name commit: f45b2949b1a235881255132a119b8cc8c3738bd5 [3/5] clk: sunxi-ng: v3s: Fix CSI1 MCLK clock name commit: 2b73328629396d32e41ca1f023653b07abf2b42f [4/5] clk: sunxi-ng: v3s: Fix TCON clock parents commit: 01fdcbc7e5a56c9cba521e0f237cb5c3fd162432 Best regards, -- Chen-Yu Tsai

Re: [PATCH 1/5] pinctrl: sunxi: v3s: Fix wrong comment about UART2 pinmux

2025-07-02 Thread Chen-Yu Tsai
On Wed, Jul 2, 2025 at 4:13 AM Paul Kocialkowski wrote: > > The original comment doesn't match the pin attribution, probably due > to a hasty copy/paste. > > Signed-off-by: Paul Kocialkowski Acked-by Chen-Yu Tsai

Re: [PATCH v11 8/8] drm: sun4i: de33: mixer: add mixer configuration for the H616

2025-05-18 Thread Chen-Yu Tsai
Signed-off-by: Jernej Skrabec > Signed-off-by: Ryan Walklin > Acked-by: Maxime Ripard Reviewed-by: Chen-Yu Tsai

Re: [PATCH v11 2/8] drm: sun4i: de2/de3: refactor mixer initialisation

2025-05-18 Thread Chen-Yu Tsai
ned-off-by: Ryan Walklin > Reviewed-by: Andre Przywara > Acked-by: Maxime Ripard Reviewed-by: Chen-Yu Tsai

Re: [PATCH v11 6/8] drm: sun4i: de33: mixer: add Display Engine 3.3 (DE33) support

2025-05-18 Thread Chen-Yu Tsai
Hi, On Fri, May 16, 2025 at 6:52 PM Ryan Walklin wrote: > > From: Jernej Skrabec > > The DE33 is a newer version of the Allwinner Display Engine IP block, > found in the H616, H618, H700 and T507 SoCs. DE2 and DE3 are already > supported by the mainline driver. > > Notable features (from the H61

Re: [PATCH v11 7/8] drm: sun4i: de33: vi_scaler: add Display Engine 3.3 (DE33) support

2025-05-18 Thread Chen-Yu Tsai
t; Signed-off-by: Ryan Walklin > Acked-by: Maxime Ripard Reviewed-by: Chen-Yu Tsai

Re: [PATCH v11 6/8] drm: sun4i: de33: mixer: add Display Engine 3.3 (DE33) support

2025-05-18 Thread Chen-Yu Tsai
the DE33. > > Signed-off-by: Jernej Skrabec > Signed-off-by: Ryan Walklin > Signed-off-by: Chris Morgan > Acked-by: Maxime Ripard Reviewed-by: Chen-Yu Tsai Code looks OK, though I have not tried to check the register offsets.

Re: [PATCH v11 4/8] drm: sun4i: de2/de3: use generic register reference function for layer configuration

2025-05-18 Thread Chen-Yu Tsai
On Fri, May 16, 2025 at 6:52 PM Ryan Walklin wrote: > > From: Jernej Skrabec > > Use the new blender register lookup function where required in the layer > commit and update code. > > Signed-off-by: Jernej Skrabec > Signed-off-by: Ryan Walklin > Acked-by: Maxime Ri

Re: [PATCH v11 3/8] drm: sun4i: de2/de3: add generic blender register reference function

2025-05-18 Thread Chen-Yu Tsai
dding a function to look the blender reference up, > with a subsequent patch to add a conditional based on the DE type. > > Signed-off-by: Jernej Skrabec > Signed-off-by: Ryan Walklin > Acked-by: Maxime Ripard Reviewed-by: Chen-Yu Tsai

Re: [PATCH v11 1/8] drm: sun4i: de2/de3: add mixer version enum

2025-05-18 Thread Chen-Yu Tsai
an enum. > > Signed-off-by: Jernej Skrabec > Signed-off-by: Ryan Walklin > Reviewed-by: Andre Przywara > Acked-by: Maxime Ripard Reviewed-by: Chen-Yu Tsai

Re: [PATCH v10 05/11] dt-bindings: allwinner: add H616 DE33 bus binding

2025-05-15 Thread Chen-Yu Tsai
On Sun, May 11, 2025 at 6:42 PM Ryan Walklin wrote: > > The Allwinner H616 and variants have a new display engine revision > (DE33). > > Add a display engine bus binding for the DE33. > > Signed-off-by: Ryan Walklin > Acked-by: Conor Dooley > Reviewed-by: Chen-Yu T

Re: (subset) [PATCH v10 00/11] drm: sun4i: add Display Engine 3.3 (DE33) support

2025-05-12 Thread Chen-Yu Tsai
[06/11] dt-bindings: allwinner: add H616 DE33 clock binding commit: ab1a94b504b6f19c294786b5920574fb374fb5cc [08/11] clk: sunxi-ng: ccu: add Display Engine 3.3 (DE33) support commit: be0e9a3727872783bad0752dc82e0857f4776049 Best regards, -- Chen-Yu Tsai

Re: (subset) [PATCH V9 00/24] drm: sun4i: add Display Engine 3.3 (DE33) support

2025-05-09 Thread Chen-Yu Tsai
0i-h616-ccu: Add LVDS reset commit: 20fb4ac9cda06527cf60c5ec7dda7c463c9c81be [02/24] clk: sunxi-ng: h616: Add LVDS reset for LCD TCON commit: 390e4cfe87cb99c80614235cbc4651c3b315a9c9 Best regards, -- Chen-Yu Tsai

Re: [PATCH V9 02/24] clk: sunxi-ng: h616: Add LVDS reset for LCD TCON

2025-05-09 Thread Chen-Yu Tsai
On Fri, May 9, 2025 at 11:14 PM Andre Przywara wrote: > > On Wed, 7 May 2025 15:19:21 -0500 > Chris Morgan wrote: > > Hi, > > despite the slightly ill fate of this series, I was wondering if we could > get the non-controversial clock parts for instance already merged, to > reduce the number of p

Re: [PATCH] drm/mediatek: mtk_dp: Fix hdmi codec and phy driver unregistration

2025-04-09 Thread Chen-Yu Tsai
On Thu, Apr 3, 2025 at 7:09 PM AngeloGioacchino Del Regno wrote: > > During probe, this driver is registering two platform devices: one > for the HDMI Codec driver and one for the DisplayPort PHY driver. > > In the probe function, none of the error cases are unregistering > any of the two platform

[PATCH] drm/bridge: anx7625: Use devm_pm_runtime_enable()

2025-04-09 Thread Chen-Yu Tsai
The anx7625 driver is open coding what devm_pm_runtime_enable() does. Switch to the common helper instead. Signed-off-by: Chen-Yu Tsai --- drivers/gpu/drm/bridge/analogix/anx7625.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix

Re: [PATCH v1 3/5] drm/mediatek: mtk_drm_drv: Unbind secondary mmsys components on err

2025-04-05 Thread Chen-Yu Tsai
omponent masters that succeeded binding all subdevices when any > of the other masters errors out. > > Fixes: 1ef7ed48356c ("drm/mediatek: Modify mediatek-drm for mt8195 multi > mmsys support") > Signed-off-by: AngeloGioacchino Del Regno > Makes sense. Reviewed-by:

Re: [PATCH v1 5/5] drm/mediatek: mtk_disp_rdma: Enable/disable interrupt on bind/unbind

2025-04-05 Thread Chen-Yu Tsai
On Wed, Apr 2, 2025 at 4:36 PM AngeloGioacchino Del Regno wrote: > > The RDMA driver is installing an ISR in the probe function but, if > the component is not bound yet, the interrupt handler may call the > vblank_cb ahead of time (while probing other drivers) or too late > (while removing other d

Re: [PATCH v1 2/5] drm/mediatek: Fix kobject put for component sub-drivers

2025-04-02 Thread Chen-Yu Tsai
that by adding a call to put_device() for all of the mmsys > devices in a loop, in error cases of mtk_drm_bind() and in the > mtk_drm_unbind() callback. > > Fixes: 1ef7ed48356c ("drm/mediatek: Modify mediatek-drm for mt8195 multi > mmsys support") > Signed-off-by: Angel

Re: [PATCH v1 1/5] drm/mediatek: mtk_drm_drv: Fix kobject put for mtk_mutex device ptr

2025-04-02 Thread Chen-Yu Tsai
in mtk_drm_bind() > to fix the refcount_t overflow. > > Fixes: 1ef7ed48356c ("drm/mediatek: Modify mediatek-drm for mt8195 multi > mmsys support") > Signed-off-by: AngeloGioacchino Del Regno > Reviewed-by: Chen-Yu Tsai > --- > drivers/gpu/drm/mediatek/mtk_drm_drv

Re: [PATCH v1 4/5] drm/mediatek: mtk_disp_ovl: Enable/disable interrupt on bind/unbind

2025-04-02 Thread Chen-Yu Tsai
On Wed, Apr 2, 2025 at 4:36 PM AngeloGioacchino Del Regno wrote: > > The OVL driver is installing an ISR in the probe function but, if > the component is not bound yet, the interrupt handler may call the > vblank_cb ahead of time (while probing other drivers) or too late > (while removing other dr

Re: [PATCH v6 08/26] drm/bridge: panel: add a panel_bridge to every panel

2025-02-18 Thread Chen-Yu Tsai
On Tue, Feb 11, 2025 at 2:34 AM Maxime Ripard wrote: > > On Thu, Feb 06, 2025 at 07:14:23PM +0100, Luca Ceresoli wrote: > > Adding a panel does currently not add a panel_bridge wrapping it. Usually > > the panel_bridge creation happens when some other driver (e.g. the previous > > bridge or the en

Re: [PATCH 03/12] dt-bindings: display: mediatek: add EXDMA yaml for MT8196

2025-01-23 Thread Chen-Yu Tsai
On Fri, Jan 24, 2025 at 12:14 AM Paul-pl Chen (陳柏霖) wrote: > > On Thu, 2025-01-23 at 08:21 +0100, Krzysztof Kozlowski wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > > > > > On 23/01/2025 07:11, Paul-pl Chen (

Re: [PATCH 03/12] dt-bindings: display: mediatek: add EXDMA yaml for MT8196

2025-01-22 Thread Chen-Yu Tsai
On Thu, Jan 23, 2025 at 2:11 PM Paul-pl Chen (陳柏霖) wrote: > > On Sat, 2025-01-18 at 10:22 +0100, Krzysztof Kozlowski wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > > > > > On 14/01/2025 06:49, Paul-pl Chen (陳

Re: [PATCH 08/12] drm/mediatek: add EXDMA support for MT8196

2025-01-20 Thread Chen-Yu Tsai
On Fri, Jan 10, 2025 at 8:54 PM paul-pl.chen wrote: > > From: "Nancy.Lin" > > EXDMA is a DMA engine for reading data from DRAM with > various DRAM footprints and data formats. For input > sources in certain color formats and color domains, > EXDMA also includes a color transfer function to > proc

Re: [PATCH 07/12] soc: mediatek: mutex: add mutex support for MT8196

2025-01-20 Thread Chen-Yu Tsai
On Fri, Jan 10, 2025 at 8:46 PM paul-pl.chen wrote: > > From: "Nancy.Lin" > > Add mutex support the main and external display for MT8196. > > Signed-off-by: Nancy.Lin > Signed-off-by: Paul-pl.Chen > --- > drivers/soc/mediatek/mtk-mutex.c | 233 +++-- > include/linux/s

Re: [PATCH v3 1/7] dt-bindings: mailbox: mediatek: Add MT8196 support for gce-mailbox

2025-01-19 Thread Chen-Yu Tsai
On Sun, Jan 19, 2025 at 5:24 AM Jassi Brar wrote: > > On Thu, Dec 19, 2024 at 11:08 AM Jason-JH.Lin > wrote: > > > > 1. Add compatible name and iommus property to mediatek,gce-mailbox.yaml > >for MT8196. > > > >- The compatible name "mediatek,mt8196-gce-mailbox" is added to > > ensu

Re: [PATCH v3] drm/bridge:anx7625: Update HDCP status at atomic_enable()

2024-12-11 Thread Chen-Yu Tsai
On Thu, Dec 12, 2024 at 1:51 PM Xin Ji wrote: > > When user enabled HDCP feature, userspace will set HDCP content > to DRM_MODE_CONTENT_PROTECTION_DESIRED. Next, anx7625 will update > HDCP content to DRM_MODE_CONTENT_PROTECTION_ENABLED if down stream > support HDCP feature. > > However once HDCP c

[PATCH v2] drm/panel: visionox-rm69299: Remove redundant assignments of panel fields

2024-12-04 Thread Chen-Yu Tsai
drm_panel_init() was made to initialize the fields in |struct drm_panel|. There is no need to separately initialize them again. Drop the separate assignments that are redundant. Also fix up any uses of `ctx->panel.dev` to use `dev` directly. Signed-off-by: Chen-Yu Tsai --- Changes since

Re: [PATCH] drm/panel: visionox-rm69299: Remove redundant assignments of panel fields

2024-12-02 Thread Chen-Yu Tsai
On Mon, Dec 2, 2024 at 8:50 PM Dmitry Baryshkov wrote: > > On Mon, Dec 02, 2024 at 02:24:48PM +0800, Chen-Yu Tsai wrote: > > drm_panel_init() was made to initialize the fields in |struct drm_panel|. > > There is no need to separately initialize them again. > > > >

[PATCH] drm/panel: visionox-rm69299: Remove redundant assignments of panel fields

2024-12-01 Thread Chen-Yu Tsai
drm_panel_init() was made to initialize the fields in |struct drm_panel|. There is no need to separately initialize them again. Drop the separate assignments that are redundant. Signed-off-by: Chen-Yu Tsai --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 3 --- 1 file changed, 3 deletions

Re: [RFC PATCH] drm/bridge: panel: Use devm_drm_bridge_add()

2024-11-29 Thread Chen-Yu Tsai
On Fri, Nov 29, 2024 at 10:55 PM Maxime Ripard wrote: > > On Fri, Nov 29, 2024 at 10:12:02PM +0800, Sui Jingfeng wrote: > > Hi, > > > > On 2024/11/29 18:51, Maxime Ripard wrote: > > > On Wed, Nov 27, 2024 at 05:58:31PM +0800, Chen-Yu Tsai wrote: > > > >

Re: [RFC PATCH] drm/bridge: panel: Use devm_drm_bridge_add()

2024-11-28 Thread Chen-Yu Tsai
On Thu, Nov 28, 2024 at 2:46 AM Sui Jingfeng wrote: > > Hi, > > On 2024/11/27 17:58, Chen-Yu Tsai wrote: > > Revisiting this thread since I just stepped on the same problem on a > > different device. > > > > On Thu, Nov 14, 2024 at 9:12 PM Maxime Ripard wrote

Re: [RFC PATCH] drm/bridge: panel: Use devm_drm_bridge_add()

2024-11-27 Thread Chen-Yu Tsai
Revisiting this thread since I just stepped on the same problem on a different device. On Thu, Nov 14, 2024 at 9:12 PM Maxime Ripard wrote: > > On Tue, Oct 29, 2024 at 10:53:49PM +0800, Fei Shao wrote: > > On Thu, Oct 24, 2024 at 8:36 PM Maxime Ripard wrote: > > > > > > On Wed, Oct 09, 2024 at 0

Re: [PATCH v2 2/3] drm/sun4i: use drm_mode_validate_mode() helper function

2024-11-25 Thread Chen-Yu Tsai
On Mon, Nov 25, 2024 at 9:50 PM Sean Nyekjaer wrote: > > Use new helper function for HDMI mode validation This is a bit misleading since this is actually the DPI or parallel output encoder, not HDMI. HDMI is in drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c and drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c Chen

Re: [PATCH] drm/bridge: it6505: Fix inverted reset polarity

2024-11-04 Thread Chen-Yu Tsai
On Tue, 29 Oct 2024 17:54:10 +0800, Chen-Yu Tsai wrote: > The IT6505 bridge chip has a active low reset line. Since it is a > "reset" and not an "enable" line, the GPIO should be asserted to > put it in reset and deasserted to bring it out of reset during >

Re: [PATCH] drm/mediatek: Drop dependency on ARM

2024-11-01 Thread Chen-Yu Tsai
On Tue, 29 Oct 2024 19:13:07 +0800, Chen-Yu Tsai wrote: > The recent attempt to make the MediaTek DRM driver build for non-ARM > compile tests made the driver unbuildable for arm64 platforms. Since > this is used on both ARM and arm64 platforms, just drop the dependency > on ARM. &g

Re: [PATCH] drm/mediatek: Drop dependency on ARM

2024-10-31 Thread Chen-Yu Tsai
On Thu, Oct 31, 2024 at 5:30 PM mrip...@kernel.org wrote: > > On Wed, Oct 30, 2024 at 04:52:17PM +0800, Chen-Yu Tsai wrote: > > On Wed, Oct 30, 2024 at 4:48 PM CK Hu (胡俊光) wrote: > > > > > > On Wed, 2024-10-30 at 09:25 +0100, mrip...@kernel.org wrote: > > &g

Re: [PATCH] drm/mediatek: Drop dependency on ARM

2024-10-30 Thread Chen-Yu Tsai
On Wed, Oct 30, 2024 at 4:48 PM CK Hu (胡俊光) wrote: > > On Wed, 2024-10-30 at 09:25 +0100, mrip...@kernel.org wrote: > > On Wed, Oct 30, 2024 at 03:30:34AM +, CK Hu (胡俊光) wrote: > > > Hi, Chen-yu: > > > > > > On Tue, 2024-10-29 at 19:13 +0800, Che

[PATCH] drm/mediatek: Drop dependency on ARM

2024-10-29 Thread Chen-Yu Tsai
Signed-off-by: Chen-Yu Tsai --- It looks like the culprit commit was merged through the drm-misc tree. So please merge this on top ASAP. drivers/gpu/drm/mediatek/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediat

[PATCH] drm/bridge: it6505: Fix inverted reset polarity

2024-10-29 Thread Chen-Yu Tsai
. The other known user is the MT8183 Kukui / Jacuzzi family; their device trees currently do not have the IT6505 included. Fix the polarity in the driver while there are no actual users. Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver") Cc: Signed-off-by: Chen-Yu Tsai --- driv

Re: [PATCH 2/2] drm/mediatek: Switch to for_each_child_of_node_scoped()

2024-10-28 Thread Chen-Yu Tsai
; in the future. > > Signed-off-by: Javier Carrasco Reviewed-by: Chen-Yu Tsai

Re: [PATCH 1/2] drm/mediatek: Fix child node refcount handling in early exit

2024-10-28 Thread Chen-Yu Tsai
break. > > Cc: sta...@vger.kernel.org > Fixes: d761b9450e31 ("drm/mediatek: Add cnt checking for coverity issue") > > Signed-off-by: Javier Carrasco Reviewed-by: Chen-Yu Tsai

Re: [PATCH 0/6] drm/display: hdmi: add drm_hdmi_connector_mode_valid()

2024-10-19 Thread Chen-Yu Tsai
rm > this check manually. In case of DRM_BRIDGE_OP_HDMI bridges the check can > be dropped in favour of performing it in drm_bridge_connector. > > Signed-off-by: Dmitry Baryshkov Makes sense, code looks like a correct substitution, and AFAICT covers all current in tree drivers. Whole seri

Re: [RFC PATCH] drm/bridge: panel: Use devm_drm_bridge_add()

2024-10-15 Thread Chen-Yu Tsai
On Wed, Oct 9, 2024 at 1:24 PM Fei Shao wrote: > > In the mtk_dsi driver, its DSI host attach callback calls > devm_drm_of_get_bridge() to get the next bridge. If that next bridge is > a panel bridge, a panel_bridge object is allocated and managed by the > panel device. > > Later, if the attach ca

Re: [PATCH v10 0/5] Fix degradation problem of alpha blending series

2024-10-08 Thread Chen-Yu Tsai
On Tue, Oct 8, 2024 at 3:07 PM Jason-JH Lin (林睿祥) wrote: > > On Tue, 2024-10-08 at 14:52 +0800, Chen-Yu Tsai wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > On Tue, Oct 8

Re: [PATCH v10 0/5] Fix degradation problem of alpha blending series

2024-10-07 Thread Chen-Yu Tsai
73. > > Fix the SoC degradation problem by this sreies. Tested-by: Chen-Yu Tsai > --- > > Change in v10: > 1. Fix the commit message and comment for OVL_CON_AEN Please carry tested-by tags from people for cosmetic changes such as this. > Change in v9: > 1. Add the fix pa

Re: [PATCH v9 0/5] Fix degradation problem of alpha blending series

2024-10-07 Thread Chen-Yu Tsai
73. > > Fix the SoC degradation problem by this sreies. The series fixes the display color issue on MT8173. Tested on Hana Chromebook (Telesu). Tested-by: Chen-Yu Tsai > --- > Change in v9: > 1. Add the fix patch for the XRGB downgrade issue of MT8173 > 2. Add the refine patch

Re: [PATCH v9 0/3] drm/mediatek: Add support for OF graphs

2024-09-10 Thread Chen-Yu Tsai
On Tue, Sep 10, 2024 at 5:01 PM AngeloGioacchino Del Regno wrote: > > Changes in v9: > - Rebased on next-20240910 > - Removed redundant assignment and changed a print to dev_err() > - Dropped if branch to switch conversion as requested; this will >be sent as a separate commit out of this se

Re: [PATCH] gpu: drm: Use devm_clk_get_enabled() helpers

2024-08-20 Thread Chen-Yu Tsai
On Tue, Aug 20, 2024 at 8:59 PM Rong Qianfeng wrote: > > Replace devm_clk_get() and clk_prepare_enable() with > devm_clk_get_enabled() that also disables and unprepares it on > driver detach. > > Signed-off-by: Rong Qianfeng > --- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 13 +++-- >

Re: [PATCH v3 20/26] dt-bindings: allwinner: add H616 DE33 clock binding

2024-08-18 Thread Chen-Yu Tsai
On Sun, Aug 18, 2024 at 7:08 AM Ryan Walklin wrote: > > The Allwinner H616 and variants have a new display engine revision > (DE33). > > Add a clock binding for the DE33. > > Signed-off-by: Ryan Walklin Reviewed-by: Chen-Yu Tsai

Re: [PATCH v3 21/26] dt-bindings: allwinner: add H616 DE33 mixer binding

2024-08-18 Thread Chen-Yu Tsai
cks, > therefore a fallback for the mixer compatible is not provided. > > Add a display engine mixer binding for the DE33. > > Signed-off-by: Ryan Walklin > Acked-by: Conor Dooley Reviewed-by: Chen-Yu Tsai

Re: [PATCH v3 19/26] dt-bindings: allwinner: add H616 DE33 bus binding

2024-08-18 Thread Chen-Yu Tsai
On Sun, Aug 18, 2024 at 7:08 AM Ryan Walklin wrote: > > The Allwinner H616 and variants have a new display engine revision > (DE33). > > Add a display engine bus binding for the DE33. > > Signed-off-by: Ryan Walklin > Acked-by: Conor Dooley Reviewed-by: Chen-Yu Tsai &

Re: [PATCH v3 04/26] drm: sun4i: de2: Initialize layer fields earlier

2024-08-18 Thread Chen-Yu Tsai
by: Jernej Skrabec > Co-developed-by: Ryan Walklin > Signed-off-by: Ryan Walklin Reviewed-by: Chen-Yu Tsai

Re: [PATCH v3 22/26] clk: sunxi-ng: ccu: add Display Engine 3.3 (DE33) support

2024-08-18 Thread Chen-Yu Tsai
On Sun, Aug 18, 2024 at 7:08 AM Ryan Walklin wrote: > > From: Jernej Skrabec > > The DE33 is a newer version of the Allwinner Display Engine IP block, > found in the H616, H618, H700 and T507 SoCs. DE2 and DE3 are already > supported by the mainline driver. > > The DE33 in the H616 has mixer0 and

Re: panel-simple-dp-aux: "DP AUX done_probing() can't defer" on MT8186 w/ Collabora kernel

2024-08-02 Thread Chen-Yu Tsai
On Tue, Jul 30, 2024 at 7:24 AM Dmitry Baryshkov wrote: > > On Sat, Jul 27, 2024 at 08:33:10PM GMT, Alper Nebi Yasak wrote: > > Hi, > > > > I have a MT8186 "Magneton" Chromebook that I'm trying to boot a kernel > > based on Collabora's for-kernelci branch [1], using a config from > > postmarketOS

Re: [PATCH] drm/mediatek: Set sensible cursor width/height values to fix crash

2024-07-18 Thread Chen-Yu Tsai
(CC-ed Fei Shao) On Thu, Jul 18, 2024 at 4:24 PM AngeloGioacchino Del Regno wrote: > > Hardware-speaking, there is no feature-reduced cursor specific > plane, so this driver reserves the last all Overlay plane as a > Cursor plane, but sets the maximum cursor width/height to the > maximum value th

Re: [PATCH v2] drm/mipi-dsi: Add OF notifier handler

2024-07-04 Thread Chen-Yu Tsai
On Fri, Jun 28, 2024 at 6:31 PM Luca Ceresoli wrote: > > Hello Chen-Yu, > > +Rob > > On Thu, 27 Jun 2024 15:19:03 +0800 > Chen-Yu Tsai wrote: > > > Add OF notifier handler needed for creating/destroying MIPI DSI devices > > according to dynamic runtime chang

[PATCH v2] drm/mipi-dsi: Add OF notifier handler

2024-06-27 Thread Chen-Yu Tsai
Add OF notifier handler needed for creating/destroying MIPI DSI devices according to dynamic runtime changes in the DT live tree. This code is enabled when CONFIG_OF_DYNAMIC is selected. This is based on existing code for I2C and SPI subsystems. Signed-off-by: Chen-Yu Tsai --- Changes since v1

Re: [PATCH v4 1/5] clk: sunxi-ng: common: Support minimum and maximum rate

2024-06-26 Thread Chen-Yu Tsai
On Thu, Jun 27, 2024 at 9:23 AM Pafford, Robert J. wrote: > > Frank Oltmanns writes: > > > Hi Robert, > > > > 26.06.2024 18:03:24 Pafford, Robert J. : > > > >> Hi Frank, > >> > >> Moving to a new for loop makes sense. Let me know when you have a patch > > > > The patch is here, strange you didn't

Re: [PATCH] drm/mediatek: select DRM_GEM_DMA_HELPER if DRM_FBDEV_EMULATION=y

2024-06-25 Thread Chen-Yu Tsai
Hi Thomas, On Thu, Jun 20, 2024 at 10:20 PM Chun-Kuang Hu wrote: > > Hi, Chen-Yu: > > Chen-Yu Tsai 於 2024年6月20日 週四 下午1:47寫道: > > > > With the recent switch from fbdev-generic to fbdev-dma, the driver now > > requires the DRM GEM DMA helpers. This dependency is miss

[PATCH] drm/mipi-dsi: Add OF notifier handler

2024-06-25 Thread Chen-Yu Tsai
Add OF notifier handler needed for creating/destroying MIPI DSI devices according to dynamic runtime changes in the DT live tree. This code is enabled when CONFIG_OF_DYNAMIC is selected. This is based on existing code for I2C and SPI subsystems. Signed-off-by: Chen-Yu Tsai --- This is a patch I

Re: [PATCH] drm/mediatek: select DRM_GEM_DMA_HELPER if DRM_FBDEV_EMULATION=y

2024-06-20 Thread Chen-Yu Tsai
On Thu, Jun 20, 2024 at 2:37 PM Thomas Zimmermann wrote: > > Hi > > Am 20.06.24 um 07:47 schrieb Chen-Yu Tsai: > > With the recent switch from fbdev-generic to fbdev-dma, the driver now > > requires the DRM GEM DMA helpers. This dependency is missing, and will > >

[PATCH] drm/mediatek: select DRM_GEM_DMA_HELPER if DRM_FBDEV_EMULATION=y

2024-06-19 Thread Chen-Yu Tsai
With the recent switch from fbdev-generic to fbdev-dma, the driver now requires the DRM GEM DMA helpers. This dependency is missing, and will cause a link failure if fbdev emulation is enabled. Add the missing dependency. Fixes: 0992284b4fe4 ("drm/mediatek: Use fbdev-dma") Signed-off-b

Re: [PATCH 3/6] dt-bindings: gpu: powervr-rogue: Add MediaTek MT8173 GPU

2024-06-13 Thread Chen-Yu Tsai
On Tue, Jun 4, 2024 at 12:18 PM Chen-Yu Tsai wrote: > > On Fri, May 31, 2024 at 9:37 PM Frank Binns wrote: > > > > Hi ChenYu, > > > > On Thu, 2024-05-30 at 16:35 +0800, Chen-Yu Tsai wrote: > > > The MediaTek MT8173 comes with a PowerVR Rogue GX6250, w

Re: [PATCH v5 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

2024-06-05 Thread Chen-Yu Tsai
On Wed, Jun 5, 2024 at 7:15 PM AngeloGioacchino Del Regno wrote: > > Il 05/06/24 03:38, CK Hu (胡俊光) ha scritto: > > Hi, Angelo: > > > > On Tue, 2024-05-21 at 09:57 +0200, AngeloGioacchino Del Regno wrote: > >> Document OF graph on MMSYS/VDOSYS: this supports up to three DDP paths > >> per HW insta

Re: [PATCH 5/6] arm64: dts: mediatek: mt8173: Fix MFG_ASYNC power domain clock

2024-06-05 Thread Chen-Yu Tsai
On Wed, Jun 5, 2024 at 7:25 PM AngeloGioacchino Del Regno wrote: > > Il 05/06/24 10:25, Chen-Yu Tsai ha scritto: > > On Thu, May 30, 2024 at 6:03 PM AngeloGioacchino Del Regno > > wrote: > >> > >> Il 30/05/24 10:35, Chen-Yu Tsai ha scritto: > >>>

Re: [PATCH 2/6] clk: mediatek: Add mt8173-mfgtop driver

2024-06-05 Thread Chen-Yu Tsai
On Thu, May 30, 2024 at 6:16 PM Chen-Yu Tsai wrote: > > On Thu, May 30, 2024 at 5:59 PM AngeloGioacchino Del Regno > wrote: > > > > Il 30/05/24 10:35, Chen-Yu Tsai ha scritto: > > > The MFG (GPU) block on the MT8173 has a small glue layer, named MFG_TOP > &g

Re: [PATCH 5/6] arm64: dts: mediatek: mt8173: Fix MFG_ASYNC power domain clock

2024-06-05 Thread Chen-Yu Tsai
On Thu, May 30, 2024 at 6:03 PM AngeloGioacchino Del Regno wrote: > > Il 30/05/24 10:35, Chen-Yu Tsai ha scritto: > > The MFG_ASYNC domain, which is likely associated to the whole MFG block, > > currently specifies clk26m as its domain clock. This is bogus, since the > &

Re: [PATCH v2 2/2] drm/panfrost: Add support for Mali on the MT8188 SoC

2024-06-04 Thread Chen-Yu Tsai
t; > Signed-off-by: AngeloGioacchino Del Regno > Reviewed-by: Chen-Yu Tsai > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c > b/drivers/gpu/drm/panfrost/panfrost_drv.c > in

Re: [PATCH v2 1/2] dt-bindings: gpu: mali-bifrost: Add compatible for MT8188 SoC

2024-06-04 Thread Chen-Yu Tsai
On Tue, Jun 4, 2024 at 8:39 PM AngeloGioacchino Del Regno wrote: > > Add a compatible for the MediaTek MT8188 SoC, with an integrated > ARM Mali G57 MC3 (Valhall-JM) GPU. > > Signed-off-by: AngeloGioacchino Del Regno > Reviewed-by: Chen-Yu Tsai > --- > Documentation

Re: [PATCH 3/6] dt-bindings: gpu: powervr-rogue: Add MediaTek MT8173 GPU

2024-06-03 Thread Chen-Yu Tsai
On Fri, May 31, 2024 at 10:25 PM Adam Ford wrote: > > On Fri, May 31, 2024 at 8:37 AM Frank Binns wrote: > > > > Hi ChenYu, > > > > On Thu, 2024-05-30 at 16:35 +0800, Chen-Yu Tsai wrote: > > > The MediaTek MT8173 comes with a PowerVR Rogue GX6250, w

Re: [PATCH 3/6] dt-bindings: gpu: powervr-rogue: Add MediaTek MT8173 GPU

2024-06-03 Thread Chen-Yu Tsai
On Fri, May 31, 2024 at 9:37 PM Frank Binns wrote: > > Hi ChenYu, > > On Thu, 2024-05-30 at 16:35 +0800, Chen-Yu Tsai wrote: > > The MediaTek MT8173 comes with a PowerVR Rogue GX6250, which is one > > of the Series6XT GPUs, another sub-family of the Rogue family. > >

Re: [PATCH 4/6] drm/imagination: Add compatible string entry for Series6XT

2024-06-02 Thread Chen-Yu Tsai
On Fri, May 31, 2024 at 7:18 PM Frank Binns wrote: > > On Thu, 2024-05-30 at 16:35 +0800, Chen-Yu Tsai wrote: > > The MediaTek MT8173 comes with a PowerVR Rogue GX6250, which is part > > of the Series6XT, another variation of the Rogue family of GPUs. > > > &g

Re: [PATCH 1/6] dt-bindings: clock: mediatek: Add mt8173 mfgtop

2024-05-31 Thread Chen-Yu Tsai
On Thu, May 30, 2024 at 11:43 PM Conor Dooley wrote: > > On Thu, May 30, 2024 at 04:35:00PM +0800, Chen-Yu Tsai wrote: > > The MFG (GPU) block on the MT8173 has a small glue layer, named MFG_TOP > > in the datasheet, that contains clock gates, some power sequence signal >

Re: [PATCH 0/6] powervr: MT8173 GPU support

2024-05-30 Thread Chen-Yu Tsai
On Thu, May 30, 2024 at 4:35 PM Chen-Yu Tsai wrote: > > Hi everyone, > > This series enables the PowerVR GPU found in the MT8173 SoC, found in > some Chromebooks. > > This version is different from the initial powervr driver submission [1] > in that it splits out the GPU g

Re: [PATCH 2/6] clk: mediatek: Add mt8173-mfgtop driver

2024-05-30 Thread Chen-Yu Tsai
On Thu, May 30, 2024 at 5:59 PM AngeloGioacchino Del Regno wrote: > > Il 30/05/24 10:35, Chen-Yu Tsai ha scritto: > > The MFG (GPU) block on the MT8173 has a small glue layer, named MFG_TOP > > in the datasheet, that contains clock gates, some power sequence signal > > d

[PATCH 5/6] arm64: dts: mediatek: mt8173: Fix MFG_ASYNC power domain clock

2024-05-30 Thread Chen-Yu Tsai
t;) Signed-off-by: Chen-Yu Tsai --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 3458be7f7f61..136b28f80cc2 100644 --- a/arch/arm64/boot/dt

[PATCH 3/6] dt-bindings: gpu: powervr-rogue: Add MediaTek MT8173 GPU

2024-05-30 Thread Chen-Yu Tsai
/ Signed-off-by: Chen-Yu Tsai --- .../bindings/gpu/img,powervr-rogue.yaml | 24 +++ 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml index

[PATCH 6/6] arm64: dts: mediatek: mt8173: Add GPU device nodes

2024-05-30 Thread Chen-Yu Tsai
The MediaTek MT8173 comes with a PowerVR Rogue GX6250, which is part of the Series6XT, another variation of the Rogue family of GPUs. On top of the GPU is a glue layer that handles some clock and power signals. Add device nodes for both. Signed-off-by: Chen-Yu Tsai --- arch/arm64/boot/dts

[PATCH 1/6] dt-bindings: clock: mediatek: Add mt8173 mfgtop

2024-05-30 Thread Chen-Yu Tsai
, while the power sequencing bits are exposed as one singular power domain. Signed-off-by: Chen-Yu Tsai --- .../clock/mediatek,mt8173-mfgtop.yaml | 71 +++ include/dt-bindings/clock/mt8173-clk.h| 7 ++ 2 files changed, 78 insertions(+) create mode 100644

[PATCH 4/6] drm/imagination: Add compatible string entry for Series6XT

2024-05-30 Thread Chen-Yu Tsai
The MediaTek MT8173 comes with a PowerVR Rogue GX6250, which is part of the Series6XT, another variation of the Rogue family of GPUs. Signed-off-by: Chen-Yu Tsai --- drivers/gpu/drm/imagination/pvr_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/imagination/pvr_drv.c

[PATCH 2/6] clk: mediatek: Add mt8173-mfgtop driver

2024-05-30 Thread Chen-Yu Tsai
, while the power sequencing bits are exposed as one singular power domain. Signed-off-by: Chen-Yu Tsai --- drivers/clk/mediatek/Kconfig | 9 + drivers/clk/mediatek/Makefile| 1 + drivers/clk/mediatek/clk-mt8173-mfgtop.c | 240 +++ 3 files changed, 250

  1   2   3   4   5   6   7   8   9   10   >