Re: [Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

2022-03-02 Thread Chris Wilson
iary table invalidation is done only for the > engine executing the request. And the mmio address for the aux_inv > register is set after the engine instance becomes certain. > > Signed-off-by: Chris Wilson > Signed-off-by: Fei Yang > --- > drivers/gpu/drm/i915/gt/gen8_eng

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Rename gt to gt0

2021-11-17 Thread Chris Wilson
Quoting Andi Shyti (2021-11-17 13:34:56) > diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c > b/drivers/gpu/drm/i915/display/intel_atomic_plane.c > index 089fb4658b216..0bbf8c0c42eac 100644 > --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c > +++

Re: [Intel-gfx] [PATCH] drm/i915: remove IS_ACTIVE

2021-10-01 Thread Chris Wilson
Quoting Lucas De Marchi (2021-10-01 08:40:41) > When trying to bring IS_ACTIVE to linux/kconfig.h I thought it wouldn't > provide much value just encapsulating it in a boolean context. So I also > added the support for handling undefined macros as the IS_ENABLED() > counterpart. However the

Re: [PATCH] i915: Drop relocation support on all new hardware (v3)

2021-03-11 Thread Chris Wilson
Quoting Zbigniew Kempczyński (2021-03-11 11:44:32) > On Wed, Mar 10, 2021 at 03:50:07PM -0600, Jason Ekstrand wrote: > > The Vulkan driver in Mesa for Intel hardware never uses relocations if > > it's running on a version of i915 that supports at least softpin which > > all versions of i915

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Propagate errors on awaiting already signaled fences"

2021-03-11 Thread Chris Wilson
Quoting Daniel Vetter (2021-03-11 16:01:46) > On Fri, Mar 05, 2021 at 11:05:46AM -0600, Jason Ekstrand wrote: > > This reverts commit 9e31c1fe45d555a948ff66f1f0e3fe1f83ca63f7. Ever > > since that commit, we've been having issues where a hang in one client > > can propagate to another. In

Re: [PATCH] gpu: drm: i915: fix error return code of igt_buddy_alloc_smoke()

2021-03-08 Thread Chris Wilson
Quoting Jia-Ju Bai (2021-03-08 08:59:52) > When i915_random_order() returns NULL to order, no error return code of > igt_buddy_alloc_smoke() is assigned. > To fix this bug, err is assigned with -EINVAL in this case. It would not be EINVAL since that is used for a reference failure, but in this

Re: [PATCH] gpu: drm: i915: fix error return code of igt_threaded_blt()

2021-03-08 Thread Chris Wilson
Quoting Jia-Ju Bai (2021-03-08 09:07:22) > When kcalloc() returns NULL to tsk or thread, no error code of > igt_threaded_blt() is returned. > To fix this bug, -ENOMEM is returned as error code. Because we decided to skip the test if it could not be run due to insufficient memory, as opposed to

Re: [PATCH] Revert "drm/i915: Propagate errors on awaiting already signaled fences"

2021-03-05 Thread Chris Wilson
Quoting Jason Ekstrand (2021-03-05 17:05:46) > This reverts commit 9e31c1fe45d555a948ff66f1f0e3fe1f83ca63f7. Ever > since that commit, we've been having issues where a hang in one client > can propagate to another. In particular, a hang in an app can propagate > to the X server which causes the

[PATCH] dma-buf: Fix confusion of dynamic dma-buf vs dynamic attachment

2021-03-05 Thread Chris Wilson
nning the attachment if the attachment rather than the dmabuf is to be dynamic. Fixes: bb42df4662a4 ("dma-buf: add dynamic DMA-buf handling v15") Fixes: c545781e1c55 ("dma-buf: doc polish for pin/unpin") Signed-off-by: Chris Wilson Cc: Daniel Vetter Cc: Christian König Cc: #

Re: [Intel-gfx] [PATCH] drm/i915/gem: Add a check for object size for corner cases

2021-02-16 Thread Chris Wilson
Quoting Ram Moon, AnandX (2021-02-16 12:05:23) > Hi Chris, > > -Original Message- > From: dri-devel On Behalf Of Chris > Wilson > Sent: Monday, February 15, 2021 6:10 PM > To: Auld, Matthew ; Ram Moon, AnandX > ; Surendrakumar Upadhyay, TejaskumarX > ; Ursul

Re: [Intel-gfx] [PATCH] drm/i915/gem: Add a check for object size for corner cases

2021-02-15 Thread Chris Wilson
Quoting Ram Moon, AnandX (2021-02-15 12:29:17) > Hi Chris, > > -Original Message- > From: dri-devel On Behalf Of Chris > Wilson > Sent: Wednesday, February 10, 2021 4:15 PM > To: Ram Moon, AnandX ; Jani Nikula > ; Auld, Matthew ; > Surendrakumar Upadhya

Re: [RFC 3/3] drm/i915/gt: Export device and per-process runtimes via procfs

2021-02-12 Thread Chris Wilson
Quoting Emil Velikov (2021-02-12 15:45:04) > On Fri, 12 Feb 2021 at 15:16, Chris Wilson wrote: > > > > Quoting Emil Velikov (2021-02-12 14:57:56) > > > Hi Chris, > > > > > > On Thu, 4 Feb 2021 at 12:11, Chris Wilson > > > wrote: > >

Re: [RFC 3/3] drm/i915/gt: Export device and per-process runtimes via procfs

2021-02-12 Thread Chris Wilson
Quoting Emil Velikov (2021-02-12 14:57:56) > Hi Chris, > > On Thu, 4 Feb 2021 at 12:11, Chris Wilson wrote: > > > > Register with /proc/gpu to provide the client runtimes for generic > > top-like overview, e.g. gnome-system-monitor can use this information to > &g

Re: [Intel-gfx] [PATCH] drm/i915/gem: Add a check for object size for corner cases

2021-02-10 Thread Chris Wilson
Quoting Anand Moon (2021-02-10 07:59:29) > Add check for object size to return appropriate error -E2BIG or -EINVAL > to avoid WARM_ON and sucessfull return for some testcase. No. You miss the point of having those warnings. We need to inspect the code to remove the last remaining "int pagenum",

[PATCH v3] kcmp: Support selection of SYS_kcmp without CHECKPOINT_RESTORE

2021-02-05 Thread Chris Wilson
CHECKPOINT_RESTORE in their configs and so, by extension, SYS_kcmp. References: https://gitlab.freedesktop.org/drm/intel/-/issues/3046 Signed-off-by: Chris Wilson Cc: Kees Cook Cc: Andy Lutomirski Cc: Will Drewry Cc: Andrew Morton Cc: Dave Airlie Cc: Daniel Vetter Cc: Lucas Stach Cc: Rasmus Villemoes Cc

Re: [PATCH v2] kernel: Expose SYS_kcmp by default

2021-02-05 Thread Chris Wilson
Quoting Kees Cook (2021-02-05 21:20:33) > On Fri, Feb 05, 2021 at 09:16:01PM +0000, Chris Wilson wrote: > > The subject should of course be changed, as it is no longer being > > enabled by default. > > "default n" is redundant. I thought being explicit would be p

Re: [PATCH v2] kernel: Expose SYS_kcmp by default

2021-02-05 Thread Chris Wilson
The subject should of course be changed, as it is no longer being enabled by default. Something like kcmp: Support selection of SYS_kcmp without CHECKPOINT_RESTORE Quoting Chris Wilson (2021-02-05 21:06:10) > Userspace has discovered the functionality offered by SYS_kcmp and has > s

[PATCH v2] kernel: Expose SYS_kcmp by default

2021-02-05 Thread Chris Wilson
/3046 Signed-off-by: Chris Wilson Cc: Kees Cook Cc: Andy Lutomirski Cc: Will Drewry Cc: Andrew Morton Cc: Dave Airlie Cc: Daniel Vetter Cc: Lucas Stach Acked-by: Daniel Vetter # DRM depends on SYS_kcmp --- v2: - Default n. - Borrrow help message from man kcmp. - Export

[PATCH] kernel: Expose SYS_kcmp by default

2021-02-05 Thread Chris Wilson
, lift SYS_kcmp out of the non-default CONFIG_CHECKPOINT_RESTORE into the selectable syscall category. Signed-off-by: Chris Wilson Cc: Kees Cook Cc: Andy Lutomirski Cc: Will Drewry Cc: Andrew Morton Cc: Dave Airlie Cc: Daniel Vetter Cc: Lucas Stach --- init/Kconfig

[PATCH] drm/i915: Autoselect CONFIG_CHECKPOINT_RESTORE for SYS_kcmp

2021-02-05 Thread Chris Wilson
/intel/-/issues/3046 Signed-off-by: Chris Wilson Cc: Jani Nikula Cc: Daniel Vetter --- drivers/gpu/drm/i915/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index 1e1cb245fca7..470a5214bd33 100644 --- a/drivers/gpu/drm/i915

[RFC 3/3] drm/i915/gt: Export device and per-process runtimes via procfs

2021-02-04 Thread Chris Wilson
Register with /proc/gpu to provide the client runtimes for generic top-like overview, e.g. gnome-system-monitor can use this information to show the per-process multi-GPU usage. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/gt/intel_gt.c

[RFC 2/3] drm/i915: Look up clients by pid

2021-02-04 Thread Chris Wilson
Use the pid to find associated clients, and report their runtime. This will be used to provide the information via procfs. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drm_client.c | 70 +++--- drivers/gpu/drm/i915/i915_drm_client.h | 12 +++-- 2 files changed

[RFC 1/3] proc: Show GPU runtimes

2021-02-04 Thread Chris Wilson
that would show the GPU% on/next the CPU overview. Then we could have a futher expansion of a GPU% into per-channel utilisation. That would be useful to check to see what is saturating a particular channel, e.g. find the video decoder bottleneck. Signed-off-by: Chris Wilson --- fs/proc/Makefile

Re: [Intel-gfx] v5.11-rc5 BUG kmalloc-1k (Not tainted): Redzone overwritten

2021-02-01 Thread Chris Wilson
Quoting Jani Nikula (2021-01-28 13:23:48) > > A number of our CI systems are hitting redzone overwritten errors after > s2idle, with the errors introduced between v5.11-rc4 and v5.11-rc5. See > snippet below, full logs for one affected machine at [1]. > > Known issue? Fwiw, I think this should

Re: [PATCH] drm/i915: Remove unreachable code

2021-01-30 Thread Chris Wilson
Quoting Vinicius Tinti (2021-01-30 12:34:11) > On Fri, Jan 29, 2021 at 08:55:54PM +0000, Chris Wilson wrote: > > Quoting Vinicius Tinti (2021-01-29 18:15:19) > > > By enabling -Wunreachable-code-aggressive on Clang the following code > > > paths are unreachable

Re: [PATCH] drm/i915: Remove unreachable code

2021-01-29 Thread Chris Wilson
Quoting Vinicius Tinti (2021-01-29 18:15:19) > By enabling -Wunreachable-code-aggressive on Clang the following code > paths are unreachable. That code exists as commentary and, especially for sdvo, library functions that we may need in future. The ivb-gt1 case => as we now set the gt level for

Re: [Intel-gfx] linux-next: Tree for Jan 27 (drm/i915)

2021-01-27 Thread Chris Wilson
Quoting Randy Dunlap (2021-01-27 20:28:05) > On 1/27/21 11:30 AM, Randy Dunlap wrote: > > On 1/27/21 11:08 AM, Randy Dunlap wrote: > >> On 1/27/21 6:44 AM, Stephen Rothwell wrote: > >>> Hi all, > >>> > >>> Note: the patch file has failed to upload :-( > >>> > >>> Changes since 20210125: > >>> > >>

Re: [Intel-gfx] [PATCH v5 4/5] drm/i915: Don't assign to struct drm_device.pdev

2021-01-27 Thread Chris Wilson
t as a copy of module parameters. */ Stick the mock - i915->drm.pdev = pdev; in this patch, and I'm happy. With that, the series is Reviewed-by: Chris Wilson -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v5 1/5] drm/i915: Remove references to struct drm_device.pdev

2021-01-27 Thread Chris Wilson
Quoting Thomas Zimmermann (2021-01-27 12:41:31) > diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c > b/drivers/gpu/drm/i915/selftests/mock_gem_device.c > index 0188f877cab2..2a07a008de2e 100644 > --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c > +++

Re: [PATCH v2] drm/i915/gt: use new tasklet API for execution list

2021-01-26 Thread Chris Wilson
next Ta. Saves me having to do the fixup. Reviewed-by: Chris Wilson Will be applied to drm-intel-gt-next which is scheduled for inclusion in 5.13. It should apply against the 5.12 merge window if there's a tree through which you want to migrate the tasklet API faster. -Chris

Re: [PATCH] drm/i915/gem: fix non-SMP build failure

2021-01-25 Thread Chris Wilson
Quoting Arnd Bergmann (2021-01-25 12:25:34) > From: Arnd Bergmann > > The x86-specific wbinvd_on_all_cpus() function is exported > through asm/smp.h, causing a build failure in the i915 driver > when SMP is disabled: > > drivers/gpu/drm/i915/i915_gem.c:1182:2: error: implicit declaration of >

Re: [PATCH] i915: Fix DRM_I915_WERROR dependencies

2021-01-25 Thread Chris Wilson
Quoting Arnd Bergmann (2021-01-25 12:26:44) > From: Arnd Bergmann > > CONFIG_DRM_I915_DEBUG now selects CONFIG_DRM_I915_WERROR, but fails > to honor its dependencies: > > WARNING: unmet direct dependencies detected for DRM_I915_WERROR > Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] &&

Re: [PATCH] drm/i915/gvt: fix uninitialized return in intel_gvt_update_reg_whitelist()

2021-01-25 Thread Chris Wilson
pin_map() > fails. True. > Let's fix the bug and silence the false positive. > > Fixes: 493f30cd086e ("drm/i915/gvt: parse init context to update cmd > accessible reg whitelist") > Signed-off-by: Dan Carpenter Reviewed-by: Chris Wilson -Chris ___

Re: [PATCH] drm/i915/selftest: Fix potential memory leak

2021-01-22 Thread Chris Wilson
Quoting Pan Bian (2021-01-22 01:56:40) > Object out is not released on path that no VMA instance found. The root > cause is jumping to an unexpected label on the error path. Wouldn't the root cause be whatever caused the allocation to fail? Language notwithstanding, Reviewed-by: Chris

Re: [PATCH v4 3/6] drm/i915/gt: Remove references to struct drm_device.pdev

2021-01-18 Thread Chris Wilson
Quoting Thomas Zimmermann (2021-01-18 13:14:17) > Using struct drm_device.pdev is deprecated. Convert i915 to struct > drm_device.dev. No functional changes. This needs to be before or in the previous patch, as that patch removed assignment of i915->drm.pdev. Or the removal of the assignment

Re: [PATCH] drm/i915/userptr: detect un-GUP-able pages early

2021-01-15 Thread Chris Wilson
Quoting Chris Wilson (2021-01-15 16:56:42) > Quoting Jinoh Kang (2021-01-15 16:23:31) > > If GUP-ineligible pages are passed to a GEM userptr object, -EFAULT is > > returned only when the object is actually bound. > > > > The xf86-video-intel userspace

Re: [PATCH] drm/i915/userptr: detect un-GUP-able pages early

2021-01-15 Thread Chris Wilson
Quoting Jinoh Kang (2021-01-15 16:23:31) > If GUP-ineligible pages are passed to a GEM userptr object, -EFAULT is > returned only when the object is actually bound. > > The xf86-video-intel userspace driver cannot differentiate this > condition, and marks the GPU as wedged. The idea was to call

Re: [PATCH] dma-buf: Add debug option

2021-01-15 Thread Chris Wilson
Quoting Daniel Vetter (2021-01-15 15:52:26) > +static void mangle_sg_table(struct sg_table *sg_table) > +{ > +#ifdef CONFIG_DMABUF_DEBUG > + int i; > + struct scatterlist *sg; > + > + if (!sg_table) if (!IS_ENABLED(CONFIG_DMABUF_DEBUG) || IS_ERR_OR_NULL(sg_table)) > +

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-01-15 Thread Chris Wilson
Quoting Daniel Vetter (2021-01-14 09:47:40) > On Thu, Jan 14, 2021 at 09:45:37AM +0000, Chris Wilson wrote: > > Quoting Daniel Vetter (2021-01-14 09:30:32) > > > On Thu, Jan 14, 2021 at 10:23 AM Chris Wilson > > > wrote: > > > > The only othe

Re: [Intel-gfx] [BUG] on reboot: bisected to: drm/i915: Shut down displays gracefully on reboot

2021-01-14 Thread Chris Wilson
Quoting Steven Rostedt (2021-01-14 21:32:06) > On reboot, one of my test boxes now triggers the following warning: 057fe3535eb3 ("drm/i915: Disable RPM wakeref assertions during driver shutdown") is included with the drm-intel-fixes PR. -Chris ___

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-01-14 Thread Chris Wilson
Quoting Daniel Vetter (2021-01-14 09:30:32) > On Thu, Jan 14, 2021 at 10:23 AM Chris Wilson > wrote: > > The only other problem I see with the implementation is that there's > > nothing that says that each dmabuf->ops->map_dma_buf() returns a new > > sg_table, so

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-01-14 Thread Chris Wilson
Quoting Daniel Vetter (2021-01-14 09:02:57) > On Wed, Jan 13, 2021 at 10:08 PM Chris Wilson > wrote: > > Quoting Daniel Vetter (2021-01-13 20:50:11) > > > On Wed, Jan 13, 2021 at 4:43 PM Chris Wilson > > > wrote: > > > > > > > > Quoting Dan

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-01-13 Thread Chris Wilson
Quoting Daniel Vetter (2021-01-13 20:50:11) > On Wed, Jan 13, 2021 at 4:43 PM Chris Wilson wrote: > > > > Quoting Daniel Vetter (2021-01-13 14:06:04) > > > We have too many people abusing the struct page they can get at but > > > really shouldn't in importers.

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-01-13 Thread Chris Wilson
Quoting Daniel Vetter (2021-01-13 14:06:04) > We have too many people abusing the struct page they can get at but > really shouldn't in importers. Aside from that the backing page might > simply not exist (for dynamic p2p mappings) looking at it and using it > e.g. for mmap can also wreak the page

Re: [PATCH] [v2] i915: fix shift warning

2021-01-03 Thread Chris Wilson
uiltin_constant_p(w) ? __const_hweight64(w) : > __arch_hweight64(w)) > > Change it to hweight_long() to avoid the warning. > > Signed-off-by: Arnd Bergmann Reviewed-by:: Chris Wilson -Chris ___ dri-devel mailing list dri-devel@lists.freed

Re: [PATCH] i915: fix shift warning

2021-01-02 Thread Chris Wilson
Quoting Arnd Bergmann (2021-01-02 11:23:20) > On Wed, Dec 30, 2020 at 4:56 PM Chris Wilson wrote: > > > > Quoting Arnd Bergmann (2020-12-30 15:39:14) > > > From: Arnd Bergmann > > > > > > Randconfig builds on 32-bit machines show lots of warnings for >

Re: [PATCH] i915: fix shift warning

2020-12-30 Thread Chris Wilson
Quoting Arnd Bergmann (2020-12-30 15:39:14) > From: Arnd Bergmann > > Randconfig builds on 32-bit machines show lots of warnings for > the i915 driver for incorrect bit masks like: mask is a u8. VCS0 is 2, I915_MAX_VCS 4 (u8 & GENMASK(5, 2)) >> 2 >

Re: [PATCH] drm/i915: remove h from printk format specifier

2020-12-15 Thread Chris Wilson
Quoting t...@redhat.com (2020-12-15 14:41:01) > From: Tom Rix > > See Documentation/core-api/printk-formats.rst. > h should no longer be used in the format specifier for printk. It's understood by format_decode(). * 'h', 'l', or 'L' for integer fields At least reference commit cbacb5ab0aa0

Re: [Intel-gfx] [PATCH] drm/i915: Check the correct variable

2020-12-03 Thread Chris Wilson
Quoting Andi Shyti (2020-12-03 11:12:24) > Hi Dan, > > > There is a copy and paste bug in this code. It's supposed to check > > "obj2" instead of checking "obj" a second time. > > > > Fixes: 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx > > locking, v2.") > >

Re: [PATCH] drm/i915: Check the correct variable

2020-12-03 Thread Chris Wilson
rnal(i915, PAGE_SIZE); > - if (IS_ERR(obj)) { > - err = PTR_ERR(obj); > + if (IS_ERR(obj2)) { > + err = PTR_ERR(obj2); Reviewed-by: Chris Wilson -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [RFC PATCH 092/162] drm/i915/uapi: introduce drm_i915_gem_create_ext

2020-12-01 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:08) > Same old gem_create but with now with extensions support. This is needed > to support various upcoming usecases. For now we use the extensions > mechanism to support setting an immutable-priority-list of potential > placements, at creation time. > > If

Re: [Intel-gfx] [RFC PATCH 124/162] drm/i915/lmem: allocate HWSP in lmem

2020-11-30 Thread Chris Wilson
Quoting Matthew Auld (2020-11-30 17:17:16) > On 27/11/2020 13:55, Chris Wilson wrote: > > Quoting Matthew Auld (2020-11-27 12:06:40) > >> From: Michel Thierry > > > > Rationale goes here. > > > > Is this wise? HWSP is very frequently read by the CPU

Re: [Intel-gfx] [RFC PATCH 118/162] drm/i915/dg1: Reserve first 1MB of local memory

2020-11-30 Thread Chris Wilson
Quoting Matthew Auld (2020-11-30 11:09:57) > On 27/11/2020 13:52, Chris Wilson wrote: > > Quoting Matthew Auld (2020-11-27 12:06:34) > >> From: Imre Deak > >> > >> On DG1 A0/B0 steppings the first 1MB of local memory must be reserved. > >> One reas

Re: [RFC PATCH 107/162] drm/i915: setup GPU device lmem region

2020-11-30 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:23) > From: CQ Tang > > The lmem region needs to remove the stolen part. > > Cc: Joonas Lahtinen > Cc: Matthew Auld > Cc: Abdiel Janulgue > Cc: Chris P Wilson > Cc: Balestrieri, Francesco > Cc: Niranjana Vishwanathapura > Cc: Venkata S Dhanalakota >

RE: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

2020-11-27 Thread Chris Wilson
Quoting Pandey, Hariom (2020-10-28 11:55:04) > Ok, I have initiated the steps to upgrade the CI machine's silicon & BIOS. The single ehl we have in CI is still failing to enter rc6, both in the selftest and runtime testing. And I note that RAPL doesn't recognise it, so it doesn't report the power

Re: [RFC PATCH 006/162] drm/i915: split gen8+ flush and bb_start emission functions to their own file

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:04:42) > From: Daniele Ceraolo Spurio > > These functions are independent from the backend used and can therefore > be split out of the exelists submission file, so they can be re-used by > the upcoming GuC submission backend. > > Base

Re: [RFC PATCH 005/162] drm/i915/gt: Rename lrc.c to execlists_submission.c

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:04:41) > From: Chris Wilson > > We want to separate the utility functions for controlling the logical > ring context from the execlists submission mechanism (which is an > overgrown scheduler). > > This is similar to Daniele's work

Re: [Intel-gfx] [RFC PATCH 004/162] drm/i915/gt: Move move context layout registers and offsets to lrc_reg.h

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:04:40) > From: Chris Wilson > > Cleanup intel_lrc.h by moving some of the residual common register > definitions into intel_lrc_reg.h, prior to rebranding and splitting off > the submission backends. > > v2: keep the SCHEDULE enum i

Re: [RFC PATCH 001/162] drm/i915/selftest: also consider non-contiguous objects

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:04:37) > In igt_ppgtt_sanity_check we should also exercise the non-contiguous > option for LMEM, since this will give us slightly different sg layouts > and alignment. > > Signed-off-by: Matthew Auld Reviewed-by: Chris

Re: [PATCH] drm/i915: remove trailing semicolon in macro definition

2020-11-27 Thread Chris Wilson
esno(info->name)); > +#define PRINT_FLAG(name) drm_printf(p, "%s: %s\n", #name, yesno(info->name)) > DEV_INFO_FOR_EACH_FLAG(PRINT_FLAG); I thought that this was a macro that avoided adding the ';' to each invocation. Perhaps another time. Reviewed-by: Chris Wilso

Re: [Intel-gfx] [RFC PATCH 092/162] drm/i915/uapi: introduce drm_i915_gem_create_ext

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:08) > +int > +i915_gem_create_ioctl(struct drm_device *dev, void *data, > + struct drm_file *file) > +{ > + struct drm_i915_private *i915 = to_i915(dev); > + struct create_ext ext_data = { .i915 = i915 }; > + struct

Re: [Intel-gfx] [RFC PATCH 160/162] drm/i915/dg1: Fix GPU hang due to shmemfs page drop

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:07:16) > From: Venkata Ramana Nayana > > This is to fix a bug in upstream > commit a6326a4f8ffb ("drm/i915/gt: Keep a no-frills swappable copy of the > default context state") > > We allocate context state obj ce->state from lmem, so in >

Re: [Intel-gfx] [RFC PATCH 157/162] drm/i915: Improve accuracy of eviction stats

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:07:13) > From: Tvrtko Ursulin > > Current code uses jiffie time to do the accounting and then does: > > diff = jiffies - start; > msec = diff * 1000 / HZ; > ... > atomic_long_add(msec, >time_swap_out_ms); > > If we assume jiffie can be as

Re: [RFC PATCH 150/162] drm/i915: need consider system BO snoop for dgfx

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:07:06) > From: CQ Tang > > When cache_level is NONE, we check HAS_LLC(i915). > But additionally for DGFX, we also need to check > HAS_SNOOP(i915) on system memory object to use > I915_BO_CACHE_COHERENT_FOR_READ. on dg1, has_llc=0, and > has_snoop=1. Otherwise,

Re: [Intel-gfx] [RFC PATCH 148/162] drm/i915: suspend/resume enable blitter eviction

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:07:04) > From: Venkata Ramana Nayana > > In suspend mode use blitter eviction before disable the runtime > interrupts and in resume use blitter after the gem resume happens. Consider add it to the suspend prepare function. -Chris

Re: [RFC PATCH 147/162] drm/i915/gt: Allocate default ctx objects in SMEM

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:07:03) > From: Venkata Ramana Nayana > > If record default objects are created in LMEM and in suspend > pin the pages of obj (src) and use blitter for eviction. But > during request creation using blitter context and try to pin the same > default object, to

Re: [Intel-gfx] [RFC PATCH 146/162] drm/i915/pm: suspend and restore ppgtt mapping

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:07:02) > From: Prathap Kumar Valsan > > During suspend we will lose all page tables as they are allocated in > LMEM. In-order to make sure that the contexts do not access the > corrupted page table after we restore, we are evicting all vma's that > are bound

Re: [RFC PATCH 144/162] drm/i915: Reset blitter context when unpark engine

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:07:00) > From: Venkata Ramana Nayana > > We are only doing it now for kernel_context. We also need to do for the > copy engine blitter context. > > Signed-off-by: Venkata Ramana Nayana > --- > drivers/gpu/drm/i915/gt/intel_engine_pm.c | 5 + > 1 file

Re: [RFC PATCH 143/162] drm/i915: suspend/resume eviction

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:59) > +static int intel_dmem_evict_buffers(struct drm_device *dev, bool in_suspend) > +{ > + struct drm_i915_private *i915 = to_i915(dev); > + struct drm_i915_gem_object *obj; > + struct intel_memory_region *mem; > + int id, ret = 0; >

Re: [Intel-gfx] [RFC PATCH 141/162] drm/i915: Lmem eviction statistics by category

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:57) > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 82f431cc38cd..6f0ab363bdee 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -1225,6 +1225,11 @@ struct drm_i915_private { >

Re: [Intel-gfx] [RFC PATCH 140/162] drm/i915: window_blt_copy is used for swapin and swapout

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:56) > From: Ramalingam C > > window_blt_copy feature is used for swapin and swapout based on the i915 > module parameter called enable_eviction. A module parameter? -Chris ___ dri-devel mailing list

Re: [Intel-gfx] [RFC PATCH 137/162] drm/i915: blt copy between objs using pre-created vma windows

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:53) > +int i915_window_blt_copy(struct drm_i915_gem_object *dst, > +struct drm_i915_gem_object *src) > +{ > + struct drm_i915_private *i915 = to_i915(src->base.dev); > + struct intel_context *ce =

Re: [Intel-gfx] [RFC PATCH 134/162] drm/i915/dg1: Measure swap in/out timing stats

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:50) > From: Sudeep Dutt > > Signed-off-by: Sudeep Dutt > --- > drivers/gpu/drm/i915/gem/i915_gem_region.c | 16 ++-- > drivers/gpu/drm/i915/i915_debugfs.c| 3 +++ > drivers/gpu/drm/i915/i915_drv.h| 2 ++ > 3 files

Re: [Intel-gfx] [RFC PATCH 133/162] drm/i915/dg1: Track swap in/out stats via debugfs

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:49) > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 1366b53ac8c9..7b1e95d494e6 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -1214,6 +1214,9 @@ struct drm_i915_private { >

Re: [Intel-gfx] [RFC PATCH 128/162] drm/i915/dg1: intel_memory_region_evict() changes for eviction

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:44) > From: CQ Tang > > Function i915_gem_shrink_memory_region() is changed to > intel_memory_region_evict() and moved from i915_gem_shrinker.c > to intel_memory_region.c, this function is used to handle local > memory swapping, in addition to evict

Re: [RFC PATCH 126/162] drm/i915/gem: Update shmem available memory

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:42) > From: Bommu Krishnaiah > > Update shmem available memory in “intel_memory_region” Was avail ever set? -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [Intel-gfx] [RFC PATCH 125/162] drm/i915/lmem: Limit block size to 4G

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:41) > From: Venkata Sandeep Dhanalakota > > when allocating pages to lmem object of size 4G or greater > we allocate memory blocks from buddy system. Any lmem object is from the buddy system. > In this scenario > buddy sytem can allocate blocks that can

Re: [Intel-gfx] [RFC PATCH 124/162] drm/i915/lmem: allocate HWSP in lmem

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:40) > From: Michel Thierry Rationale goes here. Is this wise? HWSP is very frequently read by the CPU, and expected to be cached on the CPU. What do the performance profiles indicate? -Chris ___ dri-devel

Re: [Intel-gfx] [RFC PATCH 118/162] drm/i915/dg1: Reserve first 1MB of local memory

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:34) > From: Imre Deak > > On DG1 A0/B0 steppings the first 1MB of local memory must be reserved. > One reason for this is that the 0xA-0xB range is not accessible > by the display, probably since this region is redirected to another > memory

Re: [Intel-gfx] [RFC PATCH 103/162] drm/i915: allocate context from LMEM

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:19) > Based on a patch from Michel Thierry. > > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Abdiel Janulgue > --- > .../drm/i915/gt/intel_execlists_submission.c | 31 ++- > 1 file changed, 30 insertions(+), 1 deletion(-) > >

Re: [Intel-gfx] [RFC PATCH 101/162] drm/i915/gtt/dg1: add PTE_LM plumbing for PPGTT

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:17) > For the PTEs we get an LM bit, to signal whether the page resides in > SMEM or LMEM. > > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Abdiel Janulgue > Signed-off-by: Daniele Ceraolo Spurio > Signed-off-by: Niranjana Vishwanathapura >

Re: [RFC PATCH 098/162] drm/i915/gtt: map the PD up front

2020-11-27 Thread Chris Wilson
xts. Here we replace the kmap with the object > maping code that for simple single page shmemfs object will return a > plain kmap, that is then kept for the lifetime of the page directory. > > Signed-off-by: Matthew Auld > Signed-off-by: Chris Wilson We are going to really struggle

Re: [Intel-gfx] [RFC PATCH 097/162] drm/i915: Distinction of memory regions

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:13) > From: Zbigniew Kempczyński > > IGTs should be able to choose testing strategy depending on memory > regions and its sizes. Add region instance number to make this > easier and descriptive. > > Cc: Matthew Auld > Cc: Ramalingam C > Cc: Tvrtko

Re: [RFC PATCH 093/162] drm/i915/lmem: allocate cmd ring in lmem

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:09) > From: Michel Thierry > > Signed-off-by: Michel Thierry > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Abdiel Janulgue > --- > drivers/gpu/drm/i915/gt/intel_ring.c | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-)

Re: [Intel-gfx] [RFC PATCH 092/162] drm/i915/uapi: introduce drm_i915_gem_create_ext

2020-11-27 Thread Chris Wilson
Quoting Matthew Auld (2020-11-27 12:06:08) > Same old gem_create but with now with extensions support. This is needed > to support various upcoming usecases. For now we use the extensions > mechanism to support setting an immutable-priority-list of potential > placements, at creation time. > > If

Re: [PATCH] drm/modes: Switch to 64bit maths to avoid integer overflow

2020-11-25 Thread Chris Wilson
Quoting Ville Syrjälä (2020-10-30 14:43:46) > On Fri, Oct 30, 2020 at 02:19:45PM +0000, Chris Wilson wrote: > > Quoting Ville Syrjala (2020-10-22 20:42:56) > > > From: Ville Syrjälä > > > > > > The new >8k CEA modes have dotclocks reaching 5.94 GHz, wh

Re: [Intel-gfx] [PATCH] drm/i915: fix error return code in check_partial_mapping()

2020-11-25 Thread Chris Wilson
Quoting Luo Meng (2020-11-25 01:29:38) > Fix to return a negative error code from the error handling case > instead of 0 in function check_partial_mapping(), as done elsewhere > in this function. It's not an error, just the end of testing. -Chris ___

Re: [PATCH] intel: Do not assert on unknown chips in drm_intel_decode_context_alloc

2020-11-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-11-19 13:42:07) > > On 18/11/2020 17:04, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-11-18 16:36:01) > >> From: Tvrtko Ursulin > >> > >> There is this long standing nit of igt/tools/intel_error_decode asserting > >

Re: [PATCH] intel: Do not assert on unknown chips in drm_intel_decode_context_alloc

2020-11-18 Thread Chris Wilson
_decode_context_alloc to make it > not assert but just return NULL (which seems an already possible return > value). > > Signed-off-by: Tvrtko Ursulin Good riddance, Reviewed-by: Chris Wilson -Chris ___ dri-devel mailing list dri-

[PATCH] Revert "drm: convert drm_atomic_uapi.c to new debug helpers"

2020-11-15 Thread Chris Wilson
t;[3.755211] Modules linked in: i915 mei_hdcp x86_pkg_temp_thermal coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_intel snd_intel_dspcfg snd_hda_codec r8169 snd_hwdep snd_hda_core realtek mei_me snd_pcm mei lpc_ich prime_numbers <4>[3.755224] CR2: 0000 &l

Re: [PATCH] drm/modes: Switch to 64bit maths to avoid integer overflow

2020-10-30 Thread Chris Wilson
Quoting Ville Syrjala (2020-10-22 20:42:56) > From: Ville Syrjälä > > The new >8k CEA modes have dotclocks reaching 5.94 GHz, which > means our clock*1000 will now overflow the 32bit unsigned > integer. Switch to 64bit maths to avoid it. > > Cc: sta...@vger.kernel.org > Reported-by: Randy

[PATCH v2] drm: Quieten [zero] EDID carping

2020-10-29 Thread Chris Wilson
it's just the loglevel chosen was set to be caught by CI if it ever occurred as it was expected to be an internal error not external. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2203 Signed-off-by: Chris Wilson Cc: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 4 ++-- 1 file changed, 2

Re: [Intel-gfx] [PATCH] drm: Silence zero EDID carping

2020-10-29 Thread Chris Wilson
Quoting Ville Syrjälä (2020-10-29 14:07:46) > On Thu, Oct 29, 2020 at 11:00:30AM +0000, Chris Wilson wrote: > > We have a few displays in CI that always report their EDID as a bunch of > > zeroes. This is consistent behavioud, so one assumes intentional > > indication of an

[PATCH] drm: Silence zero EDID carping

2020-10-29 Thread Chris Wilson
carp to EDID that violate their checksums or otherwise return unexpected illegal data upon reading. These are more likely to be inconsistent bad connections rather than being intended. Signed-off-by: Chris Wilson --- drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

Re: linux-next: Signed-off-by missing for commit in the drm-intel-fixes tree

2020-10-28 Thread Chris Wilson
Quoting Stephen Rothwell (2020-10-28 21:28:23) > Hi all, > > Commit > > d13208a88f41 ("lockdep: Fix nr_unused_locks") > > is missing a Signed-off-by from its author. > > Also, the author's email name is missing the leading 'P'. And it shouldn't be in the drm-intel-fixes tree. -Chris

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

2020-10-19 Thread Chris Wilson
Quoting Rodrigo Vivi (2020-10-19 19:29:36) > > I just checked the CI picture and it looks much better indeed. > > Only bad case being the gt_pm, which is also failing on other platforms. Not nearly in the same manner. CI is indicating that there is no RC6 entry and no power saving at all;

Re: [Intel-gfx] [PATCH] drm/vgem: Replace vgem_object_funcs with the common drm shmem helper

2020-10-12 Thread Chris Wilson
Quoting Daniel Vetter (2020-10-12 15:12:50) > On Mon, Oct 12, 2020 at 03:01:09PM +0100, Chris Wilson wrote: > > Quoting Daniel Vetter (2020-10-12 14:55:07) > > > On Mon, Oct 12, 2020 at 12:49 PM Chris Wilson > > > wrote: > > > > Quoting Daniel Vetter (2020-

Re: [Intel-gfx] [PATCH] drm/vgem: Replace vgem_object_funcs with the common drm shmem helper

2020-10-12 Thread Chris Wilson
Quoting Daniel Vetter (2020-10-12 14:55:07) > On Mon, Oct 12, 2020 at 12:49 PM Chris Wilson > wrote: > > Quoting Daniel Vetter (2020-10-09 17:16:06) > > > On Fri, Oct 9, 2020 at 12:21 PM Chris Wilson > > > wrote: > > > > > > > > vgem

Re: [PATCH 2/3] drm/vkms: Switch to shmem helpers

2020-10-12 Thread Chris Wilson
Quoting Daniel Vetter (2020-10-10 00:21:55) > Inspired by a patch by Chris Wilson for vgem. Plus this gives us vmap > at the gem bo level, which we need for generic fbdev emulation. > > Luckily shmem also tracks ->vaddr, so we just need to adjust the code > all over a bi

[PATCH 2/2] drm/vgem: Replace vgem_object_funcs with the common drm shmem helper

2020-10-12 Thread Chris Wilson
the helper. v2: The gem prime mmap helper does not handle exchanging the vma->file, so skip the conversion to the common prime helper and leave the patch only converting to the common shmem helper. Signed-off-by: Chris Wilson Reviewed-by: Daniel Vetter #v1 --- drivers/gpu/drm/Kconfig |

  1   2   3   4   5   6   7   8   9   10   >