[PATCH v2 resend] drm/armada: Fix off-by-one error in armada_overlay_get_property()

2023-05-23 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven Reviewed-by: Russell King (Oracle) --- Compile-tested only. v2: - Add Reviewed-by. --- drivers/gpu/drm/armada/armada_overlay.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_overlay.c b/drivers/gpu/

Convert existing KMS drivers to atomic modesetting?

2023-05-22 Thread Geert Uytterhoeven
, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.

Re: [PATCH] fbdev: fbmem: mark get_fb_unmapped_area() static

2023-05-19 Thread Geert Uytterhoeven
Hi Helge, On Fri, May 19, 2023 at 4:37 PM Helge Deller wrote: > * Geert Uytterhoeven : > > On Tue, May 16, 2023 at 10:23 PM Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > There is a global function with this name on sparc, but no > > >

Re: [PATCH v4 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-19 Thread Geert Uytterhoeven
during > creation. > > Suggested-by: Geert Uytterhoeven > Signed-off-by: Biju Das > --- > v3->v4: > * Dropped Rb tag from Geert as there are new changes. > * Introduced __i2c_new_dummy_device() to share the code between >i2c_new_dummy_device and i2c_new_ancillary_dev

Re: [PATCH] fbdev: fbmem: mark get_fb_unmapped_area() static

2023-05-17 Thread Geert Uytterhoeven
reable character device support on nommu"? This seems to be selected only by DRM_STM. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myse

Re: [PATCH v3 1/5] i2c: Enhance i2c_new_ancillary_device API

2023-05-16 Thread Geert Uytterhoeven
rom PMIC driver) > > Signed-off-by: Biju Das > --- > v3: > * New patch Thanks for your patch! Looks correct to me, so Reviewed-by: Geert Uytterhoeven Some suggestions for improvement below... > --- a/drivers/i2c/i2c-core-base.c > +++ b/drivers/i2c/i2c-core-base.c > @

Re: [PATCH v2 04/10] net: ethernet: 8390: Replace GPL boilerplate with SPDX identifier

2023-05-12 Thread Geert Uytterhoeven
ibution for more details. > */ > - > /* Peter De Schrijver (p...@mind.be) */ > /* Oldenburg 2000 */ > Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m

Re: [PATCH] fbdev: modedb: Add a 1920x1080 at 60 Hz video mode

2023-05-12 Thread Geert Uytterhoeven
t; FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, [1] https://projectf.io/posts/video-timings-vga-720p-1080p/#hd-1920x1080-60-hz Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conve

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-11 Thread Geert Uytterhoeven
ean the resolution of the text console, akin to "fbset "? I have to admit I do not know if there is a command line tool to do that... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conver

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-11 Thread Geert Uytterhoeven
ons. See also commit 4aafae27d0ce73f8 ("sh: hd64461 tidying."), which claims they are no longer needed. Don't the I/O port macros just treat the port as an absolute base address when sh_io_port_base isn't set? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lo

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-10 Thread Geert Uytterhoeven
Hi Thomas, On Wed, May 10, 2023 at 4:20 PM Thomas Zimmermann wrote: > Am 10.05.23 um 14:34 schrieb Geert Uytterhoeven: > > On Wed, May 10, 2023 at 1:06 PM Thomas Zimmermann > > wrote: > >> Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(), > >&

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-10 Thread Geert Uytterhoeven
*/ > +#ifdef CONFIG_64BIT > +static inline u64 fb_readq(const volatile void __iomem *addr) > +{ > + return __raw_readq(addr); ... so how can this call work? > +} > +#define fb_readq fb_readq > + > +static inline void fb_writeq(u64 b, volatile void __iomem *addr) > +{ &

Re: [PATCH 37/53] drm/rcar-du: Convert to platform remove callback returning void

2023-05-08 Thread Geert Uytterhoeven
urning zero in > the remove callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal co

Re: [PATCH 39/53] drm/shmobile: Convert to platform remove callback returning void

2023-05-08 Thread Geert Uytterhoeven
ro in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations

Re: [PATCH v2 17/19] fbdev: Validate info->screen_{base,buffer} in fb_ops implementations

2023-05-03 Thread Geert Uytterhoeven
Hi Thomas, On Wed, May 3, 2023 at 4:30 PM Thomas Zimmermann wrote: > Am 03.05.23 um 11:51 schrieb Geert Uytterhoeven: > > On Fri, Apr 28, 2023 at 2:26 PM Thomas Zimmermann > > wrote: > >> Push the test for info->screen_base from fb_read() and fb_write() into > &g

Re: [PATCH v2 17/19] fbdev: Validate info->screen_{base,buffer} in fb_ops implementations

2023-05-03 Thread Geert Uytterhoeven
separate fields, to protect against misuse? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just sa

Re: [PATCH v3 0/6] fbdev: Move framebuffer I/O helpers to

2023-05-03 Thread Geert Uytterhoeven
/19] arch: Consolidate "[1], but with that applied, I had to manually fixup drivers/video/fbdev/core/fb_cfb_fops.c. [1] https://lore.kernel.org/all/20230417125651.25126-1-tzimmerm...@suse.de, Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linu

Re: [PATCH v3 4/6] fbdev: Include via

2023-05-03 Thread Geert Uytterhoeven
t this in the case of asm/io.h > > vs. linux/io.h. > > > > I understand that's the case too. I believe even checkpatch.pl complains > about it? (not that the script always get right, but just as an example). One more to chime in: in general, drivers should only include . Inc

Re: [PATCH v2 5/5] fbdev: Define framebuffer I/O from Linux' I/O functions

2023-04-28 Thread Geert Uytterhoeven
dian, whereas the regular accessors are explicitly > little-endian, so there is a slight risk of inadvertently changing > behaviour on big-endian systems (MIPS most likely, but a few old ARM > platforms run BE as well). Also on m68k, when ISA or PCI are enabl

Re: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions

2023-04-28 Thread Geert Uytterhoeven
Hi Thomas, On Fri, Apr 28, 2023 at 1:20 PM Thomas Zimmermann wrote: > Am 26.04.23 um 17:21 schrieb Geert Uytterhoeven: > > On Wed, Apr 26, 2023 at 5:06 PM Thomas Zimmermann > > wrote: > >> Am 26.04.23 um 17:01 schrieb Geert Uytterhoeven: > >>> On Tue, Apr 2

Re: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions

2023-04-26 Thread Geert Uytterhoeven
Hi Thomas, On Wed, Apr 26, 2023 at 5:06 PM Thomas Zimmermann wrote: > Am 26.04.23 um 17:01 schrieb Geert Uytterhoeven: > > On Tue, Apr 25, 2023 at 4:28 PM Thomas Zimmermann > > wrote: > >> Move the existing CFB read and write code for I/O memory into > >

Re: [PATCH 6/6] drm/fb-helper: Use fb_{cfb,sys}_{read, write}()

2023-04-26 Thread Geert Uytterhoeven
elper could implement .fb_sync() instead of .fb_write(). Likewise for the "cfb" (which is a misnomer) variants below. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with tec

Re: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions

2023-04-26 Thread Geert Uytterhoeven
ak; > + } > + > + fb_memcpy_tofb(dst, src, c); > + dst += c; > + src += c; > + *ppos += c; > + buf += c; > + cnt += c; > + count -= c; > + } > + > +

Re: [PATCH 4/6] fbdev: Validate info->screen_{base, buffer} in fb_ops implementations

2023-04-26 Thread Geert Uytterhoeven
dev/core/fbmem.c? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like

Re: [PATCH 3/6] fbdev: Don't re-validate info->state in fb_ops implementations

2023-04-26 Thread Geert Uytterhoeven
ned-off-by: Thomas Zimmermann Thanks for your patch! > drivers/video/fbdev/core/fb_sys_fops.c | 6 -- > drivers/video/fbdev/sm712fb.c | 6 ------ Reviewed-by: Geert Uytterhoeven But there are several other fbdev drivers to fix: drivers/media/pci/ivtv/ivtvfb.c drivers/vi

Re: [PATCH 2/6] fbdev: Use screen_buffer in fb_sys_{read,write}()

2023-04-26 Thread Geert Uytterhoeven
y. > > Since the fb_sys_{read,write}() functions operate on the latter address > space, it is wrong to use .screen_base and .screen_buffer must be used > instead. This also get rids of all the casting needed due not using the ... due to not ... > correct data type." +1 Reviewe

Re: [PATCH 1/6] fbdev: Return number of bytes read or written

2023-04-26 Thread Geert Uytterhoeven
*buf, size_t > count, loff_t *ppos) > > kfree(buffer); > > - return (err) ? err : cnt; > + return cnt ? cnt : err; > } Looks all good to me, so Reviewed-by: Geert Uytterhoeven However, shouldn't the copy_to_user() handling in fb_read() be fixed, too? Gr{oetj

Re: [PATCH v8 5/5] MAINTAINERS: Add maintainer for RZ DU drivers

2023-04-25 Thread Geert Uytterhoeven
> > +F: drivers/gpu/drm/renesas/rz-du/ > > > + > > > DRM DRIVERS FOR ROCKCHIP > > > M: Sandy Huang > > > M: Heiko Stübner > > > > Who's gonna maintain the common parts under drivers/gpu/drm/renesas/? > > At the moment, there i

Re: [PATCH v8 5/5] MAINTAINERS: Add maintainer for RZ DU drivers

2023-04-25 Thread Geert Uytterhoeven
> M: Heiko Stübner Who's gonna maintain the common parts under drivers/gpu/drm/renesas/? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical p

Re: [PATCH v8 3/5] dt-bindings: display: renesas,rzg2l-du: Document RZ/V2L DU bindings

2023-04-25 Thread Geert Uytterhoeven
* Fixed the typo vsp2->du > * Added Rb tag from Rob as the change is trivial. Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people,

Re: [PATCH 2/2] drm/ofdrm: Update expected device name

2023-04-24 Thread Geert Uytterhoeven
.name = "of-display", > + .name = "of-display.0", > .of_match_table = ofdrm_of_match_display, > }, > .probe = ofdrm_probe, Same comment as for "[PATCH 1/2] fbdev/offb: Update expected device name". https://lore.kernel

Re: [PATCH 1/2] fbdev/offb: Update expected device name

2023-04-24 Thread Geert Uytterhoeven
isplay") instead of the node name. I think the problem is with the of_platform_default_populate_init() function, which should create proper name@unit-address device nodes, with unique unit addresses, and with the correct compatible value. Gr{oetje,eeting}s, Geert -

Re: [PATCH v7 6/8] arm64: dts: renesas: r9a07g054: Add DU node

2023-04-20 Thread Geert Uytterhoeven
Hi Biju, On Tue, Apr 11, 2023 at 2:12 PM Biju Das wrote: > Add DU node to RZ/V2L SoC DTSI. > > Signed-off-by: Biju Das > --- > v7: > * New patch. Reviewed-by: Geert Uytterhoeven > --- a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi > +++ b/arch/arm64/boot/dts/renesas/r9

Re: [PATCH v7 5/8] arm64: dts: renesas: r9a07g044: Add DU node

2023-04-20 Thread Geert Uytterhoeven
On Tue, Apr 11, 2023 at 2:08 PM Biju Das wrote: > Add DU node to RZ/G2L SoC DTSI. > > Signed-off-by: Biju Das > --- > v7: > * New patch. Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux

Re: [PATCH v7 4/8] drm: rzg2l-du: Add RZ/V2L DU Support

2023-04-20 Thread Geert Uytterhoeven
info }, > + { .compatible = "renesas,r9a07g054-du", .data = > _du_r9a07g044_info }, > { /* sentinel */ } So this change implies no fallback compatible value, OK. Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert

Re: [PATCH v7 2/8] dt-bindings: display: renesas,rzg2l-du: Document RZ/V2L DU bindings

2023-04-20 Thread Geert Uytterhoeven
ith s/vsp2/du/, it doesn't match patch 6/8, where you use "renesas,r9a07g054-du" without the fallback. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical peop

Re: [PATCH v5] drm/fbdev-generic: prohibit potential out-of-bounds access

2023-04-20 Thread Geert Uytterhoeven
Hi Thomas, On Thu, Apr 20, 2023 at 2:59 PM Thomas Zimmermann wrote: > Am 20.04.23 um 14:25 schrieb Geert Uytterhoeven: > > On Thu, Apr 20, 2023 at 1:10 PM Thomas Zimmermann > > wrote: > >> Am 20.04.23 um 12:04 schrieb Sui Jingfeng: > >>> What will happen i

Re: [PATCH v5] drm/fbdev-generic: prohibit potential out-of-bounds access

2023-04-20 Thread Geert Uytterhoeven
t and size. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say

Re: [PATCH] drm/fb-helper: Fix height, width, and accel_flags in fb_var

2023-04-20 Thread Geert Uytterhoeven
Hi Daniel, On Wed, Apr 19, 2023 at 6:38 PM Daniel Vetter wrote: > On Tue, Apr 18, 2023 at 08:42:46PM +0200, Geert Uytterhoeven wrote: > > Fbtest contains some very simple validation of the fbdev userspace API > > contract. When used with shmob-drm, it reports the fol

Re: [PATCH v5] drm/fbdev-generic: prohibit potential out-of-bounds access

2023-04-20 Thread Geert Uytterhoeven
ze aligned because of it need mmap (Thomas) > - Adding fixes tag (Thomas) > > Fixes: aa15c677cc34 ("drm/fb-helper: Fix vertical damage clipping") > > Signed-off-by: Sui Jingfeng > Reviewed-by: Thomas Zimmermann > Tested-by: Geert Uytterhoeven Thanks for the update!

[PATCH] drm/fb-helper: Fix height, width, and accel_flags in fb_var

2023-04-18 Thread Geert Uytterhoeven
/fb-helper: fix input validation gaps in check_var") Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/drm_fb_helper.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 64458982be40c4

Re: [PATCH v2 0/5] drm: shmobile: Fixes and enhancements

2023-04-18 Thread Geert Uytterhoeven
Hi Laurent, On Tue, Apr 18, 2023 at 9:49 AM Laurent Pinchart wrote: > On Mon, Apr 17, 2023 at 03:40:20PM +0200, Geert Uytterhoeven wrote: > > Currently, there are two drivers for the LCD controller on Renesas > > SuperH-based and ARM-based SH-Mobile and R-Mobile SoCs: > >

[PATCH v2 2/5] drm: shmobile: Add support for DRM_FORMAT_XRGB8888

2023-04-17 Thread Geert Uytterhoeven
DRM_FORMAT_XRGB aka XR24 is the modus francus of DRM, and should be supported by all drivers. The handling for DRM_FORMAT_XRGB is similar to DRM_FORMAT_ARGB, just ignore the alpha channel. Signed-off-by: Geert Uytterhoeven Reviewed-by: Thomas Zimmermann Reviewed-by: Laurent

[PATCH v2 5/5] drm: shmobile: Make DRM_SHMOBILE visible on Renesas SoC platforms

2023-04-17 Thread Geert Uytterhoeven
), and by widening the dependency range to ARCH_RENESAS (for ARM). Signed-off-by: Geert Uytterhoeven Reviewed-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart --- v2: - Add Reviewed-by, - Drop dependency on ARM, reword. This driver was disabled on SuperH in commit c66de8cc2ea62941 ("drm/shmobile

[PATCH v2 0/5] drm: shmobile: Fixes and enhancements

2023-04-17 Thread Geert Uytterhoeven
...@glider.be Geert Uytterhoeven (5): drm: shmobile: Use %p4cc to print fourcc codes drm: shmobile: Add support for DRM_FORMAT_XRGB drm: shmobile: Switch to drm_crtc_init_with_planes() drm: shmobile: Add missing call to drm_fbdev_generic_setup() drm: shmobile: Make DRM_SHMOBILE visible

[PATCH v2 3/5] drm: shmobile: Switch to drm_crtc_init_with_planes()

2023-04-17 Thread Geert Uytterhoeven
. Signed-off-by: Geert Uytterhoeven Reviewed-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart --- v2: - Add Reviewed-by. --- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 30 +-- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/shmobile

[PATCH v2 4/5] drm: shmobile: Add missing call to drm_fbdev_generic_setup()

2023-04-17 Thread Geert Uytterhoeven
Set up generic fbdev emulation, to enable support for the Linux console. Use 16 as the preferred depth, as that is a good compromise between colorfulness and resource utilization, and the default of the fbdev driver. Suggested-by: Laurent Pinchart Signed-off-by: Geert Uytterhoeven Reviewed

[PATCH v2 1/5] drm: shmobile: Use %p4cc to print fourcc codes

2023-04-17 Thread Geert Uytterhoeven
Replace the printing of hexadecimal fourcc format codes by pretty-printed format names, using the "%p4cc" format specifier. Signed-off-by: Geert Uytterhoeven Reviewed-by: Thomas Zimmermann --- v2: - Add Reviewed-by. --- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 4 ++-- drive

Re: [PATCH v3] drm/fbdev-generic: prohibit potential out-of-bounds access

2023-04-17 Thread Geert Uytterhoeven
ch break the trigger condition of this bug by shrinking the shadow > buffer size to sizes->surface_height * buffer->fb->pitches[0]. > > Fixes: '8fbc9af55de0 ("drm/fbdev-generic: Set screen size to size of GEM > buffer")' > > Signed-off-by: Sui Jingfeng Thanks,

Re: [PATCH] fbmem: Reject FB_ACTIVATE_KD_TEXT from userspace

2023-04-11 Thread Geert Uytterhoeven
return -EFAULT; > > + /* only for kernel-internal use */ > > + var.activate &= ~FB_ACTIVATE_KD_TEXT; > > console_lock(); > > lock_fb_info(info); > > ret = fbcon_modechange_possible(info, ); Perhaps FB_ACTIVATE_KD_TEXT

Re: [PATCH 2/2] drm: Spelling s/randevouz/rendez-vouz/

2023-04-11 Thread Geert Uytterhoeven
Hi Marc, On Tue, Apr 11, 2023 at 12:49 PM Marc Dionne wrote: > On Tue, Apr 11, 2023 at 7:44 AM Geert Uytterhoeven > wrote: > > > > Fix a misspelling of "rendez-vouz". > > > > Signed-off-by: Geert Uytterhoeven > > --- a/include/drm/task_

[PATCH v2 2/2] drm: Spelling s/randevouz/rendez-vous/

2023-04-11 Thread Geert Uytterhoeven
Fix a misspelling of "rendez-vous". Signed-off-by: Geert Uytterhoeven --- v2: - s/vouz/vous/. --- include/drm/task_barrier.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/task_barrier.h b/include/drm/task_barrier.h index 217c1cf21c1ab7d5..f6e6ed

[PATCH v2 1/2] drm: Spelling s/sempahore/semaphore/

2023-04-11 Thread Geert Uytterhoeven
Fix misspellings of "semaphore". Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/i915/i915_request.c | 2 +- drivers/gpu/drm/radeon/cik.c| 2 +- drivers/gpu/drm/radeon/r600.c | 2 +- include/drm/task_barrier.h | 2 +- 4 files changed, 4 insertions(+), 4

Re: [PATCH v3 28/65] clk: renesas: r9a06g032: Add a determine_rate hook

2023-04-11 Thread Geert Uytterhoeven
s an oversight, then we are at least explicit about our > behavior now and it can be further refined down the line. > > Signed-off-by: Maxime Ripard LGTM, so Reviewed-by: Geert Uytterhoeven But I do not have the hardware. > --- a/drivers/clk/renesas/r9a06g032-clocks.c > +++ b/driver

[PATCH 1/2] drm: Spelling s/sempahore/semaphore/

2023-04-11 Thread Geert Uytterhoeven
Fix misspellings of "semaphore". Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/i915/i915_request.c | 2 +- drivers/gpu/drm/radeon/cik.c| 2 +- drivers/gpu/drm/radeon/r600.c | 2 +- include/drm/task_barrier.h | 2 +- 4 files changed, 4 insertions(+), 4

[PATCH 2/2] drm: Spelling s/randevouz/rendez-vouz/

2023-04-11 Thread Geert Uytterhoeven
Fix a misspelling of "rendez-vouz". Signed-off-by: Geert Uytterhoeven --- include/drm/task_barrier.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/task_barrier.h b/include/drm/task_barrier.h index 217c1cf21c1ab7d5..59ead429acb2afb0 100644 --- a/i

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-11 Thread Geert Uytterhoeven
ighning the checks in the core, > > because that's realistically really all that will ever happen. > > > > Reported-by: syzbot+20dcf81733d43ddff...@syzkaller.appspotmail.com > > Link: > > https://syzkaller.appspot.com/bug?id=c5faf983bfa4a607de530cd3bb008888bf06cefc > &

Re: [PATCH v2 08/19] arch/m68k: Implement with generic helpers

2023-04-11 Thread Geert Uytterhoeven
On Thu, Apr 6, 2023 at 4:30 PM Thomas Zimmermann wrote: > Replace the architecture's fb_is_primary_device() with the generic > one from . No functional changes. > > v2: > * provide empty fb_pgprotect() on non-MMU systems > > Signed-off-by: Thomas Zimmermann >

Re: [PATCH v2 07/19] arch/m68k: Merge variants of fb_pgprotect() into single function

2023-04-11 Thread Geert Uytterhoeven
h the switch to . > > Signed-off-by: Thomas Zimmermann Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical peo

Re: [PATCH v2 01/19] fbdev: Prepare generic architecture helpers

2023-04-11 Thread Geert Uytterhoeven
unsigned long off) Does this affect any noMMU platforms that relied on fb_pgprotect() doing nothing before? Perhaps the body below should be protected by "#ifdef CONFIG_MMU"? > +{ > + vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); Sho

Re: [PATCH 5/5] drm: shmobile: Make DRM_SHMOBILE visible on Renesas SoC platforms

2023-04-10 Thread Geert Uytterhoeven
Hi Laurent, On Wed, Apr 5, 2023 at 6:02 AM Laurent Pinchart wrote: > On Fri, Mar 31, 2023 at 04:48:11PM +0200, Geert Uytterhoeven wrote: > > The LCD Controller supported by the drm-shmob driver is not only present > > on SuperH SH-Mobile SoCs, but also on Renesas ARM SH/R-Mobile

Re: [PATCH 3/5] drm: shmobile: Switch to drm_crtc_init_with_planes()

2023-04-10 Thread Geert Uytterhoeven
Hi Laurent, Thanks for your comments! On Wed, Apr 5, 2023 at 5:59 AM Laurent Pinchart wrote: > On Fri, Mar 31, 2023 at 04:48:09PM +0200, Geert Uytterhoeven wrote: > > The SH-Mobile DRM driver uses the legacy drm_crtc_init(), which > > advertizes only the formats in safe_modeset_

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-04 Thread Geert Uytterhoeven
Hi Daniel, On Tue, Apr 4, 2023 at 5:55 PM Daniel Vetter wrote: > On Tue, 4 Apr 2023 at 16:51, Geert Uytterhoeven wrote: > > On Tue, Apr 4, 2023 at 4:19 PM Daniel Vetter wrote: > > > On Tue, Apr 04, 2023 at 03:59:12PM +0200, Daniel Vetter wrote: > > > > On Tue, Ap

Re: [PATCH] drm/fb-helper: Remove helpers to change frame buffer config

2023-04-04 Thread Geert Uytterhoeven
Hi Daniel, On Tue, Aug 9, 2022 at 5:03 PM Daniel Vetter wrote: > On Sat, Jul 02, 2022 at 08:05:54PM +0200, Helge Deller wrote: > > On 6/29/22 12:56, Geert Uytterhoeven wrote: > > > The DRM fbdev emulation layer does not support pushing back > > > changes

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-04 Thread Geert Uytterhoeven
CC linux-fbdev On Tue, Apr 4, 2023 at 4:41 PM Thomas Zimmermann wrote: > Am 04.04.23 um 16:19 schrieb Daniel Vetter: > > On Tue, Apr 04, 2023 at 03:59:12PM +0200, Daniel Vetter wrote: > >> On Tue, Apr 04, 2023 at 03:53:09PM +0200, Geert Uytterhoeven wrote: > >

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-04 Thread Geert Uytterhoeven
CC linux-fbdev On Tue, Apr 4, 2023 at 4:19 PM Daniel Vetter wrote: > On Tue, Apr 04, 2023 at 03:59:12PM +0200, Daniel Vetter wrote: > > On Tue, Apr 04, 2023 at 03:53:09PM +0200, Geert Uytterhoeven wrote: > > > On Tue, Apr 4, 2023 at 2:36 PM Daniel Vetter > > > w

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-04 Thread Geert Uytterhoeven
8) This is a bug in the vkmsdrmfb driver and/or DRM helpers. The message was added to make sure the individual drivers are fixed. Perhaps it should be changed to BUG() instead, so dmesg output cannot be drown? > Fixes: 6c11df58fd1a ("fbmem: Check virtual screen sizes in fb_set_var()") > Cc:

Re: [PATCH v2] drm/vblank: Fix for drivers that do not drm_vblank_init()

2023-04-04 Thread Geert Uytterhoeven
ce at virtual address > 0074 Thanks, this fixes a crash seen with the ssd130x DRM driver. Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with

Re: [PATCH 0/5] drm: shmobile: Fixes and enhancements

2023-04-03 Thread Geert Uytterhoeven
Hi Thomas, On Mon, Apr 3, 2023 at 3:14 PM Thomas Zimmermann wrote: > Am 31.03.23 um 16:48 schrieb Geert Uytterhoeven: > > Currently, there are two drivers for the LCD controller on Renesas > > SuperH-based and ARM-based SH-Mobile and R-Mobile SoCs: > >1. sh_mobile_lc

[PATCH 1/5] drm: shmobile: Use %p4cc to print fourcc codes

2023-03-31 Thread Geert Uytterhoeven
Replace the printing of hexadecimal fourcc format codes by pretty-printed format names, using the "%p4cc" format specifier. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 4 ++-- drivers/gpu/drm/shmobile/shmob_drm_kms.c | 4 ++-- 2 files changed, 4

[PATCH 4/5] drm: shmobile: Add missing call to drm_fbdev_generic_setup()

2023-03-31 Thread Geert Uytterhoeven
Set up generic fbdev emulation, to enable support for the Linux console. Use 16 as the preferred depth, as that is a good compromise between colorfulness and resource utilization, and the default of the fbdev driver. Suggested-by: Laurent Pinchart Signed-off-by: Geert Uytterhoeven --- drivers

[PATCH 5/5] drm: shmobile: Make DRM_SHMOBILE visible on Renesas SoC platforms

2023-03-31 Thread Geert Uytterhoeven
The LCD Controller supported by the drm-shmob driver is not only present on SuperH SH-Mobile SoCs, but also on Renesas ARM SH/R-Mobile SoCs. Make its option visible, so the user can enable support for it. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/shmobile/Kconfig | 2 +- 1 file

[PATCH 2/5] drm: shmobile: Add support for DRM_FORMAT_XRGB8888

2023-03-31 Thread Geert Uytterhoeven
DRM_FORMAT_XRGB aka XR24 is the modus francus of DRM, and should be supported by all drivers. The handling for DRM_FORMAT_XRGB is similar to DRM_FORMAT_ARGB, just ignore the alpha channel. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 1

[PATCH 3/5] drm: shmobile: Switch to drm_crtc_init_with_planes()

2023-03-31 Thread Geert Uytterhoeven
. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 30 +-- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c index 08dc1428aa16caf0..11dd2bc803e7cb62

[PATCH 0/5] drm: shmobile: Fixes and enhancements

2023-03-31 Thread Geert Uytterhoeven
Armadillo-800-EVA development board, using a temporary platform-enablement patch[1]. Thanks for your comments! [1] https://lore.kernel.org/r/c03d4edbd650836bf6a96504df82338ec6d800ff.1680272980.git.geert+rene...@glider.be Geert Uytterhoeven (5): drm: shmobile: Use %p4cc to print fourcc codes

Re: Build regressions/improvements in v6.3-rc3 (drm/msm/)

2023-03-21 Thread Geert Uytterhoeven
Hi Randy, On Tue, Mar 21, 2023 at 4:10 PM Randy Dunlap wrote: > On 3/21/23 00:34, Geert Uytterhoeven wrote: > > On Tue, Mar 21, 2023 at 6:38 AM Randy Dunlap wrote: > >> On 3/20/23 01:21, Geert Uytterhoeven wrote: > >>> Below is the list of build error/wa

Re: Build regressions/improvements in v6.3-rc3 (drm/msm/)

2023-03-21 Thread Geert Uytterhoeven
Hi Randy, On Tue, Mar 21, 2023 at 6:38 AM Randy Dunlap wrote: > On 3/20/23 01:21, Geert Uytterhoeven wrote: > > Below is the list of build error/warning regressions/improvements in > > v6.3-rc3[1] compared to v6.2[2]. > > > > Summarized: > > - build errors:

[PATCH v2] drm/armada: Fix off-by-one error in armada_overlay_get_property()

2023-03-20 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven Reviewed-by: Russell King (Oracle) --- Compile-tested only. v2: - Add Reviewed-by. --- drivers/gpu/drm/armada/armada_overlay.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_overlay.c b/drivers/gpu/

Re: [PATCH 39/51] video: fbdev: sh_mobile_lcdcfb: Convert to platform remove callback returning void

2023-03-19 Thread Geert Uytterhoeven
ro in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal convers

Re: [PATCH v2] drm/format-helper: Make conversion_buf_size() support sub-byte pixel fmts

2023-03-16 Thread Geert Uytterhoeven
; > + dst_pitch = DIV_ROUND_UP(drm_rect_width(clip) * bpp, 8); I know I'm a bit late to the party, but here's actually a helper for that: dst_pitch = drm_format_info_min_pitch(info, 0, drm_rect_width(clip)); > + } > > return dst_pitch * drm_rect_height(clip);

Re: [PATCH v3 35/38] video: handle HAS_IOPORT dependencies

2023-03-15 Thread Geert Uytterhoeven
G_PCI. So: depends on FB && !SPARC32 depends on ATARI || HAS_IOPORT > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond

Re: [PATCH v2 001/101] lib: Add option iterator

2023-03-10 Thread Geert Uytterhoeven
gt; create mode 100644 lib/cmdline_iter.c Just wondering, is there any code that can be shared with/reused from the existing lib/cmdline.c? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversatio

Re: [PATCH v2 000/101] fbdev: Fix memory leak in option parsing

2023-03-10 Thread Geert Uytterhoeven
spect > video= settings in any configuration. > > v2: > * use kstrdup()/kfree() for video strings (Geert, Timur) > * fix iterator docs (Randy) > * update iterator interface Thanks for the update, this looks much better! Gr{oetje,eeting}s,

Re: [PATCH v2 061/101] fbdev/ps3fb: Duplicate video-mode option string

2023-03-10 Thread Geert Uytterhoeven
_debug(" -> %s:%d\n", __func__, __LINE__); > ps3_system_bus_driver_unregister(_driver); > + kfree(mode_option_buf); > pr_debug(" <- %s:%d\n", __func__, __LINE__); > } Gr{oetje,eeting}s, Geert -- Geert Uyt

Re: [PATCH 00/99] fbdev: Fix memory leak in option parsing

2023-03-07 Thread Geert Uytterhoeven
Hi Thomas, On Tue, Mar 7, 2023 at 9:23 AM Thomas Zimmermann wrote: > Am 07.03.23 um 08:53 schrieb Geert Uytterhoeven: > > On Mon, Mar 6, 2023 at 5:00 PM Thomas Zimmermann > > wrote: > >> Introduce struct option_iter and helpers to parse command-line > >> optio

Re: [PATCH 00/99] fbdev: Fix memory leak in option parsing

2023-03-07 Thread Geert Uytterhoeven
that drivers don't refer directly > to the option string's memory. The option iterator then replaces manual > parsing loops based on strsep(","). Thanks for your series! Unfortunately I cannot say I'm thrilled about this: you are replacing a single small dynamic memory leak by 36 lar

Re: [PATCH 11/99] fbdev/aty: Duplicate video-mode option string

2023-03-06 Thread Geert Uytterhoeven
ret=%d\n", ret)) > + continue; > + if (WARN(ret >= sizeof(mode_option_buf), "aty128fb: > option too long\n")) > + continue; > + mode_option = mode_option_buf;

[PATCH] drm/msm/dpu: Fix bit-shifting UB in DPU_HW_VER() macro

2023-03-06 Thread Geert Uytterhoeven
es: 100d7ef6995d1f86 ("drm/msm/dpu: add support for SM8450") Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h b/drivers/gpu/drm/

Re: Build regressions/improvements in v6.3-rc1

2023-03-06 Thread Geert Uytterhoeven
On Mon, 6 Mar 2023, Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v6.3-rc1[1] compared to v6.2[2]. Summarized: - build errors: +9/-14 - build warnings: +4/-1447 Happy fixing! ;-) Thanks to the linux-next team for providing the build service

Re: [PATCH 2/3] drm: rcar-du: lvds: Move LVDS enable code to separate code section

2023-02-14 Thread Geert Uytterhoeven
> Signed-off-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking t

Re: [Intel-gfx] [PATCH v3 2/2] drm/probe_helper: sort out poll_running vs poll_enabled

2023-02-07 Thread Geert Uytterhoeven
t Pinchart Signed-off-by: Dmitry Baryshkov Thanks for your patch! This gets rids of the warning splats on e.g. Renesas Koelsch and Salvator-XS, so Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux b

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Geert Uytterhoeven
Hi Neil, On Tue, Feb 7, 2023 at 11:02 AM Geert Uytterhoeven wrote: > On Tue, Feb 7, 2023 at 10:59 AM Neil Armstrong > wrote: > > On 07/02/2023 10:40, Geert Uytterhoeven wrote: > > > On Tue, Jan 10, 2023 at 5:37 PM Dmitry Baryshkov > > > wrote: > > >>

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Geert Uytterhoeven
Hi Neil, On Tue, Feb 7, 2023 at 10:59 AM Neil Armstrong wrote: > On 07/02/2023 10:40, Geert Uytterhoeven wrote: > > On Tue, Jan 10, 2023 at 5:37 PM Dmitry Baryshkov > > wrote: > >> On 10/01/2023 08:57, Laurentiu Palcu wrote: > >>> On Mon, Jan 09, 2023 at 10:2

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Geert Uytterhoeven
On Tue, Jan 10, 2023 at 11:20 AM Geert Uytterhoeven wrote: > On Tue, Jan 10, 2023 at 8:07 AM Laurentiu Palcu > wrote: > > On Mon, Jan 09, 2023 at 10:26:28PM +0200, Dmitry Baryshkov wrote: > > > On 09/01/2023 18:21, Laurentiu Palcu wrote: > > > > It

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Geert Uytterhoeven
t me test it locally before posting. Is this fix available? Do you have a lore link? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm

Re: remove arch/sh

2023-02-03 Thread Geert Uytterhoeven
sh: sh for 32 bit, sh64 for 64 bit <<<<<<<<<<<<<<< > - sparc: sparc32 for 32 bit, sparc64 for 64 bit No, support for sh64 was removed in commit 37744feebc086908 ("sh: remove sh5 support") in v5.8. Gr{oetje,eeting}s,

Re: [PATCH 01/22] gpu/drm: remove the shmobile drm driver

2023-02-03 Thread Geert Uytterhoeven
my list... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say

Re: remove arch/sh

2023-02-03 Thread Geert Uytterhoeven
is done by next week. > > We're still discussing among SuperH developer community whether there will be > a second > maintainer, so please bear with us a few more days. I will collect patches in > the > meantime. Thanks a lot! If you need any help with process, setup, ... d

Re: [PATCH] tree-wide: trivial: s/ a SPI/ an SPI/

2023-02-03 Thread Geert Uytterhoeven
nt letter S, but the S is pronounced with its > letter name, "es."). While I agree with your pronunciation, I believe the SPI maintainer (which you forgot to CC) pronounces it in James Bond-style, i.e. rhymes with "spy" ;-) Gr{oetje,eeting}s, Geert -

Re: UBSAN: shift-out-of-bounds in fbcon_set_font

2023-01-26 Thread Geert Uytterhoeven
d max_font_height (128), but fbcon has stricter limits. fbcon_set_font() should reject fonts with width > 32 or height > 32. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations

<    2   3   4   5   6   7   8   9   10   11   >