that would require too much back and forth, I'm okay with what is
currently proposed.
Reviewed-by: Hamza Mahfooz
---
The below approximates when each driver's date was last updated.
$ git grepblame "\(\.date = \".*\"\|#define.*DRIVER_DATE\)" -- drivers/gpu
drivers/acc
: 2cd3271b7a31 ("kbuild: avoid duplicate warning options")
Signed-off-by: Arnd Bergmann
Acked-by: Hamza Mahfooz
For the amdgpu changes.
---
drivers/gpu/drm/amd/display/dc/dce110/Makefile | 2 +-
drivers/gpu/drm/amd/display/dc/dce112/Makefile | 2 +-
drivers/gpu/drm/amd/display
: Hamza Mahfooz
Cc: Tsung-hua Lin
Cc: Chris Chi
Cc: Harry Wentland
Tested-by: Daniel Wheeler
Reviewed-by: Sun peng Li
Acked-by: Rodrigo Siqueira
Signed-off-by: Ivan Lipski
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 6 ++
1 file changed, 6 insertions(+)
diff --git
On 2/16/24 03:19, Pekka Paalanen wrote:
On Fri, 2 Feb 2024 10:28:35 -0500
Hamza Mahfooz wrote:
We want programs besides the compositor to be able to enable or disable
panel power saving features.
Could you also explain why, in the commit message, please?
It is unexpected for arbitrary
On 2/16/24 03:19, Pekka Paalanen wrote:
On Fri, 2 Feb 2024 10:28:35 -0500
Hamza Mahfooz wrote:
We want programs besides the compositor to be able to enable or disable
panel power saving features.
Could you also explain why, in the commit message, please?
It is unexpected for arbitrary
On 2/9/24 08:02, Dan Carpenter wrote:
These ANDs should be ORs or it will lead to a NULL dereference.
Fixes: fb5a3d037082 ("drm/amd/display: Add NULL test for 'timing generator' in
'dcn21_set_pipe()'")
Fixes: 886571d217d7 ("drm/amd/display: Fix 'panel_cntl' could be null in
Removing an amdgpu device that still has user space references allocated
to it causes undefined behaviour. So, implement amdgpu_pci_can_remove()
and disallow devices that still have files allocated to them from being
unbound.
Cc: sta...@vger.kernel.org
Signed-off-by: Hamza Mahfooz
---
drivers
Wire up the can_remove() callback, such that pci drivers can implement
their own version of it.
Cc: sta...@vger.kernel.org
Signed-off-by: Hamza Mahfooz
---
drivers/pci/pci-driver.c | 12
include/linux/pci.h | 5 +
2 files changed, 17 insertions(+)
diff --git a/drivers
() callback to allow drivers to indicate if it isn't
appropriate to remove a device at the given time.
Cc: sta...@vger.kernel.org
Signed-off-by: Hamza Mahfooz
---
drivers/base/bus.c | 4
include/linux/device/bus.h | 2 ++
2 files changed, 6 insertions(+)
diff --git a/drivers/base/bus.c b
Cc: Mario Limonciello
Signed-off-by: Hamza Mahfooz
---
v2: hide ABM_LEVEL_IMMEDIATE_DISABLE in the read case, force an atomic
commit when setting the value, call sysfs_remove_group() in
amdgpu_dm_connector_unregister() and add some documentation.
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu
On 1/30/24 11:12, Alex Deucher wrote:
Add a helper so that drm drivers can consistently report
shared status via the fdinfo shared memory stats interface.
In addition to handle count, show buffers as shared if they
are shared via dma-buf as well (e.g., shared with v4l or some
other subsystem).
Cc: Mario Limonciello
Signed-off-by: Hamza Mahfooz
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 59 +++
1 file changed, 59 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index cd98b3565178..b3fcd8330
On 1/13/24 09:58, Christophe JAILLET wrote:
It is likely that the statement related to 'dml_edp' is misplaced. So move
it in the correct "case SIGNAL_TYPE_EDP".
Fixes: 7966f319c66d ("drm/amd/display: Introduce DML2")
Signed-off-by: Christophe JAILLET
Nice catch! Applied, thanks!
---
-by: Hamza Mahfooz
---
drivers/gpu/drm/Kconfig | 18 ++
drivers/gpu/drm/Makefile | 3 +++
2 files changed, 21 insertions(+)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 6ec33d36f3a4..36a00cba2540 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm
Ripard
Cc: Thomas Zimmermann
Cc: Alex Deucher
Cc: Christian König
Cc: Pan, Xinhui
Cc: Karol Herbst
Cc: Lyude Paul
Cc: Danilo Krummrich
Cc: Rob Clark
Cc: Abhinav Kumar
Cc: Dmitry Baryshkov
Cc: Sean Paul
Cc: Marijn Suijten
Cc: Hamza Mahfooz
Acked-by: Javier Martinez Canillas
Acked
On 12/29/23 11:25, Melissa Wen wrote:
IGT `amdgpu/amd_color/crtc-lut-accuracy` fails right at the beginning of
the test execution, during atomic check, because DC rejects the
bandwidth state for a fb sizing 64x64. The test was previously working
with the deprecated dc_commit_state(). Now using
e it won't be part of it.
Thus, it's not truly a "global state", unlike object state structures
that do contain the entire state of a given object.
Signed-off-by: Maxime Ripard
Reviewed-by: Hamza Mahfooz
---
include/drm/drm_atomic.h | 8 +++-
1 file changed, 7 insertions(+),
Cc: Nathan Chancellor
On 11/29/23 13:12, Jani Nikula wrote:
At least the i915 and amd drivers enable a bunch more compiler warnings
than the kernel defaults.
Extend the W=1 warnings to the entire drm subsystem by default. Use the
copy-pasted warnings from scripts/Makefile.extrawarn with
On 11/27/23 09:54, Christian König wrote:
Try to fill up VRAM as well by setting the busy flag on GTT allocations.
This fixes the issue that when VRAM was evacuated for suspend it's never
filled up again unless the application is restarted.
Link:
Hi André,
On 11/22/23 11:19, André Almeida wrote:
Hi,
This work from me and Simon adds support for DRM_MODE_PAGE_FLIP_ASYNC through
the atomic API. This feature is already available via the legacy API. The use
case is to be able to present a new frame immediately (or as soon as
possible), even
+ amd-gfx
+ Felix
On 11/20/23 10:16, bugzilla-dae...@kernel.org wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=218168
Bug ID: 218168
Summary: amdgpu: kfd_topology.c warning: the frame size of 1408
bytes is larger than 1024 bytes
On 11/14/23 10:27, José Pekkarinen wrote:
The following patch will fix a minor issue where a debug message is
referencing an struct that has just being checked whether is null or
not. This has been noticed by using coccinelle, in the following output:
On 11/14/23 01:36, José Pekkarinen wrote:
The following patch will fix a minor issue where a debug message is
referencing an struct that has just being checked whether is null or
not. This has been noticed by using coccinelle, in the following output:
it.
Cc: Alex Deucher
Cc: Mario Limonciello
Signed-off-by: Hamza Mahfooz
---
v2: only return -ETIMEDOUT for DMUB_STATUS_TIMEOUT
---
Documentation/gpu/amdgpu/display/dc-debug.rst | 41
.../gpu/amdgpu/display/trace-groups-table.csv | 29 ++
.../amd/display/amdgpu_dm
it.
Cc: Alex Deucher
Cc: Mario Limonciello
Signed-off-by: Hamza Mahfooz
---
Documentation/gpu/amdgpu/display/dc-debug.rst | 41 +
.../gpu/amdgpu/display/trace-groups-table.csv | 29 ++
.../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 91 +++
.../gpu/drm/amd/display
On 11/1/23 17:36, Alex Deucher wrote:
On Wed, Nov 1, 2023 at 5:01 PM Hamza Mahfooz wrote:
Without this fix the 5120x1440@240 timing of these monitors
leads to screen flickering.
Cc: sta...@vger.kernel.org # 6.1+
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1442
Co-developed
On 11/2/23 13:12, Nathan Chancellor wrote:
On Thu, Nov 02, 2023 at 12:59:00PM -0400, Hamza Mahfooz wrote:
On 11/2/23 12:24, Nathan Chancellor wrote:
When building ARCH=x86_64 allmodconfig with clang, which have sanitizers
enabled, there is a warning about a large stack frame.
drivers/gpu
On 11/2/23 12:24, Nathan Chancellor wrote:
When building ARCH=x86_64 allmodconfig with clang, which have sanitizers
enabled, there is a warning about a large stack frame.
drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6265:13:
error: stack frame size (2520) exceeds limit
Without this fix the 5120x1440@240 timing of these monitors
leads to screen flickering.
Cc: sta...@vger.kernel.org # 6.1+
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1442
Co-developed-by: Harry Wentland
Signed-off-by: Harry Wentland
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm
On 10/27/23 11:55, Lakha, Bhawanpreet wrote:
[AMD Official Use Only - General]
There was a consensus to use memset instead of {0}. I remember making
changes related to that previously.
Hm, seems like it's used rather consistently in the DM and in DC
though.
Bhawan
Also, please write the tagline in present tense.
On 10/27/23 11:53, Hamza Mahfooz wrote:
On 10/26/23 17:25, Yuran Pereira wrote:
Since `pr_config` is not initialized after its declaration, the
following operations with `replay_enable_option` may be performed
when `replay_enable_option
On 10/26/23 17:25, Yuran Pereira wrote:
Since `pr_config` is not initialized after its declaration, the
following operations with `replay_enable_option` may be performed
when `replay_enable_option` is holding junk values which could
possibly lead to undefined behaviour
```
...
On 10/26/23 22:44, chentao wrote:
From: Kunwu Chan
There is a typo in the kernel documentation for function
drm_atomic_helper_wait_for_dependencies. Fix it.
Signed-off-by: Kunwu Chan
Applied, thanks!
---
drivers/gpu/drm/drm_atomic_helper.c | 4 ++--
1 file changed, 2 insertions(+), 2
Hi Kunwu,
Can you make the tagline something along the lines of `drm/atomic
helper: fix spelling mistake "preceeding" -> "preceding"`, in general to
determine an appropriate prefix, you can see what previous commits used
when making changes to files in your particular patch, e.g. using the
On 10/15/23 10:27, Geert Uytterhoeven wrote:
Currently drm_client_buffer_addfb() uses the legacy drm_mode_addfb(),
which uses bpp and depth to guess the wanted buffer format.
However, drm_client_buffer_addfb() already knows the exact buffer
format, so there is no need to convert back and forth
On 10/18/23 14:45, Nathan Chancellor wrote:
display_mode_code.c is unconditionally built with
-Wframe-larger-than=2048, which causes warnings even when
CONFIG_FRAME_WARN has been set to 0, which should show no warnings.
Use the existing $(frame_warn_flag) variable, which handles this
situation.
On 10/13/23 06:30, Ville Syrjälä wrote:
On Thu, Oct 12, 2023 at 02:49:27PM -0400, Hamza Mahfooz wrote:
The BenQ GW2765 reports that it supports higher (> 8) bpc modes, but
when trying to set them we end up with a black screen. So, limit it to 8
bpc modes.
Bad cable/etc was ruled
The BenQ GW2765 reports that it supports higher (> 8) bpc modes, but
when trying to set them we end up with a black screen. So, limit it to 8
bpc modes.
Cc: sta...@vger.kernel.org # 6.5+
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2610
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/
On 10/10/23 08:15, Andi Shyti wrote:
From: Nirmoy Das
Add a function for ratelimitted debug print.
Signed-off-by: Nirmoy Das
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
Cc: David Airlie
Cc: Daniel Vetter
Reviewed-by: Matthew Auld
Reviewed-by: Andrzej Hajda
On 9/21/23 10:15, Sebastian Andrzej Siewior wrote:
Hi,
I stumbled uppon the amdgpu driver via a bugzilla report. The actual fix
is #4 + #5 and the rest was made while looking at the code.
Sebastian
I have applied the series, thanks!
--
Hamza
On 10/3/23 15:53, Harry Wentland wrote:
On 2023-09-21 10:15, Sebastian Andrzej Siewior wrote:
This is a revert of the commit mentioned below while it is not wrong, as
in the kernel will explode, having migrate_disable() here it is
complete waste of resources.
Additionally commit message is
From: Ivan Lipski
This reverts commit 45e1ade04b4d60fe5df859076005779f27c4c9be.
Since, it causes the following IGT tests to fail:
kms_cursor_legacy@cursor-vs-flip.*
kms_cursor_legacy@flip-vs-cursor.*
Signed-off-by: Ivan Lipski
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display
On 9/14/23 17:04, Hamza Mahfooz wrote:
On 9/14/23 16:40, Harry Wentland wrote:
On 2023-09-14 13:53, Hamza Mahfooz wrote:
On eDP we can receive invalid modes from dm_update_crtc_state() for
entirely new streams for which drm_mode_set_crtcinfo() shouldn't be
called on. So, instead of calling
On 9/14/23 16:40, Harry Wentland wrote:
On 2023-09-14 13:53, Hamza Mahfooz wrote:
On eDP we can receive invalid modes from dm_update_crtc_state() for
entirely new streams for which drm_mode_set_crtcinfo() shouldn't be
called on. So, instead of calling drm_mode_set_crtcinfo() from within
state to stream
validation")
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.
On 9/13/23 16:03, Alex Deucher wrote:
On Wed, Sep 13, 2023 at 3:57 PM Hamza Mahfooz wrote:
On 9/13/23 15:54, Alex Deucher wrote:
On Wed, Sep 13, 2023 at 12:17 PM Hamza Mahfooz wrote:
On 9/13/23 12:10, Nathan Chancellor wrote:
When building with clang, there is a warning (or error when
On 9/13/23 15:54, Alex Deucher wrote:
On Wed, Sep 13, 2023 at 12:17 PM Hamza Mahfooz wrote:
On 9/13/23 12:10, Nathan Chancellor wrote:
When building with clang, there is a warning (or error when
CONFIG_WERROR is set):
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm
On 9/13/23 12:10, Nathan Chancellor wrote:
When building with clang, there is a warning (or error when
CONFIG_WERROR is set):
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:368:21:
error: variable 'old_payload' is uninitialized when used here
[-Werror,-Wuninitialized]
yload
allocation/removement")
Signed-off-by: Nathan Chancellor
Reviewed-by: Hamza Mahfooz
Hm, seems like this was pushed through drm-misc-next and as such our CI
didn't get a chance to test it.
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 6 +++---
1 file changed, 3
On 9/11/23 13:12, André Almeida wrote:
As suggested by Christian at [0], this patchset merges all debug modules
parameters and creates a new one for disabling soft recovery:
Maybe we can overload the amdgpu_gpu_recovery module option with this.
Or even better merge all the developer module
On 9/11/23 09:54, André Almeida wrote:
Christian, Alex, I think this series is ready to be picked as well.
Can you rebase this onto amd-staging-drm-next
(https://gitlab.freedesktop.org/agd5f/linux)? Since it currently doesn't
apply there.
Em 31/08/2023 12:29, André Almeida escreveu:
As
On 9/10/23 19:44, Randy Dunlap wrote:
Fix the typo in the kernel-doc for @replay_mode to prevent
kernel-doc warnings:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:623: warning: Incorrect use
of kernel-doc format: * @replay mode: Replay supported
On 9/8/23 03:54, Jiapeng Chong wrote:
No functional modification involved.
drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dpms.c:2476
link_set_dpms_on() warn: if statement not indented.
Reported-by: Abaci Robot
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6502
Signed-off-by:
This reverts commit 5b7a256c982636ebc4f16b708b40ff56d33c8a86.
Since, we now have an actual fix for this issue, we can get rid of this
workaround as it can cause pin failures if enough VRAM isn't carved out
by the BIOS.
Cc: sta...@vger.kernel.org # 6.1+
Signed-off-by: Hamza Mahfooz
---
v2: new
upper_32_bits()/lower_32_bits() and AMDGPU_GPU_PAGE_SHIFT.
Cc: sta...@vger.kernel.org
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2354
Fixes: 81d0bcf99009 ("drm/amdgpu: make display pinning more flexible (v2)")
Signed-off-by: Yifan Zhang
Signed-off-by: Hamza Mahfooz
---
v2: use upp
: a463b263032f ("drm/amd/display: Fix frames_to_insert math")
Fixes: ded6119e825a ("drm/amd/display: Reinstate LFC optimization")
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 9 ++---
1 file changed, 6 insertions(+), 3 dele
-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c
b/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c
index 1bfdf0271fdf..a68fb45ed487 100644
Signed-off-by: Hamza Mahfooz
---
.../drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 24 ---
1 file changed, 4 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c
b/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c
index 0989a0152ae8
...@vger.kernel.org
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2809
Signed-off-by: Hamza Mahfooz
---
.../drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 24 ---
1 file changed, 4 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c
b
Link:
https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/commit/cb77add45011b129e21f3cb2a4089a73dde56179
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_
On 8/24/23 08:07, Lee Jones wrote:
On Thu, 24 Aug 2023, Jani Nikula wrote:
On Thu, 24 Aug 2023, Lee Jones wrote:
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
The next question is, how
On 8/23/23 16:51, Alex Deucher wrote:
@Mahfooz, Hamza
can you respin with the NULL check?
sure.
Alex
On Wed, Aug 16, 2023 at 10:25 AM Christian König
wrote:
Am 16.08.23 um 15:41 schrieb Hamza Mahfooz:
On 8/16/23 01:55, Christian König wrote:
Am 15.08.23 um 19:26 schrieb Hamza
ht_control() function pointer to
dce110_edp_backlight_control().
Cc: sta...@vger.kernel.org
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2765
Fixes: 9c75891feef0 ("drm/amd/display: rework recent update PHY state commit")
Suggested-by: Swapnil Patel
Signed-off-by: Hamza Mahfooz
On 8/18/23 09:28, Alex Deucher wrote:
On Fri, Aug 18, 2023 at 9:25 AM Hamza Mahfooz wrote:
As made mention of in commit 4a2df0d1f28e ("drm/amd/display: Fixed
non-native modes not lighting up"), we shouldn't call
drm_mode_set_crtcinfo() once the crtc timings have been decided. Sin
nk")
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 3b27b7742854..e9aff5014e39 100644
-
On 8/16/23 01:55, Christian König wrote:
Am 15.08.23 um 19:26 schrieb Hamza Mahfooz:
fbcon requires that we implement _framebuffer_funcs.dirty.
Otherwise, the framebuffer might take a while to flush (which would
manifest as noticeable lag). However, we can't enable this callback for
non
amdgpu_dirtyfb() and only enable it for fbcon
framebuffers on devices that support atomic KMS.
Cc: Aurabindo Pillai
Cc: Mario Limonciello
Cc: sta...@vger.kernel.org # 6.1+
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2519
Signed-off-by: Hamza Mahfooz
---
v2: update variable names
amdgpu_dirtyfb() and only enable it for fbcon
framebuffers on devices that support atomic KMS.
Cc: Aurabindo Pillai
Cc: Mario Limonciello
Cc: sta...@vger.kernel.org # 6.1+
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2519
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/amdgpu
() to amdgpu_dm_atomic_check() and check if
the memory domain has changed in amdgpu_dm_atomic_check().
Cc: sta...@vger.kernel.org
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2733
Fixes: 3f86b60691e6 ("drm/amd/display: only accept async flips for fast
updates")
Signed-off-by: Hamza Mahfo
() to amdgpu_dm_atomic_check() and check if
the memory domain has changed in amdgpu_dm_atomic_check().
Cc: sta...@vger.kernel.org
Fixes: 3f86b60691e6 ("drm/amd/display: only accept async flips for fast
updates")
Tested-by: Marcus Seyfarth
Signed-off-by: Hamza Mahfooz
---
.../gpu/drm/a
On 6/21/23 16:24, André Almeida wrote:
From: Simon Ser
Up until now, amdgpu was silently degrading to vsync when
user-space requested an async flip but the hardware didn't support
it.
The hardware doesn't support immediate flips when the update changes
the FB pitch, the DCC state, the
eucher
Cc: Nathan Chancellor
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/amdgpu/Makefile | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/Makefile
b/drivers/gpu/drm/amd/amdgpu/Makefile
index 86b833085f19..8d16f280b695 100644
---
On 6/9/23 04:17, Lee Jones wrote:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:48:22:
warning: ‘SYNAPTICS_DEVICE_ID’ defined but not used [-Wunused-const-variable=]
Cc: Harry Wentland
Cc: Leo Li
Cc: Rodrigo Siqueira
On 6/8/23 13:01, Nathan Chancellor wrote:
-Wunused-but-set-variable was only supported in clang starting with
13.0.0, so earlier versions will emit a warning, which is turned into a
hard error for the kernel to mirror GCC:
error: unknown warning option '-Wunused-but-set-variable'; did you
display_mode_lib *mode_lib)
| ^
1 error generated.
So, since UseMinimumDCFCLK() consumes a lot of stack space, mark it as
noinline_for_stack to prevent it from blowing up
dml314_ModeSupportAndSystemConfigurationFull()'s stack size.
Signed-off-by: Hamza Mahfooz
---
.../gpu/drm/amd
display_mode_lib *mode_lib)
| ^
1 error generated.
So, since UseMinimumDCFCLK() consumes a lot of stack space, mark it as
noinline_for_stack to prevent it from blowing up
dml31_ModeSupportAndSystemConfigurationFull()'s stack size.
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd
On 6/3/23 10:52, Felix Richter wrote:
Hi Guys,
sorry for the silence from my side. I had a lot of things to take care
of after returning from vacation. Also I had to wait on the zfs modules
to be updated to support kernel 6.3 for further testing.
The bad news is that I am still
On 6/2/23 06:12, GONG, Ruiqi wrote:
Currently compiling linux-next with allmodconfig triggers the following
error:
./drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h: In function
‘dc_fixpt_truncate’:
./drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:528:22: error:
left
On 6/2/23 02:17, Jiapeng Chong wrote:
No functional modification involved.
drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dpms.c:2377
link_set_dpms_on() warn: inconsistent indenting.
Reported-by: Abaci Robot
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5376
Signed-off-by:
On 5/30/23 11:50, Ho, Kenny wrote:
[Public]
On 5/30/23 11:24, Hamza Mahfooz wrote:
I am able to get clean builds with this enabled on GCC 11-13 and Clang
15, at least as of commit e786aef0869c ("drm/amd/display: remove unused
definition") on amd-staging-drm-next.
Did you try int
On 5/25/23 12:38, Hamza Mahfooz wrote:
We want to do -Werror builds on our CI. However, non-amdgpu breakages
have prevented us from doing so thus far. Also, there are a number of
additional checks that we should enable, that the community cares about
and are hidden behind -Wextra. So, define
for the amdgpu kernel module and enable -Wextra while
disabling all of the checks that are too noisy.
Cc: Alex Deucher
Cc: Kenny Ho
Suggested-by: Jani Nikula
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/amdgpu/Kconfig | 10 ++
drivers/gpu/drm/amd/amdgpu/Makefile | 9 +
2
compile
checks
On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz
wrote:
Currently, there are quite a number of issues that are quite easy for
the CI to catch, that slip through the cracks. Among them, there are
unused variable and indentation issues. Also, we should consider all
warnings to be compile
On 5/24/23 15:54, Harry Wentland wrote:
On 5/24/23 15:27, Hamza Mahfooz wrote:
On 5/24/23 15:22, Alex Deucher wrote:
On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz wrote:
Currently, there are quite a number of issues that are quite easy for
the CI to catch, that slip through the cracks
On 5/24/23 15:22, Alex Deucher wrote:
On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz wrote:
Currently, there are quite a number of issues that are quite easy for
the CI to catch, that slip through the cracks. Among them, there are
unused variable and indentation issues. Also, we should
about them. So, enable -Werror, -Wunused and
-Wmisleading-indentation for all kernel builds.
Cc: Alex Deucher
Cc: Harry Wentland
Cc: Kenny Ho
Signed-off-by: Hamza Mahfooz
---
v2: fix grammatical error
---
drivers/gpu/drm/amd/display/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git
them. So, enable -Werror, -Wunused and
-Wmisleading-indentation for all kernel builds.
Cc: Alex Deucher
Cc: Harry Wentland
Cc: Kenny Ho
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/Makefile
On 5/24/23 04:57, Jiapeng Chong wrote:
No functional modification involved.
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/dcn314_fpu.c:269
dcn314_update_bw_bounding_box_fpu() warn: inconsistent indenting.
Reported-by: Abaci Robot
Closes:
On 5/23/23 23:59, Yang Li wrote:
Eliminate the following warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:889:43:
warning: unused variable 'res_create_maximus_funcs'
Reported-by: Abaci Robot
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5296
Fixes:
On 5/23/23 04:34, Arnd Bergmann wrote:
From: Arnd Bergmann
The .resync_fifo_dccg_dio() callback pointer was added in an #ifdef block,
but is called unconditionally:
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2292:31:
error: 'struct hwseq_private_funcs' has no
On 5/23/23 07:49, Tom Rix wrote:
gcc with W=1 reports
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:1069:43: error:
‘res_create_maximus_funcs’ defined but not used
[-Werror=unused-const-variable=]
1069 | static const struct resource_create_funcs res_create_maximus_funcs =
did from
debugfs")
Reported-by: kernel test robot
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/disp
set_abm_event() is never actually used. So, drop it.
Fixes: b46c01aa0329 ("drm/amd/display: Refactor ABM feature")
Reported-by: kernel test robot
Reported-by: Tom Rix
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 12
drivers/gpu/drm/a
m/amd/display: Add DSC support for Navi (v2)")
Reported-by: Christophe JAILLET
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
b/drivers/gpu/drm/amd/display/dc/dsc/dc_d
On 5/12/23 03:04, Jiapeng Chong wrote:
./drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c:586:37-39: WARNING !A || A
&& B is equivalent to !A || B.
./drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c:595:37-39: WARNING !A || A
&& B is equivalent to !A || B.
Reported-by: Abaci Robot
Link:
On 5/7/23 23:09, Huacai Chen wrote:
LoongArch now provides kernel_fpu_begin() and kernel_fpu_end() that are
used like the x86 counterparts in commit 2b3bd32ea3a22ea2d ("LoongArch:
Provide kernel fpu functions"), so we can enable DC_FP on LoongArch for
supporting more DCN devices.
Signed-off-by:
Hey Huacai,
On 5/5/23 07:32, Huacai Chen wrote:
Now LoongArch provides kernel_fpu_begin() and kernel_fpu_end() in commit
2b3bd32ea3a22ea2d ("LoongArch: Provide kernel fpu functions"), so we can
enable DC_FP for DCN devices.
Have you had the chance to test how well this is working on actual
rom gmc_v9_0_hw_fini().
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2522
Fixes: 3029c855d79f ("drm/amdgpu: Fix desktop freezed after gpu-reset")
Signed-off-by: Hamza Mahfooz
---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gp
On 5/1/23 10:31, Arnd Bergmann wrote:
From: Arnd Bergmann
A global function without a header prototype has made it into
linux-next during the merge window:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6339:6: error: no
previous prototype for 'amdgpu_dm_connector_funcs_force'
On 4/26/23 15:24, Harshit Mogalapalli wrote:
We have a NULL check for 'dc_dmub_srv' in dc_dmub_srv_cmd_run_list()
but we are dereferencing it before checking.
Fix this moving the dereference next to NULL check.
This issue is found with Smatch(static analysis tool).
Fixes: e97cc04fe0fb
1 - 100 of 203 matches
Mail list logo