t;> duplication
>> and finally it does not allow to handle more than one device in system.
>> It seems better to embed such structures in private context of the device.
>
> Gently ping.
This patch series already is in exynos-drm-next-todo branch. I will move
it to exynos-drm-n
FER) {
> + return ret;
> + } else {
WARNING: else is not generally useful after a break or return
#146: FILE: drivers/gpu/drm/exynos/exynos_dp_core.c:1208:
+ return ret;
+ } else {
How about just returning ret like below?
On 2014? 10? 23? 01:34, Ajay kumar wrote:
> On Wed, Oct 22, 2014 at 8:26 PM, Inki Dae wrote:
>>
>> Thanks for contribution.
>>
>> It seems reasonable that you separate device drivers into FIMD and DECON
>> because many registers of them have many differe
,
Inki Dae
On 2014? 10? 10? 21:48, Ajay Kumar wrote:
> This series is based on exynos-drm-next branch of Inki Dae's tree at:
> git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git
>
> DECON(Display and Enhancement Controller) is the new IP
> in exynos7 SOC for generatin
On 2014? 10? 10? 21:39, Andrzej Hajda wrote:
> On 10/02/2014 12:52 PM, Inki Dae wrote:
>> On 2014? 10? 02? 17:58, Joonyoung Shim wrote:
>>> Hi Andrzej,
>>>
>>> On 10/01/2014 05:14 PM, Andrzej Hajda wrote:
>>>> The patch disables vblanks during dpms
ve me tested-by after test? I cannot test this module
because I have no any board equipped with dp panel.
Jingoo or other?
Thanks,
Inki Dae
>> drivers/gpu/drm/exynos/exynos_dp_core.c | 58
>> +++
>> drivers/gpu/drm/exynos/exynos_dp_core.h |2
On 2014? 10? 08? 00:28, Inki Dae wrote:
>
> Sorry for late.
>
> On 2014? 10? 07? 21:27, Andrzej Hajda wrote:
>> Hi Inki,
>>
>> Gently ping.
>>
>> Andrzej
>>
>>
>> On 09/19/2014 02:57 PM, Andrzej Hajda wrote:
>>> Initializa
it could attempt to disabling vblank for non-existing crtc,
which in turn, null pointer access occurs.
Thanks,
Inki Dae
>>
>> Signed-off-by: Andrzej Hajda
>> ---
>> drivers/gpu/drm/exynos/exynos_drm_drv.c | 18 +-
>> 1 file changed, 9 insertions(+), 9 de
encoder object isn't used anymore so remove it.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_vidi.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c
b/drivers/gpu/drm/exynos/exynos_drm_vidi.c
index 9395e85..50faf91 100644
//<- store the latest
vblank frame count.
} else {
drm_crtc_vblank_on(crtc); //<- restore the vblank
frame count.
}
[snip]
}
Tested and worked well with above patch. How about it?
Thanks,
Inki Dae
>
>>From 6de01473746af225c688ee430123001d57d9af2a
On 2014? 10? 02? 08:47, Joonyoung Shim wrote:
> Hi Tomasz,
>
> On 10/02/2014 12:13 AM, Tomasz Figa wrote:
>> Hi Inki,
>>
>> On 17.09.2014 15:48, Inki Dae wrote:
>>> This interface and relevant codes aren't used anymore.
>>>
>>
>> Hmm, I
On 2014? 10? 01? 22:17, Tomasz Figa wrote:
> Hi Inki,
>
> On 17.09.2014 15:48, Inki Dae wrote:
>> This patch removes DRM_EXYNOS_GEM_MMAP ictrl feature specific
>> to Exynos drm and instead uses drm generic mmap.
>
> It looks like libdrm_exynos is still using DRM_EXYNOS
On 2014? 10? 01? 14:48, Inki Dae wrote:
> On 2014? 09? 30? 20:29, Andrzej Hajda wrote:
>> Hi Inki,
>>
>> Gently ping.
>
> Hi Andrzej,
>
> I merged it to local repository to test. But now exynos drm doesn't work
> correctly since pulling drm-next of Dave reg
t with -v option from second
times.
2. error occurs when we try to test unbind.
Now we are checking these problems. Can you try to also check it?
Thanks,
Inki Dae
>
> Andrzej
>
> On 09/10/2014 01:53 PM, Andrzej Hajda wrote:
>> The patch replaces separate calls to driver (de)re
before updating overlay registers.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index 2f896df..8a45a70 100644
2014-09-20 1:04 GMT+09:00 Inki Dae :
> 2014-09-19 21:58 GMT+09:00 Andrzej Hajda :
>> The patch replaces legacy functions
>> drm_plane_init() / drm_crtc_init() with
>> drm_universal_plane_init() and drm_crtc_init_with_planes().
>> It allows to replace fake prim
2014-09-18 17:50 GMT+09:00 Joonyoung Shim :
> From fimd driver and vidi driver, dev->irq_enabled and
> dev->vblank_disable_allowed are set and also mixer needs them even if
> missed. It's duplicated so set them when loads drm driver.
Picked it up.
Thanks,
Inki Dae
>
> Sig
leanup of crtcs to core,
> this way planes and crtcs are cleaned in correct order.
>
> Signed-off-by: Andrzej Hajda
> ---
> Hi Inki, Joonyoung,
>
> This is 2nd version of the patch with addressed comments of Joonyoung.
Picked it up.
Thanks,
Inki Dae
>
> Regards
, VM_DONTEXPEND and VM_DONTDUMP. These flags were already
set by drm_gem_mmap
- do not include , which isn't needed anymore.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 26 -
drivers/gpu/drm/exynos/exynos_drm_drv.h |1 -
drivers/gpu/drm/exynos/exynos_drm_gem.c
Thanks for review.
Below trivial things you pointed out will be fixed soon.
On 2014? 09? 18? 13:56, Joonyoung Shim wrote:
> Hi,
>
> On 09/17/2014 10:48 PM, Inki Dae wrote:
>> This patch removes DRM_EXYNOS_GEM_MMAP ictrl feature specific
>> to Exynos drm and instead
mmap interface
because the drm generic mmap which uses vm offset manager stuff can
also do mmap directly.
This patch makes a userspace region to be mapped with whole physical
memory region allocated by userspace request when mmap system call is
requested.
Signed-off-by: Inki Dae
---
drivers/gpu
This interface and relevant codes aren't used anymore.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_drv.c |3 ---
drivers/gpu/drm/exynos/exynos_drm_gem.c | 17 -
drivers/gpu/drm/exynos/exynos_drm_gem.h |4
include/uapi/drm/exynos_drm.h
This patch set removes unnecessary DRM_EXYNOS_GEM_MAP_OFFSET interface
which isn't used anymore and also uses drm generic mmap interface
instead of a mmap interface specific to Exynos drm. So this patch set
removes a existing mmap interface and relevant codes specific to Exynos
drm.
Inki Dae (2
ied all patches except patch #5. As of now, it seems good to merge
also patch #5 if you couldn't post next version of that patch until the
end of this week. In this case, I will have a pull request including
that patch so that we can fix it up correctly later. Give me your
opinion if there is other plan
ll with
them by the end of the week.
Thanks for notice,
Inki Dae
>
> Please continue to send fixes for -next pulls, and I'm kinda open to
> new hw support depending on how intrusive it is to other code.
>
> Now we have a strange new time of a few weeks where maybe we should go
> fix
unds very much like exynos should switch to universal planes so
>> that the fake primary plane created by the helpers doesn't get in the way.
>> And for chips which already use planes for everything internally this
>> shouldn't be a lot more than a few lines.
>> -Daniel
>
On 2014? 09? 12? 20:04, Andrzej Hajda wrote:
> On 09/12/2014 12:45 PM, Inki Dae wrote:
>> On 2014? 09? 12? 18:27, Andrzej Hajda wrote:
>>> On 09/12/2014 10:57 AM, Daniel Vetter wrote:
>>>> On Fri, Sep 12, 2014 at 05:34:50PM +0900, Inki Dae wrote:
>>>>>
On 2014? 09? 12? 18:27, Andrzej Hajda wrote:
> On 09/12/2014 10:57 AM, Daniel Vetter wrote:
>> On Fri, Sep 12, 2014 at 05:34:50PM +0900, Inki Dae wrote:
>>> Hi Andrzej,
>>>
>>> On 2014? 09? 09? 22:16, Andrzej Hajda wrote:
>>>> Adding reference to
On 2014? 09? 12? 17:57, Daniel Vetter wrote:
> On Fri, Sep 12, 2014 at 05:34:50PM +0900, Inki Dae wrote:
>> Hi Andrzej,
>>
>> On 2014? 09? 09? 22:16, Andrzej Hajda wrote:
>>> Adding reference to framebuffer should be accompanied with removing
>>> reference t
rtc = crtc;
> plane->fb = crtc->primary->fb;
> drm_framebuffer_reference(plane->fb);
>
> + if (old_fb)
> + drm_framebuffer_unreference(old_fb);
This time would be a good chance that we can consider drm flip queue to
make sure that whole memory region to old_fb is scanned out completely
before dropping a reference of old_fb. the reference of old_fb should be
dropped at irq handler of each crtc devices, fimd and mixer.
Thanks,
Inki Dae
> +
> return 0;
> }
>
>
Update Exynos's DRM driver to use component match support rater than
add_components.
Changelog v2:
- release devices and drivers if failed.
- change compare_of to compare_dev.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 44 +++
1 file
t; In the 2nd version of the series I have included changes proposed by
> Joonyoung Shim.
> I have decided to resend whole series because the changes caused merge
> conflicts and
> two separate patches have been added to the series.
> Changes are described in comit messages.
Applied.
Than
On 2014? 09? 11? 16:01, Joonyoung Shim wrote:
> Hi,
>
> On 09/11/2014 03:22 PM, Daniel Vetter wrote:
>> On Thu, Sep 11, 2014 at 11:16:53AM +0900, Inki Dae wrote:
>>> On 2014? 09? 10? 18:01, Daniel Vetter wrote:
>>>> Ok I've stumbled over the exynos mmap st
On 2014? 09? 11? 15:22, Daniel Vetter wrote:
> On Thu, Sep 11, 2014 at 11:16:53AM +0900, Inki Dae wrote:
>> On 2014? 09? 10? 18:01, Daniel Vetter wrote:
>>> Ok I've stumbled over the exynos mmap stuff again while cleaning up
>>> drm legacy cruft and I just don't ge
sting and above fixup patch set. Will look into them soon. :)
Thanks,
Inki Dae
>
> Few additional comments below.
>
> On 09/01/2014 02:19 PM, Inki Dae wrote:
>> Update Exynos's DRM driver to use component match support rater than
>> add_components.
>>
>
.html
Is there any issue I am missing , that could be incurred by Exynos codes?
Thanks,
Inki Dae
>
> Thanks, Daniel
>
>
> On Fri, Dec 20, 2013 at 11:36 AM, Inki Dae wrote:
>> This patch resolves potential deadlock issue that can be incurred
>> by changing file->
sung-soc/37266
>
> I have tested successfully your patch with trats and universal_c210 boards.
>
> Few additional comments below.
>
> On 09/01/2014 02:19 PM, Inki Dae wrote:
>> Update Exynos's DRM driver to use component match support rater than
>> add_components.
>&g
Update Exynos's DRM driver to use component match support rater than
add_components.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 40 ++-
1 file changed, 18 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/exynos
On 2014? 08? 31? 06:33, Russell King - ARM Linux wrote:
> On Thu, Jul 03, 2014 at 12:26:39AM +0900, Inki Dae wrote:
>> 2014-07-01 23:22 GMT+09:00 Russell King - ARM Linux > arm.linux.org.uk>:
>>> On Thu, Jun 26, 2014 at 03:46:01PM +0100, Russell King - ARM Linux wrote:
&
On 2014? 08? 18? 20:38, Andrzej Hajda wrote:
> On 08/18/2014 10:11 AM, Inki Dae wrote:
>> This patch adds a new flag, MIPI_DSI-MODE_LPM, to transmit data
>> in low power. With this flag, msg.flags has MIPI_DSI_MSG_USE_LPM
>> so that host driver of each SoC can clear or set rel
On 2014? 08? 14? 11:22, YoungJun Cho wrote:
> The type of this function is unsigned long, and it is expected
> to return proper fout value or zero if something is wrong.
> So this patch fixes wrong return value for error cases.
Applied.
Thanks,
Inki Dae
>
> Signed-off-by: YoungJ
Signed-off-by: Inki Dae
---
arch/arm/boot/dts/exynos3250.dtsi | 15 +++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/exynos3250.dtsi
b/arch/arm/boot/dts/exynos3250.dtsi
index 2bab12f..480dedf 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot
This patch adds mipi_phy device node to reset, disable and enable
DSIM and CSIS PHY.
Signed-off-by: Inki Dae
---
arch/arm/boot/dts/exynos3250.dtsi |6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/exynos3250.dtsi
b/arch/arm/boot/dts/exynos3250.dtsi
index 0ec2584
Signed-off-by: Inki Dae
---
arch/arm/boot/dts/exynos3250.dtsi | 12
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/exynos3250.dtsi
b/arch/arm/boot/dts/exynos3250.dtsi
index 1d52de6..0ec2584 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts
Signed-off-by: Inki Dae
---
.../devicetree/bindings/video/samsung-fimd.txt |1 +
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 10 ++
2 files changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/video/samsung-fimd.txt
b/Documentation/devicetree
This patch adds Exynos3250/3472 SoCs support.
Signed-off-by: Inki Dae
---
.../devicetree/bindings/video/exynos_dsim.txt |1 +
drivers/gpu/drm/exynos/exynos_drm_dsi.c|8
2 files changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/video
This patch series adds of_device_id and relevant device nodes
for Exynos3250 SoC support.
Inki Dae (5):
drm/exynos: mipi-dsi: add Exynos3 SoC support
drm/exynos: fimd: add Exynos3 SoC support
ARM: dts: add fimd device node to exynos3250.dsti
ARM: dts: add mipi_phy device node
between high speed transmissions.
For this, this patch adds a new bit, DSIM_CLKLANE_STOP, and makes
the host driver set this bit only in case that dsi->mode_flags has
MIPI_DSI_CLOCK_NON_CONTINUOUS flag.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c |
power, the peripheral driver
should set MIPI_DSI_MODE_LPM flag.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/drm_mipi_dsi.c |6 ++
include/drm/drm_mipi_dsi.h |2 ++
2 files changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
index
properly.
Patch 1:
Add MIPI_DSI_MODE_LPM flag. If panel driver sets this flag, then msg->flags
will have MIPI_DSI_MSG_USE_LPM so that host driver can transmit data in low
power.
Patch 2:
Just exynos part for supporting non-continuous and continuous clock mode.
Inki Dae (2):
drm/mipi-dsi: consi
On 2014? 08? 12? 20:54, YoungJun Cho wrote:
> Hi Inki, Andrzej
>
> On 08/11/2014 04:09 PM, Inki Dae wrote:
>> On 2014? 08? 08? 18:40, Andrzej Hajda wrote:
>>> On 08/08/2014 11:02 AM, Andrzej Hajda wrote:
>>>> On 08/08/2014 09:37 AM, Inki Dae wrote:
>>
DSIM_TX_REQUEST_HSCLK
only in case that dsi->mode_flags has no MIPI_DSI_CLOCK_NON_CONTINUOUS
flag.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 32 +--
1 file changed, 30 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exy
power, the peripheral driver
should set MIPI_DSI_MODE_LPM flag.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/drm_mipi_dsi.c |6 ++
include/drm/drm_mipi_dsi.h |2 ++
2 files changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
index
properly.
Patch 1:
Add MIPI_DSI_MODE_LPM flag, and with this flag, mipi-dsi framework will set
MIPI_DSI_MSG_USE_LPM.
Patch 2:
Just exynos part for supporting non-continuous and continuous clock mode.
Inki Dae (2):
drm/mipi-dsi: consider low power transmission.
drm/exynos: mipi-dsi: consider non
On 2014? 08? 11? 18:11, Thierry Reding wrote:
> On Mon, Aug 11, 2014 at 05:15:35PM +0900, Inki Dae wrote:
>> On 2014? 08? 11? 16:50, Thierry Reding wrote:
>>> On Mon, Aug 11, 2014 at 04:35:46PM +0900, Inki Dae wrote:
>>>> On 2014? 08? 11? 16:24, Thierry Reding wro
On 2014? 08? 11? 16:50, Thierry Reding wrote:
> On Mon, Aug 11, 2014 at 04:35:46PM +0900, Inki Dae wrote:
>> On 2014? 08? 11? 16:24, Thierry Reding wrote:
>>> On Mon, Aug 11, 2014 at 02:19:21PM +0900, Inki Dae wrote:
>>>> On 2014? 08? 08? 18:55, Thierry Reding
On 2014? 08? 11? 16:44, Andrzej Hajda wrote:
> On 08/11/2014 09:09 AM, Inki Dae wrote:
>> On 2014? 08? 08? 18:40, Andrzej Hajda wrote:
>>> On 08/08/2014 11:02 AM, Andrzej Hajda wrote:
>>>> On 08/08/2014 09:37 AM, Inki Dae wrote:
>>>>> On 2014? 08? 0
On 2014? 08? 11? 16:24, Thierry Reding wrote:
> On Mon, Aug 11, 2014 at 02:19:21PM +0900, Inki Dae wrote:
>> On 2014? 08? 08? 18:55, Thierry Reding wrote:
>>> On Fri, Aug 08, 2014 at 04:37:07PM +0900, Inki Dae wrote:
>>>> On 2014? 08? 08? 16:03, Thierry Reding wro
On 2014? 08? 08? 18:40, Andrzej Hajda wrote:
> On 08/08/2014 11:02 AM, Andrzej Hajda wrote:
>> On 08/08/2014 09:37 AM, Inki Dae wrote:
>>> On 2014? 08? 08? 16:03, Thierry Reding wrote:
>>>> On Fri, Aug 08, 2014 at 10:45:47AM +0900, Inki Dae wrote:
>>>>>
On 2014? 08? 08? 18:55, Thierry Reding wrote:
> On Fri, Aug 08, 2014 at 04:37:07PM +0900, Inki Dae wrote:
>> On 2014? 08? 08? 16:03, Thierry Reding wrote:
>>> On Fri, Aug 08, 2014 at 10:45:47AM +0900, Inki Dae wrote:
>>>> On 2014? 08? 07? 22:55, Thierry Reding wro
On 2014? 08? 08? 16:03, Thierry Reding wrote:
> On Fri, Aug 08, 2014 at 10:45:47AM +0900, Inki Dae wrote:
>> On 2014? 08? 07? 22:55, Thierry Reding wrote:
>>> On Thu, Aug 07, 2014 at 10:39:29PM +0900, Inki Dae wrote:
>>>> On 2014? 08? 07? 22:17, Thierry Reding wro
On 2014? 08? 07? 22:55, Thierry Reding wrote:
> On Thu, Aug 07, 2014 at 10:39:29PM +0900, Inki Dae wrote:
>> On 2014? 08? 07? 22:17, Thierry Reding wrote:
>>> On Thu, Aug 07, 2014 at 10:05:44PM +0900, Inki Dae wrote:
>>>> On 2014? 08? 07? 20:09, Thierry Reding wro
On 2014? 08? 07? 22:17, Thierry Reding wrote:
> On Thu, Aug 07, 2014 at 10:05:44PM +0900, Inki Dae wrote:
>> On 2014? 08? 07? 20:09, Thierry Reding wrote:
>>> On Thu, Aug 07, 2014 at 07:49:03PM +0900, Inki Dae wrote:
>>>> On 2014? 08? 07? 18:09, Thierry Reding wro
On 2014? 08? 07? 20:09, Thierry Reding wrote:
> On Thu, Aug 07, 2014 at 07:49:03PM +0900, Inki Dae wrote:
>> On 2014? 08? 07? 18:09, Thierry Reding wrote:
>>> On Thu, Aug 07, 2014 at 04:51:18PM +0900, Inki Dae wrote:
>>>> On 2014? 08? 07? 15:58, Thierry Reding wro
On 2014? 08? 07? 18:09, Thierry Reding wrote:
> On Thu, Aug 07, 2014 at 04:51:18PM +0900, Inki Dae wrote:
>> On 2014? 08? 07? 15:58, Thierry Reding wrote:
>>> On Thu, Aug 07, 2014 at 02:09:19AM +0900, Inki Dae wrote:
>>>> 2014-08-06 16:43 GMT+09:00 Thierry Reding :
On 2014? 08? 07? 15:58, Thierry Reding wrote:
> On Thu, Aug 07, 2014 at 02:09:19AM +0900, Inki Dae wrote:
>> 2014-08-06 16:43 GMT+09:00 Thierry Reding :
>>> On Wed, Aug 06, 2014 at 04:11:54PM +0900, Inki Dae wrote:
>>>> On 2014? 08? 05? 20:12, Thierry Reding wrote:
&g
On 2014? 07? 29? 22:16, Andrzej Hajda wrote:
> On 07/29/2014 02:08 PM, Inki Dae wrote:
>> On 2014? 07? 29? 20:39, Andrzej Hajda wrote:
>>> On 07/29/2014 05:42 AM, Inki Dae wrote:
>>>> On 2014? 07? 29? 00:50, Andrzej Hajda wrote:
>>>>> On 07/28/2014 04:
2014-08-06 16:43 GMT+09:00 Thierry Reding :
> On Wed, Aug 06, 2014 at 04:11:54PM +0900, Inki Dae wrote:
>> On 2014? 08? 05? 20:12, Thierry Reding wrote:
> [...]
>> > I think that low power mode is more often used for command transmission
>> > (in host-driven mode
Thanks for comments.
On 2014? 08? 05? 20:12, Thierry Reding wrote:
> On Mon, Jul 28, 2014 at 06:09:58PM +0200, Andrzej Hajda wrote:
>> On 07/28/2014 04:00 AM, Inki Dae wrote:
>>> This patch adds below two flags for LPM transfer, and it attaches LPM flags
>>> to a msg
and
a littl bit refactoring codes.
If there is any problem, please kindly let me know.
Thanks,
Inki Dae
The following changes since commit 08d645c181e9b9482c249e82a061c279a986db15:
agp: remove read/write stubs (2014-08-02 06:43:51 +1000)
are available in the git repository at:
git
On 2014? 08? 03? 18:52, Tobias Jakobi wrote:
> Inki Dae wrote:
>> It seems that you have no build test because above line incurs build
>> error. Anyway I fixed it up.
> That's why I have sent v2 of the patch.
>
Oops, sorry. I didn't check v2.
Thanks,
Inki Dae
> With best wishes,
> Tobias
>
>
/gpu/drm/exynos/exynos_drm_dsi.c | 12 ++--
>> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> And this one as well.
Acked-by: Inki Dae
Thanks,
Inki Dae
>
> Thierry
>
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
nqueue_node *runqueue_node;
> struct list_head *run_cmdlist;
> struct list_head *event_list;
>
> + if (!g2d_priv)
> + return -ENODEV;
> +
> + dev = g2d_priv->dev
It seems that you have no build test because above line incurs build
error. Anyw
2014-08-03 16:03 GMT+09:00 Inki Dae :
> 2014-07-29 19:23 GMT+09:00 Andrzej Hajda :
>> On 07/29/2014 02:57 AM, YoungJun Cho wrote:
>>> Hi Andrzej,
>>>
>>> On 07/29/2014 01:09 AM, Andrzej Hajda wrote:
>>>> On 07/28/2014 04:00 AM, Inki Dae wrote:
>&g
2014-07-29 19:23 GMT+09:00 Andrzej Hajda :
> On 07/29/2014 02:57 AM, YoungJun Cho wrote:
>> Hi Andrzej,
>>
>> On 07/29/2014 01:09 AM, Andrzej Hajda wrote:
>>> On 07/28/2014 04:00 AM, Inki Dae wrote:
>>>> This patch adds below two flags for LPM transfe
need an Acked-by from you on this one as well. It has a build
> time dependency on earlier patches in this series, so taking it through
> the panel tree along with the rest is probably easiest.
Acked-by: Inki Dae
Thanks,
Inki Dae
>
> Thierry
>
/gpu/drm/exynos/exynos_drm_dpi.c |8 ++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> Looks good to me. Inki, can I have your Acked-by to take this through
> the panel tree?
Of course.
Acked-by: Inki Dae
Thanks,
Inki Dae
>
> Thierry
>
On 2014? 07? 29? 20:59, Andreas F?rber wrote:
> Am 29.07.2014 10:05, schrieb Sjoerd Simons:
>> On Tue, 2014-07-29 at 14:38 +0900, Inki Dae wrote:
>>> On 2014? 07? 28? 23:45, Sjoerd Simons wrote:
>>>> On Mon, 2014-07-28 at 23:17 +0900, Inki Dae wrote:
>>>&
On 2014? 07? 29? 20:39, Andrzej Hajda wrote:
> On 07/29/2014 05:42 AM, Inki Dae wrote:
>> On 2014? 07? 29? 00:50, Andrzej Hajda wrote:
>>> On 07/28/2014 04:00 AM, Inki Dae wrote:
>>>> This patch adds LPM transfer support for video or command data.
>>>
On 2014? 07? 28? 23:45, Sjoerd Simons wrote:
> Hey Inki,
>
> On Mon, 2014-07-28 at 23:17 +0900, Inki Dae wrote:
>> On 2014? 07? 28? 17:30, Sjoerd Simons wrote:
>> Sorry for late,
>>
>> I don't see why Exynos drm driver should be auto-loaded module. I think
>
On 2014? 07? 29? 00:50, Andrzej Hajda wrote:
> On 07/28/2014 04:00 AM, Inki Dae wrote:
>> This patch adds LPM transfer support for video or command data.
>>
>> With this patch, Exynos MIPI DSI controller can transfer command or
>> video data with HS or LP mode in acc
On 2014? 07? 29? 01:09, Andrzej Hajda wrote:
> On 07/28/2014 04:00 AM, Inki Dae wrote:
>> This patch adds below two flags for LPM transfer, and it attaches LPM flags
>> to a msg in accordance with master's mode_flags set by LCD Panel driver.
>>
>> MIPI_DSI_MODE_CMD_L
On 2014? 07? 28? 17:30, Sjoerd Simons wrote:
> Hey Inki,
>
> On Mon, 2014-07-21 at 08:50 +0200, Sjoerd Simons wrote:
>> Hey Inki,
>>
>> On Mon, 2014-07-21 at 12:02 +0900, Inki Dae wrote:
>>> On 2014? 07? 19? 05:36, Sjoerd Simons wrote:
>>>> The
-off-by: Inki Dae
Acked-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 5e78d45..1bed105 100644
dance with those
requirements."
Some LCD Panel devices, nt35502a, would need LPM transfer support
because they should receive some initial commands with LPM by default
hardware setting.
Changelog v2: just add more descriptions.
Signed-off-by: Inki Dae
Acked-by: Kyungmin Park
---
drive
.
Changelog v2:
- Add more describtions.
- Enable High Speed clock only in case of stand by request.
Inki Dae (2):
drm/mipi-dsi: add (LPM) Low Power Mode transfer support
drm/exynos: dsi: add LPM (Low Power Mode) transfer support
drivers/gpu/drm/drm_mipi_dsi.c |3 +++
drivers/gpu/drm
On 2014? 07? 24? 19:48, Andrzej Hajda wrote:
> +CC: Thierry and Alexandre
>
> On 07/18/2014 12:56 PM, Inki Dae wrote:
>> This patch adds LPM transfer support for video or command data.
>>
>> With this patch, Exynos MIPI DSI controller can transfer command or
>&
On 2014? 07? 24? 19:23, Andrzej Hajda wrote:
> Hi Inki,
>
> +CC: Thierry and Alexandre
>
> On 07/18/2014 12:56 PM, Inki Dae wrote:
>> This patch adds below two flags for LPM transfer, and it attaches LPM flags
>> to a msg in accordance with master's mode_fl
er property
> ARM: dts: exynos5: add system register property
> ARM: dts: exynos5420: add mipi-phy node
> ARM: dts: exynos5420: add dsi node
Piked them up except patch 9 and 10. The two patches are needed for more
review and consensus
Thanks,
Inki Dae
>
> .../devicetree/bindings/p
On 2014? 07? 03? 22:10, Andrzej Hajda wrote:
> This set of independent patches contains various improvement and fixes
> for exynos_drm ipp framework.
> The patchset is based on exynos-drm-next branch.
Applied.
Thanks,
Inki Dae
>
> Regards
> Andrzej
>
>
> Andrzej
nt it.
P.s. Thierry already opposed the use of mipi_dsi_host_ops, I agree with
him. And also it seems not good to use crtc and encoder/connector
because these frameworks are common to all architecture including x86 so
other architectures wouldn't need TE feature.
Thanks,
Inki Dae
> Regard
On 2014? 07? 21? 18:23, Andrzej Hajda wrote:
> Hi Inki,
>
> On 07/09/2014 04:47 PM, Inki Dae wrote:
>> On 2014? 07? 03? 22:10, Andrzej Hajda wrote:
>>> This set of independent patches contains various improvement and fixes
>>> for exynos_drm ipp framework.
>&g
struct i2c_client *client, struct device_node *node)
> +struct drm_bridge *ptn3460_init(struct drm_device *dev,
> + struct drm_encoder *encoder,
> + struct i2c_client *client,
> + struct de
gt;bridge as is there. I think lvds bridge device drivers
could follow Linux driver model with this approach.
Rob, it seems to need at least your ACK so that I can merge this patch
series to exynos-drm-next.
Thanks,
Inki Dae
>
> Ajay Kumar (9):
> [RESEND PATCH V5 01/12] drm/exynos: M
ing OF match tables
> without a
> MODULE_DEVICE_TABLE call.
Hi,
Exynos drm follows single-driver model. So each usb driver of Exynos drm
wouldn't need its own MODULE_DEVICE_TABLE.
Thanks,
Inki Dae
>
> Sjoerd Simons (3):
> Revert "drm/exynos: fix module build error"
> Revert &q
atches ("drm: exynos: hdmi: make 'hdmi-en' regulator optional
> and keep it enabled" and "drm: hdmi/mixer: enable exynos 4210 and 4x12
> soc support") add proper support for Exynos4 SoCs to Exynos DRM drivers.
> Those patches should go to exynos-drm kernel tree.
Picked them
This patch adds LPM transfer support for video or command data.
With this patch, Exynos MIPI DSI controller can transfer command or
video data with HS or LP mode in accordance with mode_flags set
by LCD Panel driver.
Signed-off-by: Inki Dae
Acked-by: Kyungmin Park
---
drivers/gpu/drm/exynos
clock behavior in accordance with those
requirements."
Some LCD Panel devices, nt35502a, would need LPM transfer support
because they should receive some initial commands with LPM by default
hardware setting.
Signed-off-by: Inki Dae
Acked-by: Kyungmin Park
---
drivers/gpu/drm/drm_mipi_ds
This patch series adds LPM tranfer support for video and command data.
For this, this patch adds two flags, and makes MIPI DSI host to send
commands to LCD Panel device with LPM if mode_flags of LCD Panel driver
includes LPM flag.
And also it applies this feature to Exynos MIPI DSI driver.
Inki
On 2014? 07? 16? 19:12, YoungJun Cho wrote:
> Hi Thierry,
>
> On 07/16/2014 04:54 PM, Thierry Reding wrote:
>> On Wed, Jul 16, 2014 at 11:23:09AM +0900, YoungJun Cho wrote:
>>> Hi Inki,
>>>
>>> On 07/15/2014 11:34 AM, Inki Dae wrote:
>>>> On 2
1001 - 1100 of 2980 matches
Mail list logo
