[PATCH v10 8/9] drm/imx: Add drm_panic support

) * move get_scanout_buffer() to plane helper functions Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c index

[PATCH v10 6/9] drm/simpledrm: Add drm_panic support

helper functions (Thomas Zimmermann) Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/tiny/simpledrm.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c index 7ce1c4617675..f498665be8c4 100644 --- a/drivers

[PATCH v10 7/9] drm/mgag200: Add drm_panic support

with drm_panic_set_buffer() (Thomas Zimmermann) v9: * Revert to using get_scanout_buffer() (Sima) * move get_scanout_buffer() to plane helper functions (Thomas Zimmermann) Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/mgag200/mgag200_drv.h | 7 ++- drivers/gpu/drm/mgag200/mgag200_mode.c | 18

[PATCH v10 5/9] drm/fb_dma: Add generic get_scanout_buffer() for drm_panic

-by: Jocelyn Falempe --- drivers/gpu/drm/drm_fb_dma_helper.c | 47 + include/drm/drm_fb_dma_helper.h | 4 +++ 2 files changed, 51 insertions(+) diff --git a/drivers/gpu/drm/drm_fb_dma_helper.c b/drivers/gpu/drm/drm_fb_dma_helper.c index 3b535ad1b07c..010327069ad4 100644

[PATCH v10 3/9] drm/panic: Add support for color format conversion

format helper to drm_panic Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_panic.c | 272 ++-- 1 file changed, 262 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.c index faa64961c0f2..2c3b2fffe659 100644

[PATCH v10 2/9] drm/panic: Add a drm panic handler

in drm_panic (Thomas Zimmermann). * Simplify the text drawing functions. * Use kmsg_dumper instead of panic_notifier (Sima). Signed-off-by: Jocelyn Falempe --- Documentation/gpu/drm-kms.rst| 12 + drivers/gpu/drm/Kconfig | 23 ++ drivers/gpu/drm/Makefile

[PATCH v10 1/9] drm/panic: Add drm panic locking

ote that the locking is very much not correct there, hence this separate rfc. v2: - fix authorship, this was all my typing - some typo oopsies - link to the drm panic work by Jocelyn for context v10: - Use spinlock_irqsave/restore (John Ogness) Signed-off-by: Daniel Vetter Cc: Jocelyn Falempe Cc: And

[PATCH v10 0/9] drm/panic: Add a drm panic handler

drm/panic: Add drm panic locking Jocelyn Falempe (8): drm/panic: Add a drm panic handler drm/panic: Add support for color format conversion drm/panic: Add debugfs entry to test without triggering panic. drm/fb_dma: Add generic get_scanout_buffer() for drm_panic drm/simpledrm: Add drm

Re: [PATCH] vmwgfx: Create debugfs ttm_resource_manager entry only if needed

On 13/03/2024 18:57, Zack Rusin wrote: On Tue, Mar 12, 2024 at 5:36 AM Jocelyn Falempe wrote: [...] Thanks! That looks great. I can push it through drm-misc-fixes. Thanks, I think I only forget the "drm/" in the commit title, but yes you can push it with this small

Re: [PATCH 12/43] drm/mgag200: Use fbdev-shmem

Hi, Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe -- Jocelyn On 12/03/2024 16:45, Thomas Zimmermann wrote: Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann

Re: [PATCH 09/43] drm/ast: Use fbdev-shmem

Hi, Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe -- Jocelyn On 12/03/2024 16:45, Thomas Zimmermann wrote: Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann

Re: [v9,5/9] drm/fb_dma: Add generic get_scanout_buffer() for drm_panic

On 12/03/2024 17:44, Sui Jingfeng wrote: Hi, I'm get attracted by your patch, so I want to comment. Please correct or ignore me if I say something wrong. On 2024/3/7 17:14, Jocelyn Falempe wrote: This was initialy done for imx6, but should work on most drivers using drm_fb_dma_helper. v8

Re: [PATCH v9 0/9] drm/panic: Add a drm panic handler

On 12/03/2024 16:16, Sui Jingfeng wrote: Hi, On 2024/3/7 17:14, Jocelyn Falempe wrote: This introduces a new drm panic handler, which displays a message when a panic occurs. So when fbcon is disabled, you can still see a kernel panic. This is one of the missing feature, when disabling VT

Re: [v9,3/9] drm/panic: Add a drm panic handler

On 12/03/2024 14:18, Sui Jingfeng wrote: Hi, [...] While applying you patch, there is new blank line at EOF reported, see below. This is not an issue, but I want to report this to you. Hi, Thanks, I will remove it for the next version. -- Jocelyn git am

Re: [v2] drm/mgag200: Add a workaround for low-latency

On 12/03/2024 13:56, Sui Jingfeng wrote: Hi, Interesting patch! I know this patch already merged. While study this patch, I have a few questions. On 2024/2/8 17:51, Jocelyn Falempe wrote: We found a regression in v5.10 on real-time server, using the rt-kernel and the mgag200 driver. It's

[PATCH] vmwgfx: Create debugfs ttm_resource_manager entry only if needed

7fe30 R10: R11: 0246 R12: 7f4c41573000 R13: 0003 R14: 7f4c41572010 R15: 0003 ORIG_RAX: CS: 0033 SS: 002b Signed-off-by: Jocelyn Falempe Fixes: af4a25bbe5e7 ("drm/vmwgfx: Add debugfs entries for various ttm

Re: [PATCH v9 1/9] drm/panic: Add drm panic locking

On 07/03/2024 11:27, John Ogness wrote: On 2024-03-07, Jocelyn Falempe wrote: diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 39ef0a6addeb..c0bb91312fb2 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c

Re: [RFC] How to test panic handlers, without crashing the kernel

On 05/03/2024 18:50, Guilherme G. Piccoli wrote: On 05/03/2024 13:52, Jocelyn Falempe wrote: [...] Or maybe have two lists of panic notifiers, the safe and the destructive list. So in case of fake panic, we can only call the safe notifiers. I tried something like that: https

Re: [PATCH v9 2/9] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill

Hi, On 07/03/2024 16:41, Thomas Zimmermann wrote: Am 07.03.24 um 15:08 schrieb Thomas Zimmermann: Hi Am 07.03.24 um 10:14 schrieb Jocelyn Falempe: This is needed for drm_panic, to draw the font, and fill the background color, in multiple color format. As you know, I'm not happy about

[PATCH v9 9/9] drm/ast: Add drm_panic support

) * move get_scanout_buffer() to plane helper functions Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_mode.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index a718646a66b8..49f2d8bd3377 100644

[PATCH v9 7/9] drm/mgag200: Add drm_panic support

with drm_panic_set_buffer() (Thomas Zimmermann) v9: * Revert to using get_scanout_buffer() (Sima) * move get_scanout_buffer() to plane helper functions (Thomas Zimmermann) Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/mgag200/mgag200_drv.h | 7 ++- drivers/gpu/drm/mgag200/mgag200_mode.c | 18

[PATCH v9 8/9] drm/imx: Add drm_panic support

) * move get_scanout_buffer() to plane helper functions Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c index

[PATCH v9 6/9] drm/simpledrm: Add drm_panic support

helper functions (Thomas Zimmermann) Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/tiny/simpledrm.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c index 7ce1c4617675..f498665be8c4 100644 --- a/drivers

[PATCH v9 3/9] drm/panic: Add a drm panic handler

to using get_scanout_buffer() (Sima) * Move get_scanout_buffer() and panic_flush() to the plane helper functions (Thomas Zimmermann) * Register all planes with get_scanout_buffer() to the panic notifier * Use drm_panic_lock() to protect against race (Sima) Signed-off-by: Jocelyn Falempe

[PATCH v9 5/9] drm/fb_dma: Add generic get_scanout_buffer() for drm_panic

-by: Jocelyn Falempe --- drivers/gpu/drm/drm_fb_dma_helper.c | 47 + include/drm/drm_fb_dma_helper.h | 4 +++ 2 files changed, 51 insertions(+) diff --git a/drivers/gpu/drm/drm_fb_dma_helper.c b/drivers/gpu/drm/drm_fb_dma_helper.c index 3b535ad1b07c..010327069ad4 100644

[PATCH v9 4/9] drm/panic: Add debugfs entry to test without triggering panic.

ane in the device's debugfs directory. This allows to test for each plane of each GPU independently. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/Kconfig | 9 + drivers/gpu/drm/drm_panic.c | 38 + 2 files changed, 47 insertions(+) diff --

[PATCH v9 2/9] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill

by the kernel test bot Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_format_helper.c | 432 ++-- include/drm/drm_format_helper.h | 9 + 2 files changed, 360 insertions(+), 81 deletions(-) diff --git a/drivers/gpu/drm/drm_format_helper.c b/drivers/gpu/drm

[PATCH v9 1/9] drm/panic: Add drm panic locking

ote that the locking is very much not correct there, hence this separate rfc. v2: - fix authorship, this was all my typing - some typo oopsies - link to the drm panic work by Jocelyn for context Signed-off-by: Daniel Vetter Cc: Jocelyn Falempe Cc: Andrew Morton Cc: "Peter Zijlstra (Intel)&quo

[PATCH v9 0/9] drm/panic: Add a drm panic handler

ectory. This allows to test for each plane of each GPU independently. Daniel Vetter (1): drm/panic: Add drm panic locking Jocelyn Falempe (8): drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill drm/panic: Add a drm panic handler drm/panic: Add debugfs entry to test without triggering

Re: [RFC] How to test panic handlers, without crashing the kernel

On 05/03/2024 17:23, Michael Kelley wrote: From: Guilherme G. Piccoli Sent: Monday, March 4, 2024 1:43 PM On 04/03/2024 18:12, John Ogness wrote: [...] The second question is how to simulate a panic context in a non-destructive way, so we can test the panic notifiers in CI, without

Re: [RFC] How to test panic handlers, without crashing the kernel

On 04/03/2024 22:12, John Ogness wrote: [Added printk maintainer and kdb folks] Hi Jocelyn, On 2024-03-01, Jocelyn Falempe wrote: While writing a panic handler for drm devices [1], I needed a way to test it without crashing the machine. So from debugfs, I called atomic_notifier_call_chain

Re: [RFC] drm/panic: Add drm panic locking

nic work by Jocelyn for context Signed-off-by: Daniel Vetter Cc: Jocelyn Falempe Cc: Andrew Morton Cc: "Peter Zijlstra (Intel)" Cc: Lukas Wunner Cc: Petr Mladek Cc: Steven Rostedt Cc: John Ogness Cc: Sergey Senozhatsky Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmerma

[RFC] How to test panic handlers, without crashing the kernel

Hi, While writing a panic handler for drm devices [1], I needed a way to test it without crashing the machine. So from debugfs, I called atomic_notifier_call_chain(_notifier_list, ...), but it has the side effect of calling all other panic notifiers registered. So Sima suggested to move

Re: [PATCH v8 5/8] drm/simpledrm: Add drm_panic support

On 29/02/2024 12:17, Daniel Vetter wrote: On Tue, Feb 27, 2024 at 11:04:16AM +0100, Jocelyn Falempe wrote: Add support for the drm_panic module, which displays a user-friendly message to the screen when a kernel panic occurs. v8: * Replace get_scanout_buffer() with drm_panic_set_buffer

Re: [PATCH v8 3/8] drm/panic: Add debugfs entry to test without triggering panic.

On 29/02/2024 12:21, Daniel Vetter wrote: On Tue, Feb 27, 2024 at 11:04:14AM +0100, Jocelyn Falempe wrote: Add a debugfs file, so you can test drm_panic without freezing your machine. This is unsafe, and should be enabled only for developer or tester. to display the drm_panic screen, just

[PATCH v8 4/8] drm/fb_dma: Add generic set_scanout_buffer() for drm_panic

This was initialy done for imx6, but should work on most drivers using drm_fb_dma_helper. v8: * Replace get_scanout_buffer() logic with drm_panic_set_buffer() (Thomas Zimmermann) Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_fb_dma_helper.c | 37

[PATCH v8 3/8] drm/panic: Add debugfs entry to test without triggering panic.

Add a debugfs file, so you can test drm_panic without freezing your machine. This is unsafe, and should be enabled only for developer or tester. to display the drm_panic screen, just run: echo 1 > /sys/kernel/debug/drm_panic/trigger Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/Kcon

[PATCH v8 8/8] drm/ast: Add drm_panic support

Add support for the drm_panic module, which displays a message to the screen when a kernel panic occurs. v7 * Use drm_for_each_primary_visible_plane() v8: * Replace get_scanout_buffer() logic with drm_panic_set_buffer() (Thomas Zimmermann) Signed-off-by: Jocelyn Falempe --- drivers/gpu

[PATCH v8 5/8] drm/simpledrm: Add drm_panic support

Add support for the drm_panic module, which displays a user-friendly message to the screen when a kernel panic occurs. v8: * Replace get_scanout_buffer() with drm_panic_set_buffer() (Thomas Zimmermann) Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/tiny/simpledrm.c | 17

[PATCH v8 7/8] drm/imx: Add drm_panic support

Add support for the drm_panic module, which displays a user-friendly message to the screen when a kernel panic occurs. v7: * use drm_panic_gem_get_scanout_buffer() helper v8: * Replace get_scanout_buffer() logic with drm_panic_set_buffer() Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm

[PATCH v8 6/8] drm/mgag200: Add drm_panic support

with drm_panic_set_buffer() (Thomas Zimmermann) Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/mgag200/mgag200_g200.c| 2 ++ drivers/gpu/drm/mgag200/mgag200_g200eh.c | 2 ++ drivers/gpu/drm/mgag200/mgag200_g200eh3.c | 2 ++ drivers/gpu/drm/mgag200/mgag200_g200er.c | 2 ++ drivers/gpu/drm/mgag200

[PATCH v8 2/8] drm/panic: Add a drm panic handler

-by: Jocelyn Falempe --- Documentation/gpu/drm-kms.rst| 12 + drivers/gpu/drm/Kconfig | 23 ++ drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_panic.c | 400 +++ drivers/gpu/drm/drm_plane.c | 3 + include

[PATCH v8 1/8] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill

by the kernel test bot Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_format_helper.c | 432 ++-- include/drm/drm_format_helper.h | 9 + 2 files changed, 360 insertions(+), 81 deletions(-) diff --git a/drivers/gpu/drm/drm_format_helper.c b/drivers/gpu/drm

[RFC][PATCH v8 0/8] drm/panic: Add a drm panic handler

eplace get_scanout_buffer() with set_scanout_buffer() to simplify the locking. (Thomas Zimmermann) * Add a debugfs entry, to trigger the drm_panic without a real panic (Sima) * Fix the drm_panic Documentation, and include it in drm-kms.rst Best regards, Jocelyn Falempe (8): drm/format-helpe

Re: [PATCH v2] drm/mgag200: Add a workaround for low-latency

On 08/02/2024 12:49, Thomas Zimmermann wrote: Am 08.02.24 um 10:51 schrieb Jocelyn Falempe: We found a regression in v5.10 on real-time server, using the rt-kernel and the mgag200 driver. It's some really specialized workload, with <10us latency expectation on isolated core. After the v5

[PATCH v2] drm/mgag200: Add a workaround for low-latency

r low-latency workload, so the new kconfig DRM_MGAG200_IOBURST_WORKAROUND depends on PREEMPT_RT and X86. For more context, the whole thread can be found here [1] Signed-off-by: Jocelyn Falempe Link: https://lore.kernel.org/dri-devel/20231019135655.313759-1-jfale...@redhat.com/ # 1 --- drive

Re: [PATCH] drm/mgag200: Add a workaround for low-latency

On 07/02/2024 10:47, Thomas Zimmermann wrote: Hi Am 06.02.24 um 23:21 schrieb Jocelyn Falempe: We found a regression in v5.10 on real-time server, using the rt-kernel and the mgag200 driver. It's some really specialized workload, with <10us latency expectation on isolated core. Af

[PATCH] drm/mgag200: Add a workaround for low-latency

r low-latency workload, so the new kconfig DRM_MGAG200_LATENCY_WORKAROUND depends on PREEMPT_RT and X86. For more context, the whole thread can be found here: https://lore.kernel.org/dri-devel/20231019135655.313759-1-jfale...@redhat.com/ Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/m

Re: [PATCH] drm/mgag200: Flush the cache to improve latency

On 06/02/2024 14:33, Daniel Vetter wrote: On Mon, Dec 11, 2023 at 10:31:28AM +0100, Jocelyn Falempe wrote: On 06/11/2023 11:46, Jocelyn Falempe wrote: On 23/10/2023 10:30, Jocelyn Falempe wrote: On 20/10/2023 14:06, Thomas Zimmermann wrote: (cc'ing lkml for feedback) Hi Jocelyn Am

Re: [PATCH 00/23] [RFC] drm/format-helper: Introduce drm_pixmap, font support and filling

Hi Thomas, Thanks for taking the time to write this series. I find the drm_pixmap is a nice improvement, and simplifies a bit the code. Regarding the font blit, I'm not convinced by this approach. I don't see the benefit of using the same function between fonts and framebuffer copy, as it's

Re: [PATCH v7 1/9] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill

Thomas Am 19.01.24 um 11:58 schrieb Thomas Zimmermann: Hi Am 17.01.24 um 17:40 schrieb Jocelyn Falempe: On 17/01/2024 16:06, Thomas Zimmermann wrote: Hi Am 04.01.24 um 17:00 schrieb Jocelyn Falempe: This is needed for drm_panic, to draw the font, and fill the background color, in multiple color

[PATCH 2/2] drm/vmwgfx: Keep a gem reference to user bos in surfaces

y McAllister Cc: Ian Forbes Signed-off-by: Zack Rusin Fixes: a950b989ea29 ("drm/vmwgfx: Do not drop the reference to the handle too soon") Cc: # v6.2+ Reviewed-by: Martin Krastev Link: https://patchwork.freedesktop.org/patch/msgid/20230928041355.737635-1-z...@kde.org Signed-off-by

[PATCH 1/2] drm/vmwgfx: Fix possible invalid drm gem put calls

e too soon") Cc: # v6.4+ Reviewed-by: Maaz Mombasawala Link: https://patchwork.freedesktop.org/patch/msgid/20230818041301.407636-1-z...@kde.org Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 6 ++ drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 8 drive

[PATCH 0/2] drm/vmwgfx backport two fixes to v6.1.x branch

Hi, I've backported this two commits: f9e96bf19054 drm/vmwgfx: Fix possible invalid drm gem put calls 91398b413d03 drm/vmwgfx: Keep a gem reference to user bos in surfaces They both fixes a950b989ea29 ("drm/vmwgfx: Do not drop the reference to the handle too soon") which has been backported to

Re: [PATCH v7 2/9] drm/panic: Add a drm panic handler

On 12/01/2024 14:50, Daniel Vetter wrote: On Thu, Jan 04, 2024 at 05:00:46PM +0100, Jocelyn Falempe wrote: +/** + * drm_panic_init() - Initialize drm-panic subsystem + * + * register the panic notifier + */ +void drm_panic_init(void) +{ + atomic_notifier_chain_register(_notifier_list

Re: [PATCH v7 2/9] drm/panic: Add a drm panic handler

On 17/01/2024 16:49, Thomas Zimmermann wrote: Hi Am 04.01.24 um 17:00 schrieb Jocelyn Falempe: [...] +    /** + * @get_scanout_buffer: + * + * Get the current scanout buffer, to display a panic message with drm_panic. + * The driver should do the minimum changes to provide

Re: [PATCH v7 1/9] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill

On 17/01/2024 16:26, Jani Nikula wrote: On Thu, 04 Jan 2024, Jocelyn Falempe wrote: This is needed for drm_panic, to draw the font, and fill the background color, in multiple color format. v5: * Change the drawing API, use drm_fb_blit_from_r1() to draw the font. * Also add drm_fb_fill

Re: [PATCH v7 1/9] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill

On 17/01/2024 16:06, Thomas Zimmermann wrote: Hi Am 04.01.24 um 17:00 schrieb Jocelyn Falempe: This is needed for drm_panic, to draw the font, and fill the background color, in multiple color format. TBH, I don't like this patch at all. It looks like you're reimplementing existing

Re: [PATCH v7 5/9] drm/fb_dma: Add generic get_scanout_buffer() for drm_panic

On 12/01/2024 14:41, Daniel Vetter wrote: On Thu, Jan 04, 2024 at 05:00:49PM +0100, Jocelyn Falempe wrote: This was initialy done for imx6, but should work on most drivers using drm_fb_dma_helper. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_fb_dma_helper.c | 55

Re: [PATCH v7 2/9] drm/panic: Add a drm panic handler

On 12/01/2024 14:31, Daniel Vetter wrote: On Thu, Jan 04, 2024 at 05:00:46PM +0100, Jocelyn Falempe wrote: This module displays a user friendly message when a kernel panic occurs. It currently doesn't contain any debug information, but that can be added later. v2 * Use get_scanout_buffer

Re: [RFC][PATCH v7 0/9] drm/panic: Add a drm panic handler

On 12/01/2024 15:00, Daniel Vetter wrote: On Thu, Jan 04, 2024 at 05:00:44PM +0100, Jocelyn Falempe wrote: This introduces a new drm panic handler, which displays a message when a panic occurs. So when fbcon is disabled, you can still see a kernel panic. This is one of the missing feature

Re: [PATCH v7 5/9] drm/fb_dma: Add generic get_scanout_buffer() for drm_panic

On 08/01/2024 11:20, Maxime Ripard wrote: Hi, On Thu, Jan 04, 2024 at 05:00:49PM +0100, Jocelyn Falempe wrote: This was initialy done for imx6, but should work on most drivers using drm_fb_dma_helper. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_fb_dma_helper.c | 55

Re: [PATCH v7 3/9] drm/plane: Add drm_for_each_primary_visible_plane macro

e) total: 1 errors, 0 warnings, 21 lines checked I think this requirement cannot work when you use list_for_each kind of macros. Do you have any suggestion ? Best regards, -- Jocelyn On 04/01/2024 17:00, Jocelyn Falempe wrote: To support drm_panic, most drivers need to find the current

Re: [PATCH] drm/mgag200: Fix caching setup for remapped video memory

a lot for taking some time to look at the latency issue. This looks good to me. Reviewed-by: Jocelyn Falempe -- Jocelyn

[PATCH v7 9/9] drm/imx: Add drm_panic support

Add support for the drm_panic module, which displays a user-friendly message to the screen when a kernel panic occurs. v7: * use drm_panic_gem_get_scanout_buffer() helper Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH v7 8/9] drm/ast: Add drm_panic support

Add support for the drm_panic module, which displays a message to the screen when a kernel panic occurs. v7 * Use drm_for_each_primary_visible_plane() Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.c | 26 -- 1 file changed, 24 insertions(+), 2

[PATCH v7 3/9] drm/plane: Add drm_for_each_primary_visible_plane macro

To support drm_panic, most drivers need to find the current primary visible plane with a framebuffer attached. Signed-off-by: Jocelyn Falempe --- include/drm/drm_plane.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index

[PATCH v7 7/9] drm/mgag200: Add drm_panic support

Add support for the drm_panic module, which displays a message to the screen when a kernel panic occurs. v5: * Also check that the plane is visible and primary. (Thomas Zimmermann) v7: * use drm_for_each_primary_visible_plane() Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/mgag200

[PATCH v7 6/9] drm/simpledrm: Add drm_panic support

Add support for the drm_panic module, which displays a user-friendly message to the screen when a kernel panic occurs. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/tiny/simpledrm.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/tiny/simpledrm.c b

[PATCH v7 1/9] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill

by the kernel test bot Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_format_helper.c | 432 ++-- include/drm/drm_format_helper.h | 9 + 2 files changed, 360 insertions(+), 81 deletions(-) diff --git a/drivers/gpu/drm/drm_format_helper.c b/drivers/gpu/drm

[PATCH v7 4/9] drm/panic: Add drm_panic_is_format_supported()

So driver knows early if drm_panic will be able to display something on the current scanout buffer. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_panic.c | 13 + include/drm/drm_panic.h | 4 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm

[PATCH v7 5/9] drm/fb_dma: Add generic get_scanout_buffer() for drm_panic

This was initialy done for imx6, but should work on most drivers using drm_fb_dma_helper. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_fb_dma_helper.c | 55 + include/drm/drm_fb_dma_helper.h | 4 +++ 2 files changed, 59 insertions(+) diff --git

[PATCH v7 2/9] drm/panic: Add a drm panic handler

*private field, so drivers can pass private data to draw_pixel_xy() and flush(). v6 * Fix sparse warning for panic_msg and logo. v7 * Add select DRM_KMS_HELPER for the color conversion functions. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/Kconfig | 23 +++ drivers/gpu/drm/Makefile

[RFC][PATCH v7 0/9] drm/panic: Add a drm panic handler

ric implementation for drivers that uses drm_fb_dma. (Maxime Ripard) * Add back the IMX/IPUV3 support, and use the generic implementation. (Maxime Ripard) Best regards, Jocelyn Falempe (9): drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill drm/panic: Add a drm panic handler drm/pl

Re: [PATCH v3 4/4] drm/ssd130x: Add support for the SSD133x OLED controller family

a new fourcc needs to be added to support this format. small typo here, R:G:B 6:5:6 => that's 17 bits other than that, it looks good to me, feel free to add: Reviewed-by: Jocelyn Falempe Signed-off-by: Javier Martinez Canillas --- (no changes since v1) drivers/gpu/drm/solomon/ssd130x-i2

Re: [PATCH] drm/mgag200: Fix gamma lut not initialized for G200ER, G200EV, G200SE

I just merged it to drm-misc-fixes: https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-fixes=11f9eb899ecc8c02b769cf8d2532ba12786a7af7 Thanks, -- Jocelyn

Re: [PATCH] drm/mgag200: Fix gamma lut not initialized for G200ER, G200EV, G200SE

On 18/12/2023 12:31, Thomas Zimmermann wrote: Hi Am 14.12.23 um 17:38 schrieb Jocelyn Falempe: When mgag200 switched from simple KMS to regular atomic helpers, the initialization of the gamma settings was lost. This leads to a black screen, if the bios/uefi doesn't use the same pixel color

[PATCH] drm/mgag200: Fix gamma lut not initialized for G200ER, G200EV, G200SE

lized.") for most G200, but G200ER, G200EV, G200SE use their own version of crtc_helper_atomic_enable() and need to be fixed too. Fixes: 1baf9127c482 ("drm/mgag200: Replace simple-KMS with regular atomic helpers") Cc: #v6.1+ Reported-by: Roger Sewell Suggested-by: Roger Sewell Si

Re: [PATCH v5 6/6] drm/imx: Add drm_panic support

On 14/12/2023 14:48, Maxime Ripard wrote: Hi, On Fri, Nov 03, 2023 at 03:53:30PM +0100, Jocelyn Falempe wrote: Proof of concept to add drm_panic support on an arm based GPU. I've tested it with X11/llvmpipe, because I wasn't able to have 3d rendering with etnaviv on my imx6 board. Signed

Re: [PATCH] drm/mgag200: Flush the cache to improve latency

On 06/11/2023 11:46, Jocelyn Falempe wrote: On 23/10/2023 10:30, Jocelyn Falempe wrote: On 20/10/2023 14:06, Thomas Zimmermann wrote: (cc'ing lkml for feedback) Hi Jocelyn Am 19.10.23 um 15:55 schrieb Jocelyn Falempe: We found a regression in v5.10 on real-time server, using the rt-kernel

[PATCH v6 3/5] drm/simpledrm: Add drm_panic support

Add support for the drm_panic module, which displays a user-friendly message to the screen when a kernel panic occurs. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/tiny/simpledrm.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/tiny/simpledrm.c b

[PATCH v6 4/5] drm/mgag200: Add drm_panic support

Add support for the drm_panic module, which displays a message to the screen when a kernel panic occurs. v5: * Also check that the plane is visible and primary. (Thomas Zimmermann) Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/mgag200/mgag200_drv.c | 25 + 1 file

[PATCH v6 5/5] drm/ast: Add drm_panic support

Add support for the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ast

[PATCH v6 2/5] drm/panic: Add a drm panic handler

*private field, so drivers can pass private data to draw_pixel_xy() and flush(). v6 * Fix sparse warning for panic_msg and logo Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/Kconfig | 22 +++ drivers/gpu/drm/Makefile| 1 + drivers/gpu/drm/drm_drv.c | 8 + drivers/gpu/drm

[PATCH v6 1/5] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill

by the kernel test bot Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_format_helper.c | 431 ++-- include/drm/drm_format_helper.h | 9 + 2 files changed, 359 insertions(+), 81 deletions(-) diff --git a/drivers/gpu/drm/drm_format_helper.c b/drivers/gpu/drm

[RFC][PATCH v6 0/5] drm/panic: Add a drm panic handler

ard. But it shows that it can still work on ARM with DMA buffer in this case. Best regards, Jocelyn Falempe (5): drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill drm/panic: Add a drm panic handler drm/simpledrm: Add drm_panic support drm/mgag200: Add drm_panic support drm/ast:

Re: [PATCH] drm/ast: Disconnect BMC if physical connector is connected

connector has a display attached. This way compositors will only see one connected connector at a time; either the physical one or the BMC. Thanks for the patch. I can't test it because I don't have physical access to a machine with aspeed GPU, but it looks good to me. Reviewed-by: Jocelyn Falempe

Re: Incomplete stable drm/ast backport - screen freeze on boot

On 13/11/2023 17:37, Sasha Levin wrote: On Mon, Nov 13, 2023 at 10:49:01AM +0100, Thomas Zimmermann wrote: (cc: gregkh) Hi Jocelyn Am 13.11.23 um 10:36 schrieb Jocelyn Falempe: On 13/11/2023 09:34, Keno Fischer wrote: Greetings, When connected to a remote machine via the BMC KVM

Re: [PATCH 00/10] drm/ast: Detect device type before init

, and will allow further refactoring later. For the whole series: Reviewed-by: Jocelyn Falempe -- Jocelyn

Re: [PATCH 09/10] drm/ast: Detect ast device type and config mode without ast device

On 13/11/2023 09:50, Thomas Zimmermann wrote: Return the ast chip and config in the detection function's parameters instead of storing them directly in the ast device instance. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_main.c | 104 ++--- 1

Re: Incomplete stable drm/ast backport - screen freeze on boot

On 13/11/2023 09:34, Keno Fischer wrote: Greetings, When connected to a remote machine via the BMC KVM functionality, I am experiencing screen freezes on boot when using 6.5 stable, but not master. The BMC on the machine in question is an ASpeed AST2600. A quick bisect shows the problematic

Re: BUG in drm_kms_helper_poll_enable() fixed by reverting "drm/ast: report connection status on Display Port."

in this crash. Can you test with the attached patch ? I want to see if the detect callback is called, and also make sure the delayed_work struct is properly initialized. Thanks, Kim Best regards, -- Jocelyn From 0a9f2d81af1087ab3648206dfce160639385a6b6 Mon Sep 17 00:00:00 2001 From: Jocelyn Fal

Re: [PATCH] drm/mgag200: Flush the cache to improve latency

On 23/10/2023 10:30, Jocelyn Falempe wrote: On 20/10/2023 14:06, Thomas Zimmermann wrote: (cc'ing lkml for feedback) Hi Jocelyn Am 19.10.23 um 15:55 schrieb Jocelyn Falempe: We found a regression in v5.10 on real-time server, using the rt-kernel and the mgag200 driver. It's some really

Re: [PATCH] drm/ast: use managed devres functions

On 30/10/2023 10:50, Philipp Stanner wrote: Currently, tha ast-driver just maps the PCI-dev's regions with pcim_iomap(). It does not actually reserve the regions exclusively with, e.g., pci_request_regions(). Replace the calls to pcim_iomap() with ones to pcim_iomap_regions() to reserve and map

[PATCH v5 5/6] drm/ast: Add drm_panic support

Add support for the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.c | 4 ++-- drivers/gpu/drm/ast/ast_drv.h | 3 +++ drivers/gpu/drm/ast/ast_mode.c | 26 ++ 3 files

[PATCH v5 6/6] drm/imx: Add drm_panic support

Proof of concept to add drm_panic support on an arm based GPU. I've tested it with X11/llvmpipe, because I wasn't able to have 3d rendering with etnaviv on my imx6 board. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 30 1 file changed

[PATCH v5 4/6] drm/mgag200: Add drm_panic support

Add support for the drm_panic module, which displays a message to the screen when a kernel panic occurs. v5: * Also check that the plane is visible and primary. (Thomas Zimmermann) Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/mgag200/mgag200_drv.c | 25 + 1 file

[PATCH v5 1/6] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill

This is needed for drm_panic, to draw the font, and fill the background color, in multiple color format. v5: * Change the drawing API, use drm_fb_blit_from_r1() to draw the font. * Also add drm_fb_fill() to fill area with background color. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm

[PATCH v5 2/6] drm/panic: Add a drm panic handler

*private field, so drivers can pass private data to draw_pixel_xy() and flush(). Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/Kconfig | 22 +++ drivers/gpu/drm/Makefile| 1 + drivers/gpu/drm/drm_drv.c | 8 + drivers/gpu/drm/drm_panic.c | 368

[PATCH v5 3/6] drm/simpledrm: Add drm_panic support

Add support for the drm_panic module, which displays a user-friendly message to the screen when a kernel panic occurs. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/tiny/simpledrm.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/tiny/simpledrm.c b

<    1   2   3   4   5   >