Re: [PATCH v2] drm/panthor: Simplify mmu_hw_do_operation_locked

2025-08-15 Thread Karunika Choo
On 15/08/2025 15:10, Steven Price wrote: > On 15/08/2025 15:01, Karunika Choo wrote: >> On 15/08/2025 14:42, Steven Price wrote: >>> The only callers to mmu_hw_do_operation_locked() pass an 'op' of either >>> AS_COMAND_FLUSH_MEM or AS_COMMAND_FLUSH_PT. This me

Re: [PATCH v2] drm/panthor: Simplify mmu_hw_do_operation_locked

2025-08-15 Thread Karunika Choo
On 15/08/2025 14:42, Steven Price wrote: > The only callers to mmu_hw_do_operation_locked() pass an 'op' of either > AS_COMAND_FLUSH_MEM or AS_COMMAND_FLUSH_PT. This means the code paths > after that are dead. Removing those paths means the > mmu_hw_do_flush_on_gpu_ctrl() function might has well be

[PATCH v9 6/7] drm/panthor: Make MMU cache maintenance use FLUSH_CACHES command

2025-08-07 Thread Karunika Choo
FLUSH_CACHES command and will also use this by default going forward. Reviewed-by: Steven Price Reviewed-by: Chia-I Wu Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_mmu.c | 33 +++ 1 file changed, 33 insertions(+) diff --git a

[PATCH v9 7/7] drm/panthor: Add support for Mali-Gx20 and Mali-Gx25 GPUs

2025-08-07 Thread Karunika Choo
This patch adds firmware binary and GPU model naming support for Mali-Gx20 and Mali-Gx25 GPUs. Reviewed-by: Steven Price Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ drivers/gpu/drm/panthor/panthor_hw.c | 18 ++ 2

[PATCH v9 4/7] drm/panthor: Add support for Mali-Gx15 family of GPUs

2025-08-07 Thread Karunika Choo
nce of Ray Intersection feature support. This patch adds: - support for correctly identifying the model names for Mali-Gx15 GPUs. - arch 11.8 FW binary support Reviewed-by: Steven Price Reviewed-by: Chia-I Wu Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/pa

[PATCH v9 5/7] drm/panthor: Serialize GPU cache flush operations

2025-08-07 Thread Karunika Choo
Co-developed-by: Dennis Tsiang Signed-off-by: Dennis Tsiang Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_gpu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/panthor/panthor_gpu.c b/drivers/gpu/drm/panthor/panthor_gpu.c index 5e2c3173ae27

[PATCH v9 2/7] drm/panthor: Simplify getting the GPU model name

2025-08-07 Thread Karunika Choo
ed GPU features. Reviewed-by: Steven Price Reviewed-by: Chia-I Wu Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.c | 61 1 file changed, 17 insertions(+), 44 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/d

[PATCH v9 3/7] drm/panthor: Add support for Mali-G710, Mali-G510 and Mali-G310

2025-08-07 Thread Karunika Choo
This patch adds GPU model name and FW binary support for Mali-G710, Mali-G510, and Mali-G310. Reviewed-by: Steven Price Reviewed-by: Chia-I Wu Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ drivers/gpu/drm/panthor/panthor_hw.c | 6

[PATCH v9 1/7] drm/panthor: Add panthor_hw and move gpu_info initialization into it

2025-08-07 Thread Karunika Choo
version guards if the change is minor. For more complex changes, the function can be forked and the appropriate function will need to be called based on the GPU architecture version. Reviewed-by: Steven Price Reviewed-by: Chia-I Wu Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo

[PATCH v9 0/7] Add support for new Mali GPUs

2025-08-07 Thread Karunika Choo
com/ Karunika Choo (7): drm/panthor: Add panthor_hw and move gpu_info initialization into it drm/panthor: Simplify getting the GPU model name drm/panthor: Add support for Mali-G710, Mali-G510 and Mali-G310 drm/panthor: Add support for Mali-Gx15 family of GPUs drm/panthor: Serialize GPU ca

[PATCH v2] drm/panthor: Serialize GPU cache flush operations

2025-07-31 Thread Karunika Choo
Co-developed-by: Dennis Tsiang Signed-off-by: Dennis Tsiang Signed-off-by: Karunika Choo --- v2: - Added missing 'Signed-off-by' for Dennis. - Picked up R-b from Liviu. - Link to v1: https://lore.kernel.org/all/20250730174338.1650212-1-karunika.c...@arm.com/ drivers/gpu/d

Re: [PATCH v1] drm/panthor: Serialize GPU cache flush operations

2025-07-31 Thread Karunika Choo
On 31/07/2025 11:57, Steven Price wrote: > On 30/07/2025 18:43, Karunika Choo wrote: >> In certain scenarios, it is possible for multiple cache flushes to be >> requested before the previous one completes. This patch introduces the >> cache_flush_lock mutex to serialize these

[PATCH v1] drm/panthor: Serialize GPU cache flush operations

2025-07-30 Thread Karunika Choo
In certain scenarios, it is possible for multiple cache flushes to be requested before the previous one completes. This patch introduces the cache_flush_lock mutex to serialize these operations and ensure that any requested cache flushes are completed instead of dropped. Signed-off-by: Karunika

[PATCH v8 6/6] drm/panthor: Add support for Mali-Gx20 and Mali-Gx25 GPUs

2025-07-24 Thread Karunika Choo
This patch adds firmware binary and GPU model naming support for Mali-Gx20 and Mali-Gx25 GPUs. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ drivers/gpu/drm/panthor/panthor_hw.c | 18 ++ 2 files changed, 20 insertions(+) diff --git a/drivers/gpu

[PATCH v8 5/6] drm/panthor: Make MMU cache maintenance use FLUSH_CACHES command

2025-07-24 Thread Karunika Choo
FLUSH_CACHES command and will also use this by default going forward. Reviewed-by: Steven Price Reviewed-by: Chia-I Wu Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_mmu.c | 33 +++ 1 file changed, 33 insertions(+) diff --git a

[PATCH v8 4/6] drm/panthor: Add support for Mali-Gx15 family of GPUs

2025-07-24 Thread Karunika Choo
nce of Ray Intersection feature support. This patch adds: - support for correctly identifying the model names for Mali-Gx15 GPUs. - arch 11.8 FW binary support Reviewed-by: Steven Price Reviewed-by: Chia-I Wu Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/pa

[PATCH v8 3/6] drm/panthor: Add support for Mali-G710, Mali-G510 and Mali-G310

2025-07-24 Thread Karunika Choo
This patch adds GPU model name and FW binary support for Mali-G710, Mali-G510, and Mali-G310. Reviewed-by: Steven Price Reviewed-by: Chia-I Wu Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ drivers/gpu/drm/panthor/panthor_hw.c | 6

[PATCH v8 1/6] drm/panthor: Add panthor_hw and move gpu_info initialization into it

2025-07-24 Thread Karunika Choo
version guards if the change is minor. For more complex changes, the function can be forked and the appropriate function will need to be called based on the GPU architecture version. Reviewed-by: Steven Price Reviewed-by: Chia-I Wu Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo

[PATCH v8 2/6] drm/panthor: Simplify getting the GPU model name

2025-07-24 Thread Karunika Choo
ed GPU features. Reviewed-by: Steven Price Reviewed-by: Chia-I Wu Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.c | 61 1 file changed, 17 insertions(+), 44 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/d

[PATCH v8 0/6] Add support for new Mali GPUs

2025-07-24 Thread Karunika Choo
ent implementation as much as possible. - Added support for G710, G715, G720, and G725 series of Mali GPUs. - Link to v1: https://lore.kernel.org/all/20241219170521.64879-1-karunika.c...@arm.com/ Karunika Choo (6): drm/panthor: Add panthor_hw and move gpu_info initialization into it drm/panthor: Simpl

[PATCH v7 4/6] drm/panthor: Add support for Mali-Gx15 family of GPUs

2025-07-24 Thread Karunika Choo
nce of Ray Intersection feature support. This patch adds: - support for correctly identifying the model names for Mali-Gx15 GPUs. - arch 11.8 FW binary support Reviewed-by: Chia-I Wu Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 1 + drive

[PATCH v7 6/6] drm/panthor: Add support for Mali-Gx20 and Mali-Gx25 GPUs

2025-07-24 Thread Karunika Choo
GPU_COHERENCY_PROTOCOL if coherency is enabled. Reviewed-by: Chia-I Wu Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_device.c | 3 +-- drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ drivers/gpu/drm/panthor/panthor_gpu.c| 14 -- drivers/gpu/drm

[PATCH v7 5/6] drm/panthor: Make MMU cache maintenance use FLUSH_CACHES command

2025-07-24 Thread Karunika Choo
FLUSH_CACHES command and will also use this by default going forward. Reviewed-by: Chia-I Wu Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_mmu.c | 33 +++ 1 file changed, 33 insertions(+) diff --git a/drivers/gpu/drm/panthor

[PATCH v7 2/6] drm/panthor: Simplify getting the GPU model name

2025-07-24 Thread Karunika Choo
ed GPU features. Reviewed-by: Chia-I Wu Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.c | 61 1 file changed, 17 insertions(+), 44 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/gpu/drm/p

[PATCH v7 3/6] drm/panthor: Add support for Mali-G710, Mali-G510 and Mali-G310

2025-07-24 Thread Karunika Choo
This patch adds GPU model name and FW binary support for Mali-G710, Mali-G510, and Mali-G310. Reviewed-by: Chia-I Wu Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ drivers/gpu/drm/panthor/panthor_hw.c | 6 ++ 2 files changed, 8

[PATCH v7 1/6] drm/panthor: Add panthor_hw and move gpu_info initialization into it

2025-07-24 Thread Karunika Choo
version guards if the change is minor. For more complex changes, the function can be forked and the appropriate function will need to be called based on the GPU architecture version. Reviewed-by: Chia-I Wu Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor

[PATCH v7 0/6] Add support for new Mali GPUs

2025-07-24 Thread Karunika Choo
ink to v1: https://lore.kernel.org/all/20241219170521.64879-1-karunika.c...@arm.com/ Karunika Choo (6): drm/panthor: Add panthor_hw and move gpu_info initialization into it drm/panthor: Simplify getting the GPU model name drm/panthor: Add support for Mali-G710, Mali-G510 and Mali-G310

Re: [PATCH v6 4/6] drm/panthor: Add support for Mali-Gx15 family of GPUs

2025-07-24 Thread Karunika Choo
On 24/07/2025 06:40, Chia-I Wu wrote: > On Mon, Jul 21, 2025 at 3:13 PM Karunika Choo wrote: >> >> Mali-Gx15 introduces a new GPU_FEATURES register that provides >> information about GPU-wide supported features. The register value will >> be passed on to userspace via g

[PATCH v6 6/6] drm/panthor: Add support for Mali-Gx20 and Mali-Gx25 GPUs

2025-07-21 Thread Karunika Choo
GPU_COHERENCY_PROTOCOL if coherency is enabled. Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_device.c | 2 +- drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ drivers/gpu/drm/panthor/panthor_gpu.c| 14 -- drivers/gpu/drm/panthor/panthor_hw.c

[PATCH v6 3/6] drm/panthor: Add support for Mali-G710, Mali-G510 and Mali-G310

2025-07-21 Thread Karunika Choo
This patch adds GPU model name and FW binary support for Mali-G710, Mali-G510, and Mali-G310. Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ drivers/gpu/drm/panthor/panthor_hw.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a

[PATCH v6 2/6] drm/panthor: Simplify getting the GPU model name

2025-07-21 Thread Karunika Choo
ed GPU features. Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.c | 61 1 file changed, 17 insertions(+), 44 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/gpu/drm/panthor/panthor_hw.c index 3f7175

[PATCH v6 5/6] drm/panthor: Make MMU cache maintenance use FLUSH_CACHES command

2025-07-21 Thread Karunika Choo
FLUSH_CACHES command and will also use this by default going forward. Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_mmu.c | 33 +++ 1 file changed, 33 insertions(+) diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu

[PATCH v6 0/6] Add support for new Mali GPUs

2025-07-21 Thread Karunika Choo
support for G710, G715, G720, and G725 series of Mali GPUs. - Link to v1: https://lore.kernel.org/all/20241219170521.64879-1-karunika.c...@arm.com/ Karunika Choo (6): drm/panthor: Add panthor_hw and move gpu_info initialization into it drm/panthor: Simplify getting the GPU model name drm/panthor

[PATCH v6 1/6] drm/panthor: Add panthor_hw and move gpu_info initialization into it

2025-07-21 Thread Karunika Choo
version guards if the change is minor. For more complex changes, the function can be forked and the appropriate function will need to be called based on the GPU architecture version. Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/Makefile | 1

[PATCH v6 4/6] drm/panthor: Add support for Mali-Gx15 family of GPUs

2025-07-21 Thread Karunika Choo
nce of Ray Intersection feature support. This patch adds: - support for correctly identifying the model names for Mali-Gx15 GPUs. - arch 11.8 FW binary support Reviewed-by: Liviu Dudau Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 1 + drivers/gpu/drm/panthor/panthor_h

Re: [PATCH v4 7/7] drm/panthor: Add support for Mali-Gx20 and Mali-Gx25 GPUs

2025-07-21 Thread Karunika Choo
On 11/06/2025 00:45, Chia-I Wu wrote: > On Mon, Jun 2, 2025 at 7:34 AM Karunika Choo wrote: >> >> Mali-Gx20 and Mali-Gx25 deprecates the use of FLUSH_MEM and FLUSH_PT >> MMU_AS commands in favour of cache maintenance via >> GPU_COMMAND's FLUSH_CACHES and FLUSH_PA_

Re: [PATCH v4 6/7] drm/panthor: Support GPU_CONTROL cache flush based on feature bit

2025-07-21 Thread Karunika Choo
On 23/06/2025 11:23, Steven Price wrote: > On 02/06/2025 15:32, Karunika Choo wrote: >> As the FLUSH_MEM and FLUSH_PT commands are deprecated in GPUs from >> Mali-Gx20 onwards, this patch adds support for performing cache >> maintenance via the FLUSH_CACHES command in GPU

Re: [PATCH v4 6/7] drm/panthor: Support GPU_CONTROL cache flush based on feature bit

2025-07-21 Thread Karunika Choo
On 11/06/2025 00:42, Chia-I Wu wrote: > On Mon, Jun 2, 2025 at 7:42 AM Karunika Choo wrote: >> >> As the FLUSH_MEM and FLUSH_PT commands are deprecated in GPUs from >> Mali-Gx20 onwards, this patch adds support for performing cache >> maintenance via the FLUSH_CACHES

Re: [PATCH v4 3/7] drm/panthor: Simplify getting the GPU model name

2025-07-21 Thread Karunika Choo
On 11/06/2025 00:32, Chia-I Wu wrote: > On Mon, Jun 2, 2025 at 8:16 AM Karunika Choo wrote: >> >> This patch replaces the panthor_model structure with a simple switch >> case based on the product_id which is in the format of: >> ((arch_major << 24) | pro

Re: [PATCH v4 1/7] drm/panthor: Add GPU specific initialization framework

2025-07-21 Thread Karunika Choo
On 11/06/2025 00:12, Chia-I Wu wrote: > On Mon, Jun 2, 2025 at 7:33 AM Karunika Choo wrote: >> >> This patch provides an initialization framework for multiple Mali GPUs >> by introducing a GPU support look-up table. Each entry contains, at >> minimum, the architectu

[PATCH v5 4/6] drm/panthor: Add support for Mali-Gx15 family of GPUs

2025-07-21 Thread Karunika Choo
Us. - arch 11.8 FW binary support Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 1 + drivers/gpu/drm/panthor/panthor_hw.c | 15 +++ drivers/gpu/drm/panthor/panthor_regs.h | 11 +++ include/uapi/drm/panthor_drm.h | 3 +++ 4 files c

[PATCH v5 1/6] drm/panthor: Add panthor_hw and move gpu_info initialization into it

2025-07-21 Thread Karunika Choo
version guards if the change is minor. For more complex changes, the function can be forked and the appropriate function will need to be called based on the GPU architecture version. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/Makefile | 1 + drivers/gpu/drm/panthor

[PATCH v5 5/6] drm/panthor: Make MMU cache maintenance use FLUSH_CACHES command

2025-07-21 Thread Karunika Choo
FLUSH_CACHES command and will also use this by default going forward. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_mmu.c | 33 +++ 1 file changed, 33 insertions(+) diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c

[PATCH v5 3/6] drm/panthor: Add support for Mali-G710, Mali-G510 and Mali-G310

2025-07-21 Thread Karunika Choo
This patch adds GPU model name and FW binary support for Mali-G710, Mali-G510, and Mali-G310. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ drivers/gpu/drm/panthor/panthor_hw.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/panthor

[PATCH v5 6/6] drm/panthor: Add support for Mali-Gx20 and Mali-Gx25 GPUs

2025-07-21 Thread Karunika Choo
supported. This patch also fixes a minor bug that incorrectly writes ACE instead of ACE_LITE to GPU_COHERENCY_PROTOCOL if coherency is enabled. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_device.c | 2 +- drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ drivers/gpu/drm/panthor

[PATCH v5 0/6] Add support for new Mali GPUs

2025-07-21 Thread Karunika Choo
unnecessary pre-parsing of register fields from v1. Retaining current implementation as much as possible. - Added support for G710, G715, G720, and G725 series of Mali GPUs. - Link to v1: https://lore.kernel.org/all/20241219170521.64879-1-karunika.c...@arm.com/ Karunika Choo (6): drm/panthor

[PATCH v5 2/6] drm/panthor: Simplify getting the GPU model name

2025-07-21 Thread Karunika Choo
ed GPU features. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.c | 61 1 file changed, 17 insertions(+), 44 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/gpu/drm/panthor/panthor_hw.c index 3f7175cb0ab4..f39010c0ca86 100644

[PATCH 6/6] drm/panthor: Add support for Mali-Gx20 and Mali-Gx25 GPUs

2025-07-21 Thread Karunika Choo
supported. This patch also fixes a minor bug that incorrectly writes ACE instead of ACE_LITE to GPU_COHERENCY_PROTOCOL if coherency is enabled. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_device.c | 2 +- drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ drivers/gpu/drm/panthor

[PATCH 5/6] drm/panthor: Make MMU cache maintenance use FLUSH_CACHES command

2025-07-21 Thread Karunika Choo
FLUSH_CACHES command and will also use this by default going forward. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_mmu.c | 33 +++ 1 file changed, 33 insertions(+) diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c

[PATCH 3/6] drm/panthor: Add support for Mali-G710, Mali-G510 and Mali-G310

2025-07-21 Thread Karunika Choo
This patch adds GPU model name and FW binary support for Mali-G710, Mali-G510, and Mali-G310. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ drivers/gpu/drm/panthor/panthor_hw.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/panthor

[PATCH 4/6] drm/panthor: Add support for Mali-Gx15 family of GPUs

2025-07-21 Thread Karunika Choo
Us. - arch 11.8 FW binary support Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 1 + drivers/gpu/drm/panthor/panthor_hw.c | 15 +++ drivers/gpu/drm/panthor/panthor_regs.h | 11 +++ include/uapi/drm/panthor_drm.h | 3 +++ 4 files c

[PATCH 2/6] drm/panthor: Simplify getting the GPU model name

2025-07-21 Thread Karunika Choo
ed GPU features. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.c | 61 1 file changed, 17 insertions(+), 44 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/gpu/drm/panthor/panthor_hw.c index 3f7175cb0ab4..f39010c0ca86 100644

[PATCH 1/6] drm/panthor: Add panthor_hw and move gpu_info initialization into it

2025-07-21 Thread Karunika Choo
version guards if the change is minor. For more complex changes, the function can be forked and the appropriate function will need to be called based on the GPU architecture version. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/Makefile | 1 + drivers/gpu/drm/panthor

[PATCH 0/6] Add support for new Mali GPUs

2025-07-21 Thread Karunika Choo
unnecessary pre-parsing of register fields from v1. Retaining current implementation as much as possible. - Added support for G710, G715, G720, and G725 series of Mali GPUs. - Link to v1: https://lore.kernel.org/all/20241219170521.64879-1-karunika.c...@arm.com/ Karunika Choo (6): drm/panthor

[PATCH v4 1/7] drm/panthor: Add GPU specific initialization framework

2025-06-02 Thread Karunika Choo
This patch provides an initialization framework for multiple Mali GPUs by introducing a GPU support look-up table. Each entry contains, at minimum, the architecture major version of the GPU, and may optionally provide feature flags and register offset overrides. Signed-off-by: Karunika Choo

[PATCH v4 4/7] drm/panthor: Add support for Mali-G710, Mali-G510 and Mali-G310

2025-06-02 Thread Karunika Choo
This patch adds GPU model name and FW binary support for Mali-G710, Mali-G510, and Mali-G310. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ drivers/gpu/drm/panthor/panthor_hw.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/panthor

[PATCH v4 7/7] drm/panthor: Add support for Mali-Gx20 and Mali-Gx25 GPUs

2025-06-02 Thread Karunika Choo
patch enables FLUSH_CACHES for both families of GPUs via the PANTHOR_HW_FEATURE_GPU_CTRL_CACHE_FLUSH bit until FLUSH_PA_RANGE support is added. It also adds the aforementioned register definitions and firmware binary support for arch 12.8 and 13.8. Signed-off-by: Karunika Choo --- drivers/gp

[PATCH v3 7/7] drm/panthor: Add support for Mali-G720 and Mali-G725 GPUs

2025-06-02 Thread Karunika Choo
patch enables FLUSH_CACHES for both families of GPUs via the PANTHOR_HW_FEATURE_GPU_CTRL_CACHE_FLUSH bit until FLUSH_PA_RANGE support is added. It also adds the aforementioned register definitions and firmware binary support for arch 12.8 and 13.8. Signed-off-by: Karunika Choo --- drivers/gp

[PATCH v4 2/7] drm/panthor: Move GPU info initialization into panthor_hw.c

2025-06-02 Thread Karunika Choo
necessary register reads behind GPU architecture version guards if the change is minor. For more complex changes, the function can be forked and we can leverage the panthor_hw_ops structure to provide architecture specific initialization routines. Signed-off-by: Karunika Choo --- drivers/gpu/drm

[PATCH v4 6/7] drm/panthor: Support GPU_CONTROL cache flush based on feature bit

2025-06-02 Thread Karunika Choo
also enables cache maintenance via GPU_CONTROL for Mali-Gx10 and Mali-Gx15 GPUs for consistency. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.c | 6 + drivers/gpu/drm/panthor/panthor_hw.h | 6 + drivers/gpu/drm/panthor/panthor_mmu.c | 35

[PATCH v4 5/7] drm/panthor: Add support for Mali-Gx15 family of GPUs

2025-06-02 Thread Karunika Choo
Us. - arch 11.8 FW binary support Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 1 + drivers/gpu/drm/panthor/panthor_hw.c | 18 ++ drivers/gpu/drm/panthor/panthor_regs.h | 11 +++ include/uapi/drm/panthor_drm.h | 3 +++ 4 files c

[PATCH v3 4/7] drm/panthor: Add support for Mali-G710, Mali-G510 and Mali-G310

2025-06-02 Thread Karunika Choo
This patch adds GPU model name and FW binary support for Mali-G710, Mali-G510, and Mali-G310. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ drivers/gpu/drm/panthor/panthor_hw.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/panthor

[PATCH v4 0/7] Add GPU specific initialization framework to support new Mali GPUs

2025-06-02 Thread Karunika Choo
current implementation as much as possible. - Added support for G710, G715, G720, and G725 series of Mali GPUs. - Link to v1: https://lore.kernel.org/all/20241219170521.64879-1-karunika.c...@arm.com/ Thanks, Karunika Choo Karunika Choo (7): drm/panthor: Add GPU specific initialization

[PATCH v4 3/7] drm/panthor: Simplify getting the GPU model name

2025-06-02 Thread Karunika Choo
ed GPU features. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.c | 63 +++--- drivers/gpu/drm/panthor/panthor_regs.h | 2 + 2 files changed, 19 insertions(+), 46 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/gpu/drm/panthor/pantho

[PATCH v3 0/7] Add GPU specific initialization framework to support new Mali GPUs

2025-06-02 Thread Karunika Choo
G725 series of Mali GPUs. - Link to v1: https://lore.kernel.org/all/20241219170521.64879-1-karunika.c...@arm.com/ Thanks, Karunika Choo Karunika Choo (7): drm/panthor: Add GPU specific initialization framework drm/panthor: Move GPU info initialization into panthor_hw.c drm/panthor: Make

[PATCH v3 3/7] drm/panthor: Make getting GPU model name simple and extensible

2025-06-02 Thread Karunika Choo
ed GPU features. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.c | 63 +++--- drivers/gpu/drm/panthor/panthor_regs.h | 2 + 2 files changed, 19 insertions(+), 46 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/gpu/drm/panthor/pantho

[PATCH v3 5/7] drm/panthor: Add support for Mali-Gx15 family of GPUs

2025-06-02 Thread Karunika Choo
Us. - arch 11.8 FW binary support Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 1 + drivers/gpu/drm/panthor/panthor_hw.c | 18 ++ drivers/gpu/drm/panthor/panthor_regs.h | 11 +++ include/uapi/drm/panthor_drm.h | 3 +++ 4 files c

[PATCH v3 6/7] drm/panthor: Support GPU_CONTROL cache flush based on feature bit

2025-06-02 Thread Karunika Choo
also enables cache maintenance via GPU_CONTROL for Mali-Gx10 and Mali-Gx15 GPUs for consistency. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.c | 6 + drivers/gpu/drm/panthor/panthor_hw.h | 6 + drivers/gpu/drm/panthor/panthor_mmu.c | 35

[PATCH v3 2/7] drm/panthor: Move GPU info initialization into panthor_hw.c

2025-06-02 Thread Karunika Choo
necessary register reads behind GPU architecture version guards if the change is minor. For more complex changes, the function can be forked and we can leverage the panthor_hw_ops structure to provide architecture specific initialization routines. Signed-off-by: Karunika Choo --- drivers/gpu/drm

[PATCH v3 1/7] drm/panthor: Add GPU specific initialization framework

2025-06-02 Thread Karunika Choo
This patch provides an initialization framework for multiple Mali GPUs by introducing a GPU support look-up table. Each entry contains, at minimum, the architecture major version of the GPU, and may optionally provide feature flags and register offset overrides. Signed-off-by: Karunika Choo

[PATCH v3 3/7] drm/panthor: Simplify getting the GPU model name

2025-06-02 Thread Karunika Choo
ed GPU features. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.c | 63 +++--- drivers/gpu/drm/panthor/panthor_regs.h | 2 + 2 files changed, 19 insertions(+), 46 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/gpu/drm/panthor/pantho

[PATCH v3 5/7] drm/panthor: Add support for Mali-G715 family of GPUs

2025-06-02 Thread Karunika Choo
and Mali-G615 GPUs. - arch 11.8 FW binary support Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 1 + drivers/gpu/drm/panthor/panthor_hw.c | 18 ++ drivers/gpu/drm/panthor/panthor_regs.h | 11 +++ include/uapi/drm/panthor_drm.h |

[PATCH v4 0/2] drm/panthor: Add 64-bit register accessors

2025-04-17 Thread Karunika Choo
-devel/20250410163546.919749-1-karunika.c...@arm.com/ Kind regards, Karunika Choo Karunika Choo (2): drm/panthor: Add 64-bit and poll register accessors drm/panthor: Clean up 64-bit register definitions drivers/gpu/drm/panthor/panthor_device.h | 71 ++ drivers/gpu/drm/panthor

[PATCH v4 2/2] drm/panthor: Clean up 64-bit register definitions

2025-04-17 Thread Karunika Choo
: Boris Brezillon Suggested-by: Boris Brezillon Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_drv.c | 4 +- drivers/gpu/drm/panthor/panthor_gpu.c | 8 +-- drivers/gpu/drm/panthor/panthor_gpu.h | 10 +-- drivers/gpu/drm/panthor/panthor_mmu.c | 16 ++--- drivers/gpu/drm

[PATCH v4 1/2] drm/panthor: Add 64-bit and poll register accessors

2025-04-17 Thread Karunika Choo
: Boris Brezillon Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_device.h | 71 ++ drivers/gpu/drm/panthor/panthor_drv.c| 4 +- drivers/gpu/drm/panthor/panthor_fw.c | 9 +- drivers/gpu/drm/panthor/panthor_gpu.c| 159 +-- drivers/gpu/drm

[PATCH v2 1/2] drm/panthor: Add 64-bit and poll register accessors

2025-04-11 Thread Karunika Choo
This patch adds 64-bit register accessors to simplify register access in Panthor. It also adds 32-bit and 64-bit variants for read_poll_timeout. This patch also updates Panthor to use the new 64-bit accessors and poll functions. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor

[PATCH v3 1/2] drm/panthor: Add 64-bit and poll register accessors

2025-04-11 Thread Karunika Choo
This patch adds 64-bit register accessors to simplify register access in Panthor. It also adds 32-bit and 64-bit variants for read_poll_timeout. This patch also updates Panthor to use the new 64-bit accessors and poll functions. Reviewed-by: Boris Brezillon Signed-off-by: Karunika Choo

[PATCH v3 0/2] drm/panthor: Add 64-bit register accessors

2025-04-11 Thread Karunika Choo
register definitions and renamed *_LO registers - Link to v1: https://lore.kernel.org/dri-devel/20250410163546.919749-1-karunika.c...@arm.com/ Kind regards, Karunika Choo Karunika Choo (2): drm/panthor: Add 64-bit and poll register accessors drm/panthor: Clean up 64-bit register definitions

[PATCH v3 2/2] drm/panthor: Clean up 64-bit register definitions

2025-04-11 Thread Karunika Choo
-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_gpu.c | 12 ++-- drivers/gpu/drm/panthor/panthor_gpu.h | 10 +-- drivers/gpu/drm/panthor/panthor_mmu.c | 16 ++--- drivers/gpu/drm/panthor/panthor_regs.h | 94 +- 4 files changed, 52 insertions(+), 80 deletions

Re: [PATCH] drm/panthor: Add 64-bit and poll register accessors

2025-04-11 Thread Karunika Choo
On 10/04/2025 17:46, Boris Brezillon wrote: > On Thu, 10 Apr 2025 17:35:46 +0100 > Karunika Choo wrote: > >> This patch adds 64-bit register accessors to simplify register access in >> Panthor. It also adds 32-bit and 64-bit variants for read_poll_timeout. >> >>

[PATCH v2 2/2] drm/panthor: Clean up 64-bit register definitions

2025-04-11 Thread Karunika Choo
With the introduction of 64-bit register accessors, the separate *_HI definitions are no longer necessary. This change removes them and renames the corresponding *_LO entries for cleaner and more consistent register definitions. Suggested-by: Boris Brezillon Signed-off-by: Karunika Choo

[PATCH v2 0/2] drm/panthor: Add 64-bit register accessors

2025-04-11 Thread Karunika Choo
...@arm.com/ Kind regards, Karunika Choo Karunika Choo (2): drm/panthor: Add 64-bit and poll register accessors drm/panthor: Clean up 64-bit register definitions drivers/gpu/drm/panthor/panthor_device.h | 71 drivers/gpu/drm/panthor/panthor_fw.c | 9 +- drivers/gpu/drm/panthor

[PATCH] drm/panthor: Add 64-bit and poll register accessors

2025-04-10 Thread Karunika Choo
This patch adds 64-bit register accessors to simplify register access in Panthor. It also adds 32-bit and 64-bit variants for read_poll_timeout. This patch also updates Panthor to use the new 64-bit accessors and poll functions. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor

Re: [PATCH v2 1/9] drm/panthor: Add 64-bit and poll register accessors

2025-04-10 Thread Karunika Choo
On 10/04/2025 14:28, Boris Brezillon wrote: > On Wed, 9 Apr 2025 14:00:54 +0100 > Karunika Choo wrote: > >> On 21/03/2025 07:48, Boris Brezillon wrote: >>> On Thu, 20 Mar 2025 11:17:33 + >>> Karunika Choo wrote: >>> >>>> This pat

Re: [PATCH v2 5/9] drm/panthor: Make getting GPU model name simple and extensible

2025-04-10 Thread Karunika Choo
On 21/03/2025 08:02, Boris Brezillon wrote: > On Thu, 20 Mar 2025 11:17:37 + > Karunika Choo wrote: > >> This patch replaces the previous panthor_model structure with a simple >> switch case based on the product_id, which is in the format of: >> ((arch_m

Re: [PATCH v2 2/9] drm/panthor: Use 64-bit and poll register accessors

2025-04-09 Thread Karunika Choo
On 21/03/2025 07:53, Boris Brezillon wrote: > On Thu, 20 Mar 2025 11:17:34 + > Karunika Choo wrote: > >> This patch updates Panthor to use the new 64-bit accessors and poll >> functions. > > nit: I don't think it makes sense to dissociate the introduction of

Re: [PATCH v2 1/9] drm/panthor: Add 64-bit and poll register accessors

2025-04-09 Thread Karunika Choo
On 21/03/2025 07:48, Boris Brezillon wrote: > On Thu, 20 Mar 2025 11:17:33 + > Karunika Choo wrote: > >> This patch adds 64-bit register accessors to simplify register access in >> Panthor. It also adds 32-bit and 64-bit variants for read_poll_timeout. >> >

[PATCH v2 5/9] drm/panthor: Make getting GPU model name simple and extensible

2025-04-05 Thread Karunika Choo
rences based on GPU features. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.c | 63 +++--- drivers/gpu/drm/panthor/panthor_regs.h | 1 + 2 files changed, 18 insertions(+), 46 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/g

[PATCH v2 6/9] drm/panthor: Add support for Mali-G715 family of GPUs

2025-04-05 Thread Karunika Choo
family of GPUs. - arch 11.8 FW binary support - reading and handling of GPU_FEATURES register Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 1 + drivers/gpu/drm/panthor/panthor_hw.c | 26 ++ drivers/gpu/drm/panthor/panthor_r

[PATCH v2 4/9] drm/panthor: Move GPU info initialization into panthor_hw.c

2025-04-05 Thread Karunika Choo
will enable Panthor to support GPUs with changes to register offsets, size and fields. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_gpu.c | 95 --- drivers/gpu/drm/panthor/panthor_hw.c | 105 ++ drivers/gpu/drm/panthor/panthor_hw.h

[PATCH v2 1/9] drm/panthor: Add 64-bit and poll register accessors

2025-04-04 Thread Karunika Choo
This patch adds 64-bit register accessors to simplify register access in Panthor. It also adds 32-bit and 64-bit variants for read_poll_timeout. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_regs.h | 55 ++ 1 file changed, 55 insertions(+) diff --git

[PATCH v2 3/9] drm/panthor: Add GPU specific initialization framework

2025-03-20 Thread Karunika Choo
U, base addresses describing changes in register offsets, and supported features. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/Makefile | 1 + drivers/gpu/drm/panthor/panthor_device.c | 5 ++ drivers/gpu/drm/panthor/panthor_device.h | 3 + drivers/gpu/drm/panthor/pant

[PATCH v2 2/9] drm/panthor: Use 64-bit and poll register accessors

2025-03-20 Thread Karunika Choo
This patch updates Panthor to use the new 64-bit accessors and poll functions. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 9 +- drivers/gpu/drm/panthor/panthor_gpu.c | 142 +++--- drivers/gpu/drm/panthor/panthor_mmu.c | 34 ++ 3 files

[PATCH v2 8/9] drm/panthor: Add support for Mali-G720 and Mali-G725 GPUs

2025-03-20 Thread Karunika Choo
patch enables FLUSH_CACHES for both families of GPUs via the PANTHOR_HW_FEATURE_GPU_CTRL_CACHE_FLUSH bit until FLUSH_PA_RANGE support is added. It also adds the aforementioned register definitions and firmware binary support for arch 12.8 and 13.8. Signed-off-by: Karunika Choo --- drivers/gp

[PATCH v2 9/9] drm/panthor: Add support for Mali-G710, Mali-G510, and Mali-G310

2025-03-20 Thread Karunika Choo
This patch adds GPU model name and FW binary support for Mali-G710, Mali-G510, and Mali-G310. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ drivers/gpu/drm/panthor/panthor_hw.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/panthor

[PATCH v2 0/9] drm/panthor: Add GPU specific initialization framework to support new Mali GPUs

2025-03-20 Thread Karunika Choo
. - Removed unnecessary pre-parsing of register fields from v1. Retaining current implementation as much as possible. - Added support for G710, G715, G720, and G725 series of Mali GPUs. - Link to v1: https://lore.kernel.org/all/20241219170521.64879-1-karunika.c...@arm.com/ Thanks, Karunika Choo

[PATCH v2 7/9] drm/panthor: Support GPU_CONTROL cache flush based on feature bit

2025-03-20 Thread Karunika Choo
-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.h | 6 + drivers/gpu/drm/panthor/panthor_mmu.c | 35 +++ 2 files changed, 41 insertions(+) diff --git a/drivers/gpu/drm/panthor/panthor_hw.h b/drivers/gpu/drm/panthor/panthor_hw.h index dfe0f86c5d76

[RFC PATCH 1/4] drm/panthor: Add 64-bit register accessors

2024-12-19 Thread Karunika Choo
This patch adds 64-bit register accessors to simplify register access in Panthor. It also adds 64-bit variants for read_poll_timeout and replaces all 64-bit and poll register accesses with these new functions. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 11

[RFC PATCH 0/4] drm/panthor: Add GPU specific initialization and feature detection

2024-12-19 Thread Karunika Choo
. Patch 3/4 implements the GPU specific initialization framework. Patch 4/4 provides an example of feature detection by performing cache flushes via the GPU_COMMAND register in place of the AS_COMMAND register when a feature bit ise set. Karunika Choo (4): drm/panthor: Add 64-bit register

[RFC PATCH 2/4] drm/panthor: Add parsed gpu properties

2024-12-19 Thread Karunika Choo
This patch adds parsing of GPU register fields on initialization instead of parsing the fields each time it is needed. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/Makefile | 1 + drivers/gpu/drm/panthor/panthor_device.c | 1 + drivers/gpu/drm/panthor/panthor_device.h

  1   2   >