Hi Louis,
On 2/23/24 08:37, Louis Chauvet wrote:
This patchset is the second version of [1]. It is almost a complete
rewrite to use a line-by-line algorithm for the composition.
It can be divided in three parts:
- PATCH 1 to 4: no functional change is intended, only some formatting and
Hi Louis,
Thanks for your patches! Could you please rebase them on top of
drm-misc-next? It would make it easier for me to review and test the
patches.
Best Regards,
- Maíra
On 2/1/24 14:31, Louis Chauvet wrote:
This patchset aims to solve issues I found in [1], and at the same time
simplify
On 1/5/24 12:32, Melissa Wen wrote:
On 01/05, Maíra Canal wrote:
Dump the contents of the DRM MM allocator of the V3D driver. This will
help us to debug the VA ranges allocated.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/v3d/v3d_debugfs.c | 15 +++
1 file changed, 15
On 1/11/24 04:13, Iago Toral wrote:
Ok, thanks for checking, you can add my R-B on the original patch then.
Applied to drm-misc/drm-misc-next-fixes!
Best Regards,
- Maíra
Iago
El mié, 10-01-2024 a las 07:42 -0300, Maira Canal escribió:
Hi Iago,
On 1/10/24 03:48, Iago Toral wrote:
I
On 1/8/24 05:43, Maxime Ripard wrote:
On Fri, 5 Jan 2024 14:58:36 -0300, Ma=C3=ADra Canal wrote:
Currently, when using non-blocking commits, we can see the following
kernel warning:
=20
[ 110.908514] [ cut here ]
[ 110.908529] refcount_t: underflow; use-after-free.
=20
Hi Iago,
On 1/10/24 03:48, Iago Toral wrote:
I think this is fine, but I was wondering if it would be simpler and
easier to just remove the sched cleanup from v3d_job_init and instead
always rely on callers to eventually call v3d_job_cleanup for fail
paths, where we are already calling
On 1/9/24 09:07, Iago Toral wrote:
Thanks Maíra!
Reviewed-by: Iago Toral Quiroga
Applied to drm-misc/drm-misc-next-fixes!
Best Regards,
- Maíra
El mar, 09-01-2024 a las 08:30 -0300, Maíra Canal escribió:
RPi 4 uses V3D 4.2, which is currently not supported by the register
definition
Hi Simon,
On 12/16/23 11:15, Simon Ser wrote:
Bubble up any error to the caller.
Signed-off-by: Simon Ser
Cc: Maxime Ripard
Cc: Kees Cook
Cc: Dave Stevenson
Reviewed-by: Maíra Canal
Best Regards,
- Maíra
---
drivers/gpu/drm/vc4/vc4_plane.c | 5 -
1 file changed, 4
On 11/30/23 13:40, Maíra Canal wrote:
Maíra Canal (11):
drm/v3d: Don't allow two multisync extensions in the same job
drm/v3d: Decouple job allocation from job initiation
drm/v3d: Use v3d_get_extensions() to parse CPU job data
drm/v3d: Create tracepoints to track the CPU job
Hi Iago,
On 11/28/23 05:42, Iago Toral wrote:
El lun, 27-11-2023 a las 15:48 -0300, Maíra Canal escribió:
From: Melissa Wen
Detach CSD job setup from CSD submission ioctl to reuse it in CPU
submission ioctl for indirect CSD job.
Signed-off-by: Melissa Wen
Co-developed-by: Maíra Canal
Hi Iago,
On 11/27/23 06:16, Iago Toral wrote:
El jue, 23-11-2023 a las 21:47 -0300, Maíra Canal escribió:
(...)
+static void
+v3d_timestamp_query(struct v3d_cpu_job *job)
+{
+ struct v3d_timestamp_query_info *timestamp_query =
timestamp_query;
+ struct v3d_bo *bo =
Hi Iago,
On 11/27/23 05:12, Iago Toral wrote:
El jue, 23-11-2023 a las 21:47 -0300, Maíra Canal escribió:
We want to allow the IOCTLs to allocate the job without initiating
it.
This will be useful for the CPU job submission IOCTL, as the CPU job
has
the need to use information from the user
On 11/8/23 10:05, Melissa Wen wrote:
On 11/06, Maíra Canal wrote:
I've been contributing to V3D with improvements, reviews, testing and
debugging. Therefore, add myself as a co-maintainer of the V3D driver.
Signed-off-by: Maíra Canal
Acked-by: Melissa Wen
Applied to
Hi Simon,
Thanks for working on this feature!
On 11/9/23 04:45, Simon Ser wrote:
User-space sometimes needs to allocate scanout-capable memory for
GPU rendering purposes. On a vc4/v3d split render/display SoC, this
is achieved via DRM dumb buffers: the v3d user-space driver opens
the primary
Hi,
I've just applied this patchset to drm-misc/drm-misc-next.
Thanks Melissa and Chema for reviewing it!
Best Regards,
- Maíra
On 9/5/23 18:06, Maíra Canal wrote:
This patchset exposes GPU usages stats both globally and per-file
descriptor.
The first patch exposes the accumulated amount of
Hi Iago,
On 10/30/23 09:20, Iago Toral wrote:
El mar, 24-10-2023 a las 07:05 -0300, Maira Canal escribió:
Hi Iago,
On 10/24/23 02:57, Iago Toral wrote:
El lun, 23-10-2023 a las 07:58 -0300, Maíra Canal escribió:
Currently, we are only warning the user if the BIN or RENDER jobs
don't
finish
Hi Iago,
The whole series is:
Reviewed-by: Maíra Canal
You can add my r-b in the next version (adding the DTS maintainers in
CC).
Best Regards,
- Maíra
On 10/30/23 05:28, Iago Toral Quiroga wrote:
This series includes patches to update the V3D kernel module
that drives the VideoCore VI GPU
Hi Maxime,
Wouldn't be nice to add to the TODO list an item regarding the deleted
drm_mm tests? Something just to remember us to develop new tests for it
in the future.
Best Regards,
- Maíra
On 10/25/23 10:24, Maxime Ripard wrote:
Most of those suites are undocumented and aren't really clear
Hi David,
EVoC is on hold at the current moment due to some bureaucracy issues.
I'm CCing other possible mentors, but at the moment, I'm not sure if a
EVoC project is possible.
Best Regards,
- Maíra
On 10/24/23 22:57, DAVID WALTERS wrote:
Hello,
I have a draft of a proposal that I would
Hi Iago,
On 10/24/23 02:57, Iago Toral wrote:
El lun, 23-10-2023 a las 07:58 -0300, Maíra Canal escribió:
Currently, we are only warning the user if the BIN or RENDER jobs
don't
finish before we unregister V3D. We must wait for all jobs to finish
before unregistering. Therefore, warn the user
Hi Arthur,
On 9/27/23 19:52, Arthur Grillo wrote:
On 27/09/23 19:47, Maira Canal wrote:
Hi Arthur,
On 9/20/23 03:11, Arthur Grillo wrote:
The kunit_action_platform_driver_unregister is added with
_platform_driver as ctx, but the kunit_release_action is called
pdev as ctx. Fix
Hi Arthur,
On 9/18/23 20:51, Arthur Grillo wrote:
This patchset tests the drm_fb_blit() function.
As this function can be used with already tested formats, the first
patch adds calls to drm_fb_blit() on the tests of supported formats.
Some supported formats were not yet covered by the
Hi Kees,
On 9/22/23 14:32, Kees Cook wrote:
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and
Please, add a commit message and your s-o-b.
Apart from that,
Reviewed-by: Maíra Canal
Best Regards,
- Maíra
On 9/28/23 08:45, Iago Toral Quiroga wrote:
---
drivers/gpu/drm/v3d/v3d_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/v3d/v3d_drv.c
Hi Iago,
On 9/28/23 08:45, Iago Toral Quiroga wrote:
V3D t.x takes a new parameter to configure TFU jobs that needs
I believe t.x should be 7.x.
to be provided by user space.
As I mentioned before, please, add your s-o-b.
---
include/uapi/drm/v3d_drm.h | 5 +
1 file changed, 5
Hi Iago,
On 9/28/23 08:45, Iago Toral Quiroga wrote:
Please, add a commit message and your s-o-b to the patch. Here is a
reference on how to format your patches [1].
Also, please, run checkpatch on this patch and address the warnings.
[1]
Hi Arthur,
On 9/20/23 03:11, Arthur Grillo wrote:
The kunit_action_platform_driver_unregister is added with
_platform_driver as ctx, but the kunit_release_action is called
pdev as ctx. Fix that by replacing it with _platform_driver.
Fixes: 4f2b0b583baa ("drm/tests: helpers: Switch to kunit
On 9/15/23 11:17, Janusz Krzysztofik wrote:
Hi Maíra,
Thanks for review.
On Friday, 15 September 2023 16:01:31 CEST Maira Canal wrote:
Hi,
On 9/11/23 10:03, Janusz Krzysztofik wrote:
While drm_mm test was converted form igt selftest to kunit, unexpected
value of "end" argument eq
Hi,
On 9/11/23 10:03, Janusz Krzysztofik wrote:
While drm_mm test was converted form igt selftest to kunit, unexpected
value of "end" argument equal "start" was introduced to one of calls to a
function that executes the drm_test_mm_insert_range for specific start/end
pair of arguments. As a
Hi Arthur,
On 9/5/23 18:27, Arthur Grillo wrote:
To fully cover drm_fb_blit(), add format conversion tests that are only
supported through drm_fb_blit().
Signed-off-by: Arthur Grillo
Reviewed-by: Maíra Canal
Best Regards,
- Maíra
---
drivers/gpu/drm/tests/drm_format_helper_test.c |
Hi Arthur,
On 9/5/23 18:27, Arthur Grillo wrote:
Add a call to drm_fb_blit() on existing format conversion tests that
has support.
Signed-off-by: Arthur Grillo
Reviewed-by: Maíra Canal
Best Regards,
- Maíra
---
drivers/gpu/drm/tests/drm_format_helper_test.c | 142
Hi Arthur,
On 9/1/23 15:52, Arthur Grillo wrote:
fourccs_out array is not initialized. As the
drm_fb_build_fourcc_list() doesn't necessarily change all the array,
and the test compares all of it, the comparison could fail if the
array is not initialized. Zero initialize the array to fix this.
Hi Arthur,
On 9/1/23 15:05, Arthur Grillo wrote:
When CONFIG_DEBUG_FS is not set -Wunused-function warnings appear,
make the static function inline to suppress that.
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202309012114.t8vlfaf8-...@intel.com/
Closes:
Hi Carlos,
On 9/4/23 14:22, Carlos wrote:
Hi Maíra,
On 8/26/23 11:06, Maíra Canal wrote:
Hi Carlos,
On 8/25/23 13:07, Carlos Eduardo Gallo Filho wrote:
Add a single KUnit test case for the drm_framebuffer_cleanup function.
Signed-off-by: Carlos Eduardo Gallo Filho
---
Hi Carlos,
On 9/4/23 15:52, Carlos wrote:
Hi Maíra,
On 8/26/23 11:13, Maíra Canal wrote:
Hi Carlos,
On 8/25/23 13:07, Carlos Eduardo Gallo Filho wrote:
Add a single KUnit test case for the drm_framebuffer_lookup function.
Signed-off-by: Carlos Eduardo Gallo Filho
---
Hi Carlos,
On 9/4/23 13:57, Carlos wrote:
Hi Maíra,
On 8/26/23 10:58, Maíra Canal wrote:
Hi Carlos,
On 8/25/23 13:07, Carlos Eduardo Gallo Filho wrote:
Introduce a test to cover the creation of framebuffer with
modifier on a device that doesn't support it.
Signed-off-by: Carlos Eduardo
Hi Carlos,
On 9/4/23 14:41, Carlos wrote:
Hi Maíra,
On 8/26/23 11:16, Maíra Canal wrote:
Hi Carlos,
On 8/25/23 13:11, Carlos Eduardo Gallo Filho wrote:
Add a single KUnit test case for the drm_framebuffer_init function.
Signed-off-by: Carlos Eduardo Gallo Filho
---
Hi Arthur,
On 9/1/23 14:08, Arthur Grillo wrote:
Insert parameterized test for the drm_fb_blit() to ensure correctness
and prevent future regressions.
The test is done by adding a call to drm_fb_blit() on every format
that has support. Also, to fully test the function, add new format
On 9/1/23 15:05, Arthur Grillo wrote:
When CONFIG_DEBUG_FS is not set -Wunused-function warnings appear,
make the static function inline to suppress that.
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202309012114.t8vlfaf8-...@intel.com/
Closes:
On 9/1/23 15:52, Arthur Grillo wrote:
fourccs_out array is not initialized. As the
drm_fb_build_fourcc_list() doesn't necessarily change all the array,
and the test compares all of it, the comparison could fail if the
array is not initialized. Zero initialize the array to fix this.
Fixes:
Hi Arthur,
On 8/11/23 15:17, Arthur Grillo wrote:
Test the default pitch fallback when NULL is passed as the dst_pitch on
the conversion procedures.
Signed-off-by: Arthur Grillo
Reviewed-by: Maíra Canal
Best Regards,
- Maíra
---
drivers/gpu/drm/tests/drm_format_helper_test.c | 126
On 8/11/23 15:17, Arthur Grillo wrote:
Insert parameterized test for the drm_fb_build_fourcc_list() to ensure
correctness and prevent future regressions.
Signed-off-by: Arthur Grillo
---
drivers/gpu/drm/tests/drm_format_helper_test.c | 148 +
1 file changed, 148
Hi Arthur,
On 8/11/23 15:17, Arthur Grillo wrote:
Insert parameterized test for the drm_fb_memcpy() to ensure correctness
and prevent future regressions. The test case can accept different
formats.
Signed-off-by: Arthur Grillo
---
drivers/gpu/drm/tests/drm_format_helper_test.c | 391
Hi Matthew,
I'm not sure in which tree you plan to apply this series, but if you
plan to apply it on drm-misc-next, it would be nice to rebase on top of
it. It would make it easier for driver maintainers to review it.
Apart from the small nit below it, I tested the Xe tree on v3d and
things
On 7/21/23 15:23, Arthur Grillo wrote:
Insert parameterized test for the drm_fb_memcpy() to ensure correctness
and prevent future regressions. The test case can accept different
formats.
Signed-off-by: Arthur Grillo
---
.../gpu/drm/tests/drm_format_helper_test.c| 391 ++
On 7/21/23 15:23, Arthur Grillo wrote:
The drm_fb_memcpy() supports multi-plane formats. To fully test it in
the future, add multi-plane support to the conversion_buf_size() helper.
Signed-off-by: Arthur Grillo
Reviewed-by: Maíra Canal
Best Regards,
- Maíra
---
On 7/21/23 15:23, Arthur Grillo wrote:> Insert parameterized test for
the drm_fb_build_fourcc_list() to ensure
correctness and prevent future regressions.
Signed-off-by: Arthur Grillo
---
.../gpu/drm/tests/drm_format_helper_test.c| 143 ++
1 file changed, 143
On 7/21/23 15:23, Arthur Grillo wrote:
Insert parameterized test for the drm_fb_clip_offset() to ensure
correctness and prevent future regressions.
Signed-off-by: Arthur Grillo
Could you please use the prefix drm/tests in the commit message for all
patches? Besides that:
Reviewed-by: Maíra
On 7/21/23 15:23, Arthur Grillo wrote:
Insert parameterized test for the drm_fb_swab() to ensure correctness
and prevent future regressions.
Signed-off-by: Arthur Grillo
With the nit I pointed in patch #1 addressed,
Reviewed-by: Maíra Canal
Best Regards,
- Maíra
---
Hi Arthur,
Just nitpicking, but...
On 7/21/23 15:23, Arthur Grillo wrote:
Test the default pitch fallback when NULL is passed as the dst_pitch on
the conversion procedures.
Signed-off-by: Arthur Grillo
---
.../gpu/drm/tests/drm_format_helper_test.c| 132 --
1 file
On 8/3/23 17:52, Sebastian Wick wrote:
On Sun, Jul 30, 2023 at 12:51 AM Maíra Canal wrote:
After we flush the workqueue at the commit tale, we need to make sure
that no work is queued until we destroy the state. Currently, new work
can be queued in the workqueue, even after the commit tale,
On 5/23/23 09:32, Maíra Canal wrote:
Currently, it is possible for the composer to be set as enabled and then
as disabled without a proper call for the vkms_vblank_simulate(). This
is problematic, because the driver would skip one CRC output, causing CRC
tests to fail. Therefore, we need to make
Hi Helen,
Great to see this coming to the DRM!
Just wondering, any chance we could add a stage to perform tests on
VKMS? The main way of validating VKMS is through IGT tests, so I feel
it would be a perfect match to have VKMS as a stage on the CI. As a
generic KMS driver, VKMS is also great to
Hi,
On 7/28/23 07:16, Tvrtko Ursulin wrote:
Hi,
On 27/07/2023 15:23, Maíra Canal wrote:
The previous patch exposed the accumulated amount of active time per
client for each V3D queue. But this doesn't provide a global notion of
the GPU usage.
Therefore, provide the accumulated amount of
Hi Arthur,
On 7/8/23 22:38, Arthur Grillo wrote:
Support a 1D gamma LUT with interpolation for each color channel on the
VKMS driver. Add a check for the LUT length by creating
vkms_atomic_check().
Enable VKMS to run the test igt@kms_plane@pixel-format.
Tested with:
igt@kms_color@gamma
Hi Arthur,
On 7/27/23 16:22, Arthur Grillo wrote:
The drm_exec tests where crashing[0] because of a null dereference. This
is caused by a new access of the `driver` attribute of `struct
drm_driver` on drm_gem_private_object_init(). Alloc the drm_device to
fix that.
[0]
[15:05:24]
On 7/18/23 18:44, Nathan Chancellor wrote:
Hi all,
A proposed update to clang's -Wconstant-logical-operand [1] to warn when
the left hand side is a constant as well now triggers with the modulo
expression in nsecs_to_jiffies_timeout() when NSEC_PER_SEC is not a
multiple of HZ, such as
Hi Nathan,
On 7/18/23 18:44, Nathan Chancellor wrote:
A proposed update to clang's -Wconstant-logical-operand to warn when the
left hand side is a constant shows the following instance in
nsecs_to_jiffies_timeout() when NSEC_PER_SEC is not a multiple of HZ,
such as CONFIG_HZ=300:
In file
Hi Melissa,
On 7/23/23 18:00, Melissa Wen wrote:
On 07/23, Maíra Canal wrote:
Following the DRM assumption, VKMS currently assumes that the alpha is
pre-multiplied. Moreover, it doesn't support the alpha property.
So, first, implement the alpha property to VKMS and then, the blend
mode
Hi Maxime,
On 7/20/23 08:15, Maxime Ripard wrote:
Hi,
Since v6.5-rc1, kunit gained a devm/drmm-like mechanism that makes tests
resources much easier to cleanup.
This series converts the existing tests to use those new actions where
relevant.
> Let me know what you think,
With the problems
Hi Christian,
I believe that `select DRM_EXEC` is missing on v3d's Kconfig file. If
we don't select it, we will get some compilation errors.
Apart from this problem, I ran some tests on the RPi 4 and didn't see
any problems.
Best Regards,
- Maíra
On 7/12/23 09:47, Christian König wrote:
Just
On 7/12/23 10:42, Geert Uytterhoeven wrote:
All debug messages in drm_gem_framebuffer_helper.c use drm_dbg_kms(),
except for one, which uses drm_dbg().
Replace the outlier by drm_dbg_kms() to restore consistency.
Fixes: c91acda3a380bcaf ("drm/gem: Check for valid formats")
Signed-off-by: Geert
On 7/11/23 10:31, Christian König wrote:
Exercise at least all driver facing functions of this new component.
v2: add array test as well
v3: some kunit cleanups
v4: more tests and cleanups
Signed-off-by: Christian König
---
drivers/gpu/drm/Kconfig | 1 +
On 6/27/23 05:12, Pekka Paalanen wrote:
On Mon, 26 Jun 2023 14:35:25 -0300
Maira Canal wrote:
Hi Pekka,
On 6/26/23 05:17, Pekka Paalanen wrote:
On Sat, 24 Jun 2023 18:48:08 -0300
Maira Canal wrote:
Hi Arthur,
Thanks for working on this feature for the VKMS!
On 6/21/23 16:41, Arthur
On 6/24/23 18:29, Carlos Eduardo Gallo Filho wrote:
Swap tests parameters names so they actually reflect what is being tested.
v1: https://lore.kernel.org/all/20230623152518.8603-1-gcar...@disroot.org/
v2: Simplified commit message.
Signed-off-by: Carlos Eduardo Gallo Filho
Reviewed-by: André
Hi Pekka,
On 6/26/23 05:17, Pekka Paalanen wrote:
On Sat, 24 Jun 2023 18:48:08 -0300
Maira Canal wrote:
Hi Arthur,
Thanks for working on this feature for the VKMS!
On 6/21/23 16:41, Arthur Grillo wrote:
Support a 1D gamma LUT with interpolation for each color channel on the
VKMS driver
Hi Jim,
On 6/23/23 19:23, Jim Shargo wrote:
This change adds the basic scaffolding for ConfigFS, including setting
up the default directories. It does not allow for the registration of
configfs-backed devices, which is complex and provided in a follow-up
commit.
This CL includes docs about
Hi Jim,
On 6/23/23 19:23, Jim Shargo wrote:
In many testing circumstances, we will want to just create a new device
and test against that. If we create a default device, it can be annoying
to have to manually select the new device instead of choosing the only
one that exists.
The param,
Hi Jim,
On 6/23/23 19:23, Jim Shargo wrote:
This change supports multiple CRTCs, encoders, connectors instead of one
of each per device.
Since ConfigFS-based devices will support multiple crtcs, it's useful to
move all of the writeback/composition data from being per-"output" to
being
Hi Jim,
Thanks for working on this great feature for the VKMS!
On 6/23/23 19:23, Jim Shargo wrote:
This is a small refactor to make ConfigFS support easier. Once we
support ConfigFS, there can be multiple devices instantiated by the
driver, and so moving everything into managed memory makes
Hi Arthur,
Thanks for working on this feature for the VKMS!
On 6/21/23 16:41, Arthur Grillo wrote:
Support a 1D gamma LUT with interpolation for each color channel on the
VKMS driver. Add a check for the LUT length by creating
vkms_atomic_check().
Tested with:
igt@kms_color@gamma
Hi edagarmarjara,
First, you need to include a commit message to the patch. Check [1] to
see a basic guide to submit patches.
On 6/19/23 20:22, edagarmarjara wrote:
---
drivers/gpu/drm/tests/drm_rect_test.c | 30 +++
1 file changed, 30 insertions(+)
diff --git
Hi Carlos,
Great catch!
On 6/23/23 12:25, Carlos Eduardo Gallo Filho wrote:
The "YVU420 DRM_MODE_FB_MODIFIERS set without modifier" test
hadn't DRM_MODE_FB_MODIFIERS set, so that it was in fact testing
another case, while the "YVU420 Normal sizes" test in turn was with
DRM_MODE_FB_MODIFIERS
73 matches
Mail list logo
