Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-20 Thread Noralf Trønnes
Den 29.07.2022 18.34, skrev Maxime Ripard: > The TV mode property has been around for a while now to select and get the > current TV mode output on an analog TV connector. > > Despite that property name being generic, its content isn't and has been > driver-specific which makes it hard to

Re: [PATCH v1 23/35] drm/vc4: vec: Convert to the new TV mode property

2022-08-20 Thread Noralf Trønnes
Den 29.07.2022 18.35, skrev Maxime Ripard: > Now that the core can deal fine with analog TV modes, let's convert the vc4 > VEC driver to leverage those new features. > > We've added some backward compatibility to support the old TV mode property > and translate it into the new TV norm

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-18 Thread Noralf Trønnes
Den 18.08.2022 01.23, skrev Noralf Trønnes: > > > Den 17.08.2022 15.11, skrev Noralf Trønnes: >> >> >> Den 17.08.2022 13.46, skrev Maxime Ripard: >>> On Tue, Aug 16, 2022 at 09:35:24PM +0200, Noralf Trønnes wrote: >>>> Den 16.08.2022 11.49,

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-17 Thread Noralf Trønnes
Den 17.08.2022 15.11, skrev Noralf Trønnes: > > > Den 17.08.2022 13.46, skrev Maxime Ripard: >> On Tue, Aug 16, 2022 at 09:35:24PM +0200, Noralf Trønnes wrote: >>> Den 16.08.2022 11.49, skrev Maxime Ripard: >>>> On Tue, Aug 16, 2022 at 11:42:20AM +0

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-17 Thread Noralf Trønnes
Den 17.08.2022 13.46, skrev Maxime Ripard: > On Tue, Aug 16, 2022 at 09:35:24PM +0200, Noralf Trønnes wrote: >> Den 16.08.2022 11.49, skrev Maxime Ripard: >>> On Tue, Aug 16, 2022 at 11:42:20AM +0200, Noralf Trønnes wrote: >>>> Den 16.08.2022 10.26,

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-16 Thread Noralf Trønnes
Den 16.08.2022 11.49, skrev Maxime Ripard: > On Tue, Aug 16, 2022 at 11:42:20AM +0200, Noralf Trønnes wrote: >> >> >> Den 16.08.2022 10.26, skrev Maxime Ripard: >>> Hi, >>> >>> On Mon, Aug 08, 2022 at 02:44:56PM +0200, Noralf Trønnes wrote

Re: [PATCH v1 06/35] drm/connector: Only register TV mode property if present

2022-08-15 Thread Noralf Trønnes
Den 15.08.2022 12.40, skrev Maxime Ripard: > Hi, > > On Mon, Aug 08, 2022 at 02:49:08PM +0200, Noralf Trønnes wrote: >> Den 29.07.2022 18.34, skrev Maxime Ripard: >>> The drm_create_tv_properties() will create the TV mode property >>> unconditionally. >&

Re: [PATCH v1 03/35] drm/atomic: Add TV subconnector property to get/set_property

2022-08-15 Thread Noralf Trønnes
Den 15.08.2022 09.35, skrev Maxime Ripard: > Hi Noralf, > > Thanks for your review > > On Mon, Aug 08, 2022 at 02:30:42PM +0200, Noralf Trønnes wrote: >> Den 29.07.2022 18.34, skrev Maxime Ripard: >>> The subconnector property was created by drm_mode_create_t

Re: [PATCH v2 00/14] drm/format-helper: Move to struct iosys_map

2022-08-08 Thread Noralf Trønnes
onversion > drm/format-helper: Rework XRGB-to-MONO conversion > drm/format-helper: Move destination-buffer handling into internal > helper > drm/format-helper: Rename parameter vmap to src > Tested-by: Noralf Trønnes * gud: XRGB-to-{MONO,GRAY8,RGB332,RGB565}

Re: [PATCH v1 00/35] drm: Analog TV Improvements

2022-08-08 Thread Noralf Trønnes
Den 29.07.2022 18.34, skrev Maxime Ripard: > Hi, > > Here's a series aiming at improving the command line named modes support, > and more importantly how we deal with all the analog TV variants. > > The named modes support were initially introduced to allow to specify the > analog TV mode to

Re: [PATCH v1 06/35] drm/connector: Only register TV mode property if present

2022-08-08 Thread Noralf Trønnes
er. > > Signed-off-by: Maxime Ripard > I don't understand why this makes the transition easier, but if you think so: Acked-by: Noralf Trønnes > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index 68a4e47f85a9..d73a68764b6e 100644 > ---

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-08 Thread Noralf Trønnes
Den 29.07.2022 18.34, skrev Maxime Ripard: > The TV mode property has been around for a while now to select and get the > current TV mode output on an analog TV connector. > > Despite that property name being generic, its content isn't and has been > driver-specific which makes it hard to

Re: [PATCH v1 03/35] drm/atomic: Add TV subconnector property to get/set_property

2022-08-08 Thread Noralf Trønnes
> Let's solve this. > > Signed-off-by: Maxime Ripard > I just realised that this and the select_subconnector property isn't used by any drivers. Do you plan to use them? Maybe they don't need to be wired up at all. Anyways, up to you: Reviewed-by: Noralf Trønnes > diff --git a/dri

Re: [PATCH v1 02/35] drm/connector: Rename subconnector state variable

2022-08-08 Thread Noralf Trønnes
bconnector to make it move > obvious what it's about. > > Signed-off-by: Maxime Ripard > Reviewed-by: Noralf Trønnes

Re: [PATCH v1 01/35] drm/atomic-helper: Rename drm_atomic_helper_connector_tv_reset to avoid ambiguity

2022-08-08 Thread Noralf Trønnes
o > drm_atomic_helper_connector_tv_margins_reset() to remove that ambiguity > and hopefully make it more obvious. > > Signed-off-by: Maxime Ripard > Reviewed-by: Noralf Trønnes

Re: [PATCH 3/3] drm/gud: Fix endianness in gud_xrgb8888_to_color() helper

2022-07-19 Thread Noralf Trønnes
Den 08.07.2022 20.21, skrev Geert Uytterhoeven: > DRM formats are defined to be little-endian, unless the > DRM_FORMAT_BIG_ENDIAN flag is set. Hence when converting from one > format to another, multi-byte pixel values loaded from memory must be > converted from little-endian to host-endian.

Re: [PATCH v2] drm/mipi-dbi: align max_chunk to 2 in spi_transfer

2022-05-30 Thread Noralf Trønnes
Den 10.05.2022 05.02, skrev Yunhao Tian: > In __spi_validate, there's a validation that no partial transfers > are accepted (xfer->len % w_size must be zero). When > max_chunk is not a multiple of bpw (e.g. max_chunk = 65535, > bpw = 16), the transfer will be rejected. > > This patch aligns

Re: [PATCH 0/4] drm: Ignore non-existing color planes in helpers

2022-05-16 Thread Noralf Trønnes
helpers on simpledrm. > Tested with drm/gud, now there's only one UBSAN warning: Tested-by: Noralf Trønnes I was hoping to get some time to give a review, but it doesn't look like I'm able to do that. Noralf. > [1] > https://lore.kernel.org/dri-devel/20

Re: [PATCH v3 4/5] drm/gud: Map framebuffer BOs with drm_gem_fb_vmap()

2022-05-09 Thread Noralf Trønnes
Den 09.05.2022 10.32, skrev Thomas Zimmermann: > Hi Noralf > > Am 06.05.22 um 16:11 schrieb Thomas Zimmermann: >> Hi >> >> Am 06.05.22 um 16:01 schrieb Noralf Trønnes: >>> Hi Thomas, >>> >>> I'm getting this on Ubuntu 22.04: >>> &g

Re: [PATCH v3 4/5] drm/gud: Map framebuffer BOs with drm_gem_fb_vmap()

2022-05-06 Thread Noralf Trønnes
igned-off-by: Thomas Zimmermann > Acked-by: Noralf Trønnes > Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/gud/gud_pipe.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/gud/gud_pipe.c b/drivers/gpu/drm/gud/gud_pipe.c >

Re: [PATCH] drm/mipi-dbi: Fix max_chunk calculation in spi_transfer

2022-04-16 Thread Noralf Trønnes
Den 08.03.2022 02.56, skrev Yunhao Tian: > In __spi_validate, there's a validation that no partial transfers > are accepted (xfer->len % w_size must be zero). When > max_chunk is not a multiple of bpw (e.g.max_chunk = 65535, > bpw = 16), the transfer will be rejected. > > This patch clamps

Re: [PATCH 2/2] drm/panel: lvds: Drop now redundant width-mm and height-mm check

2022-04-11 Thread Noralf Trønnes
Vetter > Cc: Dmitry Osipenko > Cc: Laurent Pinchart > Cc: Noralf Trønnes > Cc: Rob Herring > Cc: Robert Foss > Cc: Sam Ravnborg > Cc: Thomas Zimmermann > To: dri-devel@lists.freedesktop.org > --- Reviewed-by: Noralf Trønnes

Re: [PATCH 1/2] drm/modes: Make width-mm/height-mm check in of_get_drm_panel_display_mode() mandatory

2022-04-11 Thread Noralf Trønnes
e.g. scaling accordingly. > > Signed-off-by: Marek Vasut > Cc: Christoph Niedermaier > Cc: Daniel Vetter > Cc: Dmitry Osipenko > Cc: Laurent Pinchart > Cc: Noralf Trønnes > Cc: Rob Herring > Cc: Robert Foss > Cc: Sam Ravnborg > Cc: Thomas Zimmermann > To:

Re: [PATCH] dt-bindings: display: panel: mipi-dbi-spi: Make width-mm/height-mm mandatory

2022-04-08 Thread Noralf Trønnes
Den 08.04.2022 19.55, skrev Marek Vasut: > On 4/8/22 16:50, Noralf Trønnes wrote: >> Hi Marek, > > Hi, > >> I see that you have commit rights so I assume you will be applying this >> patch. > > It's already in drm-misc-fixes: > > https://cgit.fr

Re: [PATCH] dt-bindings: display: panel: mipi-dbi-spi: Make width-mm/height-mm mandatory

2022-04-08 Thread Noralf Trønnes
"dt-bindings: display: add bindings for MIPI DBI > compatible SPI panels") > Signed-off-by: Marek Vasut > Cc: Christoph Niedermaier > Cc: Daniel Vetter > Cc: Dmitry Osipenko > Cc: Laurent Pinchart > Cc: Noralf Trønnes > Cc: Rob Herring > Cc: Robert Foss

Re: [PATCH] dt-bindings: display: panel: mipi-dbi-spi: Make width-mm/height-mm mandatory

2022-04-05 Thread Noralf Trønnes
ed-off-by: Marek Vasut > Cc: Christoph Niedermaier > Cc: Daniel Vetter > Cc: Dmitry Osipenko > Cc: Laurent Pinchart > Cc: Noralf Trønnes > Cc: Rob Herring > Cc: Robert Foss > Cc: Sam Ravnborg > Cc: Thomas Zimmermann > Cc: devicet...@vger.kernel.org > To: dr

Re: [RFC][PATCH 2/3] drm/modes: Make width-mm/height-mm mandatory in of_get_drm_panel_display_mode()

2022-04-02 Thread Noralf Trønnes
Den 02.04.2022 19.55, skrev Marek Vasut: > On 4/2/22 19:08, Noralf Trønnes wrote: >> >> >> Den 02.04.2022 18.39, skrev Marek Vasut: >>> On 4/2/22 09:45, Noralf Trønnes wrote: >>>> >>>> >>>> Den 02.04.2022 06.28, skrev Marek V

Re: [RFC][PATCH 2/3] drm/modes: Make width-mm/height-mm mandatory in of_get_drm_panel_display_mode()

2022-04-02 Thread Noralf Trønnes
Den 02.04.2022 18.39, skrev Marek Vasut: > On 4/2/22 09:45, Noralf Trønnes wrote: >> >> >> Den 02.04.2022 06.28, skrev Marek Vasut: >>> On 4/2/22 05:19, Laurent Pinchart wrote: >>>> On Fri, Apr 01, 2022 at 10:36:24PM +0200, Marek Vasut wrote: >

Re: [RFC][PATCH 2/3] drm/modes: Make width-mm/height-mm mandatory in of_get_drm_panel_display_mode()

2022-04-02 Thread Noralf Trønnes
Den 02.04.2022 06.28, skrev Marek Vasut: > On 4/2/22 05:19, Laurent Pinchart wrote: >> On Fri, Apr 01, 2022 at 10:36:24PM +0200, Marek Vasut wrote: >>> On 4/1/22 20:46, Laurent Pinchart wrote: On Fri, Apr 01, 2022 at 06:37:54PM +0200, Marek Vasut wrote: > Make the width-mm/height-mm

Re: [PATCH] drm/repaper: combine allocs in repaper_spi_transfer()

2022-03-13 Thread Noralf Trønnes
Den 13.03.2022 17.07, skrev Tom Rix: > > On 3/13/22 8:41 AM, Noralf Trønnes wrote: >> >> Den 13.03.2022 15.10, skrev t...@redhat.com: >>> From: Tom Rix >>> >>> repaper_spi_transfer() allocates a single byte >>> for the spi header

Re: [PATCH] drm/repaper: combine allocs in repaper_spi_transfer()

2022-03-13 Thread Noralf Trønnes
Den 13.03.2022 15.10, skrev t...@redhat.com: > From: Tom Rix > > repaper_spi_transfer() allocates a single byte > for the spi header and then another buffer for > the payload. Combine the allocs into a single > buffer with offsets. To simplify the offsets > put the header after the payload.

Re: [PATCH 0/6] drm/tiny/st7735r: Match up with staging/fbtft driver

2022-03-09 Thread Noralf Trønnes
Den 24.11.2021 16.07, skrev Noralf Trønnes: > Hi, > > This patchset adds a missing piece for decommissioning the > staging/fbtft/fb_st7735r.c driver namely a way to configure the > controller from Device Tree. > > All fbtft drivers have builtin support for one display

Re: linux-next: build failure after merge of the amdgpu tree

2022-03-08 Thread Noralf Trønnes
Hi drm-misc maintainers, I don't know who has act on this but the driver came through drm-misc-next so it's most likely not amd. The initial post can be found here: https://lore.kernel.org/linux-next/yiyc2fqgf7d%2fq...@sirena.org.uk/T/ Noralf. Den 07.03.2022 14.04, skrev Mark Brown: > On Mon,

Re: [PATCH v6 0/5] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-28 Thread Noralf Trønnes
Den 28.02.2022 09.31, skrev Maxime Ripard: > Hi, > > On Sun, Feb 27, 2022 at 01:47:08PM +0100, Noralf Trønnes wrote: >> Hi, >> >> This patchset adds a driver that will work with most MIPI DBI compatible >> SPI panels out there. >> >> One change

[PATCH v6 4/5] drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev

2022-02-27 Thread Noralf Trønnes
Ravnborg Signed-off-by: Noralf Trønnes --- include/drm/drm_mipi_dbi.h | 8 1 file changed, 8 insertions(+) diff --git a/include/drm/drm_mipi_dbi.h b/include/drm/drm_mipi_dbi.h index 6fe13cce2670..dad2f187b64b 100644 --- a/include/drm/drm_mipi_dbi.h +++ b/include/drm/drm_mipi_dbi.h

[PATCH v6 1/5] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-02-27 Thread Noralf Trønnes
Ravnborg Reviewed-by: Rob Herring Signed-off-by: Noralf Trønnes --- .../display/panel/panel-mipi-dbi-spi.yaml | 126 ++ 1 file changed, 126 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml diff --git a/Documentation

[PATCH v6 5/5] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-27 Thread Noralf Trønnes
e compatible instead (Rob) - Add wiki entry in MAINTAINERS Acked-by: Maxime Ripard Reviewed-by: Sam Ravnborg Signed-off-by: Noralf Trønnes --- MAINTAINERS | 8 + drivers/gpu/drm/tiny/Kconfig | 15 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu

[PATCH v6 3/5] drm/modes: Add of_get_drm_panel_display_mode()

2022-02-27 Thread Noralf Trønnes
Add a function to get a drm_display_mode from a panel-timing device tree subnode. Suggested-by: Sam Ravnborg Reviewed-by: Sam Ravnborg Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_modes.c | 49 + include/drm/drm_modes.h | 8 ++ 2 files

[PATCH v6 2/5] drm/modes: Remove trailing whitespace

2022-02-27 Thread Noralf Trønnes
Remove trailing whitespace from a comment. Acked-by: Sam Ravnborg Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_modes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 96b13e36293c..77a4c8dd0bb8 100644

[PATCH v6 0/5] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-27 Thread Noralf Trønnes
Hi, This patchset adds a driver that will work with most MIPI DBI compatible SPI panels out there. One change this time: Fix indentation in the DT binding. All patches are reviewed now so I will apply this after Rob's bot have looked at the binding. Thanks for reviewing! Noralf. Noralf

[PATCH v5 5/5] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-24 Thread Noralf Trønnes
e compatible instead (Rob) - Add wiki entry in MAINTAINERS Acked-by: Maxime Ripard Signed-off-by: Noralf Trønnes --- MAINTAINERS | 8 + drivers/gpu/drm/tiny/Kconfig | 15 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/pa

[PATCH v5 3/5] drm/modes: Add of_get_drm_panel_display_mode()

2022-02-24 Thread Noralf Trønnes
Add a function to get a drm_display_mode from a panel-timing device tree subnode. Suggested-by: Sam Ravnborg Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_modes.c | 49 + include/drm/drm_modes.h | 8 ++ 2 files changed, 57 insertions

[PATCH v5 0/5] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-24 Thread Noralf Trønnes
1129093946.xhp22mvdut3m67sc@houat/ [2] https://github.com/notro/panel-mipi-dbi/wiki Noralf Trønnes (5): dt-bindings: display: add bindings for MIPI DBI compatible SPI panels drm/modes: Remove trailing whitespace drm/modes: Add of_get_drm_panel_display_mode() drm/mipi-dbi: Add driver_priv

[PATCH v5 4/5] drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev

2022-02-24 Thread Noralf Trønnes
Ravnborg Signed-off-by: Noralf Trønnes --- include/drm/drm_mipi_dbi.h | 8 1 file changed, 8 insertions(+) diff --git a/include/drm/drm_mipi_dbi.h b/include/drm/drm_mipi_dbi.h index 6fe13cce2670..dad2f187b64b 100644 --- a/include/drm/drm_mipi_dbi.h +++ b/include/drm/drm_mipi_dbi.h

[PATCH v5 2/5] drm/modes: Remove trailing whitespace

2022-02-24 Thread Noralf Trønnes
Remove trailing whitespace from a comment. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_modes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 96b13e36293c..77a4c8dd0bb8 100644 --- a/drivers/gpu/drm

[PATCH v5 1/5] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-02-24 Thread Noralf Trønnes
) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/panel-mipi-dbi-spi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MIPI DBI SPI Panel + +maintainers: + - Noralf Trønnes + +description: | + This binding is for display panels using a MIPI DBI compatible

Re: [PATCH] drm/repaper: Use format helper for xrgb8888 to monochrome conversion

2022-02-24 Thread Noralf Trønnes
ned-off-by: Javier Martinez Canillas > --- Tested-by: Noralf Trønnes Reviewed-by: Noralf Trønnes Do you have commit rights and will apply this patch? Noralf.

Re: [PATCH v4 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-02-21 Thread Noralf Trønnes
Den 18.02.2022 16.11, skrev Noralf Trønnes: > Add binding for MIPI DBI compatible SPI panels. > > v4: > - There should only be two compatible (Maxime) > - s/panel-dbi-spi/panel-mipi-dbi-spi/in compatible > > v3: > - Move properties to Device Tree (Maxime) > -

Re: [PATCH v4 3/3] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-20 Thread Noralf Trønnes
Den 20.02.2022 20.57, skrev Sam Ravnborg: > Hi Noralf. > > On Sun, Feb 20, 2022 at 07:11:14PM +0100, Noralf Trønnes wrote: >>> Den 20.02.2022 11.04, skrev Sam Ravnborg: >>>> Hi Noralf, >>>> >>>>>> +static int panel_mipi_dbi_get_mode(s

Re: [PATCH v4 3/3] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-20 Thread Noralf Trønnes
> Den 20.02.2022 11.04, skrev Sam Ravnborg: > > Hi Noralf, > > > >>> +static int panel_mipi_dbi_get_mode(struct mipi_dbi_dev *dbidev, struct drm_display_mode *mode) > >>> +{ > >>> + struct device *dev = dbidev->drm.dev; > >>> + u32 width_mm = 0, height_mm = 0; > >>> + struct display_timing timing;

Re: [PATCH v4 3/3] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-20 Thread Noralf Trønnes
Den 19.02.2022 23.10, skrev Sam Ravnborg: > Hi Noralf, > On Fri, Feb 18, 2022 at 04:11:10PM +0100, Noralf Trønnes wrote: >> Add a driver that will work with most MIPI DBI compatible SPI panels. >> This avoids adding a driver for every new MIPI DBI compatible controller >

Re: [PATCH v4 3/3] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-20 Thread Noralf Trønnes
Den 20.02.2022 11.04, skrev Sam Ravnborg: > Hi Noralf, > >>> +static int panel_mipi_dbi_get_mode(struct mipi_dbi_dev *dbidev, struct >>> drm_display_mode *mode) >>> +{ >>> + struct device *dev = dbidev->drm.dev; >>> + u32 width_mm = 0, height_mm = 0; >>> + struct display_timing timing;

[PATCH v4 2/3] drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev

2022-02-18 Thread Noralf Trønnes
-by: Noralf Trønnes --- include/drm/drm_mipi_dbi.h | 8 1 file changed, 8 insertions(+) diff --git a/include/drm/drm_mipi_dbi.h b/include/drm/drm_mipi_dbi.h index 6fe13cce2670..dad2f187b64b 100644 --- a/include/drm/drm_mipi_dbi.h +++ b/include/drm/drm_mipi_dbi.h @@ -130,6 +130,14 @@ struct

[PATCH v4 0/3] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-18 Thread Noralf Trønnes
after all. See wiki[2] for script to make command firmware files. Noralf. [1] https://lore.kernel.org/dri-devel/20211129093946.xhp22mvdut3m67sc@houat/ [2] https://github.com/notro/panel-mipi-dbi/wiki Noralf Trønnes (3): dt-bindings: display: add bindings for MIPI DBI compatible SPI panels drm

[PATCH v4 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-02-18 Thread Noralf Trønnes
v2: - Fix path for panel-common.yaml - Use unevaluatedProperties - Drop properties which are in the allOf section - Drop model property (Rob) Acked-by: Maxime Ripard Signed-off-by: Noralf Trønnes --- .../display/panel/panel-mipi-dbi-spi.yaml | 125 ++ 1 file changed, 125

[PATCH v4 3/3] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-18 Thread Noralf Trønnes
e compatible instead (Rob) - Add wiki entry in MAINTAINERS Acked-by: Maxime Ripard Signed-off-by: Noralf Trønnes --- MAINTAINERS | 8 + drivers/gpu/drm/tiny/Kconfig | 13 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/pa

Re: [PATCH v3 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-02-11 Thread Noralf Trønnes
Den 11.02.2022 14.27, skrev Maxime Ripard: > On Fri, Feb 11, 2022 at 02:04:32PM +0100, Noralf Trønnes wrote: >> Add binding for MIPI DBI compatible SPI panels. >> >> v3: >> - Move properties to Device Tree (Maxime) >> - Use contains for compatible (Maxime) >&

[PATCH v3 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-02-11 Thread Noralf Trønnes
are in the allOf section - Drop model property (Rob) Signed-off-by: Noralf Trønnes --- .../display/panel/panel-mipi-dbi-spi.yaml | 124 ++ 1 file changed, 124 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml diff --git

[PATCH v3 2/3] drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev

2022-02-11 Thread Noralf Trønnes
devm_drm_dev_alloc() can't allocate structures that embed a structure which then again embeds drm_device. Workaround this by adding a driver_private pointer to struct mipi_dbi_dev which the driver can use for its additional state. v3: - Add documentation Signed-off-by: Noralf Trønnes

[PATCH v3 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-02-11 Thread Noralf Trønnes
he command functions so they can be moved to drm_mipi_dbi and shared with a future panel-mipi-dpi-spi driver v2: - Drop model property and use compatible instead (Rob) - Add wiki entry in MAINTAINERS Signed-off-by: Noralf Trønnes --- MAINTAINERS| 8 + drivers/g

[PATCH v3 0/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-02-11 Thread Noralf Trønnes
/panel. Noralf. [1] https://lore.kernel.org/dri-devel/20211129093946.xhp22mvdut3m67sc@houat/ [2] https://github.com/notro/panel-mipi-dbi/blob/main/mipi-dbi-cmd [3] https://github.com/notro/panel-mipi-dbi/wiki Noralf Trønnes (3): dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

Re: [PATCH v2 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-02-09 Thread Noralf Trønnes
Den 09.02.2022 10.04, skrev Maxime Ripard: > Hi Noralf, > > On Tue, Feb 08, 2022 at 01:16:44PM +0100, Noralf Trønnes wrote: >> Den 08.02.2022 00.20, skrev Rob Herring: >>> On Thu, Jan 27, 2022 at 10:37:22AM +0100, Maxime Ripard wrote: >>>> Hi, >>>&g

Re: [PATCH v2 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-02-08 Thread Noralf Trønnes
Den 08.02.2022 00.20, skrev Rob Herring: > On Thu, Jan 27, 2022 at 10:37:22AM +0100, Maxime Ripard wrote: >> Hi, >> >> On Tue, Jan 25, 2022 at 06:56:58PM +0100, Noralf Trønnes wrote: >>> Add binding for MIPI DBI compatible SPI panels. >>> >>> v2

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-02 Thread Noralf Trønnes
Den 02.02.2022 16.04, skrev Pekka Paalanen: > On Wed, 2 Feb 2022 10:45:42 +0100 > Noralf Trønnes wrote: > >> Den 02.02.2022 10.14, skrev Thomas Zimmermann: >>> Hi Noralf, >>> >>> since you're here, I'll just hijack the discussion to ask something o

Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-02-02 Thread Noralf Trønnes
Den 02.02.2022 11.09, skrev Maxime Ripard: > On Thu, Jan 27, 2022 at 06:53:48PM +0100, Noralf Trønnes wrote: >>>> +struct panel_mipi_dbi_config { >>>> + /* Magic string: panel_mipi_dbi_magic */ >>>> + u8 magic[15]; >>>> + >>>> +

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-02 Thread Noralf Trønnes
Den 02.02.2022 10.14, skrev Thomas Zimmermann: > Hi Noralf, > > since you're here, I'll just hijack the discussion to ask something only > semi-related. > > IIRC the gud driver doesn't update the display immediately during atomic > commits. Instead, it instructs a helper thread to do the

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-01 Thread Noralf Trønnes
Den 01.02.2022 14.38, skrev Simon Ser: > > On Tuesday, February 1st, 2022 at 13:58, Noralf Trønnes > wrote: > >> It turned out that I wasn't entirely correct here, mpv didn't cope with >> unknown types. In the PR to add support Emil Velikov wondered if

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-01 Thread Noralf Trønnes
Den 01.02.2022 14.06, skrev Javier Martinez Canillas: > Hello Noralf, > > On 2/1/22 13:58, Noralf Trønnes wrote: >> >> >> Den 31.01.2022 21.52, skrev Sam Ravnborg: >>> On Mon, Jan 31, 2022 at 09:12:21PM +0100, Javier Martinez Canillas wrote: >>&

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-01 Thread Noralf Trønnes
gt;> >> Add an I2C connector type to match the actual connector. >> >> As Noralf Trønnes mentions in commit fc06bf1d76d6 ("drm: Add SPI connector >> type"), user-space should be able to cope with a connector type that does >> not yet understand. >>

Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-01-27 Thread Noralf Trønnes
Den 27.01.2022 20.59, skrev Sam Ravnborg: > Hi Noralf, > > On Tue, Jan 25, 2022 at 06:57:00PM +0100, Noralf Trønnes wrote: >> Add a driver that will work with most MIPI DBI compatible SPI panels. >> This avoids adding a driver for every new MIPI DBI compatible controller

Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-01-27 Thread Noralf Trønnes
Den 27.01.2022 18.19, skrev David Lechner: > On 1/25/22 11:57 AM, Noralf Trønnes wrote: >> Add a driver that will work with most MIPI DBI compatible SPI panels. >> This avoids adding a driver for every new MIPI DBI compatible controller >> that is to be used by Linux. Th

Re: [PATCH v2 0/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-01-27 Thread Noralf Trønnes
Den 27.01.2022 18.13, skrev David Lechner: > On 1/25/22 11:56 AM, Noralf Trønnes wrote: >> Hi, >> >> This patchset adds a driver that will work with most MIPI DBI compatible >> SPI panels out there. >> >> It's a follow up on 'drm/tiny/st7735r: Match up

Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-01-27 Thread Noralf Trønnes
Den 27.01.2022 11.04, skrev Maxime Ripard: > On Tue, Jan 25, 2022 at 06:57:00PM +0100, Noralf Trønnes wrote: >> Add a driver that will work with most MIPI DBI compatible SPI panels. >> This avoids adding a driver for every new MIPI DBI compatible controller >> that i

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Noralf Trønnes
> > Since we got a maintainer for fbdev, I would like to > unorphan fbtft (with the idea of sending PRs to Helge) > and move it out of staging since there is no more clean > up work expected and no more drivers either. > > Thoughts? Here's a driver I have been working on: drm/panel: Add MIPI DBI

[PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-01-25 Thread Noralf Trønnes
patible instead (Rob) - Add wiki entry in MAINTAINERS Signed-off-by: Noralf Trønnes --- MAINTAINERS| 8 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-mipi-dbi.c | 394 + 4 fi

[PATCH v2 0/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-01-25 Thread Noralf Trønnes
) Noralf. [1] https://lore.kernel.org/dri-devel/20211124150757.17929-1-nor...@tronnes.org/ [2] https://lore.kernel.org/dri-devel/20211129093946.xhp22mvdut3m67sc@houat/ Noralf Trønnes (3): dt-bindings: display: add bindings for MIPI DBI compatible SPI panels drm/mipi-dbi: Add driver_private

[PATCH v2 2/3] drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev

2022-01-25 Thread Noralf Trønnes
devm_drm_dev_alloc() can't allocate structures that embed a structure which then again embeds drm_device. Workaround this by adding a driver_private pointer to struct mipi_dbi_dev which the driver can use for its additional state. Signed-off-by: Noralf Trønnes --- include/drm/drm_mipi_dbi.h | 2

[PATCH v2 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-01-25 Thread Noralf Trønnes
Add binding for MIPI DBI compatible SPI panels. v2: - Fix path for panel-common.yaml - Use unevaluatedProperties - Drop properties which are in the allOf section - Drop model property (Rob) Signed-off-by: Noralf Trønnes --- .../display/panel/panel-mipi-dbi-spi.yaml | 59

Re: [PATCH 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-01-24 Thread Noralf Trønnes
Den 24.01.2022 17.42, skrev Rob Herring: > On Mon, Jan 24, 2022 at 10:28 AM Noralf Trønnes wrote: >> >> >> >> Den 24.01.2022 17.08, skrev Rob Herring: >>> On Sun, Jan 23, 2022 at 11:25 AM Noralf Trønnes wrote: >>>> >>>> Add bin

Re: [PATCH 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-01-24 Thread Noralf Trønnes
Den 24.01.2022 17.08, skrev Rob Herring: > On Sun, Jan 23, 2022 at 11:25 AM Noralf Trønnes wrote: >> >> Add binding for MIPI DBI compatible SPI panels. > > I'm sure we already have MIPI DBI panels. What's this for? > It aims to use one driver to cover a

[PATCH 2/3] drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev

2022-01-23 Thread Noralf Trønnes
devm_drm_dev_alloc() can't allocate structures that embed a structure which then again embeds drm_device. Workaround this by adding a driver_private pointer to struct mipi_dbi_dev which the driver can use for its additional state. Signed-off-by: Noralf Trønnes --- include/drm/drm_mipi_dbi.h | 2

[PATCH 0/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-01-23 Thread Noralf Trønnes
://lore.kernel.org/dri-devel/20211129093946.xhp22mvdut3m67sc@houat/ Noralf Trønnes (3): dt-bindings: display: add bindings for MIPI DBI compatible SPI panels drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev drm/panel: Add MIPI DBI compatible SPI driver .../display/panel/panel

[PATCH 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-01-23 Thread Noralf Trønnes
the controller configuration. Signed-off-by: Noralf Trønnes --- MAINTAINERS| 7 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-mipi-dbi.c | 385 + 4 files changed, 404

[PATCH 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-01-23 Thread Noralf Trønnes
Add binding for MIPI DBI compatible SPI panels. Signed-off-by: Noralf Trønnes --- .../display/panel/panel-mipi-dbi-spi.yaml | 69 +++ 1 file changed, 69 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml diff --git

Re: [PATCH] drm/mipi-dbi: Fix source-buffer address in mipi_dbi_buf_copy

2022-01-11 Thread Noralf Trønnes
cy on GEM CMA helper > library") > Reported-by: Noralf Trønnes > Cc: Thomas Zimmermann > Cc: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Maxime Ripard > --- Reviewed-by: Noralf Trønnes

Re: [PATCH v2 1/2] drm/mipi-dbi: Remove dependency on GEM CMA helper library

2022-01-11 Thread Noralf Trønnes
> The MIPI DBI helpers access struct drm_gem_cma_object.vaddr in a > few places. Replace all instances with the correct generic GEM > functions. Use drm_gem_fb_vmap() for mapping a framebuffer's GEM > objects and drm_gem_fb_vunmap() for unmapping them. This removes > the dependency on CMA helpers

Re: [PATCH 53/60] drm/repaper: Add support for the nomodeset kernel parameter

2021-12-16 Thread Noralf Trønnes
systewm system framebuffer will be available if it was set-up. > > But only a few DRM drivers currently check for nomodeset, make this driver > to also support the command line parameter. > > Signed-off-by: Javier Martinez Canillas > --- Acked-by: Noralf Trønnes

Re: [PATCH 52/60] drm/mi0283qt: Add support for the nomodeset kernel parameter

2021-12-16 Thread Noralf Trønnes
systewm system framebuffer will be available if it was set-up. > > But only a few DRM drivers currently check for nomodeset, make this driver > to also support the command line parameter. > > Signed-off-by: Javier Martinez Canillas > --- Acked-by: Noralf Trønnes

Re: [PATCH 11/60] drm/gud: Add support for the nomodeset kernel parameter

2021-12-16 Thread Noralf Trønnes
Den 16.12.2021 09.20, skrev Thomas Zimmermann: > Hi > > Am 15.12.21 um 22:37 schrieb Noralf Trønnes: >> >> >> Den 15.12.2021 01.59, skrev Javier Martinez Canillas: >>> According to disable Documentation/admin-guide/kernel-parameters.txt, >>> thi

Re: [PATCH 11/60] drm/gud: Add support for the nomodeset kernel parameter

2021-12-15 Thread Noralf Trønnes
Den 15.12.2021 01.59, skrev Javier Martinez Canillas: > According to disable Documentation/admin-guide/kernel-parameters.txt, this > parameter can be used to disable kernel modesetting. > > DRM drivers will not perform display-mode changes or accelerated rendering > and only the systewm system

Re: [PATCH 0/6] drm/tiny/st7735r: Match up with staging/fbtft driver

2021-12-06 Thread Noralf Trønnes
Den 06.12.2021 16.26, skrev David Lechner: > On 12/1/21 8:52 AM, Maxime Ripard wrote: >> Hi Noralf, >> >> On Tue, Nov 30, 2021 at 03:30:11PM +0100, Noralf Trønnes wrote: >>> Den 29.11.2021 10.39, skrev Maxime Ripard: >>>> On Wed, Nov 24, 202

Re: [PATCH 3/6] dt-bindings: display: sitronix,st7735r: Remove spi-max-frequency limit

2021-12-06 Thread Noralf Trønnes
Den 06.12.2021 16.19, skrev David Lechner: > On 11/24/21 9:07 AM, Noralf Trønnes wrote: >> The datasheet lists the minimum Serial clock cycle (Write) as 66ns >> which is > > Is this supposed to say "maximum" rather than "minimum"? > Minimum cycle t

Re: [PATCH 0/6] drm/tiny/st7735r: Match up with staging/fbtft driver

2021-11-30 Thread Noralf Trønnes
Den 29.11.2021 10.39, skrev Maxime Ripard: > Hi, > > On Wed, Nov 24, 2021 at 04:03:07PM -0600, David Lechner wrote: >> On 11/24/21 9:07 AM, Noralf Trønnes wrote: >>> This patchset adds a missing piece for decommissioning the >>> staging/fbtft/fb_st7735r.c

Re: [PATCH 0/6] drm/tiny/st7735r: Match up with staging/fbtft driver

2021-11-25 Thread Noralf Trønnes
Den 24.11.2021 23.03, skrev David Lechner: > On 11/24/21 9:07 AM, Noralf Trønnes wrote: >> Hi, >> >> This patchset adds a missing piece for decommissioning the >> staging/fbtft/fb_st7735r.c driver namely a way to configure the >> controller from Device Tree. >

[PATCH] drm/gud: Fix descriptor magic check

2021-11-24 Thread Noralf Trønnes
le32_to_cpu() was put around the wrong operand in the descriptor magic value check. Fix this and put it around the descriptor value which is the one that is in little endian format. Fixes: 40e1a70 ("drm: Add GUD USB Display driver") Reported-by: kernel test robot Signed-off-by: Nora

[PATCH 6/6] drm: tiny: st7735r: Support DT initialization of controller

2021-11-24 Thread Noralf Trønnes
Add support for initializing the controller from device properties when the compatible is "sitronix,st7735r". The rotation property does not apply in this case since a matching ADDRESS_MODE/madctl value is necessary. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tiny/st77

[PATCH 0/6] drm/tiny/st7735r: Match up with staging/fbtft driver

2021-11-24 Thread Noralf Trønnes
7fb.yaml binding in describing the attached panel. That binding prefixes the properties with the vendor name, not sure why that is and I think it looks strange so I try without it. Noralf. Noralf Trønnes (6): dt-bindings: display: sitronix,st7735r: Fix backlight in example dt-bindings: display: sitr

[PATCH 5/6] drm/mipi-dbi: Add device property functions

2021-11-24 Thread Noralf Trønnes
Add helper functions for configuring a MIPI DBI controller from device properties. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_mipi_dbi.c | 139 + include/drm/drm_mipi_dbi.h | 3 + 2 files changed, 142 insertions(+) diff --git a/drivers/gpu/drm

[PATCH 4/6] dt-bindings: display: sitronix, st7735r: Add initialization properties

2021-11-24 Thread Noralf Trønnes
-by: Noralf Trønnes --- .../bindings/display/sitronix,st7735r.yaml| 118 +- 1 file changed, 116 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml index

[PATCH 3/6] dt-bindings: display: sitronix, st7735r: Remove spi-max-frequency limit

2021-11-24 Thread Noralf Trønnes
be messed up by transfer errors and the speed is only limited by the amount of pixel glitches that one is able to tolerate. Signed-off-by: Noralf Trønnes --- .../devicetree/bindings/display/sitronix,st7735r.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

<    1   2   3   4   5   6   7   8   9   10   >