[patch] radeon: handle errors in radeon_hwmon_init()

2010-08-08 Thread Rafał Miłecki
2010/8/8 Dan Carpenter : > Smatch complained that the ERR_PTR from hwmon_device_register() wasn't > handled. ?I added some error handling in radeon_hwmon_init() to silence > the warning. > > Unfortunately errors from radeon_pm_init() aren't handled so this > doesn't really make a difference beyond

Re: [patch] radeon: handle errors in radeon_hwmon_init()

2010-08-07 Thread Rafał Miłecki
2010/8/8 Dan Carpenter : > Smatch complained that the ERR_PTR from hwmon_device_register() wasn't > handled.  I added some error handling in radeon_hwmon_init() to silence > the warning. > > Unfortunately errors from radeon_pm_init() aren't handled so this > doesn't really make a difference beyond

Suspend lockup: How to bisect d-r-t specific commits?

2010-07-28 Thread Rafał Miłecki
W dniu 28 lipca 2010 01:01 u?ytkownik Alex Deucher napisa?: > 2010/7/27 Rafa? Mi?ecki : >> W dniu 27 lipca 2010 17:27 u?ytkownik Alex Deucher >> napisa?: >>> I'm an idiot. ?The sampler state needs to be there as it's not emitted >>> subsequently; ?I was thinking it got emitted with the texture fe

Re: Suspend lockup: How to bisect d-r-t specific commits?

2010-07-28 Thread Rafał Miłecki
W dniu 28 lipca 2010 01:01 użytkownik Alex Deucher napisał: > 2010/7/27 Rafał Miłecki : >> W dniu 27 lipca 2010 17:27 użytkownik Alex Deucher >> napisał: >>> I'm an idiot.  The sampler state needs to be there as it's not emitted >>> subsequently;  I w

Suspend lockup: How to bisect d-r-t specific commits?

2010-07-27 Thread Rafał Miłecki
W dniu 27 lipca 2010 23:53 u?ytkownik Rafa? Mi?ecki napisa?: > W dniu 27 lipca 2010 17:27 u?ytkownik Alex Deucher > napisa?: >> I'm an idiot. ?The sampler state needs to be there as it's not emitted >> subsequently; ?I was thinking it got emitted with the texture fetch >> constants like it does

Suspend lockup: How to bisect d-r-t specific commits?

2010-07-27 Thread Rafał Miłecki
W dniu 27 lipca 2010 17:27 u?ytkownik Alex Deucher napisa?: > I'm an idiot. ?The sampler state needs to be there as it's not emitted > subsequently; ?I was thinking it got emitted with the texture fetch > constants like it does in the ddx. ?That was the issue all along. > Thanks for tracking that

Re: Suspend lockup: How to bisect d-r-t specific commits?

2010-07-27 Thread Rafał Miłecki
W dniu 27 lipca 2010 23:53 użytkownik Rafał Miłecki napisał: > W dniu 27 lipca 2010 17:27 użytkownik Alex Deucher > napisał: >> I'm an idiot.  The sampler state needs to be there as it's not emitted >> subsequently;  I was thinking it got emitted with the texture fet

Re: Suspend lockup: How to bisect d-r-t specific commits?

2010-07-27 Thread Rafał Miłecki
W dniu 27 lipca 2010 17:27 użytkownik Alex Deucher napisał: > I'm an idiot.  The sampler state needs to be there as it's not emitted > subsequently;  I was thinking it got emitted with the texture fetch > constants like it does in the ddx.  That was the issue all along. > Thanks for tracking that

Suspend lockup: How to bisect d-r-t specific commits?

2010-07-27 Thread Rafał Miłecki
W dniu 26 lipca 2010 20:55 u?ytkownik Alex Deucher napisa?: > 2010/7/26 Rafa? Mi?ecki : >> W dniu 26 lipca 2010 07:57 u?ytkownik Alex Deucher >> napisa?: >>> How about v4 (attached)? ?Any better? >> >> I counted up to 9 flashes after resume this time. Didn't try this >> again (maybe different amo

Re: Suspend lockup: How to bisect d-r-t specific commits?

2010-07-26 Thread Rafał Miłecki
W dniu 26 lipca 2010 20:55 użytkownik Alex Deucher napisał: > 2010/7/26 Rafał Miłecki : >> W dniu 26 lipca 2010 07:57 użytkownik Alex Deucher >> napisał: >>> How about v4 (attached)?  Any better? >> >> I counted up to 9 flashes after resume this time. Didn&

Suspend lockup: How to bisect d-r-t specific commits?

2010-07-26 Thread Rafał Miłecki
W dniu 26 lipca 2010 07:57 u?ytkownik Alex Deucher napisa?: > How about v4 (attached)? ?Any better? I counted up to 9 flashes after resume this time. Didn't try this again (maybe different amount of flashses). -- Rafa?

Re: Suspend lockup: How to bisect d-r-t specific commits?

2010-07-26 Thread Rafał Miłecki
W dniu 26 lipca 2010 07:57 użytkownik Alex Deucher napisał: > How about v4 (attached)?  Any better? I counted up to 9 flashes after resume this time. Didn't try this again (maybe different amount of flashses). -- Rafał ___ dri-devel mailing list dri-d

Suspend lockup: How to bisect d-r-t specific commits?

2010-07-25 Thread Rafał Miłecki
W dniu 24 lipca 2010 22:41 u?ytkownik Alex Deucher napisa?: > 2010/7/24 Rafa? Mi?ecki : >> W dniu 21 lipca 2010 19:23 u?ytkownik Alex Deucher >> napisa?: >>> 2010/7/21 Rafa? Mi?ecki : W dniu 21 lipca 2010 11:30 u?ytkownik Rafa? Mi?ecki napisa?: > First bisect try gave me: > ba

Re: Suspend lockup: How to bisect d-r-t specific commits?

2010-07-25 Thread Rafał Miłecki
W dniu 24 lipca 2010 22:41 użytkownik Alex Deucher napisał: > 2010/7/24 Rafał Miłecki : >> W dniu 21 lipca 2010 19:23 użytkownik Alex Deucher >> napisał: >>> 2010/7/21 Rafał Miłecki : >>>> W dniu 21 lipca 2010 11:30 użytkownik Rafał Miłecki >>

Suspend lockup: How to bisect d-r-t specific commits?

2010-07-24 Thread Rafał Miłecki
W dniu 21 lipca 2010 19:23 u?ytkownik Alex Deucher napisa?: > 2010/7/21 Rafa? Mi?ecki : >> W dniu 21 lipca 2010 11:30 u?ytkownik Rafa? Mi?ecki >> napisa?: >>> First bisect try gave me: >>> bad: [d8c253f30d0eb975e5c42c31587ef718517f5067] >>> drm/radeon: optimize default 3D state for r6xx/r7xx bli

Re: Suspend lockup: How to bisect d-r-t specific commits?

2010-07-24 Thread Rafał Miłecki
W dniu 21 lipca 2010 19:23 użytkownik Alex Deucher napisał: > 2010/7/21 Rafał Miłecki : >> W dniu 21 lipca 2010 11:30 użytkownik Rafał Miłecki >> napisał: >>> First bisect try gave me: >>> bad: [d8c253f30d0eb975e5c42c31587ef718517f5067] >>> drm/radeo

Suspend lockup: How to bisect d-r-t specific commits?

2010-07-21 Thread Rafał Miłecki
W dniu 21 lipca 2010 11:30 u?ytkownik Rafa? Mi?ecki napisa?: > First bisect try gave me: > bad: [d8c253f30d0eb975e5c42c31587ef718517f5067] > drm/radeon: optimize default 3D state for r6xx/r7xx blits > > I'm leaving today, not sure if I manage to confirm this before next week. I switched back to

Suspend lockup: How to bisect d-r-t specific commits?

2010-07-21 Thread Rafał Miłecki
W dniu 21 lipca 2010 00:36 u?ytkownik Dave Airlie napisa?: > On Tue, 2010-07-20 at 23:37 +0200, Rafa? Mi?ecki wrote: >> OK, next question :/ How can I rebase local d-r-t onto Linus's tree? >> I've Linus's remote tree added and fetched but can not rebase against >> it. >> >> # git rebase linus >>

Re: Suspend lockup: How to bisect d-r-t specific commits?

2010-07-21 Thread Rafał Miłecki
W dniu 21 lipca 2010 11:30 użytkownik Rafał Miłecki napisał: > First bisect try gave me: > bad: [d8c253f30d0eb975e5c42c31587ef718517f5067] > drm/radeon: optimize default 3D state for r6xx/r7xx blits > > I'm leaving today, not sure if I manage to confirm this before next week.

Re: Suspend lockup: How to bisect d-r-t specific commits?

2010-07-21 Thread Rafał Miłecki
W dniu 21 lipca 2010 00:36 użytkownik Dave Airlie napisał: > On Tue, 2010-07-20 at 23:37 +0200, Rafał Miłecki wrote: >> OK, next question :/ How can I rebase local d-r-t onto Linus's tree? >> I've Linus's remote tree added and fetched but can not rebase against &

Suspend lockup: How to bisect d-r-t specific commits?

2010-07-20 Thread Rafał Miłecki
OK, next question :/ How can I rebase local d-r-t onto Linus's tree? I've Linus's remote tree added and fetched but can not rebase against it. # git rebase linus Current branch drm-radeon-testing is up to date. # git rebase --onto linus drm-radeon-testing Current branch drm-radeon-testing is up t

Suspend lockup: How to bisect d-r-t specific commits?

2010-07-20 Thread Rafał Miłecki
W dniu 20 lipca 2010 13:15 u?ytkownik Marius Gr?ger napisa?: > Am 20.07.2010 12:14, schrieb Rafa? Mi?ecki: >> >> I've installed openSUSE 11.3 which comes with 2.6.34 kernel and added >> 2.6.35-rc5 from package. In both cases suspending and resuming works >> fine. >> >> Then I downloaded 2.6.35-rc5

Suspend lockup: How to bisect d-r-t specific commits?

2010-07-20 Thread Rafał Miłecki
W dniu 20 lipca 2010 20:44 u?ytkownik Alex Deucher napisa?: > Then merge Linus' tree into your local tree: > git pull linus It was just about adding "master" after last one. Thanks a lot! :) -- Rafa?

Suspend lockup: How to bisect d-r-t specific commits?

2010-07-20 Thread Rafał Miłecki
W dniu 20 lipca 2010 18:21 u?ytkownik Alex Deucher napisa?: > The last upstream -rc to get merged into d-r-t was 2.6.35-rc4. ?If > -rc4 works, you could try bisecting from that point: > http://git.kernel.org/?p=linux/kernel/git/airlied/drm-2.6.git;a=commitdiff;h=815c4163b6c8ebf8152f42b0a5fd015cfdc

Re: Suspend lockup: How to bisect d-r-t specific commits?

2010-07-20 Thread Rafał Miłecki
OK, next question :/ How can I rebase local d-r-t onto Linus's tree? I've Linus's remote tree added and fetched but can not rebase against it. # git rebase linus Current branch drm-radeon-testing is up to date. # git rebase --onto linus drm-radeon-testing Current branch drm-radeon-testing is up t

Re: Suspend lockup: How to bisect d-r-t specific commits?

2010-07-20 Thread Rafał Miłecki
W dniu 20 lipca 2010 13:15 użytkownik Marius Gröger napisał: > Am 20.07.2010 12:14, schrieb Rafał Miłecki: >> >> I've installed openSUSE 11.3 which comes with 2.6.34 kernel and added >> 2.6.35-rc5 from package. In both cases suspending and resuming works >> fine

Re: Suspend lockup: How to bisect d-r-t specific commits?

2010-07-20 Thread Rafał Miłecki
W dniu 20 lipca 2010 20:44 użytkownik Alex Deucher napisał: > Then merge Linus' tree into your local tree: > git pull linus It was just about adding "master" after last one. Thanks a lot! :) -- Rafał ___ dri-devel mailing list dri-devel@lists.freedesk

Suspend lockup: How to bisect d-r-t specific commits?

2010-07-20 Thread Rafał Miłecki
I've installed openSUSE 11.3 which comes with 2.6.34 kernel and added 2.6.35-rc5 from package. In both cases suspending and resuming works fine. Then I downloaded 2.6.35-rc5 and compiled it myself. Suspending and resuming works fine. When trying d-r-t with the same config my machine locks up on s

Re: Suspend lockup: How to bisect d-r-t specific commits?

2010-07-20 Thread Rafał Miłecki
W dniu 20 lipca 2010 18:21 użytkownik Alex Deucher napisał: > The last upstream -rc to get merged into d-r-t was 2.6.35-rc4.  If > -rc4 works, you could try bisecting from that point: > http://git.kernel.org/?p=linux/kernel/git/airlied/drm-2.6.git;a=commitdiff;h=815c4163b6c8ebf8152f42b0a5fd015cfdc

Suspend lockup: How to bisect d-r-t specific commits?

2010-07-20 Thread Rafał Miłecki
I've installed openSUSE 11.3 which comes with 2.6.34 kernel and added 2.6.35-rc5 from package. In both cases suspending and resuming works fine. Then I downloaded 2.6.35-rc5 and compiled it myself. Suspending and resuming works fine. When trying d-r-t with the same config my machine locks up on s

[PATCH] drm/radeon/kms: add ioport register access

2010-07-17 Thread Rafał Miłecki
W dniu 17 lipca 2010 11:27 u?ytkownik Dave Airlie napisa?: > 2010/7/17 Rafa? Mi?ecki : >> Dave, last time you decided to push this fix for 2.6.35, then >> resigned. After additional fix from Alex I can see this in drm-next >> only, not in drm-fixes or Linus's tree. Did you change your mind to >>

[PATCH] drm/radeon/kms: add ioport register access

2010-07-17 Thread Rafał Miłecki
Dave, last time you decided to push this fix for 2.6.35, then resigned. After additional fix from Alex I can see this in drm-next only, not in drm-fixes or Linus's tree. Did you change your mind to postpone it until next merge window, or just forgot about this in drm-fixes? -- Rafa?

Re: [PATCH] drm/radeon/kms: add ioport register access

2010-07-17 Thread Rafał Miłecki
W dniu 17 lipca 2010 11:27 użytkownik Dave Airlie napisał: > 2010/7/17 Rafał Miłecki : >> Dave, last time you decided to push this fix for 2.6.35, then >> resigned. After additional fix from Alex I can see this in drm-next >> only, not in drm-fixes or Linus's tree. D

Re: [PATCH] drm/radeon/kms: add ioport register access

2010-07-17 Thread Rafał Miłecki
Dave, last time you decided to push this fix for 2.6.35, then resigned. After additional fix from Alex I can see this in drm-next only, not in drm-fixes or Linus's tree. Did you change your mind to postpone it until next merge window, or just forgot about this in drm-fixes? -- Rafał _

[PATCH] drm/radeon/kms: trivial code style fixes for audio

2010-07-12 Thread Rafał Miłecki
W dniu 25 czerwca 2010 21:24 u?ytkownik Rafa? Mi?ecki napisa?: > Signed-off-by: Rafa? Mi?ecki > --- > Nothing serious, just annoying lack of \n made me touch this. Trivial fixes. > > That's of course for some next merge window. As I said it's trivial but still nice to have :) d-r-t maybe? -- R

Re: [PATCH] drm/radeon/kms: trivial code style fixes for audio

2010-07-12 Thread Rafał Miłecki
W dniu 25 czerwca 2010 21:24 użytkownik Rafał Miłecki napisał: > Signed-off-by: Rafał Miłecki > --- > Nothing serious, just annoying lack of \n made me touch this. Trivial fixes. > > That's of course for some next merge window. As I said it's trivial but still ni

EXA - when does it's implementation depend on DRM?

2010-07-04 Thread Rafał Miłecki
W dniu 4 lipca 2010 22:37 u?ytkownik Dave Airlie napisa?: > 2010/7/5 Rafa? Mi?ecki : >> W dniu 4 lipca 2010 22:24 u?ytkownik Dave Airlie >> napisa?: >>> 2010/7/5 Rafa? Mi?ecki : AFAIU EXA is collection of operations (Solid, Copy, UploadToScreen, DownloadFromScreen) that touch VRAM. So

EXA - when does it's implementation depend on DRM?

2010-07-04 Thread Rafał Miłecki
W dniu 4 lipca 2010 22:24 u?ytkownik Dave Airlie napisa?: > 2010/7/5 Rafa? Mi?ecki : >> AFAIU EXA is collection of operations (Solid, Copy, UploadToScreen, >> DownloadFromScreen) that touch VRAM. So we can tell hardware to move >> xterm window 100px right (Copy) and fill freed place with blue >> (

EXA - when does it's implementation depend on DRM?

2010-07-04 Thread Rafał Miłecki
AFAIU EXA is collection of operations (Solid, Copy, UploadToScreen, DownloadFromScreen) that touch VRAM. So we can tell hardware to move xterm window 100px right (Copy) and fill freed place with blue (Solid). Is that right? So my question is: when implementing EXA (in DDX) needs DRM and when it do

Documentation of DRM's API?

2010-07-04 Thread Rafał Miłecki
W dniu 4 lipca 2010 18:11 u?ytkownik Rafa? Mi?ecki napisa?: > However, generating HTML (make htmldocs) seems to work. I can live > with that, it's fine. OK, HTMLs were generated fine for drm. I can see there are few interesting sections, including Output configuration and Output management. Thi

Documentation of DRM's API?

2010-07-04 Thread Rafał Miłecki
W dniu 4 lipca 2010 18:07 u?ytkownik Rafa? Mi?ecki napisa?: > W dniu 4 lipca 2010 17:54 u?ytkownik Jesse Barnes > napisa?: >> You can edit the DocBook/Makefile to remove the broken docs from the >> build. ?That should get you going with the drm doc itself. > > I removed z8530book.xml but still g

Documentation of DRM's API?

2010-07-04 Thread Rafał Miłecki
W dniu 4 lipca 2010 17:54 u?ytkownik Jesse Barnes napisa?: > You can edit the DocBook/Makefile to remove the broken docs from the > build. ?That should get you going with the drm doc itself. I removed z8530book.xml but still got error. Then removed mcabook.xml and I still get error for "new first

Documentation of DRM's API?

2010-07-04 Thread Rafał Miłecki
Hi, While it's quite easy to track initialization of existing KMS drivers (plus we have http://www.botchco.com/agd5f/?p=50) I am not sure where to find documentation of API. I know driver has to register some outputs/encoders/transmitters related functions that will perform querying and setting. I

[PATCH] drm/radeon/kms: add ioport register access

2010-07-04 Thread Rafał Miłecki
2010/6/30 Alex Deucher : > This is required for the NB_MISC regs on rs780/rs880 which > means HDMI/DVI/DP ports using PCIEPHY won't work without > it. It might also help with s/r (asic init) issues on other > atombios cards. > > Fixes: > https://bugs.freedesktop.org/show_bug.cgi?id=28774 > and simi

Re: EXA - when does it's implementation depend on DRM?

2010-07-04 Thread Rafał Miłecki
W dniu 4 lipca 2010 22:37 użytkownik Dave Airlie napisał: > 2010/7/5 Rafał Miłecki : >> W dniu 4 lipca 2010 22:24 użytkownik Dave Airlie napisał: >>> 2010/7/5 Rafał Miłecki : >>>> AFAIU EXA is collection of operations (Solid, Copy, UploadToScreen, >>>>

Re: EXA - when does it's implementation depend on DRM?

2010-07-04 Thread Rafał Miłecki
W dniu 4 lipca 2010 22:24 użytkownik Dave Airlie napisał: > 2010/7/5 Rafał Miłecki : >> AFAIU EXA is collection of operations (Solid, Copy, UploadToScreen, >> DownloadFromScreen) that touch VRAM. So we can tell hardware to move >> xterm window 100px right (Copy) and fill

EXA - when does it's implementation depend on DRM?

2010-07-04 Thread Rafał Miłecki
AFAIU EXA is collection of operations (Solid, Copy, UploadToScreen, DownloadFromScreen) that touch VRAM. So we can tell hardware to move xterm window 100px right (Copy) and fill freed place with blue (Solid). Is that right? So my question is: when implementing EXA (in DDX) needs DRM and when it do

Re: Documentation of DRM's API?

2010-07-04 Thread Rafał Miłecki
W dniu 4 lipca 2010 18:11 użytkownik Rafał Miłecki napisał: > However, generating HTML (make htmldocs) seems to work. I can live > with that, it's fine. OK, HTMLs were generated fine for drm. I can see there are few interesting sections, including Output configuration and Output

Re: Documentation of DRM's API?

2010-07-04 Thread Rafał Miłecki
W dniu 4 lipca 2010 18:07 użytkownik Rafał Miłecki napisał: > W dniu 4 lipca 2010 17:54 użytkownik Jesse Barnes > napisał: >> You can edit the DocBook/Makefile to remove the broken docs from the >> build.  That should get you going with the drm doc itself. > > I removed

Re: Documentation of DRM's API?

2010-07-04 Thread Rafał Miłecki
W dniu 4 lipca 2010 17:54 użytkownik Jesse Barnes napisał: > You can edit the DocBook/Makefile to remove the broken docs from the > build.  That should get you going with the drm doc itself. I removed z8530book.xml but still got error. Then removed mcabook.xml and I still get error for "new first

Documentation of DRM's API?

2010-07-04 Thread Rafał Miłecki
Hi, While it's quite easy to track initialization of existing KMS drivers (plus we have http://www.botchco.com/agd5f/?p=50) I am not sure where to find documentation of API. I know driver has to register some outputs/encoders/transmitters related functions that will perform querying and setting. I

Re: [PATCH] drm/radeon/kms: add ioport register access

2010-07-04 Thread Rafał Miłecki
how_bug.cgi?id=28774 > and similar issues reported by Alberto Milone. > > Signed-off-by: Alex Deucher Tested-by: Rafał Miłecki It really fixes FDO #28774, thanks Alex. As this is not regression fix, I guess it'll go for .36? -- Rafał

[PATCH] drm/radeon/kms/pm: fix power state indexing on igp chips in dynpm mode

2010-06-25 Thread Rafał Miłecki
2010/6/25 Alex Deucher : > Fixes: > https://bugs.freedesktop.org/show_bug.cgi?id=28745 > > Signed-off-by: Alex Deucher This fixes div by 0 which kills my machine, so I really would like to see this in .35 -- Rafa?

[PATCH] drm/radeon/kms/pm: fix power state indexing on igp chips in dynpm mode

2010-06-25 Thread Rafał Miłecki
2010/6/25 Alex Deucher : > Fixes: > https://bugs.freedesktop.org/show_bug.cgi?id=28745 > > Signed-off-by: Alex Deucher Tested-by: Rafa? Mi?ecki -- Rafa?

[PATCH] drm/radeon/kms: trivial code style fixes for audio

2010-06-25 Thread Rafał Miłecki
Signed-off-by: Rafa? Mi?ecki --- Nothing serious, just annoying lack of \n made me touch this. Trivial fixes. That's of course for some next merge window. --- drivers/gpu/drm/radeon/r600_audio.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/

Re: [PATCH] drm/radeon/kms/pm: fix power state indexing on igp chips in dynpm mode

2010-06-25 Thread Rafał Miłecki
2010/6/25 Alex Deucher : > Fixes: > https://bugs.freedesktop.org/show_bug.cgi?id=28745 > > Signed-off-by: Alex Deucher This fixes div by 0 which kills my machine, so I really would like to see this in .35 -- Rafał ___ dri-devel mailing list dri-devel@

Re: [PATCH] drm/radeon/kms/pm: fix power state indexing on igp chips in dynpm mode

2010-06-25 Thread Rafał Miłecki
2010/6/25 Alex Deucher : > Fixes: > https://bugs.freedesktop.org/show_bug.cgi?id=28745 > > Signed-off-by: Alex Deucher Tested-by: Rafał Miłecki -- Rafał ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop

[PATCH] drm/radeon/kms: trivial code style fixes for audio

2010-06-25 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki --- Nothing serious, just annoying lack of \n made me touch this. Trivial fixes. That's of course for some next merge window. --- drivers/gpu/drm/radeon/r600_audio.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/driver

[RFT][PATCH 2/2] drm/radeon/kms: enable HDMI audio on RS600/RS690.

2010-06-19 Thread Rafał Miłecki
We will need method of selecting encoder that should receive HDMI block. For now we assign HDMI block to first enabled encoder. Hopefully there are not many RS6x0 chips with two digital encoders. Signed-off-by: Rafa? Mi?ecki --- Is there anyone with RS6x0 and HDMI audio received around? --- driv

[PATCH 1/2] drm/radeon/kms: track audio engine state, do not use not setup timer

2010-06-19 Thread Rafał Miłecki
This is needed to enable audio support on devices using polling. In case user decides to disable audio (module parameter) we still will try to use timer in r600_audio_enable_polling. This would lead to BUG in kernel/timer.c. Signed-off-by: Rafa? Mi?ecki --- Dave: I think we should not hit this wi

[RFT][PATCH 2/2] drm/radeon/kms: enable HDMI audio on RS600/RS690.

2010-06-19 Thread Rafał Miłecki
We will need method of selecting encoder that should receive HDMI block. For now we assign HDMI block to first enabled encoder. Hopefully there are not many RS6x0 chips with two digital encoders. Signed-off-by: Rafał Miłecki --- Is there anyone with RS6x0 and HDMI audio received around

[PATCH 1/2] drm/radeon/kms: track audio engine state, do not use not setup timer

2010-06-19 Thread Rafał Miłecki
This is needed to enable audio support on devices using polling. In case user decides to disable audio (module parameter) we still will try to use timer in r600_audio_enable_polling. This would lead to BUG in kernel/timer.c. Signed-off-by: Rafał Miłecki --- Dave: I think we should not hit this

[PATCH] DRM / radeon / PM: Do not evict VRAM during freeze phase of hibernation

2010-06-18 Thread Rafał Miłecki
2010/6/18 Rafael J. Wysocki : > From: Rafael J. Wysocki Thanks for you recent involvement in radeon driver! I can see you used way shorter commit title this time ;) Just as a minor note, maybe you could follow prefix-style we used to see around? Like simple "drm/radeon/pm"? Or eventually somethin

Re: [PATCH] DRM / radeon / PM: Do not evict VRAM during freeze phase of hibernation

2010-06-18 Thread Rafał Miłecki
2010/6/18 Rafael J. Wysocki : > From: Rafael J. Wysocki Thanks for you recent involvement in radeon driver! I can see you used way shorter commit title this time ;) Just as a minor note, maybe you could follow prefix-style we used to see around? Like simple "drm/radeon/pm"? Or eventually somethin

[Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300

2010-06-14 Thread Rafał Miłecki
2010/6/14 Rafael J. Wysocki : > On Monday, June 14, 2010, Alex Deucher wrote: >> On Mon, Jun 14, 2010 at 10:53 AM, Rafael J. Wysocki wrote: >> > Alex, Dave, >> > >> > I'm afraid hibernation is broken on all machines using radeon/KMS with r300 >> > after commit ce8f53709bf440100cb9d31b1303291551cf5

Re: [Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300

2010-06-14 Thread Rafał Miłecki
2010/6/14 Rafael J. Wysocki : > On Monday, June 14, 2010, Alex Deucher wrote: >> On Mon, Jun 14, 2010 at 10:53 AM, Rafael J. Wysocki wrote: >> > Alex, Dave, >> > >> > I'm afraid hibernation is broken on all machines using radeon/KMS with r300 >> > after commit ce8f53709bf440100cb9d31b1303291551cf5

[PATCH] drm/radeon/kms: fix regressions in CS checker due to r6xx tiling changes

2010-06-09 Thread Rafał Miłecki
W dniu 9 czerwca 2010 16:25 u?ytkownik Alex Deucher napisa?: > 2010/6/9 Rafa? Mi?ecki : >> Any news on that? Maybe you can get it as is (for d-r-t) Dave and >> eventually get another patch later? > > I have a set of rebased patches built against drm-fixes (including > Matt's suggestion), but there

[PATCH] drm/radeon/kms: fix regressions in CS checker due to r6xx tiling changes

2010-06-09 Thread Rafał Miłecki
Any news on that? Maybe you can get it as is (for d-r-t) Dave and eventually get another patch later? -- Rafa?

Re: [PATCH] drm/radeon/kms: fix regressions in CS checker due to r6xx tiling changes

2010-06-09 Thread Rafał Miłecki
W dniu 9 czerwca 2010 16:25 użytkownik Alex Deucher napisał: > 2010/6/9 Rafał Miłecki : >> Any news on that? Maybe you can get it as is (for d-r-t) Dave and >> eventually get another patch later? > > I have a set of rebased patches built against drm-fixes (including >

Re: [PATCH] drm/radeon/kms: fix regressions in CS checker due to r6xx tiling changes

2010-06-09 Thread Rafał Miłecki
Any news on that? Maybe you can get it as is (for d-r-t) Dave and eventually get another patch later? -- Rafał ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/2] drm/radeon/kms/r600+: do not set the same voltage as current one

2010-06-07 Thread Rafał Miłecki
W dniu 7 czerwca 2010 18:24 u?ytkownik Alex Deucher napisa?: > Only VOLTAGE_SW uses current_vddc so it's irrelevant for other voltage types. I introduced displaying this value in radeom_pm_info debugfs in next patch. -- Rafa?

[PATCH 1/2] drm/radeon/kms/r600+: do not set the same voltage as current one

2010-06-07 Thread Rafał Miłecki
W dniu 7 czerwca 2010 18:09 u?ytkownik Alex Deucher napisa?: > 2010/6/7 Rafa? Mi?ecki : >> W dniu 7 czerwca 2010 07:00 u?ytkownik Alex Deucher >> napisa?: >>> 2010/6/6 Rafa? Mi?ecki : We have similar tracking for engine and memory. We could think about some solution for older GPUs as we

[PATCH 1/2] drm/radeon/kms/r600+: do not set the same voltage as current one

2010-06-07 Thread Rafał Miłecki
W dniu 7 czerwca 2010 07:00 u?ytkownik Alex Deucher napisa?: > 2010/6/6 Rafa? Mi?ecki : >> We have similar tracking for engine and memory. We could think about some >> solution for older GPUs as well, however there are not strict voltage values >> set. >> >> Signed-off-by: Rafa? Mi?ecki > > I act

Re: [PATCH 1/2] drm/radeon/kms/r600+: do not set the same voltage as current one

2010-06-07 Thread Rafał Miłecki
W dniu 7 czerwca 2010 18:24 użytkownik Alex Deucher napisał: > Only VOLTAGE_SW uses current_vddc so it's irrelevant for other voltage types. I introduced displaying this value in radeom_pm_info debugfs in next patch. -- Rafał ___ dri-devel mailing lis

Re: [PATCH 1/2] drm/radeon/kms/r600+: do not set the same voltage as current one

2010-06-07 Thread Rafał Miłecki
W dniu 7 czerwca 2010 18:09 użytkownik Alex Deucher napisał: > 2010/6/7 Rafał Miłecki : >> W dniu 7 czerwca 2010 07:00 użytkownik Alex Deucher >> napisał: >>> 2010/6/6 Rafał Miłecki : >>>> We have similar tracking for engine and memory. We could think about

Re: [PATCH 1/2] drm/radeon/kms/r600+: do not set the same voltage as current one

2010-06-07 Thread Rafał Miłecki
W dniu 7 czerwca 2010 07:00 użytkownik Alex Deucher napisał: > 2010/6/6 Rafał Miłecki : >> We have similar tracking for engine and memory. We could think about some >> solution for older GPUs as well, however there are not strict voltage values >> set. >> >> Si

[PATCH] drm/radeon/kms/pm: resurrect printing power states

2010-06-06 Thread Rafał Miłecki
Signed-off-by: Rafa? Mi?ecki --- Alex you dropped this in "rework power management". Did you have some reason for doing that? Or was that just accident? --- drivers/gpu/drm/radeon/radeon_pm.c | 45 1 files changed, 45 insertions(+), 0 deletions(-) diff --gi

[PATCH 2/2] drm/radeon/kms: add trivial debugging for voltage

2010-06-06 Thread Rafał Miłecki
Signed-off-by: Rafa? Mi?ecki --- drivers/gpu/drm/radeon/evergreen.c |1 + drivers/gpu/drm/radeon/r600.c |1 + drivers/gpu/drm/radeon/radeon_pm.c |2 ++ drivers/gpu/drm/radeon/rv770.c |1 + 4 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/rade

[PATCH 1/2] drm/radeon/kms/r600+: do not set the same voltage as current one

2010-06-06 Thread Rafał Miłecki
We have similar tracking for engine and memory. We could think about some solution for older GPUs as well, however there are not strict voltage values set. Signed-off-by: Rafa? Mi?ecki --- drivers/gpu/drm/radeon/evergreen.c |8 ++-- drivers/gpu/drm/radeon/r600.c |8 ++-- dri

[PATCH 0/2] Little voltage improvements

2010-06-06 Thread Rafał Miłecki
Patches simply add tracking of voltage and debug setting it. While it may look trivial and not important, having it would save a lot of time in debugging FDO bug #36081. This way I try to say it could be nice to have it in .35 as voltage stuff is new and we still may discover some bugs around it.

[PATCH V3] drm/radeon/kms/r600+: use voltage from requested clock mode

2010-06-06 Thread Rafał Miłecki
Signed-off-by: Rafa? Mi?ecki --- This fixes FDO bug #28375, it's kind of regression, so quite important to have it for .35. V2: Fix on RV770+ as well. All other chipsets have only one clock mode per state. V3: I'm out of luck today. Grepped for voltage in r*.c and missed evergreen. --- drivers/

[PATCH V2] drm/radeon/kms/r600+: use voltage from requested clock mode

2010-06-06 Thread Rafał Miłecki
Signed-off-by: Rafa? Mi?ecki --- This fixes FDO bug #28375, must have for .35 V2: Fix on RV770+ as well. All other chipsets have only one clock mode per state. --- drivers/gpu/drm/radeon/r600.c |8 drivers/gpu/drm/radeon/rv770.c |7 --- 2 files changed, 8 insertions(+), 7 d

[PATCH] drm/radeon/kms/r600+: use voltage from requested clock mode

2010-06-06 Thread Rafał Miłecki
Signed-off-by: Rafa? Mi?ecki --- This fixes FDO bug #28375, must have for .35 --- drivers/gpu/drm/radeon/r600.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c index d84d7cf..94c27d0 100644 --- a/drivers

[PATCH] drm/radeon/kms/pm: resurrect printing power states

2010-06-06 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki --- Alex you dropped this in "rework power management". Did you have some reason for doing that? Or was that just accident? --- drivers/gpu/drm/radeon/radeon_pm.c | 45 1 files changed, 45 insertions(+), 0 deletion

[PATCH 1/2] drm/radeon/kms/r600+: do not set the same voltage as current one

2010-06-06 Thread Rafał Miłecki
We have similar tracking for engine and memory. We could think about some solution for older GPUs as well, however there are not strict voltage values set. Signed-off-by: Rafał Miłecki --- drivers/gpu/drm/radeon/evergreen.c |8 ++-- drivers/gpu/drm/radeon/r600.c |8

[PATCH 2/2] drm/radeon/kms: add trivial debugging for voltage

2010-06-06 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki --- drivers/gpu/drm/radeon/evergreen.c |1 + drivers/gpu/drm/radeon/r600.c |1 + drivers/gpu/drm/radeon/radeon_pm.c |2 ++ drivers/gpu/drm/radeon/rv770.c |1 + 4 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 0/2] Little voltage improvements

2010-06-06 Thread Rafał Miłecki
. Rafał Miłecki (2): drm/radeon/kms/r600+: do not set the same voltage as current one drm/radeon/kms: add trivial debugging for voltage drivers/gpu/drm/radeon/evergreen.c |9 +++-- drivers/gpu/drm/radeon/r600.c |9 +++-- drivers/gpu/drm/radeon/radeon.h|1 + drivers

[PATCH V3] drm/radeon/kms/r600+: use voltage from requested clock mode

2010-06-06 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki --- This fixes FDO bug #28375, it's kind of regression, so quite important to have it for .35. V2: Fix on RV770+ as well. All other chipsets have only one clock mode per state. V3: I'm out of luck today. Grepped for voltage in r*.c and missed evergreen. --

[PATCH V2] drm/radeon/kms/r600+: use voltage from requested clock mode

2010-06-06 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki --- This fixes FDO bug #28375, must have for .35 V2: Fix on RV770+ as well. All other chipsets have only one clock mode per state. --- drivers/gpu/drm/radeon/r600.c |8 drivers/gpu/drm/radeon/rv770.c |7 --- 2 files changed, 8 insertions(+), 7

[PATCH] drm/radeon/kms/r600+: use voltage from requested clock mode

2010-06-06 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki --- This fixes FDO bug #28375, must have for .35 --- drivers/gpu/drm/radeon/r600.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c index d84d7cf..94c27d0 100644 --- a

[PATCH] drm/radeon/kms: r600 dump last 64 dwords of ring.

2010-06-04 Thread Rafał Miłecki
W dniu 4 czerwca 2010 21:55 u?ytkownik Jerome Glisse napisa?: > On Fri, Jun 04, 2010 at 02:54:42PM +0200, Rafa? Mi?ecki wrote: >> 2010/6/4 Jerome Glisse : >> > Instead of dumping unprocessed dwords, dump the last 64 >> > dwords of the ring. This make debugging of some case easier. >> > >> > Signed

[PATCH] drm/radeon/kms: r600 dump last 64 dwords of ring.

2010-06-04 Thread Rafał Miłecki
2010/6/4 Jerome Glisse : > Instead of dumping unprocessed dwords, dump the last 64 > dwords of the ring. This make debugging of some case easier. > > Signed-off-by: Jerome Glisse > --- > ?drivers/gpu/drm/radeon/r600.c | ? ?6 +++--- > ?1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH] drm/radeon/kms: r600 dump last 64 dwords of ring.

2010-06-04 Thread Rafał Miłecki
W dniu 4 czerwca 2010 21:55 użytkownik Jerome Glisse napisał: > On Fri, Jun 04, 2010 at 02:54:42PM +0200, Rafał Miłecki wrote: >> 2010/6/4 Jerome Glisse : >> > Instead of dumping unprocessed dwords, dump the last 64 >> > dwords of the ring. This make de

Re: [PATCH] drm/radeon/kms: r600 dump last 64 dwords of ring.

2010-06-04 Thread Rafał Miłecki
2010/6/4 Jerome Glisse : > Instead of dumping unprocessed dwords, dump the last 64 > dwords of the ring. This make debugging of some case easier. > > Signed-off-by: Jerome Glisse > --- >  drivers/gpu/drm/radeon/r600.c |    6 +++--- >  1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git

[PATCH] drm/radeon/kms/pm: add support for SetVoltage cmd table (V2)

2010-06-04 Thread Rafał Miłecki
2010/5/28 Alex Deucher : > diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c > index dac2534..d84d7cf 100644 > --- a/drivers/gpu/drm/radeon/r600.c > +++ b/drivers/gpu/drm/radeon/r600.c > @@ -475,6 +475,12 @@ void r600_pm_init_profile(struct radeon_device *rdev) > > ?void r6

[PATCH] drm/radeon/kms/pm: voltage fixes

2010-06-04 Thread Rafał Miłecki
2010/5/27 Alex Deucher : > diff --git a/drivers/gpu/drm/radeon/radeon_combios.c > b/drivers/gpu/drm/radeon/radeon_combios.c > index 7b5e10d..102c744 100644 > --- a/drivers/gpu/drm/radeon/radeon_combios.c > +++ b/drivers/gpu/drm/radeon/radeon_combios.c > @@ -2454,7 +2454,12 @@ default_mode: > ? ? ?

Re: [PATCH] drm/radeon/kms/pm: add support for SetVoltage cmd table (V2)

2010-06-03 Thread Rafał Miłecki
2010/5/28 Alex Deucher : > diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c > index dac2534..d84d7cf 100644 > --- a/drivers/gpu/drm/radeon/r600.c > +++ b/drivers/gpu/drm/radeon/r600.c > @@ -475,6 +475,12 @@ void r600_pm_init_profile(struct radeon_device *rdev) > >  void r6

Re: [PATCH] drm/radeon/kms/pm: voltage fixes

2010-06-03 Thread Rafał Miłecki
2010/5/27 Alex Deucher : > diff --git a/drivers/gpu/drm/radeon/radeon_combios.c > b/drivers/gpu/drm/radeon/radeon_combios.c > index 7b5e10d..102c744 100644 > --- a/drivers/gpu/drm/radeon/radeon_combios.c > +++ b/drivers/gpu/drm/radeon/radeon_combios.c > @@ -2454,7 +2454,12 @@ default_mode: >      

[PATCH 1/2] drm/radeon/kms: reset ddc_bus in object header parsing

2010-05-19 Thread Rafał Miłecki
2010/5/19 Alex Deucher : > Some LVDS connectors don't have a ddc bus, so reset the > ddc bus to invalid before parsing the next connector > to avoid using stale ddc bus data. ?Should fix > fdo bug 28164. It does, thanks :) Tested-by: Rafa? Mi?ecki -- Rafa?

Re: [PATCH 1/2] drm/radeon/kms: reset ddc_bus in object header parsing

2010-05-18 Thread Rafał Miłecki
2010/5/19 Alex Deucher : > Some LVDS connectors don't have a ddc bus, so reset the > ddc bus to invalid before parsing the next connector > to avoid using stale ddc bus data.  Should fix > fdo bug 28164. It does, thanks :) Tested-by: Rafał Mi

<    1   2   3   4   5   6   >