it6505->auto_train_retry = AUTO_TRAIN_RETRY;
>
> if (it6505->dpcd[0] == 0) {
> @@ -2960,8 +2964,11 @@ static void it6505_bridge_atomic_disable(struct
> drm_bridge *bridge,
>
> DRM_DEV_DEBUG_DRIVER(dev, "start");
>
> - if (it6505->powered)
> +
On Fri, 29 Apr 2022 at 11:49, Jagan Teki wrote:
>
> Hi Robert,
>
> Can you apply this?
>
Thanks for the reminder.
Applied to drm-misc-next.
> On Thu, Mar 31, 2022 at 8:22 PM Robert Foss wrote:
> >
> > On Thu, 31 Mar 2022 at 16:50, Jagan Teki wrote:
> >
t drm_bridge bridge;
> - struct drm_connector connector;
> struct regulator *regulator;
> struct drm_bridge *panel_bridge;
> bool pre_enabled;
> --
> 2.35.1
>
Reviewed-by: Robert Foss
Applied to drm-misc-next.
ADV7511_REG_CEC_RX_FRAME_DATA0 + 14:
> - case ADV7511_REG_CEC_RX_FRAME_LEN:
> + case ADV7511_REG_CEC_RX1_FRAME_HDR:
> + case ADV7511_REG_CEC_RX1_FRAME_DATA0...
> + ADV7511_REG_CEC_RX1_FRAME_DATA0 + 14:
> + case ADV7511_REG_CEC_RX1_FRAME_LEN:
> + case ADV7511_REG_CEC_RX2_FRAME_HDR:
> + case ADV7511_REG_CEC_RX2_FRAME_DATA0...
> + ADV7511_REG_CEC_RX2_FRAME_DATA0 + 14:
> + case ADV7511_REG_CEC_RX2_FRAME_LEN:
> + case ADV7511_REG_CEC_RX3_FRAME_HDR:
> + case ADV7511_REG_CEC_RX3_FRAME_DATA0...
> + ADV7511_REG_CEC_RX3_FRAME_DATA0 + 14:
> + case ADV7511_REG_CEC_RX3_FRAME_LEN:
> + case ADV7511_REG_CEC_RX_STATUS:
> case ADV7511_REG_CEC_RX_BUFFERS:
> case ADV7511_REG_CEC_TX_LOW_DRV_CNT:
> return true;
This is a bit of a nitpick, but the syntax of these "case X...Y"
statements was kind of hard to parse, do you mind putting them on one
line?
With or without the above suggestion fixed, r-b.
Reviewed-by: Robert Foss
);
> struct adv7511 *adv7511 = i2c_get_clientdata(i2c);
>
> - if (adv7511->type == ADV7533 || adv7511->type == ADV7535)
> - reg -= ADV7533_REG_CEC_OFFSET;
> + reg -= adv7511->reg_cec_offset;
>
> switch (reg) {
> case ADV7511_REG_CEC_RX_FRAME_HDR:
> @@ -1073,6 +1072,8 @@ static int adv7511_init_cec_regmap(struct adv7511 *adv)
> ret = adv7533_patch_cec_registers(adv);
> if (ret)
> goto err;
> +
> + adv->reg_cec_offset = ADV7533_REG_CEC_OFFSET;
> }
>
> return 0;
Reviewed-by: Robert Foss
ailed to set DSI phy mode: %d\n", ret);
> + goto uninit_phy;
> + }
> +
> ret = phy_configure(dsi->phy, phy_cfg);
> if (ret < 0) {
> DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n", ret);
> --
> 2.25.1
>
Acked-by: Robert Foss
On Fri, 22 Apr 2022 at 16:01, Robert Foss wrote:
>
> On Fri, 22 Apr 2022 at 10:49, Xin Ji wrote:
> >
> > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> >
> > Fixes
Acked-by: Robert Foss
$ref: /schemas/graph.yaml#/properties/port
> @@ -143,6 +158,8 @@ examples:
> reg = <0>;
> anx7625_in: endpoint {
> remote-endpoint = <&mipi_dsi>;
> +bus-type = <7>;
> +data-lanes = <0 1 2 3>;
> };
> };
>
Reviewed-by: Robert Foss
e == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> + pdata->is_dpi = 1;
>
> pdata->mipi_lanes = mipi_lanes;
> if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
Reviewed-by: Robert Foss
Applied to drm-misc-next.
it6505 depends on DRM_DP_AUX_BUS, the kconfig for it6505 should
reflect this dependency using 'select'.
Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
Reported-by: kernel test robot
Suggested-by: Randy Dunlap
Signed-off-by: Robert Foss
---
drivers/gpu/drm/bridge/K
quot;, dp);
> if (ret) {
> dev_err(&pdev->dev, "failed to request irq\n");
> - return ERR_PTR(ret);
> + goto err_disable_clk;
> }
> disable_irq(dp->irq);
>
> return dp;
> +
> +err_disable_clk:
> + clk_disable_unprepare(dp->clock);
> + return ERR_PTR(ret);
> }
> EXPORT_SYMBOL_GPL(analogix_dp_probe);
>
Reviewed-by: Robert Foss
Applied to drm-misc-next.
by: Marek Vasut
> Cc: Jagan Teki
> Cc: Laurent Pinchart
> Cc: Maxime Ripard
> Cc: Robert Foss
> Cc: Sam Ravnborg
> Cc: Thomas Zimmermann
> To: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/bridge/chipone-icn6211.c | 23 +--
> 1 fil
On Fri, 8 Apr 2022 at 10:21, AngeloGioacchino Del Regno
wrote:
>
> Il 08/04/22 03:30, Nícolas F. R. A. Prado ha scritto:
> > As defined in the anx7625 dt-binding, the analogix,lane0-swing and
> > analogix,lane1-swing properties are uint8 arrays. Yet, the driver was
> > reading the array as if it w
bridge->encoder);
> >
> > - if (connector->funcs->reset)
> > - connector->funcs->reset(connector);
> > + if (bridge->dev->registered) {
> > + if (connector->funcs->reset)
> > + connector->funcs->reset(connector);
> > + drm_connector_register(connector);
> > + }
>
> Reviewed-by: Jagan Teki
Fixed typos in commit message.
Reviewed-by: Robert Foss
Applied to drm-misc-next
adv7511->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID;
> + if (adv7511->i2c_main->irq)
> + adv7511->bridge.ops |= DRM_BRIDGE_OP_HPD;
> +
> adv7511->bridge.of_node = dev->of_node;
> adv7511->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
>
Reviewed-by: Robert Foss
Applied to drm-misc-next
;
> Reviewed-by: Rob Herring
> Signed-off-by: Marek Vasut
> Cc: Laurent Pinchart
> Cc: Lucas Stach
> Cc: Maxime Ripard
> Cc: Rob Herring
> Cc: Robert Foss
> Cc: Sam Ravnborg
> Cc: Thomas Zimmermann
> Cc: devicet...@vger.kernel.org
> To: dri-devel@lists.free
On Tue, 19 Apr 2022 at 04:29, Xin Ji wrote:
>
> On Thu, Apr 14, 2022 at 05:00:04PM +0800, Hsin-Yi Wang wrote:
> > Speaker may share I2S with DP and .get_eld callback will be called when
> > speaker is playing. When HDMI wans't connected, the connector will be
> > null. Instead of return an error,
s behavior has
> at least a comment around it.
>
> Currently the only mode tested is Single-link DSI to Single-link LVDS.
> Dual-link LVDS might work as well, the register programming is in place,
> but is untested.
>
> Signed-off-by: Marek Vasut
> Cc: Laurent Pinchart
> C
On Sat, 9 Apr 2022 at 06:47, Xin Ji wrote:
>
> On Mon, Apr 04, 2022 at 12:52:14PM -0500, Rob Herring wrote:
> > On Mon, Mar 28, 2022 at 08:09:54PM +0800, Xin Ji wrote:
> > > Change bus-type define for DPI.
> > >
> > > Fixes: a43661e7e819 ("dt-bindings:drm/bridge:anx7625:add vendor define")
> > >
>
Applied to drm-misc-next.
igned-off-by: Marek Vasut
> Cc: Jagan Teki
> Cc: Maxime Ripard
> Cc: Robert Foss
> Cc: Sam Ravnborg
> Cc: Stephen Rothwell
> Cc: Thomas Zimmermann
> To: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/bridge/chipone-icn6211.c | 2 +-
> 1 file changed, 1
drm_of_panel_bridge_remove() to remove the
> > bridge from ->detach(). So, let's drop the drm_of_panel_bridge_remove()
> > function call. As nwl_dsi_bridge_detach() only calls
> > drm_of_panel_bridge_remove(), it can also be dropped.
> >
> > Cc: Robert Foss
&
Applied to drm-misc-next.
Philippe, Chun-Kuang,
I applied this patch without realizing it is outside of my maintainer
domain, and caused conflict in dim-tip, which I've resolved.
Even with the conflict resolved, I think getting an AB after the fact
would be good.
Sorry about the inconvenience.
Applied to drm-misc-next.
> - if (ret)
> - return ret;
> -
> - dsi->device_found = true;
> - }
> -
> /* Attach the panel-bridge to the dsi bridge */
> return drm_bridge_attach(bridge->encoder, dsi->panel_bridge, bridge,
> flags);
> @@ -1217,7 +1190,6 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
> #ifdef CONFIG_OF
> dsi->bridge.of_node = pdev->dev.of_node;
> #endif
> - drm_bridge_add(&dsi->bridge);
>
> return dsi;
> }
> --
> 2.25.1
>
Reviewed-by: Robert Foss
M_MODE_CONNECTOR_DSI);
> - if (IS_ERR(bridge))
> - return PTR_ERR(bridge);
> - }
> + bridge = devm_drm_of_get_bridge(dsi->dev, dsi->dev->of_node, 1, 0);
> + if (IS_ERR(bridge))
> + return PTR_ERR(bridge);
>
> dsi->panel_bridge = bridge;
>
> --
> 2.25.1
>
Reviewed-by: Robert Foss
d(dev, panel);
> - if (IS_ERR(dsi->next_bridge)) {
> - ret = PTR_ERR(dsi->next_bridge);
> - goto err_unregister_host;
> - }
> }
>
> dsi->driver_data = of_device_get_match_data(dev);
> --
> 2.25.1
>
Reviewed-by: Robert Foss
On Thu, 31 Mar 2022 at 17:43, Robert Foss wrote:
>
> On Thu, 31 Mar 2022 at 17:39, Marek Vasut wrote:
> >
> > Use the atomic version of the enable/disable operations to continue the
> > transition to the atomic API. This will be needed to access the mode
> > from th
t = drm_atomic_helper_bridge_reset,
> + .atomic_get_input_bus_fmts = lt9611_atomic_get_input_bus_fmts,
> };
>
> static int lt9611_parse_dt(struct device *dev,
> --
> 2.35.1
>
Reviewed-by: Robert Foss
tate = drm_atomic_helper_bridge_duplicate_state,
> + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
> + .atomic_reset = drm_atomic_helper_bridge_reset,
> };
>
> static int lt9611_parse_dt(struct device *dev,
> --
> 2.35.1
>
Reviewed-by: Robert Foss
On Thu, 31 Mar 2022 at 17:32, Robert Foss wrote:
>
> On Sun, 13 Feb 2022 at 03:27, Marek Vasut wrote:
> >
> > In rare cases, the bridge may not start up correctly, which usually
> > leads to no display output. In case this happens, warn about it in
> > the ker
nt Pinchart
> Cc: Linus Walleij
> Cc: Robert Foss
> Cc: Sam Ravnborg
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/bridge/ti-sn65dsi83.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> b/drive
On Thu, 31 Mar 2022 at 17:20, Marek Vasut wrote:
>
> The TC358767/TC358867/TC9595 are all capable of operating in multiple
> modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Clean up the driver,
> switch to atomic ops, and add support for the DSI-to-DPI mode in
> addition to already supported DPI-to
[2].
>
> [1]
> https://github.com/rockchip-linux/kernel/blob/develop-4.19/drivers/gpu/drm/bridge/icn6211.c
> [2] https://github.com/tdjastrzebski/ICN6211-Configurator
>
> Cc: Jagan Teki
> Cc: Maxime Ripard
> Cc: Robert Foss
> Cc: Sam Ravnborg
> Cc: Thomas Zimmermann
gt; > > index eb475a3a774b..cf3f21f649cb 100644
> > > > > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > > > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > > > > @@ -719,7 +719,7 @@ static const struct drm_display_mode
> > > > > > ampire_am_1280800n3tzqw_t00h_mode = {
> > > > > > static const struct panel_desc ampire_am_1280800n3tzqw_t00h = {
> > > > > > .modes = &ire_am_1280800n3tzqw_t00h_mode,
> > > > > > .num_modes = 1,
> > > > > > - .bpc = 6,
> > > > > > + .bpc = 8,
> > > > >
> > > > > Any response on this?
Reviewed-by: Robert Foss
On Thu, 31 Mar 2022 at 15:42, Marek Vasut wrote:
>
> On 3/31/22 14:02, Robert Foss wrote:
> > Hey Marek,
>
> Hi,
>
> > On Fri, 18 Mar 2022 at 19:48, Marek Vasut wrote:
> >>
> >> This series fixes multiple problems with the ICN6211 driver and adds
&
On Fri, 25 Mar 2022 at 17:04, Adam Ford wrote:
>
> On Fri, Mar 25, 2022 at 10:00 AM Marek Szyprowski
> wrote:
> >
> > Hi Jagan,
> >
> > On 03.03.2022 17:36, Jagan Teki wrote:
> > > Updated series about drm bridge conversion of exynos dsi.
> > >
> > > Previous version can be accessible, here [1].
const
> struct i2c_device_id *id)
> adv7511_audio_exit(adv7511);
> drm_bridge_remove(&adv7511->bridge);
> err_unregister_cec:
> + cec_unregister_adapter(adv7511->cec_adap);
> i2c_unregister_device(adv7511->i2c_cec);
> clk_disable_unprepare(adv7511->cec_clk);
> err_i2c_unregister_packet:
> --
> 2.34.1
>
Reviewed-by: Robert Foss
Applied to drm-misc-next.
Applied to drm-misc-next.
from [1] and [2].
>
> [1]
> https://github.com/rockchip-linux/kernel/blob/develop-4.19/drivers/gpu/drm/bridge/icn6211.c
> [2] https://github.com/tdjastrzebski/ICN6211-Configurator
>
> Cc: Jagan Teki
> Cc: Maxime Ripard
> Cc: Robert Foss
> Cc: Sam Ravnborg
> Cc: Tho
On Fri, 18 Mar 2022 at 10:25, Liu Ying wrote:
>
> On Thu, 2022-03-17 at 18:58 +0100, José Expósito wrote:
> > The function "drm_of_find_panel_or_bridge" has been deprecated in
> > favor of "devm_drm_of_get_bridge".
> >
> > Switch to the new function and reduce boilerplate.
> >
> > Signed-off-by: J
On Fri, 25 Mar 2022 at 07:29, Xin Ji wrote:
>
> On Thu, Mar 24, 2022 at 01:07:56PM +0100, Robert Foss wrote:
> > > > > > The driver uses DRM_DEV_* for logs. Can we use this?
> > > > > Hi Hsin-Yi, as comment in drm/drm_print.h:
> > > > > &quo
gt; > > https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F20220307154558.2505734-3-robert.foss%40linaro.org%2F&data=04%7C01%7Cxji%40analogixsemi.com%7C69542695a9cd42cff5a508da00ea7baa%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637823304343387964%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi
> > > > The driver uses DRM_DEV_* for logs. Can we use this?
> > > Hi Hsin-Yi, as comment in drm/drm_print.h:
> > > "NOTE: this is deprecated in favor of drm_dbg". DRM bridge driver not
> > > use DRM_DEV_* any more. I'll send a patch to replace all of DRM_DEV_*
> > > later.
> >
> > drm_dbg is bette
Added r-b & applied to drm-misc-next.
Hey,
Thanks for submitting this.
I think this[1] patch should solve the issue you're seeing too. Can
you confirm that[1] fixes your issues?
[1] https://lore.kernel.org/all/YjJXnzJmDGsrZAXj@xps13/
Rob.
ector
> +* plat_data->attach return, that's why we record the connector
> * point after plat attached.
> */
> if (dp->plat_data->attach) {
>
Acked-by: Robert Foss
>
On Mon, 21 Feb 2022 at 09:55, Maxime Ripard wrote:
>
> On Mon, Feb 21, 2022 at 08:28:35AM +0100, José Expósito wrote:
> > The function "drm_of_find_panel_or_bridge" has been deprecated in
> > favor of "devm_drm_of_get_bridge".
> >
> > Switch to the new function and reduce boilerplate.
> >
> > Sign
On Fri, 4 Mar 2022 at 13:12, Kieran Bingham
wrote:
>
> Hi José
>
> Quoting Kieran Bingham (2022-03-03 21:59:26)
> > Quoting José Expósito (2022-03-03 18:37:20)
> > > On Mon, Feb 28, 2022 at 11:24:36PM +, Kieran Bingham wrote:
> > > > Hi José
> > > >
> > > > Quoting José Expósito (2022-02-28 18
t; >> @@ -872,7 +872,10 @@ static int anx7625_hdcp_enable(struct anx7625_data
> >> *ctx)
> >> }
> >>
> >> /* Read downstream capability */
> >> - anx7625_aux_trans(ctx, DP_AUX_NATIVE_READ, 0x68028, 1, &bcap);
> >> + ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_READ, 0x68028, 1,
> >> &bcap);
> >> + if (ret < 0)
> >> + return ret;
> >> +
> >> if (!(bcap & 0x01)) {
> >> pr_warn("downstream not support HDCP 1.4, cap(%x).\n",
> >> bcap);
> >> return 0;
> >> --
> >> 2.26.3
> >>
> >
>
Reviewed-by: Robert Foss
Applied to drm-misc-next.
/ps8640.yaml
> +F: drivers/gpu/drm/bridge/parade-ps8640.c
> +
> DRM DRIVER FOR PERVASIVE DISPLAYS REPAPER PANELS
> M: Noralf Trønnes
> S: Maintained
> --
> 2.35.1.616.g0bdcbb4464-goog
>
Reviewed-by: Robert Foss
bridge/ti,sn65dsi86.yaml
> +F: drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +
> DRM DRIVER FOR TPO TPG110 PANELS
> M: Linus Walleij
> S: Maintained
> --
> 2.35.1.616.g0bdcbb4464-goog
>
Reviewed-by: Robert Foss
On Wed, 9 Mar 2022 at 08:36, Rex-BC Chen wrote:
>
> Resend v11:
> - Resend this series for reviewing.
> - Rebase to 5.17-rc7.
>
> Changes since v10:
> - Rebase to 5.17-rc3.
> - Add more maintainers.
>
> Changes since v9:
> - Change description of "MIPI_DSI_HS_PKT_END_ALIGNED".
> - Use mode_f
3,7 @@ R: Jonas Karlman
> > R: Jernej Skrabec
> > S: Maintained
> > T: git git://anongit.freedesktop.org/drm/drm-misc
> > +F: Documentation/devicetree/bindings/display/bridge/
> > F: drivers/gpu/drm/bridge/
> >
> > DRM DRIVERS FOR EXYNOS
>
> Acked-by: Neil Armstrong
Acked-by: Robert Foss
On Mon, 7 Mar 2022 at 16:49, Robert Foss wrote:
>
> On Mon, 7 Mar 2022 at 07:12, Chen-Yu Tsai wrote:
> >
> > On Sun, Mar 06, 2022 at 07:13:30PM +0200, Laurent Pinchart wrote:
> > > Hello Xin,
> > >
> > > (Question for Rob below, and I'm afraid
This reverts commit 32568ae37596b529628ac09b875f4874e614f63f.
Signed-off-by: Robert Foss
Reviewed-by: Chen-Yu Tsai
Reviewed-by: Laurent Pinchart
---
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183
representing DPI, which it is not.
In order to prevent adding this mis-usage to the ABI, let's revert
the support.
Signed-off-by: Robert Foss
Reviewed-by: Laurent Pinchart
---
Changes since v1:
- Rob: Instead of reverting the entire commit introducing this,
do a partial revert of onl
tands V4L2_FWNODE_BUS_TYPE_PARALLEL was used to represent DPI
due to not being caught in the review process.
In order to not introduce this issue into the ABI, let's revert the changes
to the anx7625 dt-binding related to this.
[1] https://lore.kernel.org/all/yitruicikyxs3...@pendragon.ideasonboard.com/
Robert Foss
On Mon, 7 Mar 2022 at 17:38, Rob Herring wrote:
>
> On Mon, Mar 07, 2022 at 04:45:57PM +0100, Robert Foss wrote:
> > This reverts commit a43661e7e819b100e1f833a35018560a1d9abb39.
>
> S-o-b and reason for the revert?
>
> > ---
> > .../display/bridg
On Mon, 7 Mar 2022 at 16:46, Robert Foss wrote:
>
> This reverts commit a43661e7e819b100e1f833a35018560a1d9abb39.
> ---
> .../display/bridge/analogix,anx7625.yaml | 65 +--
> 1 file changed, 2 insertions(+), 63 deletions(-)
>
> diff --git
> a/
Signed-off-by: Robert Foss
On Mon, 7 Mar 2022 at 16:46, Robert Foss wrote:
>
> This reverts commit 32568ae37596b529628ac09b875f4874e614f63f.
> ---
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/ar
n Fri, Nov 05, 2021 at 11:19:03AM +0800, Xin Ji wrote:
> > > The basic anx7625 driver only support MIPI DSI rx signal input.
> > > This patch add MIPI DPI rx input configuration support, after apply
> > > this patch, the driver can support DSI rx or DPI rx by adding
> &g
This reverts commit 32568ae37596b529628ac09b875f4874e614f63f.
---
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
index e8f13
This reverts commit a43661e7e819b100e1f833a35018560a1d9abb39.
---
.../display/bridge/analogix,anx7625.yaml | 65 +--
1 file changed, 2 insertions(+), 63 deletions(-)
diff --git
a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
b/Documentation/devicetr
kyxs3...@pendragon.ideasonboard.com/
Robert Foss (2):
Revert "dt-bindings:drm/bridge:anx7625:add vendor define"
Revert "arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI
endpoint"
.../display/bridge/analogix,anx7625.yaml | 65 +--
On Wed, 2 Mar 2022 at 12:35, Guido Günther wrote:
>
> Hi Liu,
> On Wed, Feb 16, 2022 at 04:58:42PM +0800, Liu Ying wrote:
> > To initialize register NWL_DSI_IRQ_MASK, it's enough to write it
> > only once in function nwl_dsi_init_interrupts().
> >
> > Signed-off-by: Liu Ying
> > ---
> > drivers/
Applied to drm-misc-next.
Applied to drm-misc-next.
Applied to drm-misc-next.
Applied to drm-misc-next.
> > >
> > > Caused by commit
> > >
> > > b5c84a9edcd418 ("drm/bridge: add it6505 driver")
> > >
> > > I have used the drm tree from yesterday instead.
> >
> > hi all,
> >
> > The following fix should be able to address the errors. Should it be
> > squashed into b5c84a9edcd418 ("drm/bridge: add it
it6505 = file->private_data;
> struct drm_display_mode *vid = &it6505->video_info;
> u8 read_buf[READ_BUFFER_SIZE];
> - u8 *str = read_buf, *end = read_buf + PAGE_SIZE;
> + u8 *str = read_buf, *end = read_buf + READ_BUFFER_SIZE;
> ssize_t ret, count;
>
> if (!it6505)
> --
> 2.35.1.574.g5d30c73bfb-goog
>
Reviewed-by: Robert Foss
On Thu, 10 Feb 2022 at 11:38, Pin-Yen Lin wrote:
>
> The length of EDID block can be longer than 256 bytes, so we should use
> `int` instead of `u8` for the `edid_pos` variable.
>
> Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP")
> Signed-off-by: Pin-Yen Lin
> Reviewed
On Sun, 13 Feb 2022 at 11:34, Hsin-Yi Wang wrote:
>
> From: Xin Ji
>
> Send DPCD command to downstream before anx7625 power down,
> let downstream monitor enter into standby mode.
>
> Signed-off-by: Xin Ji
> Signed-off-by: Hsin-Yi Wang
> Reviewed-by: Hsin-Yi Wang
> ---
> v3->v4:
> Use common D
t; &bridge->encoder->bridge_chain)) {
> *num_output_fmts = 1;
> output_fmts[0] = MEDIA_BUS_FMT_FIXED;
>
> --
> 2.25.1
>
There are two checkstyle issues apart from the above mentioned hash
issues, and I think we can ignore those. With the above mentioned
issue fixed, feel free to add my r-b.
Reviewed-by: Robert Foss
On Thu, Feb 3, 2022, 05:42 kernel test robot wrote:
> Hi Hsin-Yi,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on drm/drm-next]
> [also build test ERROR on next-20220202]
> [cannot apply to robh/for-next drm-intel/for-linux-next v5.17-rc2]
> [If your patch is
On Fri, 14 Jan 2022 at 10:29, allen wrote:
>
> This adds support for the iTE IT6505.
> This device can convert DPI signal to DP output.
>
> From: Allen Chen
> Tested-by: Hsin-yi Wang
> Signed-off-by: Hermes Wu
> Signed-off-by: Allen Chen
> ---
> v10 -> v11 : remove drm_bridge_new_crtc_state
>
On Mon, 31 Jan 2022 at 17:55, Hsin-Yi Wang wrote:
>
> On Tue, Feb 1, 2022 at 12:37 AM Robert Foss wrote:
> >
> > On Thu, 20 Jan 2022 at 16:25, AngeloGioacchino Del Regno
> > wrote:
> > >
> > > Il 14/01/22 10:14, allen ha scritto:
> > > > Thi
On Thu, 20 Jan 2022 at 16:25, AngeloGioacchino Del Regno
wrote:
>
> Il 14/01/22 10:14, allen ha scritto:
> > This adds support for the iTE IT6505.
> > This device can convert DPI signal to DP output.
> >
> > From: Allen Chen
> > Tested-by: Hsin-yi Wang
> > Signed-off-by: Hermes Wu
> > Signed-of
On Mon, 31 Jan 2022 at 17:25, Robert Foss wrote:
>
> Hey Christophe,
>
> Thanks for submitting this fix.
>
> On Sat, 29 Jan 2022 at 16:06, Christophe JAILLET
> wrote:
> >
> > If lt9611_audio_init() fails, some resources still need to be released
> > befo
nable_hpd_interrupts(lt9611);
>
> - return lt9611_audio_init(dev, lt9611);
> + ret = lt9611_audio_init(dev, lt9611);
> + if (ret)
> + goto err_remove_bridge;
> +
> + return 0;
>
> err_remove_bridge:
> drm_bridge_remove(<9611->bridge);
> --
> 2.32.0
>
Reviewed-by: Robert Foss
On Thu, 27 Jan 2022 at 02:10, Laurent Pinchart
wrote:
>
> Hi Yongzhi,
>
> Thank you for the patch.
>
> On Sun, Jan 23, 2022 at 11:20:35PM -0800, Yongzhi Liu wrote:
> > pm_runtime_get_sync() will increase the rumtime PM counter
> > even when it returns an error. Thus a pairing decrement is needed
>
On Wed, 19 Jan 2022 at 16:17, Hsin-Yi Wang wrote:
>
> From: Xin Ji
>
> Send DPCD command to downstream before anx7625 power down,
> let downstream monitor enter into standby mode.
>
> Signed-off-by: Xin Ji
> Signed-off-by: Hsin-Yi Wang
Hsin-Yi: Can you supply a r-b tag to this patch if it look
Hey Hsin-Yi,
While I can review this patch, I don't have the authority to merge it
since it is outside the scope of my maintainership. Rob Herring,
Daniel Vetter or David Airlie would have to Ack this patch.
On Wed, 19 Jan 2022 at 16:18, Hsin-Yi Wang wrote:
>
> List panel under aux-bus node if i
On Tue, 18 Jan 2022 at 10:20, Hsin-Yi Wang wrote:
>
> Support reading edid through aux channel if panel is connected to aux
> bus. Extend anx7625_aux_dpcd_trans() to implement aux transfer function:
>
> 1. panel is populated in devm_of_dp_aux_populate_ep_devices(), so move
>anx7625_parse_dt()
return PTR_ERR(lt9611uxc->regmap);
> }
>
> - ret = lt9611uxc_parse_dt(&client->dev, lt9611uxc);
> + ret = lt9611uxc_parse_dt(dev, lt9611uxc);
> if (ret) {
> dev_err(dev, "failed to parse device tre
a.mipi_host_node);
> if (!host) {
> DRM_DEV_ERROR(dev, "fail to find dsi host.\n");
> - return -EINVAL;
> + return -EPROBE_DEFER;
> }
>
> dsi = devm_mipi_dsi_device_register_full(dev, host, &info);
> --
> 2.31.0
>
Reviewed-by: Robert Foss
Applied to drm-misc-next.
Hey Zhiming,
Again, I think the code is good, but let's fix some small stuff with
the patch submission and then I'll happily apply this.
On Thu, 13 Jan 2022 at 13:52, Zhiming Liu wrote:
>
> Signed-off-by: Zhiming Liu
The tags like Signed-off-by come after the body of the commit message.
>
> b
Hi Inki,
On Fri, 14 Jan 2022 at 02:18, Inki Dae wrote:
>
> Hi Robert,
>
> 22. 1. 12. 오후 7:05에 Robert Foss 이(가) 쓴 글:
> > Thank you again for catching this and submitting a revert.
> >
> > Reviewed-by: Robert Foss >
> > Applied to drm-misc-next.
> >
&g
t; + struct device_node *endpoint;
> struct sii902x *sii902x;
> int ret;
>
> @@ -1049,6 +1096,28 @@ static int sii902x_probe(struct i2c_client *client,
> return PTR_ERR(sii902x->reset_gpio);
> }
>
> + endpoint = of_graph_get_endpoint_by_regs(dev->of_node, 1, -1);
> + if (endpoint) {
> + struct device_node *remote =
> of_graph_get_remote_port_parent(endpoint);
> +
> + of_node_put(endpoint);
> + if (!remote) {
> + dev_err(dev, "Endpoint in port@1 unconnected\n");
> + return -ENODEV;
> + }
> +
> + if (!of_device_is_available(remote)) {
> + dev_err(dev, "port@1 remote device is disabled\n");
> + of_node_put(remote);
> + return -ENODEV;
> + }
> +
> + sii902x->next_bridge = of_drm_find_bridge(remote);
> + of_node_put(remote);
> + if (!sii902x->next_bridge)
> + return -EPROBE_DEFER;
> + }
> +
> mutex_init(&sii902x->mutex);
>
> sii902x->supplies[0].supply = "iovcc";
Reviewed-by: Robert Foss
Applied to drm-misc-next.
Hey Hsin-Yi,
On Thu, 13 Jan 2022 at 09:29, Hsin-Yi Wang wrote:
>
> Use devm_kzalloc instead of kzalloc and drop kfree(). Let the memory
> handled by driver detach.
>
> Signed-off-by: Hsin-Yi Wang
> Reviewed-by: Xin Ji
> ---
> v2->v3: remove kfree() in anx7625_i2c_remove().
> ---
> drivers/gpu
ut depending on or selecting DRM_KMS_HELPER,
> despite DRM_PANEL_BRIDGE depending on DRM_KMS_HELPER.
>
> This unmet dependency bug was detected by Kismet,
> a static analysis tool for Kconfig.
> Please advise if this is not the appropriate solution.
>
> Fixes: ce517f18944e ("drm: bridg
Reviewed-by: Robert Foss
Applied to drm-misc-next.
On Thu, 13 Jan 2022 at 20:43, Jagan Teki wrote:
>
> On Fri, Nov 12, 2021 at 11:47 AM Jagan Teki
> wrote:
> >
> > Replace atomic version of the enable/disable operations to
> > continue the transition to the ato
Hello,
Thanks for submitting this cleanup patch.
On Tue, 11 Jan 2022 at 04:41, lzmlzm wrote:
>
A commit message is necessary for all changes, no matter how trivial.
> Signed-off-by: lzmlzm
Is your name listed correctly above? For the 'Signed-off-by' tag to be
meaningful, a real name needs to
On Mon, 10 Jan 2022 at 18:25, Jagan Teki wrote:
>
> panel_bridge pointer never used anywhere except the one it
> looked up at nwl_dsi_bridge_attach.
>
> Drop it from the nwl_dsi structure.
>
> Reviewed-by: Guido Günther
> Signed-off-by: Jagan Teki
> ---
> Changes for v2:
> - collect Guido r-b
>
On Sun, 9 Jan 2022 at 23:58, Laurent Pinchart
wrote:
>
> Hi Colin,
>
> Thank you for the patch.
>
> On Sun, Jan 09, 2022 at 08:41:05PM +, Colin Ian King wrote:
> > Don't populate the read-only array clock_div_by_lanes on the stack but
> > instead it static const. Also makes the object code a l
Thank you again for catching this and submitting a revert.
Reviewed-by: Robert Foss
401 - 500 of 897 matches
Mail list logo
