Re: [PATCH 1/2] dt-bindings: drm/bridge: MHDP8546 bridge binding changes for HDCP

Hey Parshuram, Thanks for submitting this. This series rebased on upstream-drm-misc/for-linux-next fails dt binding verification. $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml On Fri, 26 Feb 2021 at 17:18, Parshuram Thombare wrote:

Re: [PATCH v4 05/14] drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support

Hey Liu, With the below nit straightened out, feel free to add my r-b. Reviewed-by: Robert Foss On Thu, 18 Feb 2021 at 04:58, Liu Ying wrote: > > This patch adds a drm bridge driver for i.MX8qm/qxp pixel combiner. > The pixel combiner takes two output streams from a singl

Re: [PATCH v4 03/14] media: docs: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

Hey Liu, This patch looks good to me. Reviewed-by: Robert Foss On Thu, 18 Feb 2021 at 04:56, Liu Ying wrote: > > This patch adds documentations for RGB666_1X30_CPADLO, RGB888_1X30_CPADLO, > RGB666_1X36_CPADLO and RGB888_1X36_CPADLO bus formats used by i.MX8qm/qxp > pixel combin

Re: [PATCH v4 02/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

Hey Liu, This patch looks good to me Reviewed-by: Robert Foss On Thu, 18 Feb 2021 at 04:56, Liu Ying wrote: > > This patch adds RGB666_1X30_CPADLO, RGB888_1X30_CPADLO, RGB666_1X36_CPADLO > and RGB888_1X36_CPADLO bus formats used by i.MX8qm/qxp pixel combiner. > The RGB pixels with

Re: [PATCH v4 01/14] phy: Add LVDS configuration options

Hey Liu, Thanks for submitting this series. This patch looks good to me. Reviewed-by: Robert Foss On Thu, 18 Feb 2021 at 04:56, Liu Ying wrote: > > This patch allows LVDS PHYs to be configured through > the generic functions and through a custom structure > added to the generic un

Re: [PATCH v4 2/2] drm/bridge: Introduce LT8912 DSI to HDMI bridge

Hey Adrien, This looks good to me. All that is missing is DRM_BRIDGE_OP_HPD support, when that's been implemented I think this series is ready to be merged. On Tue, 23 Feb 2021 at 18:56, Adrien Grassein wrote: > > Lontium Lt8912 is a DSI to HDMI bridge. > > Signed-off-by: Adrien Grassein > ---

Re: [PATCH v3 2/2] drm/bridge: anx7625: disable regulators when power off

Hey Hsin-Yi, This patch looks good to me, feel free to add my r-b. Reviewed-by: Robert Foss On Fri, 15 Jan 2021 at 08:05, Hsin-Yi Wang wrote: > > When suspending the driver, anx7625_power_standby() will be called to > turn off reset-gpios and enable-gpios. However, power supplie

Re: [RESEND v3 1/2] dt-bindings: drm/bridge: anx7625: Add power supplies

ly 1.8V power. > + > + vdd33-supply: > +description: Regulator that provides the supply 3.3V power. > + This chunk below has seen some changes. With this patch fixed, feel free to add my r-b. Reviewed-by: Robert Foss >ports: > type: object > > @@ -55,6 +64,9

Re: [PATCH v3 2/2] drm/bridge: Introduce LT8912 DSI to HDMI bridge

On Tue, 23 Feb 2021 at 11:51, Adrien Grassein wrote: > > Hey Robert, > > Le ven. 19 févr. 2021 à 22:47, Adrien Grassein > a écrit : > > > > Le ven. 19 févr. 2021 à 22:28, Robert Foss a écrit > > : > > > > > > On Fri, 19 Feb 2021 at 16:01,

Re: [PATCH v3 2/2] drm/bridge: Introduce LT8912 DSI to HDMI bridge

On Fri, 19 Feb 2021 at 16:01, Adrien Grassein wrote: > > Hey Robert, > > Le ven. 19 févr. 2021 à 14:27, Robert Foss a écrit : > > > > Hey Adrien, > > > > > > Thanks for the quick update. > No problem, I have some free time at the moment. > >

Re: [PATCH v3 2/2] drm/bridge: Introduce LT8912 DSI to HDMI bridge

Hey Adrien, Thanks for the quick update. On Thu, 18 Feb 2021 at 22:05, Adrien Grassein wrote: > > Lontium Lt8912 is a DSI to HDMI bridge. > > Signed-off-by: Adrien Grassein > --- > MAINTAINERS | 1 + > drivers/gpu/drm/bridge/Kconfig | 14 + > drivers/gp

Re: [PATCH v2 2/2] drm/bridge: Introduce LT8912 DSI to HDMI bridge

On Thu, 18 Feb 2021 at 21:36, Adrien Grassein wrote: > > Hey Robert, > > Thank you for your time and for your review. > > Le mer. 17 févr. 2021 à 18:32, Robert Foss a écrit : > > > > Hey Adrien, > > > > Thanks for submitting this! > > > > On

Re: [PATCH v2 2/2] drm/bridge: Introduce LT8912 DSI to HDMI bridge

Hey Adrien, Thanks for submitting this! On Mon, 15 Feb 2021 at 00:31, Adrien Grassein wrote: > > Lontium Lt8912 is a DSI to HDMI bridge. > > Signed-off-by: Adrien Grassein > --- > MAINTAINERS | 1 + > drivers/gpu/drm/bridge/Kconfig | 14 + > drivers/gpu/

Re: [PATCH v3 2/2] drm: bridge: Add Chipone ICN6211 MIPI-DSI to RGB bridge

d my r-b. Reviewed-by: Robert Foss On Sun, 14 Feb 2021 at 18:55, Jagan Teki wrote: > > ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. WARNING: 'Convertor' may be misspelled - perhaps 'Converter'? #6: ICN6211 is MIPI-DSI to

Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211

Hey Jagan, Thanks for submitting this. checkpatch.pl threw some typ-o warnings, and I listed them below. I think either spelling is correct, but 'spelling.txt' does list this as a typ-o explicitly, so I would suggest conforming to that just to silence the checkpatch warning. This patch also pass

Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

Hey Nicolas, Thanks for submitting this, making these flags more intuitive is really nice. This looks good to me, feel free to add my r-b. Reviewed-by: Robert Foss On Thu, 11 Feb 2021 at 04:34, Nicolas Boichat wrote: > > Many of the DSI flags have names opposite to their actual effects,

Re: [PATCH] drm: bridge: convert sysfs sprintf/snprintf family to sysfs_emit

Hey Jiapeng, Thanks for the patch. Feel free to add my r-b. Reviewed-by: Robert Foss On Sun, 7 Feb 2021 at 10:12, Jiapeng Chong wrote: > > Fix the following coccicheck warning: > > drivers/gpu/drm/bridge/lontium-lt9611uxc.c:858:8-16: WARNING: use > scnprintf or sprintf. > &g

Re: [PATCH v4 3/3] drm/bridge: anx7625: add MIPI DPI input feature support

Hey Xin, On Thu, 28 Jan 2021 at 04:12, Xin Ji wrote: > > Add MIPI rx DPI input support > > Reported-by: kernel test robot > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 326 > -- > drivers/gpu/drm/bridge/analogix/anx7625.h | 20 +- > 2

Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP

On Thu, 4 Feb 2021 at 23:25, Nicolas Boichat wrote: > > On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda wrote: > > > > > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote: > > >> Hi Xin, > &g

Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP

Hi Xin, Thanks for the patch. On Thu, 28 Jan 2021 at 12:17, Xin Ji wrote: > > Enable DSI EOTP feature for fixing some panel screen constance > shift issue. > Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. I don't think I quite understand how removing the MIPI_DSI_MODE_EOT_PACKE

Re: [PATCH] drm/bridge/analogix: remove redundant when devm_kzalloc failed

Hey Bernard, Thanks for the patch. With the below fixed, feel free to add my r-b. Reviewed-by: Robert Foss On Tue, 2 Feb 2021 at 13:09, Bernard Zhao wrote: > > Line 1590 DRM_ERROR is redundant because devm_kzalloc() already > prints an error. The line number will not be so he

Re: [PATCH v4 2/3] drm/bridge: anx7625: fix not correct return value

Hi Xin, On Thu, 28 Jan 2021 at 04:12, Xin Ji wrote: > > At some time, the original code may return non zero value, force return 0 > if operation finished Missing "." at end of line. Other than that, this patch looks fine. Feel free to add my r-b. Reviewed-by: Robert Foss

Re: [PATCH v4 1/3] dt-bindings:drm/bridge:anx7625:add vendor define flags

Hey Xin, On Thu, 28 Jan 2021 at 04:10, Xin Ji wrote: > > Add 'bus-type' and 'data-lanes' define for port0, add HDCP support > flag and DP tx lane0 and lane1 swing register array define. > > Signed-off-by: Xin Ji > --- > .../bindings/display/bridge/analogix,anx7625.yaml | 54 >

Re: [PATCH v2] drm/bridge: lt9611: Fix handling of 4k panels

Hi, +Sam Ravnborg I think this patch is ready to get pulled into the drm-misc tree. On Thu, 17 Dec 2020 at 15:09, Robert Foss wrote: > > 4k requires two dsi pipes, so don't report MODE_OK when only a > single pipe is configured. But rather report MODE_PANEL to > signal that re

[PATCH v2] drm/bridge: lt9611: Fix handling of 4k panels

4k requires two dsi pipes, so don't report MODE_OK when only a single pipe is configured. But rather report MODE_PANEL to signal that requirements of the panel are not being met. Reported-by: Peter Collingbourne Suggested-by: Peter Collingbourne Signed-off-by: Robert Foss Tested-by:

[PATCH v1] drm/bridge: lt9611: Fix handling of 4k panels

4k requires two dsi pipes, so don't report MODE_OK when only a single pipe is configured. But rather report MODE_PANEL to signal that requirements of the panel are not being met. Reported-by: Peter Collingbourne Suggested-by: Peter Collingbourne Signed-off-by: Robert Foss Tested-by:

Re: liboutput: thoughts about shared library on top of DRM/KMS

Hey Keith, Thanks for setting this up, and picking a descriptive project name :) How is liboutput going to relate to the libliftoff[1] project? [1] https://github.com/emersion/libliftoff Rob. On 05.10.19 18:09, Keith Packard wrote: During XDC this year, we heard a few presentations and ha

Re: [PATCH] libdrm: Convert to Android.mk to Android.bp

Thanks for submitting this. Acked-by: Robert Foss On 24.09.19 23:29, John Stultz wrote: This patch removes the deprecated Android.mk files and replaces them with Android.bp files, used in Android N and newer releases. This is needed in order to build libdrm/master against recent Android

[PATCH v2] drm/virtio: Remove redundant return type

virtio_gpu_fence_emit() always returns 0, since it has no error paths. Consequently no calls for virtio_gpu_fence_emit() use the return value, and it can be removed. Signed-off-by: Robert Foss Suggested-by: Emil Velikov Reviewed-by: Chia-I Wu --- This patch was suggested in this email thread

[PATCH] drm/virtio: Remove redundant return type

virtio_gpu_fence_emit() always returns 0, since it has no error paths. Consequently no calls for virtio_gpu_fence_emit() use the return value, and it can be removed. Signed-off-by: Robert Foss Suggested-by: Emil Velikov --- This patch was suggested in this email thread: [PATCH] drm/virtio

Re: [PATCH] drm/virtio: allocate fences with GFP_KERNEL

(add virtio_gpu_alloc_fence()). Signed-off-by: Chia-I Wu Cc: Gerd Hoffmann Cc: Gustavo Padovan Cc: Robert Foss Reviewed-by: Emil Velikov Side: Rob, should we follow-up on 9fdd90c0f and drop the virtio_gpu_fence_emit() return type? Good idea. None of the called functions return anything. I&#x

Re: [PATCH] drm/virtio: allocate fences with GFP_KERNEL

Hey Chia-I, This looks good to me, I can't find any spinlocks being held during that allocation. Reviewed-by: Robert Foss On 30.04.19 00:10, Chia-I Wu wrote: It was changed to GFP_ATOMIC in commit ec2f0577c (add & use virtio_gpu_queue_fenced_ctrl_buffer) because the allocation happ

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

Hey, On 3/18/19 2:11 PM, Mauro Rossi wrote: Hi, On Mon, Mar 18, 2019 at 10:58 AM Robert Foss wrote: Hey Mauro, On 3/18/19 9:38 AM, Mauro Rossi wrote: Hi Robert, On Mon, Mar 18, 2019 at 9:21 AM Robert Foss wrote: On a second note, this does not apply on libdrm/master due to

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

Hey Mauro, On 3/18/19 9:38 AM, Mauro Rossi wrote: Hi Robert, On Mon, Mar 18, 2019 at 9:21 AM Robert Foss wrote: On a second note, this does not apply on libdrm/master due to: LOCAL_SHARED_LIBRARIES := \ libcutils Sorry, we have an additional Google patch, not present in libdrm

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

On a second note, this does not apply on libdrm/master due to: LOCAL_SHARED_LIBRARIES := \ libcutils My thinking is that libcutils probably can be replaced with liblog, but I'm not 100% sure. Rob. On 3/18/19 9:09 AM, Robert Foss wrote: This is probably a good idea! Review

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

This is probably a good idea! Reviewed-by: Robert Foss On 3/17/19 9:54 PM, Mauro Rossi wrote: Hi, I used the option --subject-prefix="PATCH libdrm" but it did not go as expected. Anyway, the patch is for Android build of mesa/drm Mauro On Sun, Mar 17, 2019 at 9:50 PM Mauro Ro

Re: [PATCH] virtgpu: Update kernel header

Hey Gurchetan, Thanks for sending this in! Reviewed-by: Robert Foss On 2/28/19 1:52 AM, Gurchetan Singh wrote: Generated using make headers_install. This brings in the in/out fence support for explicit synchronization. v2: don't use experimental kernel branch Signed-off-by: Gurc

Re: [Bug 109060] android-x86 64bit builds crashes due to android/gralloc_handle.h

Hey Chih-Wei & Mauro, This fix looks good to me. Cleaned up patch name and pushed to repo. Rob. On 2018-12-14 01:05, bugzilla-dae...@freedesktop.org wrote: Bug ID 109060 Summary android-x86 64bit builds crashes due to android/gral

Re: [RESEND PATCH v3] drm/msm: Move fence put to where failure occurs

On 2018-12-04 21:21, Rob Clark wrote: On Tue, Dec 4, 2018 at 11:56 AM Robert Foss wrote: If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: R

[RESEND PATCH v3] drm/msm: Move fence put to where failure occurs

If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert Foss Reviewed-by: Chris Wilson Cc: sta...@vger.kernel.org --- drivers/gpu/drm/msm/msm_ge

Re: [PATCH 0/2] drm/virtio: fence cleanups

Hey Gerd, I was looking at making these changes too, thanks for submitting this. This series has been: Reviewed-by: Robert Foss Rob. On 2018-11-28 16:10, Gerd Hoffmann wrote: Gerd Hoffmann (2): drm/virtio: fence: pass plain pointer drm/virtio: virtio_gpu_cmd_resource_create_3d

Re: [PATCH v3] drm/msm: Move fence put to where failure occurs

Hey, I think this patch is ready for inclusion. Rob. On 2018-11-05 11:13, Robert Foss wrote: If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-

[PATCH v5 2/4] drm/virtio: add uapi for in and out explicit fences

passing an in-fence fd. * VIRTGPU_EXECBUF_FENCE_FD_OUT to be used when requesting an out-fence fd The execbuffer IOCTL is now read-write to allow the userspace to read the out-fence. On error -1 should be returned in the fence_fd field. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss

[PATCH v5 4/4] drm/virtio: bump driver version after explicit synchronization addition

From: Gustavo Padovan To reflect the (backward compatible) changes in the uabi we are bumping the driver's version. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Reviewed-by: Emil Velikov --- Changes since v3: - Emil: Added r-b drivers/gpu/drm/virtio/virtgpu_drv.h | 4 ++

[PATCH v5 1/4] drm/virtio: add virtio_gpu_alloc_fence()

. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Suggested-by: Rob Herring --- Changes since v3: - Gerd: Clarified and extended commit message - Emil: Fixed whitespace issue - Emil: Changed label name from fail_fence to fail_backoff - Emil: Remove special case for !fence->drv

[PATCH v5 0/4] virgl: fence fd support

plicit synchronization Gustavo Padovan (1): drm/virtio: bump driver version after explicit synchronization addition Robert Foss (3): drm/virtio: add virtio_gpu_alloc_fence() drm/virtio: add uapi for in and out explicit fences drm/virtio: add in/out fence support for explicit synchroni

[PATCH v5 3/4] drm/virtio: add in/out fence support for explicit synchronization

returned to userspace. VIRTGPU_EXECBUF_FENCE_FD_IN & VIRTGPU_EXECBUF_FENCE_FD_OUT are supported at the simultaneously and can be flagged for simultaneously. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Suggested-by: Rob Herring Reviewed-by: Emil Velikov --- Changes sinc

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

On 2018-11-12 12:11, Gerd Hoffmann wrote: On Mon, Nov 12, 2018 at 11:30:57AM +0100, Robert Foss wrote: Hey Gerd On 2018-11-12 10:10, Gerd Hoffmann wrote: On Fri, Nov 09, 2018 at 06:13:52PM +0100, Robert Foss wrote: Hey Gerd, On 2018-11-09 11:13, Gerd Hoffmann wrote: On Mon, Nov 05, 2018

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

Hey Gerd On 2018-11-12 10:10, Gerd Hoffmann wrote: On Fri, Nov 09, 2018 at 06:13:52PM +0100, Robert Foss wrote: Hey Gerd, On 2018-11-09 11:13, Gerd Hoffmann wrote: On Mon, Nov 05, 2018 at 05:25:05PM +, Emil Velikov wrote: On Mon, 5 Nov 2018 at 11:42, Robert Foss wrote: When the

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

Hey Gerd, On 2018-11-09 11:13, Gerd Hoffmann wrote: On Mon, Nov 05, 2018 at 05:25:05PM +, Emil Velikov wrote: On Mon, 5 Nov 2018 at 11:42, Robert Foss wrote: When the execbuf call receives an in-fence it will get the dma_fence related to that fence fd and wait on it before submitting

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

Heya, On 2018-11-05 18:25, Emil Velikov wrote: On Mon, 5 Nov 2018 at 11:42, Robert Foss wrote: When the execbuf call receives an in-fence it will get the dma_fence related to that fence fd and wait on it before submitting the draw call. On the out-fence side we get fence returned by the

[PATCH v4 2/4] drm/virtio: add uapi for in and out explicit fences

passing an in-fence fd. * VIRTGPU_EXECBUF_FENCE_FD_OUT to be used when requesting an out-fence fd The execbuffer IOCTL is now read-write to allow the userspace to read the out-fence. On error -1 should be returned in the fence_fd field. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss

[PATCH v4 0/4] virgl: fence fd support

fix compilation issues - drm/virtio: add uapi for in and out explicit fences - Check exbuf->flags for unsupported flags - drm/virtio: add in-fences support for explicit synchronization Gustavo Padovan (1): drm/virtio: bump driver version after explicit synchronization addition Robert F

[PATCH v4 1/4] drm/virtio: add virtio_gpu_alloc_fence()

. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Suggested-by: Rob Herring --- Changes since v3: - Gerd: Clarified and extended commit message - Emil: Fixed whitespace issue - Emil: Changed label name from fail_fence to fail_backoff - Emil: Remove special case for !fence->drv

[PATCH v4 4/4] drm/virtio: bump driver version after explicit synchronization addition

From: Gustavo Padovan To reflect the (backward compatible) changes in the uabi we are bumping the driver's version. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Reviewed-by: Emil Velikov --- Changes since v3: - Emil: Added r-b drivers/gpu/drm/virtio/virtgpu_drv.

[PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

returned to userspace. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Suggested-by: Rob Herring Reviewed-by: Emil Velikov --- Changes since v3: - Move all in_fence handling to the same VIRTGPU_EXECBUF_FENCE_FD_IN block - Emil: Make sure to always call dma_fence_put() - Emil

[PATCH v3] drm/msm: Move fence put to where failure occurs

If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert Foss Reviewed-by: Chris Wilson Cc: sta...@vger.kernel.org --- Changes since v2: - Ch

Re: [PATCH 2/5] drm/virtio: add uapi for in and out explicit fences

Hey Emil, On 2018-11-02 14:34, Emil Velikov wrote: On Thu, 1 Nov 2018 at 12:56, Robert Foss wrote: On 2018-10-31 10:38, Emil Velikov wrote: Hi Rob, On Thu, 25 Oct 2018 at 19:38, Robert Foss wrote: Add a new field called fence_fd that will be used by userspace to send in-fences to the

Re: [PATCH v2] drm/msm: Move fence put to where failure occurs

Hey Chris, On 2018-11-02 13:16, Chris Wilson wrote: Quoting Robert Foss (2018-11-02 12:13:13) If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: R

Re: [PATCH v2] drm/msm: Move fence put to where failure occurs

+stable On 2018-11-02 13:13, Robert Foss wrote: If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert Foss --- Changes since v1: - Chris Wi

[PATCH v2] drm/msm: Move fence put to where failure occurs

If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert Foss --- Changes since v1: - Chris Wilson: Make sure that dma_fence_put() is alway

Re: [PATCH v1] drm/msm: Move fence put to where failure occurs

Hey Chris, On 2018-11-01 17:26, Chris Wilson wrote: Quoting Robert Foss (2018-11-01 16:12:28) If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: R

[PATCH v1] drm/msm: Move fence put to where failure occurs

If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert Foss --- drivers/gpu/drm/msm/msm_gem_submit.c | 10 +- 1 file changed, 5 insert

Re: [PATCH 2/5] drm/virtio: add uapi for in and out explicit fences

On 2018-10-31 10:38, Emil Velikov wrote: Hi Rob, On Thu, 25 Oct 2018 at 19:38, Robert Foss wrote: Add a new field called fence_fd that will be used by userspace to send in-fences to the kernel and receive out-fences created by the kernel. This uapi enables virtio to take advantage of

Re: [PATCH 1/5] drm/virtio: add virtio_gpu_alloc_fence()

Hey Emil, On 2018-10-31 10:38, Emil Velikov wrote: Hi Rob, On Thu, 25 Oct 2018 at 19:38, Robert Foss wrote: From: Gustavo Padovan Refactor fence creation to remove the potential allocation failure from the cmd_submit and atomic_commit paths. Now the fence should be allocated first and

[PATCH 1/5] drm/virtio: add virtio_gpu_alloc_fence()

From: Gustavo Padovan Refactor fence creation to remove the potential allocation failure from the cmd_submit and atomic_commit paths. Now the fence should be allocated first and just after we should proceed with the rest of the execution. Signed-off-by: Gustavo Padovan Signed-off-by: Robert

[PATCH 3/5] drm/virtio: add in-fences support for explicit synchronization

From: Gustavo Padovan When the execbuf call receives an in-fence it will get the dma_fence related to that fence fd and wait on it before submitting the draw call. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Suggested-by: Rob Herring --- drivers/gpu/drm/virtio/virtgpu_ioctl.c

[PATCH 4/5] drm/virtio: add out-fences support for explicit synchronization

From: Gustavo Padovan On the out-fence side we get fence returned by the submitted draw call and attach it to a sync_file and send the sync_file fd to userspace. On error -1 is returned to userspace. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Suggested-by: Rob Herring

[PATCH 5/5] drm/virtio: bump driver version after explicit synchronization addition

From: Gustavo Padovan To reflect the (backward compatible) changes in the uabi we are bumping the driver's version. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss --- drivers/gpu/drm/virtio/virtgpu_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH 0/5] virgl: fence fd support

out-fences support for explicit synchronization drm/virtio: bump driver version after explicit synchronization addition Robert Foss (1): drm/virtio: add uapi for in and out explicit fences drivers/gpu/drm/virtio/virtgpu_drv.h | 22 +++-- drivers/gpu/drm/virtio/virtgpu_fence.c |

[PATCH 2/5] drm/virtio: add uapi for in and out explicit fences

passing an in-fence fd. * VIRTGPU_EXECBUF_FENCE_FD_OUT to be used when requesting an out-fence fd The execbuffer IOCTL is now read-write to allow the userspace to read the out-fence. On error -1 should be returned in the fence_fd field. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss

[RFC] drm: Allow DRM_IOCTL_MODE_MAP_DUMB for render nodes

simplifies the stack. Signed-off-by: Tomasz Figa Reviewed-by: Zach Reizner Signed-off-by: Nicolas Norvez Reviewed-by: Tomasz Figa Signed-off-by: Robert Foss --- I've been looking into enabling a kms_swrast based driver for mesa on the Android platform[1]. But have come up against the iss

Re: [PATCH libdrm v2 04/10] xf86drm: Allocate drmDevicePtr's on stack

to simplify the error handling and even shed a few bytes off the final binary. v2: - add a define & description behind the magic 256 (Rob) - report error to strerr and skip when over 256 device nodes (Rob) Cc: Robert Foss Signed-off-by: Emil Velikov Tested-by: Robert Foss (v1) Reviewe

Re: [PATCH libdrm 10/10] drmdevice: print the correct host1x information

Nice catch! Feel free to add my r-b to this patch. On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov While fairly close, the host1x and platform are two separate things. Signed-off-by: Emil Velikov --- tests/drmdevice.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH libdrm 09/10] drmdevice: convert the tabbed output into a tree

Feel free to add my r-b to this patch. On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov Making the output a little bit easier to parse by human beings. Signed-off-by: Emil Velikov --- tests/drmdevice.c | 78 +++ 1 file changed, 39 ins

Re: [PATCH libdrm 08/10] tests/drmdevice: add a couple of printf headers

Feel free to add my r-b to this patch. On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov Add a few printf statements, which should make the output easier to parse. Signed-off-by: Emil Velikov --- tests/drmdevice.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff

Re: [PATCH libdrm 07/10] tests/drmdevices: install alongside other utilities

Feel free to add my r-b to this patch. On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov It's mildly useful program, to ship it when the user wants the "tests" installed. Obviously the "tests" in the name is a misnomer. Signed-off-by: Emil Velikov --- tests/Makefile.am | 9 ++

Re: [PATCH libdrm 06/10] xf86drm: Add drmDevice support for virtio_gpu

Feel free to add my r-b to this patch. On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov The GPU almost exclusively lives on the PCI bus, so we expose it as a normal PCI one. This allows any existing drmDevice users to work without any changes. One could wonder why a separate types

Re: [PATCH libdrm 05/10] xf86drm: introduce a get_real_pci_path() helper

Feel free to add my r-b to this patch. On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov Introduce a helper which gets the real sysfs path for the given pci device. In other words, instead opening the /sys/dev/char/*/device symlink, we opt for the actual /sys/devices/pci*/*/ It fol

Re: [PATCH libdrm 04/10] xf86drm: Allocate drmDevicePtr's on stack

Hey Emil, On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov Currently we dynamically allocate 16 pointers and reallocate more as needed. Instead, allocate the maximum number (256) on stack - the number is small enough and is unlikely to change in the foreseeable future. This allows

Re: [PATCH libdrm 03/10] xf86drm: Fold drmDevice processing into process_device() helper

Feel free to add my r-b to this patch. On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov Don't the duplicate (nearly) identical code across the two call sites. It improves legibility and the diff stat seems nice. Signed-off-by: Emil Velikov --- xf86drm.c | 159 ++-

Re: [PATCH libdrm 02/10] xf86drm: introduce drm_device_has_rdev() helper

Feel free to add my r-b to this patch. On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov Currently we match the opened drmDevice fd with each drmDevice we process. Move that after all the devices are processed and folded, via the drm_device_has_rdev(). This makes the code easier to

Re: [PATCH libdrm 01/10] xf86drm: drmGetDevice2: error out if the fd has unknown subsys

Feel free to add my r-b to this patch. On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov Currently one can open() any /dev node. If it's unknown drmParseSubsystemType() will return an error. Track that and bail as needed. Signed-off-by: Emil Velikov --- xf86drm.c | 2 ++ 1 file

Re: [PATCH libdrm 01/10] xf86drm: drmGetDevice2: error out if the fd has unknown subsys

This series has been: Tested-by: Robert Foss On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov Currently one can open() any /dev node. If it's unknown drmParseSubsystemType() will return an error. Track that and bail as needed. Signed-off-by: Emil Velikov --- xf86drm.

Re: [drm_hwc] PSA: drm_hwc submissions via gitlab

Heya, On 2018-05-04 12:51, Daniel Stone wrote: Hi, On 3 May 2018 at 20:12, Sean Paul wrote: On Thu, May 03, 2018 at 08:30:18PM +0200, Daniel Vetter wrote: On Thu, May 3, 2018 at 5:04 PM, Sean Paul wrote: If you're still reading, I'll point out a couple other things: - There is a bug tracke

Re: [drm_hwc] PSA: drm_hwc submissions via gitlab

Hey Sean, On 2018-05-03 17:04, Sean Paul wrote: Hey all, Apologies for the direct ping. I've harvested your emails from drm_hwc git logs, and didn't want to leave anyone out. The good news is that your email address will forever be remembered in the annals of drm_hwcomposer! Anyways, back to th

Re: [PATCH v1] xf86drm: Add drmHandleMatch func

Hey Emil, On 27.04.2018 15:48, Emil Velikov wrote: On 27 April 2018 at 12:31, Robert Foss wrote: drmHandleMatch is intended to allow for userspace to filter out devices that it does not want to open. Opening specific devices using paths alone is not a reliable due to probing order. This

Re: [PATCH hwc 4/4] drm_hwcomposer: Fall back to client compositon if the gl precompostior fails

This patch is: Acked-by: Robert Foss I'll push this series upstream in a few minutes. On 04/26/2018 09:05 PM, John Stultz wrote: If the gl precompositor isn't being used, we cannot accept every layer as a device composited layer. Thus this patch adds some extra logic in the validat

[PATCH v1] xf86drm: Add drmHandleMatch func

ourse filter based on anything. But for the sake of convenience a few other simple filters have been included. If the function pointer filter ends up being called with a boilerplate fp by mutliple libdrm users, perhaps that funtion could be moved into libdrm at a future date. Signed-off-by: Robert

Re: [PATCH hwc 3/4] drm_hwcomposer: Cleanup gl precompositor init and provide uses_GL flag

This patch is: Acked-by: Robert Foss On 04/26/2018 09:05 PM, John Stultz wrote: The drm_hwcomposer has its own GL pre-compositor which is used to squish layers when there are more layers then planes on the display hardware. In many ways this duplicates the client-side GL compositing that is

Re: [PATCH hwc 2/4] drm_hwcomposer: Use log/log.h instead of cutils/log.h

This patch is: Acked-by: Robert Foss On 04/26/2018 09:05 PM, John Stultz wrote: When enabling Treble, Android builds are complaining about using cutils/log.h so instead use log/log.h Cc: Marissa Wall Cc: Sean Paul Cc: Dmitry Shmidt Cc: Robert Foss Cc: Matt Szczesiak Cc: Liviu Dudau Cc

Re: [PATCH hwc 1/4] drm_hwcomposer: Andorid.mk : Mark libdrmhwc_utils as vendor module

This patch is: Acked-by: Robert Foss On 04/26/2018 09:05 PM, John Stultz wrote: From: Sumit Semwal To allow drm_hwcomposer to build with Treble, set the libdrmhwc_utils library as a vendor module. Cc: Marissa Wall Cc: Sean Paul Cc: Dmitry Shmidt Cc: Robert Foss Cc: Matt Szczesiak Cc

Re: [PATCH hwc v2 04/18] drm_hwcomposer: Add resource manager class

On 04/18/2018 12:12 PM, Alexandru-Cosmin Gheorghe wrote: On Tue, Apr 17, 2018 at 06:08:06PM +0200, Robert Foss wrote: Hey, On 04/17/2018 05:33 PM, Sean Paul wrote: On Wed, Apr 11, 2018 at 04:22:15PM +0100, Alexandru Gheorghe wrote: Add a resource manager object that is responsible for

Re: [PATCH hwc v2 04/18] drm_hwcomposer: Add resource manager class

Hey, On 04/17/2018 05:33 PM, Sean Paul wrote: On Wed, Apr 11, 2018 at 04:22:15PM +0100, Alexandru Gheorghe wrote: Add a resource manager object that is responsible for detecting all kms devices and allocates unique display numbers for every detected display. This is controlled by the value of

Re: [PATCH hwc v2 03/18] drm_hwcomposer: drmeventlistener: Set nl_pid to 0

Hey Alexandru, Feel free to add my SoB to this patch: Signed-off-by: Robert Foss Rob. On 04/11/2018 05:22 PM, Alexandru Gheorghe wrote: By setting nl_pid to 0, we let the kernel to assign a port for us. In the current implementation there is no way we could create more than one instance for

Re: [PATCH hwc v2 02/18] drm_hwcomposer: vsyncworker: Fix deadlock on exit path

Hey Alexandru, Feel free my SoB on this patch: Signed-off-by: Robert Foss Rob. On 04/11/2018 05:22 PM, Alexandru Gheorghe wrote: vsyncworker::Routine assumes that when -EINTR is returned by WaitForSignalOrExitLocked the lock as been released, which is not true, so it hangs if a vsyncworker

Re: [PATCH hwc v2 01/18] drm_hwcomposer: vsyncworker: Fix uninitialized enabled_ field

Hey Alexandru, Feel free to add: Signed-off-by: Robert Foss Rob. On 04/11/2018 05:22 PM, Alexandru Gheorghe wrote: Signed-off-by: Alexandru Gheorghe --- vsyncworker.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/vsyncworker.cpp b/vsyncworker.cpp index 3ad16fe..3bfe4be 100644

[RFC 0/1] DRM Node Probing functionality

properties and allowing the caller to supply a list of properties that are interesting and their values. In terms of long-term maintainership this might be less pleasant than the approach of the current implementation. Robert Foss (1): xf86drm: Add drmHandleMatch func xf86drm.h | 2 ++ xf86

[RFC 1/1] xf86drm: Add drmHandleMatch func

g the already existing drmVersion and drmDevice structs. Most fields of drmVersion and drmDevice can be used for comparing between the target device and the actual FD that has been provided. Signed-off-by: Robert Foss --- xf86drm.h | 2 ++ xf86drmMode.c

[RFC 0/1] DRM Node Probing functionality

supply a list of properties that are interesting and their values. In terms of long-term maintainership this might be less pleasant than the approach of the current implementation. Robert Foss (1): xf86drm: Add drmHandleMatch func xf86drm.h | 2 ++ xf86

<    3   4   5   6   7   8   9   >