block braces unnecessary. Remove that as well.
>
> Issue identified using platform_get_irq.cocci coccicheck script.
>
> Signed-off-by: Deepak R Varma
Reviewed-by: Stefan Agner
--
Stefan
> ---
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +---
> 1 file changed, 1 inser
ed-off-by: Marek Vasut
> Cc: Alexander Stein
> Cc: Laurent Pinchart
> Cc: Lucas Stach
> Cc: Peng Fan
> Cc: Robby Cai
> Cc: Sam Ravnborg
> Cc: Stefan Agner
> ---
> V2: Check crtc for non-NULL before dereferencing it in
> mxsfb_crtc_set_crc_source
> ---
> d
t; Cc: Robby Cai
> Cc: Sam Ravnborg
> Cc: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/Kconfig | 16 +
> drivers/gpu/drm/mxsfb/Makefile | 2 +
> drivers/gpu/drm/mxsfb/lcdif_drv.c | 367 +
> drivers/gpu/drm/mxsfb/lcd
.
>
> Reported-by: Martin Kepplinger
> Signed-off-by: Guido Günther
> Reviewed-by: Lucas Stach
Acked-by: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/mxsfb_kms.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c
>
On 2021-10-11 15:41, Guido Günther wrote:
> media-bus-formats.h has them in hexadecimal as well so matching with
> that file saves one conversion when debugging.
>
> Signed-off-by: Guido Günther
> Reviewed-by: Lucas Stach
> Reviewed-by: Robert Foss
Acked-by: Stefan Agner
On 2021-10-05 14:35, Matthias Schiffer wrote:
> On Thu, 2021-09-16 at 14:50 +0200, Matthias Schiffer wrote:
>> On Fri, 2020-08-21 at 15:41 +0200, Stefan Agner wrote:
>> > Hi Matthias,
>> >
>> > On 2020-08-20 12:58, Matthias Schiffer wrote:
>> > &g
On 2021-04-15 13:00, Thomas Zimmermann wrote:
> Selecting DRM_FBDEV_EMULATION will include the correct secttings for
> fbdev emulation. Drivers should not override this.
>
> Signed-off-by: Thomas Zimmermann
Acked-by: Stefan Agner
--
Stefan
> ---
> drivers/gpu/drm/mxsfb/
fb: Stop using DRM simple display
> pipeline helper")
Reviewed-by: Stefan Agner
I allowed myself to update the author email to the one used in the
Signed-off-by line as checkpatch.pl printed a warning.
Applied to drm-misc-fixes. Thanks!
--
Stefan
> ---
> drivers/gpu/d
ronization with other devices. Fix
>> this by plugging in the drm_gem_fb_prepare_fb helper function.
>
> This is a regression in the 5.10 release series, so I would appreciate
> if someone could review/ack this patch so I can smash it into
> drm-misc-fixes.
Reviewed-by: Stefan
On 2020-09-11 13:59, Ville Syrjälä wrote:
> On Thu, Sep 10, 2020 at 11:24:24AM +0200, Stefan Agner wrote:
>> Add flag which checks that the framebuffer size matches the plane size
>> exactly. This is useful for display controller which can't handle
>> framebuffers other tha
On 2020-09-11 10:52, Daniel Vetter wrote:
> On Thu, Sep 10, 2020 at 11:24:24AM +0200, Stefan Agner wrote:
>> Add flag which checks that the framebuffer size matches the plane size
>> exactly. This is useful for display controller which can't handle
>> framebuffers other tha
On 2020-09-11 10:50, Daniel Vetter wrote:
> On Thu, Sep 10, 2020 at 11:24:23AM +0200, Stefan Agner wrote:
>> To improve readability and make it easier to add further optional checks
>> replace the boolean parameters with a single flag bitfield as parameter
>> of drm_atomic_hel
On 2020-09-08 16:16, Stefan Agner wrote:
> The lcdif IP does not support a framebuffer pitch (stride) other than
> framebuffer width. Check for equality and reject the framebuffer
> otherwise.
>
> This prevents a distorted picture when using 640x800 and running the
> Mesa gr
Add flag which checks that the framebuffer size matches the plane size
exactly. This is useful for display controller which can't handle
framebuffers other than the plane/CRTC size.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/drm_atomic_helper.c | 7 +++
drivers/gpu/drm
)
+ drm_atomic_helper_check_plane_state(e1, e2, e3, e4, 0)
)
Signed-off-by: Stefan Agner
---
This implements what has been discussed in the thread of the patch
"drm: mxsfb: check framebuffer pitch":
https://lkml.org/lkml/2020/9/8/1342
Before sending it out to all maintainers I wanted to get co
The plane size must match the CRTC already (enforced by not setting
the CAN_POSTION flag). However, the controller also requires the
framebuffer to be exactly the CRTC size. Make use of the new flag
DRM_PLANE_REQUIRE_MATCHING_FB to match the plane size.
Signed-off-by: Stefan Agner
---
drivers
at that particular resolution to width != stride. Currently
Mesa has no fallback behavior, but rejecting this configuration allows
userspace to handle the issue correctly.
Fixes: 45d59d704080 ("drm: Add new driver for MXSFB controller")
Signed-off-by: Stefan Agner
Reviewed-by: Lauren
at that particular resolution to width != stride. Currently
Mesa has no fallback behavior, but rejecting this configuration allows
userspace to handle the issue correctly.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 21 -
1 file changed, 20 insertions(+), 1
On 2020-09-08 14:33, Laurent Pinchart wrote:
> On Tue, Sep 08, 2020 at 02:29:02PM +0200, Daniel Vetter wrote:
>> On Tue, Sep 8, 2020 at 2:07 PM Stefan Agner wrote:
>> > On 2020-09-08 10:48, Daniel Vetter wrote:
>> >> On Tue, Sep 08, 2020 at 11:18:25AM +0300, Tomi Va
On 2020-09-08 10:48, Daniel Vetter wrote:
> On Tue, Sep 08, 2020 at 11:18:25AM +0300, Tomi Valkeinen wrote:
>> Hi,
>>
>> On 08/09/2020 10:55, Stefan Agner wrote:
>> > On 2020-09-07 20:18, Daniel Vetter wrote:
>> >> On Mon, Sep 07, 2020 at 07:17:12PM +0300
On 2020-09-07 20:18, Daniel Vetter wrote:
> On Mon, Sep 07, 2020 at 07:17:12PM +0300, Laurent Pinchart wrote:
>> Hi Stefan,
>>
>> Thank you for the patch.
>>
>> On Mon, Sep 07, 2020 at 06:03:43PM +0200, Stefan Agner wrote:
>> > The lcdif IP does not suppo
at that particular resolution to width != stride. Currently
Mesa has no fallback behavior, but rejecting this configuration allows
userspace to handle the issue correctly.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/mxsfb/mxsfb_kms.c | 22 ++
1 file changed, 18 insertions(+), 4 deletions
On 2020-08-24 01:26, Laurent Pinchart wrote:
> Hi Stefan,
>
> On Fri, Aug 21, 2020 at 04:53:56PM +0200, Stefan Agner wrote:
>> On 2020-08-13 03:29, Laurent Pinchart wrote:
>> > Additional compatible strings have been added in DT source for the
>> > i.MX6SL, i.M
P i.MX LCD Interface (LCDIF)
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e3fac23383d2..fe1bda639a39 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11757,7 +11757,7 @@ M:Stefan Agner
> L: dri-devel@lists.freedesktop.org
> S: Supported
> T: git git://anong
On 2020-08-13 03:29, Laurent Pinchart wrote:
> Additional compatible strings have been added in DT source for the
> i.MX6SL, i.MX6SLL, i.MX6UL and i.MX7D without updating the bindings.
> Most of the upstream DT sources use the fsl,imx28-lcdif compatible
> string, which mostly predates the
Hi Matthias,
On 2020-08-20 12:58, Matthias Schiffer wrote:
> The PIXCLK needs to be enabled in SCFG before accessing the DCU on LS1021A,
> or the access will hang.
Hm, this seems a rather ad-hoc access to SCFG from the DCU. We do
support a pixel clock in the device tree bindings of fsl-dcu, so
On 2020-07-27 04:06, Laurent Pinchart wrote:
> Hello,
>
> This patch series adds i.MX7 support to the mxsfb driver. The eLCDIF
> instance found in the i.MX7 is backward-compatible with the already
> supported LCDC v4, but has extended features amongst which the most
> notable one is a second
On 2020-07-26 20:28, Laurent Pinchart wrote:
> Hi Stefan,
>
> On Fri, Jul 17, 2020 at 05:06:55AM +0300, Laurent Pinchart wrote:
>> On Thu, Jul 09, 2020 at 12:25:42PM +0200, Stefan Agner wrote:
>> > On 2020-06-16 03:50, Laurent Pinchart wrote:
>> >> On Thu, Jun
On 2020-07-16 19:41, Uwe Kleine-König wrote:
> flags is unused since the driver was introduced in commit 45d59d704080
> ("drm: Add new driver for MXSFB controller").
Applied to drm-misc-next. Thanks.
--
Stefan
>
> Signed-off-by: Uwe Kleine-König
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4
On 2020-07-18 19:14, Guido Günther wrote:
> Hi,
> On Mon, Mar 23, 2020 at 04:51:05PM +0100, Lucas Stach wrote:
>> Am Montag, den 23.03.2020, 15:52 +0100 schrieb Guido Günther:
>> > In contrast to other display controllers on imx like DCSS and ipuv3
>> > lcdif/mxsfb does not support detiling e.g.
On 2020-06-11 14:23, Bernard Zhao wrote:
> There are three err return values in drm_fbdev_generic_setup.
> In mxsfb_probe we called this function, but didn`t handle the
> return value, this change is to add err handle, maybe make code
> a bit more readable.
This got recently changed, so I guess
Hi Laurent,
On 2020-06-16 03:50, Laurent Pinchart wrote:
> Hi Stefan,
>
> On Thu, Jun 11, 2020 at 09:33:11PM +0200, Stefan Agner wrote:
>> On 2020-05-30 05:10, Laurent Pinchart wrote:
>> > The DRM simple display pipeline helper only supports a single plane. In
>>
On 2020-05-30 05:10, Laurent Pinchart wrote:
> The LCDIF in the i.MX6SX and i.MX7 have a second plane called the alpha
> plane. Support it.
>
> Signed-off-by: Laurent Pinchart
Looks good to me.
Reviewed-by: Stefan Agner
--
Stefan
> ---
> Changes since v1:
>
> -
, we should add a
default type to avoid warnings for some panels.
Other than that, looks good to me:
Reviewed-by: Stefan Agner
> ---
> Changes since v1:
>
> - Select DRM_PANEL_BRIDGE in Kconfig
> ---
> drivers/gpu/drm/mxsfb/Kconfig | 1 +
> drivers/gpu/drm/
;fb;
> struct drm_gem_cma_object *gem;
>
> if (!fb)
> @@ -190,8 +198,8 @@ static dma_addr_t mxsfb_get_fb_paddr(struct
> mxsfb_drm_private *mxsfb)
>
> static void mxsfb_crtc_mode_set_nofb(struct mxsfb_drm_private *mxsfb)
> {
> - struct drm_device *drm
On 2020-05-30 05:10, Laurent Pinchart wrote:
> This is a cosmetic change only, no code change is included.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.h | 10 +-
> 1 file changed, 5 insertions(+), 5 dele
; expanding it further in the future as support for more SoCs is added.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Stefan Agner
> ---
> Changes since v1:
>
> - Make description more explicit by mentioning LCDIF and eLCDIF
> - Add i.MX8M
> ---
> drivers/gpu/drm/mxsfb/Kc
off-by: Laurent Pinchart
Reviewed-by: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 15 +--
> drivers/gpu/drm/mxsfb/mxsfb_kms.c | 6 +-
> 2 files changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> b/drive
On 2020-06-02 15:12, Daniel Vetter wrote:
> On Sat, May 30, 2020 at 05:14:21AM +0300, Laurent Pinchart wrote:
>> Hi Stefan,
>>
>> On Mon, Mar 23, 2020 at 10:27:21PM +0100, Stefan Agner wrote:
>> > On 2020-03-09 20:51, Laurent Pinchart wrote:
>> > > Replace
On 2020-05-28 10:06, Daniel Vetter wrote:
> On Thu, May 28, 2020 at 9:56 AM Stefan Agner wrote:
>>
>> Hi Daniel,
>>
>> On 2020-05-28 07:46, Daniel Vetter wrote:
>> > On Wed, May 27, 2020 at 11:47:56AM +0200, Daniel Vetter wrote:
>> >> mxsfb
ck we can do
>> the on/off as the first respectively last operation, and it should all
>> work.
>>
>> Signed-off-by: Daniel Vetter
>> Cc: Marek Vasut
>> Cc: Stefan Agner
>> Cc: Shawn Guo
>> Cc: Sascha Hauer
>> Cc: Pengutronix Kernel Team
Hi Laurent,
On 2020-03-09 20:51, Laurent Pinchart wrote:
> Hello,
>
> This patch series adds i.MX7 support to the mxsfb driver. The eLCDIF
> instance found in the i.MX7 is backward-compatible with the already
> supported LCDC v4, but has extended features amongst which the most
> notable one is
On 2020-03-24 00:08, Stefan Agner wrote:
> On 2020-03-09 20:52, Laurent Pinchart wrote:
>> Enable vblank handling when the CRTC is turned on and disable it when it
>> is turned off. This requires moving vblank init after the KMS pipeline
>> initialisation, otherwise drm_vbla
On 2020-03-23 22:38, Sam Ravnborg wrote:
> Hi Stefan.
>
> On Mon, Mar 23, 2020 at 10:27:21PM +0100, Stefan Agner wrote:
>> On 2020-03-09 20:51, Laurent Pinchart wrote:
>> > Replace the manual connector implementation based on drm_panel with the
>> > drm_pan
On 2020-03-09 20:52, Laurent Pinchart wrote:
> The LCDIF in the i.MX6SX and i.MX7 have a second plane called the alpha
> plane. Support it.
>
> Signed-off-by: Laurent Pinchart
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 +
> drivers/gpu/drm/mxsfb/mxsfb_drv.h | 16 ++--
>
update cycle in mxsfb_set_bus_fmt(). Make
> this more efficient by merging them together.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/mxsfb_kms.c | 47 +--
> 1 file changed, 19 insertions(+), 28 deletion
see, we specify the supported plane formats when initializing the
primary/overlay plane.
Reviewed-by: Stefan Agner
--
Stefan
> ---
> drivers/gpu/drm/mxsfb/mxsfb_kms.c | 11 ++-
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_k
On 2020-03-09 20:52, Laurent Pinchart wrote:
> The mxsfb driver is only used by OF platforms. Drop non-OF support.
Nice cleanup. Actually only supported of anyways due to the
pdev->dev.of_node check.
Reviewed-by: Stefan Agner
--
Stefan
>
> Signed-off-by: Laurent Pinchart
>
for support for the additional features.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 14 +-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
>
On 2020-03-09 20:52, Laurent Pinchart wrote:
> Extend the Kconfig option description by listing the i.MX7 SoCs, as they
> are supported by the same driver.
Can you also add "i.MX8M" to the list since the bindings for this driver
are also used in arch/arm64/boot/dts/freescale/imx8mq.dtsi.
--
On 2020-03-09 20:52, Laurent Pinchart wrote:
> The debug0 and ipversion fields of the mxsfb_devdata structure are
> unused. Remove them.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4
> drivers/gpu/drm/
On 2020-03-09 20:52, Laurent Pinchart wrote:
> Enable vblank handling when the CRTC is turned on and disable it when it
> is turned off. This requires moving vblank init after the KMS pipeline
> initialisation, otherwise drm_vblank_init() gets called with 0 CRTCs.
>
> Signed-off-by: Laurent
() as is calls .disable_vblank() manually and is
> used both at probe and remove time.
>
> The clock disabling is also moved to the last step of the
> mxsfb_crtc_atomic_disable() function, to prepare for enabling vblank
> handling.
>
> Signed-off-by: Laurent Pinchart
Looks go
now that we no
longer use the simple display pipeline we can and should use the flush
callback).
Otherwise looks good.
Reviewed-by: Stefan Agner
--
Stefan
>
> Signed-off-by: Laurent Pinchart
> ---
> drivers/gpu/drm/mxsfb/mxsfb_kms.c | 35 ++-
> 1
On 2020-03-09 20:52, Laurent Pinchart wrote:
> The mxsfb_crtc.c file doesn't handle just the CRTC, but also the other
> KMS objects. Rename it accordingly.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/Makefile
On 2020-03-09 20:52, Laurent Pinchart wrote:
> The DRM simple display pipeline helper only supports a single plane. In
> order to prepare for support of the alpha plane on i.MX6SX and i.MX7,
> move away from the helper. No new feature is added.
>
> Signed-off-by: Laurent Pinchart
I actually
On 2020-03-09 20:52, Laurent Pinchart wrote:
> A fair number of includes are not needed. Drop them, and add a couple of
> required includes that were included indirectly.
>
> Signed-off-by: Laurent Pinchart
Out of curiosity, do you have some kind of tool helping with this?
Reviewe
On 2020-03-09 20:52, Laurent Pinchart wrote:
> mxsfb_crtc.c defines several macros related to register addresses and
> bit, which duplicates macros from mxsfb_regs.h. Use the macros from
> mxsfb_regs.h instead and remove them.
>
> Signed-off-by: Laurent Pinchart
Reviewed-b
inchart
Reviewed-by: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
> b/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
> index be60c4021e2f..722bd9b4f5
On 2020-03-09 20:52, Laurent Pinchart wrote:
> The mxsfb_reset_block() function isn't special, pass it the
> mxsfb_drm_private pointer instead of a pointer to the base address.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb
pply anymore (the bus width can be specified through the
> display_info bus format).
Reviewed-by: Stefan Agner
>
> Signed-off-by: Laurent Pinchart
> ---
> drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 17 +
> drivers/gpu/drm/mxsfb/mxsfb_regs.h | 17 -
>
On 2020-03-09 20:51, Laurent Pinchart wrote:
> mxsfb_regs.h defines macros related to register bits. Some of them are
> not used and don't clearly map to any particular register, so their
> purpose isn't known. Remove them.
>
> Signed-off-by: Laurent Pinchart
Reviewed-b
; Signed-off-by: Laurent Pinchart
Reviewed-by: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/mxsfb_regs.h | 56 +++---
> 1 file changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_regs.h
> b/drivers/gpu/drm/mxsfb/mxsfb
On 2020-03-09 20:51, Laurent Pinchart wrote:
> Replace the manual connector implementation based on drm_panel with the
> drm_panel_bridge helper. This simplifies the mxsfb driver by removing
> connector-related code, and standardizing all pipeline control
> operations on bridges.
>
> A hack is
f1028d74 ("drm/mxsfb: Use drm_fbdev_generic_setup()")
> Signed-off-by: Laurent Pinchart
Reviewed-by: Stefan Agner
I guess this could be merge independent of the rest already today.
--
Stefan
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff
On 2020-02-05 23:50, Joe Perches wrote:
> On Wed, 2020-02-05 at 23:26 +0100, Stefan Agner wrote:
>> Clang prints a warning:
>> drivers/gpu/drm/drm_lock.c:363:6: warning: misleading indentation;
>> statement is not part of the previous 'if' [-Wmisleading-indentation]
>>
ere
if (!drm_core_check_feature(dev, DRIVER_LEGACY))
^
Fix this by adding a newline after the multi-line comment.
Fixes: 058ca50ce3f1 ("drm/legacy: move lock cleanup for master into lock file
(v2)")
Link: https://github.com/ClangBuiltLinux/linux/issues/855
Signed-off-by:
On 2019-11-14 14:17, Marek Vasut wrote:
> The bus_flags and bus_format handling logic does not seem to cover
> all potential usecases. Specifically, this seems to fail with an
> "edt,etm0700g0edh6" display attached to an 24bit display interface,
> with interface-pix-fmt = "rgb24" set in DT.
>
>
Hi Laurent,
On 2019-11-01 09:43, Laurent Pinchart wrote:
> Hello,
>
> I'm looking at the available options to support overlays in the display
> pipeline of the i.MX7. The LCDIF itself unfortunaltey doesn't support
> overlays, the feature being implemented in the PXP. A driver for the PXP
> is
On 2019-08-29 13:30, Robert Chiras wrote:
> From: Guido Günther
>
> The bridge might have special requirmentes on the input bus. This
> is e.g. used by the imx-nwl bridge.
>
> Signed-off-by: Guido Günther
> Reviewed-by: Stefan Agner
Applied to the drm-misc-next branch
On 2019-08-29 13:30, Robert Chiras wrote:
> Currently, the MXSFB DRM driver only supports a panel. But, its output
> display signal can also be redirected to another encoder, like a DSI
> controller. In this case, that DSI controller may act like a drm_bridge.
> In order support this use-case too,
On 2019-08-29 13:30, Robert Chiras wrote:
> Use BIT(x) and GEN_MASK(h, l) for better representation the inside of
> various registers.
>
> Signed-off-by: Robert Chiras
> Tested-by: Guido Günther
> ---
> drivers/gpu/drm/mxsfb/mxsfb_regs.h | 151
> ++---
> 1 file
On 2019-08-29 13:30, Robert Chiras wrote:
> Some of the registers, like LCDC_CTRL, CTRL2_OUTSTANDING_REQS and
> CTRL1_RECOVERY_ON_UNDERFLOW needs to be properly cleared/initialized
> for a better start and stop routine.
This patch uses CTRL2_OUTSTANDING_REQS which is only introduced in the
next
Hi Robert,
Sorry it took me so long to have a closer look at this patchset.
I will definitely merge part of it, but this particular patch actually
breaks i.MX 7. I have vertical stripes on my display with this patch
applied (using Weston with DRM backend). Not sure why this exactly
happens, from
On 2019-08-26 14:05, Guido Günther wrote:
> Hi,
> On Wed, Aug 21, 2019 at 01:15:40PM +0300, Robert Chiras wrote:
>> This patch-set improves the use of eLCDIF block on iMX 8 SoCs (like 8MQ, 8MM
>> and 8QXP). Following, are the new features added and fixes from this
>> patch-set:
>
> I've applied
On 2019-08-14 13:14, Robert Chiras wrote:
> Hi Stefan,
> On Mi, 2019-08-14 at 13:03 +0200, Stefan Agner wrote:
>> On 2019-08-14 12:48, Robert Chiras wrote:
>> >
>> > Add new optional property 'max-res', to limit the maximum supported
>> > resolution by the MX
On 2019-08-14 12:48, Robert Chiras wrote:
> Some of the regiters need, like LCDC_CTRL and CTRL2_OUTSTANDING_REQS
Typo in registers, and there is a need to many.
> needs to be properly cleared and initialized for a better start and stop
> routine.
>
> Signed-off-by: Robert Chiras
> ---
>
On 2019-08-14 12:48, Robert Chiras wrote:
> Currently, the enable of the axi clock return status is ignored, causing
> issues when the enable fails then we try to disable it. Therefore, it is
> better to check the return status and disable it only when enable
> succeeded.
Is this actually the
On 2019-08-14 12:48, Robert Chiras wrote:
> Add new optional property 'max-res', to limit the maximum supported
> resolution by the MXSFB_DRM driver.
I would also mention the reason why we need this.
I guess this needs a vendor prefix as well (fsl,max-res). I also would
like to have the ack of
On 2019-08-04 22:16, Sam Ravnborg wrote:
> Use the drm_panel_get_modes() function.
Looks good to me,
Acked-by: Stefan Agner
--
Stefan
>
> Signed-off-by: Sam Ravnborg
> Cc: Marek Vasut
> Cc: Stefan Agner
> Cc: Shawn Guo
> Cc: Sascha Hauer
> Cc: Pengutronix
On 2019-08-04 22:16, Sam Ravnborg wrote:
> Use drm_panel_get_modes() to access modes.
> This has a nice side effect to simplify the code.
>
> Signed-off-by: Sam Ravnborg
> Cc: Stefan Agner
> Cc: Alison Wang
> ---
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 10 +--
On 2019-07-26 16:46, Dmitry Osipenko wrote:
> 26.07.2019 17:23, Stefan Agner пишет:
>> Hi Thierry, Hi Dave,
>>
>> On 2018-09-07 01:31, Stefan Agner wrote:
>>> On 26.07.2018 06:36, Stefan Agner wrote:
>>>> If the GPIO subsystem is not ready make sure to ret
Hi Thierry, Hi Dave,
On 2018-09-07 01:31, Stefan Agner wrote:
> On 26.07.2018 06:36, Stefan Agner wrote:
>> If the GPIO subsystem is not ready make sure to return -EPROBE_DEFER
>> instead of silently continuing without HPD.
>>
>> Reported-by: Marcel Ziswiler
>
*timings;
> + unsigned int type;
How about connector_type? That is how this field is named in other
places.
Otherwise looks good to me.
Reviewed-by: Stefan Agner
--
Stefan
> +};
> +
> struct simple_bridge {
> struct drm_bridge bridge;
> str
s good to me.
Reviewed-by: Stefan Agner
--
Stefan
> ---
> drivers/gpu/drm/bridge/simple-bridge.c | 22 ++
> 1 file changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/simple-bridge.c
> b/drivers/gpu/drm/bridge/simple-bridge.c
>
On 2019-07-26 11:49, Guido Günther wrote:
> The bridge might have special requirmentes on the input bus. This
> is e.g. used by the imx-nwl bridge.
>
> Signed-off-by: Guido Günther
Looks good to me.
Reviewed-by: Stefan Agner
That is similar to what I sent for the imx DRM dr
On 2019-07-15 18:28, Sam Ravnborg wrote:
> On Fri, Jul 05, 2019 at 10:47:30PM +0200, Stefan Agner wrote:
>> On 2019-06-30 08:18, Sam Ravnborg wrote:
>> > Drop use of the deprecated drmP.h header file.
>> >
>> > While touching the list of include files divid
arek Vasut
> Cc: Stefan Agner
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Shawn Guo
> Cc: Sascha Hauer
> Cc: Pengutronix Kernel Team
> Cc: Fabio Estevam
> Cc: NXP Linux Team
> Cc: linux-arm-ker...@lists.infradead.org
Acked-by: Stefan Agner
--
Stefan
> ---
On 2019-06-30 08:18, Sam Ravnborg wrote:
> Drop use of the deprecated drmP.h header file.
> Fix fallout.
>
> Signed-off-by: Sam Ravnborg
> Cc: Stefan Agner
> Cc: Alison Wang
Acked-by: Stefan Agner
--
Stefan
> ---
> The list of cc: was too large to add all recipi
On 14.06.2019 22:35, Daniel Vetter wrote:
> They're the default.
>
> Aside: Would be really nice to switch the others over to
> drm_gem_object_funcs.
Acked-by: Stefan Agner
--
Stefan
>
> Signed-off-by: Daniel Vetter
> Cc: Stefan Agner
> Cc: Alison Wang
> ---
On 14.06.2019 22:35, Daniel Vetter wrote:
> They're the default.
>
> Aside: Would be really nice to switch the others over to
> drm_gem_object_funcs.
Acked-by: Stefan Agner
--
Stefan
>
> Signed-off-by: Daniel Vetter
> Cc: Marek Vasut
> Cc: Stefan Agner
> Cc: Sh
On 11.04.2019 10:23, Ben Dooks wrote:
> On 2019-04-10 23:47, Stefan Agner wrote:
>> In case the IOMMU API is not available compiling host1x fails with
>> the following error:
>> In file included from drivers/gpu/host1x/hw/host1x06.c:27:
>> drivers/gpu/host1x/h
c_free
Fixes: de5469c21ff9 ("gpu: host1x: Program the channel stream ID")
Signed-off-by: Stefan Agner
---
drivers/gpu/host1x/hw/channel_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/host1x/hw/channel_hw.c
b/drivers/gpu/host1x/hw/channel_hw.c
in
t
> Acked-by: Linus Walleij
Reviewed-by: Stefan Agner
--
Stefan
> ---
> Changes since v1:
>
> - Clarify commit message
> - Address the DRM_BUS_FLAG_SYNC_* flags
> - Rebase on top of drm-next
> ---
> drivers/gpu/drm/bridge/dumb-vga-dac.c | 6 ++---
> drivers
gt; the driving and sampling edge in their name to remove the confusion. The
> driving macros are defined as the opposite of the sampling macros to
> made code simpler based on the assumption that the driving and sampling
> edges are opposite.
>
> Signed-off-by: Laurent Pinchart
>
On 09.01.2019 15:13, Robert Chiras wrote:
> Currently, the enable of the axi clock return status is ignored, causing
> issues when the enable fails then we try to disable it. Therefore, it is
> better to check the return status and disable it only when enable
> succeeded.
> Also, remove the helper
On 02.01.2019 18:02, Ahmad Fatoum wrote:
> Hello,
>
> I got a board with the RED[0:7]/BLUE[0:7] lanes originating from the
> LCDIF swapped and would like to describe this in the device tree:
>
> This first patch extends the mxsfb driver to support
> following bus formats:
>
On 05.12.2018 11:42, Tomi Valkeinen wrote:
> Hi,
>
> On 05/12/18 10:49, Laurent Pinchart wrote:
>> From: Laurent Pinchart
>>
>> The DRM_BUS_FLAG_PIXDATA_(POS|NEG)EDGE and
>> DRM_BUS_FLAG_SYNC_(POS|NEG)EDGE flags are deprecated in favour of the
>> new
s/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 ++--
> drivers/gpu/drm/etnaviv/etnaviv_drv.c| 4 ++--
> drivers/gpu/drm/mxsfb/mxsfb_drv.c| 4 ++--
For mxsfb:
Acked-by: Stefan Agner
--
Stefan
> drivers/gpu/drm/rcar-du/rcar_du_drv.c| 2 +-
> drivers/gpu/drm
On 17.10.2018 13:25, Stefan Agner wrote:
> On 16.10.2018 18:09, Stefan Agner wrote:
>> This reverts commit 8e3b16e2117409625b89807de3912ff773aea354.
>>
>> Using the component framework requires all components to undo in
>> ->unbind what ->bind does. Unfortunatel
1 - 100 of 457 matches
Mail list logo
