naviv: request pages from DMA32 zone when needed")
Suggested-by: Sui Jingfeng
Signed-off-by: Xiaolei Wang
---
change log
v1:
https://patchwork.kernel.org/project/dri-devel/patch/20240806104733.2018783-1-xiaolei.w...@windriver.com/
v2:
Modify the issue of not retaining GFP_USER in v1
ev' uniformly.
Tested-by: Christian Gmeiner
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 10 +-
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 16
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_d
.
It also could lead to problems if mutex_destroy() gets extended, add
missing mutex_destroy() to eliminate potential concerns.
Reviewed-by: Christian Gmeiner
Signed-off-by: Sui Jingfeng
---
v2: Pick up tags and fix one more missing mutex_destroy()
drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c | 2
Currently, the etnaviv_gem_submit.c isn't call any runtime power management
functions. So drop this unused header, we can include it back when it
really get used though.
Reviewed-by: Christian Gmeiner
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 1 -
1
y: Christian Gmeiner
Signed-off-by: Sui Jingfeng
---
v2: Pick up tags and improve commit message
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index 5ffc31
Reviewed-by: Christian Gmeiner
Signed-off-by: Sui Jingfeng
---
v2: Pick up tags and improve commit message
drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
b/drivers/gpu/drm/etn
.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/Makefile | 1 +
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 12 +
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 11 +
drivers/gpu/drm/etnaviv/etnaviv_gem.h | 5 +
drivers/gpu/drm/etnaviv/etnaviv_gem_vram.c | 258
Passed: 8294400 bytes
Test Write to SHMEM 8294400 bytes
Write to SHMEM Passed: 8294400 bytes
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/Makefile | 1 +
drivers/gpu/drm/etnaviv/etnaviv_debugfs.c | 118 +
drivers/gpu/drm/etnaviv/etnaviv_debugfs.h | 15
Otherwise we don't know where a etnaviv GEM buffer object should put when
we create it at userspace.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 9 +
include/uapi/drm/etnaviv_drm.h| 12
2 files changed, 21 insertions(+)
diff --
now,
since the ernaviv_gem_new_private() has been unified. Make the
etnaviv_gem_obj_add() static is a next nature thing.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 8 +++-
drivers/gpu/drm/etnaviv/etnaviv_gem.h | 1 -
drivers/gpu/drm/etnaviv/etnaviv_gem_pr
Because some PCIe IP need special setup before its VRAM bar can be usable,
do this with instance specific object function.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/Makefile | 3 +-
drivers/gpu/drm/etnaviv/etnaviv_pci_drv.c | 19
drivers/gpu/drm/etnaviv
r handling anymore.
if true, the drm_gem_object_init() will allocate backing storage for us,
then this is a shmem buffer object. if false, we have to implement driver
specific backing storage.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 28 +
drive
.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/Kconfig | 9 ++
drivers/gpu/drm/etnaviv/Makefile | 2 +
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 45 +-
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 11 ++
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 73
uture if it
not reflect the hardware perfectly.
Expose it via etnaviv parameter mechanism to let userspace know.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 3 +++
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 9 +
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4
i
Which is corresonding to the etnaviv_gem_obj_add()
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index
containing structure.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c| 65
drivers/gpu/drm/etnaviv/etnaviv_drv.h| 7 +++
drivers/gpu/drm/etnaviv/etnaviv_gem.c| 4 +-
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +-
drivers/gpu/d
dedicated helpers introduced, etnaviv_bind() and
etnaviv_unbind() gets simplified. Another potential benefit is that
we could put the struct drm_device into struct etnaviv_drm_private
in the future, which made them share the same life time.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etn
rying to vmap a
DMABUF")
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index 1fd2cff20ef4..b899aea64
code blocks,
which make it easier to call this function on the platform where it works.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 53 ---
1 file changed, 32 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
b/dr
drm_WARN_ON() acts like WARN_ON(), but with the key difference of
using device specific information so that we know from which device
the warning is originating from.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 9 +
drivers/gpu/drm/etnaviv
Because this make the code more easier to understand, When GPU access the
VRAM, it will allocate a new mapping to use if there don't have one.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 40 +++
drivers/gpu/drm/etnaviv/etnaviv_gem.h
has
etnaviv_gem_prime_vmap_impl() as the implementation to vmap
a imported GEM buffer object.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 -
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 16 +++-
drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 12
. As then, the etnaviv_gem_xxx_release()
only need to responsible for the release page works.
The etnaviv_gem_vunmap() is added for driver internal usa case, where no
DRM GEM framework is involved.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 +
drivers/gpu/drm
This will make the newly implemented etnaviv_gem_object_funcs::print_info
get in use, which improves code sharing and simplifies debugfs. Achieve
better humen readability for debug log.
Use container_of_const() if 'struct etnaviv_gem_object *etnaviv_obj' is a
constant pointer.
Signed-o
It will be called by drm_gem_print_info() if implemented, and it can
provide more information about the framebuffer objects.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 32 +++
drivers/gpu/drm/etnaviv/etnaviv_gem.h | 2 +-
2 files changed, 33
card. Select the PCIe device as parent, generate a
virtual platform device as component master to take over the bind actions.
Sui Jingfeng (19):
drm/etnaviv: Implement drm_gem_object_funcs::print_info()
drm/etnaviv: Export drm_gem_print_info() and use it
drm/etnaviv: Implement
ernel."
However, drm/etnaviv will use the pages to implement vmap and mmap
operations of the GEM object function. The flag still set at present.
When we can't get pages, it certainly is a bug. Hence, we should print
this kind of error with drm_err() instead of dev_dbg().
Signed-off-b
Hi, Xiaolei
Thanks for your nice catch! I have more to say.
On 2024/8/16 09:55, Wang, Xiaolei wrote:
Ping ...
32 address -> 32-bit address,
Perhaps, we could improve the commit title a little bit
by writing a more accurate sentence if possible, say:
drm/etnaviv: Properly request pages from
On 2024/8/31 03:40, Sui Jingfeng wrote:
Hi, Xiaolei
On 2024/8/16 09:55, Wang, Xiaolei wrote:
Ping ...
I think, the more proper fix that Lucas hint
is to modify the 'priv->shm_gfp_mask' variable
in the|etnaviv_bind() function|. Say:
|Use "priv->shm_gfp_mask = GFP_USER
Hi, Xiaolei
On 2024/8/16 09:55, Wang, Xiaolei wrote:
Ping ...
I think, the more proper fix that Lucas hint
is to modify the 'priv->shm_gfp_mask' variable
in the|etnaviv_bind() function|. Say:
|Use "priv->shm_gfp_mask = GFP_USER | __GFP_RETRY_MAYFAIL | __GFP_NOWARN;"|
instead of
|"priv->shm_
objects, 2490368 bytes
Sui Jingfeng (2):
drm/etnaviv: Implement drm_gem_object_funcs::print_info()
drm/etnaviv: Export drm_gem_print_info() and use it
drivers/gpu/drm/drm_gem.c | 1 +
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 43 ++-
drivers/gpu/drm/etnaviv
This will make the newly implemented etnaviv_gem_object_funcs::print_info
get in use, which improves code sharing and simplifies debugfs. Achieve
better humen readability for debug log.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/drm_gem.c | 1 +
drivers/gpu/drm/etnaviv
It will be called by drm_gem_print_info() if have implemented, and this can
provide more information about the framebuffer objects.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 32 +++
drivers/gpu/drm/etnaviv/etnaviv_gem.h | 2 +-
2 files
The unpin_user_pages() function takes an unsigned long argument to store
length of the number of user space pages, and struct drm_gem_object::size
is a size_t type. The number of pages can not be negative, hence, use an
unsigned variable to store the number of pages.
Signed-off-by: Sui Jingfeng
type.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
index 3524b5811682..6b98200068e4 100644
--- a/drivers/gpu
Currently, the etnaviv_gem_submit.c isn't call any runtime power management
functions. So drop it, we can re-include it when the header really get used
though.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/dr
.
It also could lead to problems if mutex_destroy() gets extended, add
missing mutex_destroy() to eliminate potential concerns.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c | 3 +++
drivers/gpu/drm/etnaviv/etnaviv_drv.c| 1 +
drivers/gpu/drm/etnaviv/etnaviv_gem.c
drm_WARN_ON() acts like WARN_ON(), but with the key difference of
using device specific information so that we know from which device
warning is originating from.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 9 +
drivers/gpu/drm/etnaviv
Hi,
On 2024/8/20 15:39, Thomas Zimmermann wrote:
Hi
Am 19.08.24 um 10:52 schrieb Sui Jingfeng:
Hi, Thomas
I love your patch, yet ...
On 2024/8/16 20:23, Thomas Zimmermann wrote:
i915's fbdev contains additional code for hotplugging a display that
cannot be ported to the common
is
is the default if no format has been given, leave it out entirely.
Signed-off-by: Thomas Zimmermann
Thanks,
Acked-by: Sui Jingfeng
--
Best regards,
Sui
Hi, Thomas
I love your patch, yet ...
On 2024/8/16 20:23, Thomas Zimmermann wrote:
i915's fbdev contains additional code for hotplugging a display that
cannot be ported to the common fbdev client. Introduce the callback
struct drm_fb_helper.fb_hotplug and implement it for i915. The fbdev
help
Hi,
On 2024/7/31 15:09, Thomas Zimmermann wrote:
Fix support for VBLANK interrupts on G200ER, G200EV and G200SE, which
use a slightly different implementation than the others. The original
commits forgot to update the custom helpers when adding interrupt
handling for VBLANK events.
Signed-off-
Hi,
On 2024/7/29 15:15, Markus Elfring wrote:
…
the driver is loaded, drm/loongson driver still need to wait all of
needs to wait on …?
…
design. Therefore, add a dummy driver for the GPU, …
Is there a need to reconsider the categorisation
Hi,
On 2024/7/29 14:40, Markus Elfring wrote:
…
+++ b/drivers/gpu/drm/loongson/loongson_drv.h
@@ -0,0 +1,108 @@
…
+#ifndef __LOONGSON_DRV_H__
+#define __LOONGSON_DRV_H__
…
I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do
Hi,
On 2024/7/29 15:37, Markus Elfring wrote:
…
+++ b/drivers/gpu/drm/loongson/loongson_drv.c
@@ -0,0 +1,298 @@
…
+static int loongson_drm_driver_probe(struct platform_device *pdev)
+{
…
+ dev_info(&pdev->dev, "probed\n");
…
+}
…
Do you find such information really relevant?
T
before it can register DRM service to user space.
The newly introduced component framework allow us to use loose coupling
design. Therefore, add a dummy driver for the GPU, it is functional as
a subcomponent as well.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/loongson/Makefile | 3
y, as those entities do not belong to the LSDC itself.
They are common resources.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/loongson/Makefile | 2 +
drivers/gpu/drm/loongson/loongson_device.c| 30 ++
drivers/gpu/drm/loongson/loongson_drv.c | 298 +++
driv
from VRAM to GTT in 13480ms: 36MB/s
Also run IGT kms_flip and fbdev tests, no obvious problems found.
Sui Jingfeng (2):
drm/loongson: Introduce component framework support
drm/loongson: Add dummy gpu driver as a subcomponent
drivers/gpu/drm/loongson/Makefile | 5 +
drivers/gpu/
Hi,
On 7/28/24 04:28, Dmitry Baryshkov wrote:
On Sun, Jul 28, 2024 at 03:10:21AM GMT, Sui Jingfeng wrote:
Hi,
On 7/28/24 00:39, Dmitry Baryshkov wrote:
Hi,
This patch series aims to add Freescale i.MX8qxp Display Controller support.
The controller is comprised of three main components that
Hi,
On 7/28/24 00:39, Dmitry Baryshkov wrote:
Hi,
This patch series aims to add Freescale i.MX8qxp Display Controller support.
The controller is comprised of three main components that include a blit
engine for 2D graphics accelerations, display controller for display output
processing, as wel
Hi,
On 7/24/24 15:30, Markus Elfring wrote:
In some display subsystems, the functionality of a PCIe device may too
might be?
…
of the dirver is loaded, …
driver?
…
its dependencies ready before it can register
and power management
part to loongson drm proxy, as they do not belong to the LSDC itself.
While at it, also do some cleanups.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/loongson/Makefile | 6 +
drivers/gpu/drm/loongson/loonggpu_pci_drv.c | 163
drivers/gpu/drm/loongso
B/s
Copy bo of 8100KiB 60 times from GTT to VRAM in 104ms: 4673MB/s
Copy bo of 8100KiB 60 times from VRAM to GTT in 13480ms: 36MB/s
Also run IGT kms_flip and fbdev tests, no obvious problem found.
Sui Jingfeng (1):
drm/loongson: Introduce component framework support
drivers/gpu/drm/loo
61] loongson :00:06.1: [drm] fb0: loongsondrmfb frame buffer
device
Sui Jingfeng (1):
drm/loongson: Introduce component framework support
drivers/gpu/drm/loongson/Makefile | 5 +
drivers/gpu/drm/loongson/loonggpu_pci_drv.c | 156
drivers/gpu/drm/loongson/loonggpu_pc
DEFER' back to the driver core if it needs
to do so.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/loongson/Makefile | 5 +
drivers/gpu/drm/loongson/loonggpu_pci_drv.c | 156
drivers/gpu/drm/loongson/loonggpu_pci_drv.h | 33 +++
drivers/gpu/drm/loong
Hi,
On 6/25/24 11:18, Icenowy Zheng wrote:
在 2024-05-20星期一的 00:53 +0800，Sui Jingfeng写道：
drm/etnaviv use the component framework to bind multiple GPU cores to
a
virtual master, the virtual master is manually create during driver
load
time. This works well for various SoCs, yet there are some
Hi,
On 6/23/24 03:29, Dmitry Torokhov wrote:
In case of non-OF match (which
includes the case where you use software nodes) the match data is coming
from matching spi_device_id entry in the driver.
We don't care about much how it is probed now, rather, after the driver
probed by a non-OF way,
Hi,
On 6/22/24 03:58, Dmitry Torokhov wrote:
Hi Sui,
On Sun, Apr 28, 2024 at 04:36:50AM +0800, Sui Jingfeng wrote:
Because the software node backend of the fwnode API framework lacks an
implementation for the .device_get_match_data function callback. This
makes it difficult to use(and/or test
d-by: Alexandre Mergnat
Signed-off-by: AngeloGioacchino Del Regno
Acked-by: Sui Jingfeng
Hi, Jayesh
On 5/31/24 21:33, Sam Ravnborg wrote:
Hi Jayesh,
+
static const struct drm_bridge_funcs sii902x_bridge_funcs = {
.attach = sii902x_bridge_attach,
.mode_set = sii902x_bridge_mode_set,
@@ -516,6 +529,7 @@ static const struct drm_bridge_funcs sii902x_bridge_funcs =
ncoder has this flag enabled.
So move the mode_valid hook to drm_bridge_funcs with proper clock
checks for maximum and minimum pixel clock supported by the bridge.
Signed-off-by: Jayesh Choudhary
Acked-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/sii902x.c | 32 +++---
Hi,
On 5/30/24 17:29, Jayesh Choudhary wrote:
Move the mode_valid hook to drm_bridge_funcs structure to take care
of the case when the encoder attaches the bridge chain with the
DRM_BRIDGE_ATTACH_NO_CONNECTOR flag in which case, the connector is not
initialized in the bridge's attach call and mo
Hi,
On 5/31/24 05:14, Sam Ravnborg wrote:
Drop myself as reviewer of panel patches, to reflect the reality.
We lost one kindness reviewer for drivers of panel, unhappy!
Not sure if it is proper to give you a NAK here. :(
Best regards,
Sui
Signed-off-by: Sam Ravnborg
Cc: Neil Armstrong
--
isable_all/drm_atomic_helper_shutdown/]
[geert: shmob_drm_remove() already calls drm_atomic_helper_shutdown]
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Laurent Pinchart
Reviewed-by: Sui Jingfeng
Best regards,
Sui
:
Acked-by: Sui Jingfeng
---
Tested on Koelsch (R-Car M2-W).
Support for DU variants using the VSP-compositor is more convoluted,
and left to the DU experts.
---
drivers/gpu/drm/renesas/rcar-du/rcar_du_plane.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a
Hi,
On 5/27/24 21:34, Geert Uytterhoeven wrote:
Add support for the drm_panic module, which displays a message on
the screen when a kernel panic occurs.
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Jocelyn Falempe
Acked-by: Sui Jingfeng
---
Tested on Armadillo-800-EVA.
---
drivers
R [=n]
Selected by [y]:
- DRM_KUNIT_TEST [=y] && HAS_IOMEM [=y] && DRM [=y] && KUNIT [=y] && MMU [=y]
Signed-off-by: Thomas Hellström
Fixes: 54cb39e2293b ("drm/connector: hdmi: Create an HDMI sub-state")
Cc: Maxime Ripard
Cc: dri-devel@lists.freedesktop.org
Acked-by: Sui Jingfeng
Hi,
On 5/27/24 21:57, Maxime Ripard wrote:
Now that we're tracking the output bpc count in the connector state,
let's add a few tests to make sure it works as expected.
Reviewed-by: Dave Stevenson
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Maxime Ripard
Tested-by: Sui Jingfeng
0x02, 0x03, 0x1b, 0x81,
+ 0xe3, 0x05, 0x00, 0x20, 0x41, 0x10, 0xe2, 0x00, 0x4a, 0x6d, 0x03, 0x0c,
+ 0x00, 0x12, 0x34, 0x00, 0x28, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0xd0
+};
+
+#endif // DRM_KUNIT_EDID_H_
--
Best regards
Sui Jingfeng
the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Sui-Jingfeng/drm-bridge-Allow-using-fwnode-APIs-to-ge
Hi,
On 5/27/24 05:19, Dmitry Baryshkov wrote:
On Mon, May 27, 2024 at 04:21:07AM +0800, Sui Jingfeng wrote:
Normally, the drm_bridge::of_node won't be used by bridge driver instances
themselves. Rather, it is mainly used by other modules to find associated
drm bridge drvier. Therefore, a
Use the freshly created helper to replace the use of DT-dependent APIs,
also print error log if the fwnode graph is not complete which is benefit
to debug.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/chrontel-ch7033.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions
Make this driver less DT-dependent by calling the newly created helpers,
also switch to use fwnode APIs to acquire additional device properties.
No functional changes for DT-based systems.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/ti-tfp410.c | 39 +++---
1
and avoid directly referencing and/or dereferencing
it.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/sii9234.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c
index 7d2bbc31bac9..d930c093abb3 10
Make this driver less DT-dependent by calling the newly created helpers,
also switch to use fwnode APIs to acquire additional device properties.
A side benifit is that boilerplates get reduced, no functional changes
for DT-based systems.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge
Make this driver less DT-dependent by calling the freshly created helpers,
also switch to use fwnode APIs to acquire additional device properties.
One side benifit is that boilerplates get reduced, no functional changes
for DT-based systems.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm
Switch to use the fwnode APIs, which is a fundamental step to make this
driver OF-independent possible. No functional changes for DT-based systems.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/display-connector.c | 23 +++---
1 file changed, 11 insertions(+), 12
y both of drm_bridge_add() and
devm_drm_bridge_add(). A lot of driver instances has already added it into
their derived structure, promote it into drm_bridge core helps to reduce
a batch of boilerplates.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 3 +--
.../gpu/drm/brid
Make this driver less DT-dependent by calling the newly created helpers,
also switch to use fwnode APIs to acquire additional device properties.
A side benifit is that boilerplates get reduced, no functional changes
for DT-based systems.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge
Before applying this patch, people may worry about the OF and non-OF API
will have a risk to diverge. Eliminate the risk by reimplement the
of_drm_find_bridge() on the top of drm_bridge_find_by_fwnode(). As for now
the fundamental searching method is unique.
Signed-off-by: Sui Jingfeng
Note, the involved drm bridge instance should also has the fwnode
assigned, so that the user of it could find it via the fwnode handle.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/drm_bridge.c | 74
include/drm/drm_bridge.h | 11 +-
2 files ch
message and function comments
v4 -> v5:
* Modify sii9234, ch7033 and ANX7688
* Trivial fixes
v5 -> v6:
* Implement the same thing with no boilerplate introduced
* Add 'struct device *' field to the drm_bridge structure
* Re-implement of_drm_find_
subcomponent as well.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/loongson/Makefile| 3 +
drivers/gpu/drm/loongson/loong_gpu_pci_drv.c | 90
drivers/gpu/drm/loongson/loong_gpu_pci_drv.h | 27 ++
drivers/gpu/drm/loongson/loongson_module.c | 9 ++
drivers/gpu
bind until all submodules
are ready.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/loongson/Makefile | 1 +
drivers/gpu/drm/loongson/loongson_module.c| 17 +-
drivers/gpu/drm/loongson/loongson_module.h| 1 +
drivers/gpu/drm/loongson/lsdc_drv.c | 205 ++
dependency problems if not process correctly.
Add the loongson_create_platform_device() function, which allows the KMS
driver to create sub-devices for it. The manually created decice acts as
agents for the principal part, migrate the potential issue to submodule.
Signed-off-by: Sui Jingfeng
---
d
.
This allows the master don't have to tear down everything, thereore
majority setups work can be preserved. The potential cyclic dependency
problem can be solved then.
v1 -> v2:
* Squash patch 0002 and patch 0003 into one
* Fill type and improve commit message
Sui Jin
Hi, Maxime
I love you patch, yet it generates warnning calltrace. Despite it's
just a warning but it can overwhelm when we run kunit tests. Hence,
I suggest switch to the drm_atomic_connector_get_property() function.
Logs are pasted as below for easier to ready.
[ cut here ]-
h,
&data->third_len);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
+}
+
--
Best regards
Sui Jingfeng
return 0;
+ }
+ return ret;
+ }
+
+ ret = mtk_ddp_comp_get_id(ep_dev_node, comp_type);
+ if (ret < 0)
+ return ret;
+
+ /* All ok! Pass the Component ID to the caller. */
+ *cid = (unsigned int)ret;
+
+ return 0;
+}
+
--
Best regards
Sui Jingfeng
Hi,
On 5/22/24 19:48, Sui Jingfeng wrote:
if the not bridge is not ready
'not' -> 'next'
Hi,
Looks good to me in overall!
On 5/21/24 15:57, AngeloGioacchino Del Regno wrote:
It is impossible to add each and every possible DDP path combination
for each and every possible combination of SoC and board: right now,
this driver hardcodes configuration for 10 SoCs and this is going to
gro
Hi,
On 5/20/24 19:13, Dmitry Baryshkov wrote:
On Mon, 20 May 2024 at 14:11, Sui Jingfeng wrote:
Hi,
On 5/20/24 06:11, Dmitry Baryshkov wrote:
On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote:
Commit f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins"
Hi,
On 5/20/24 06:11, Dmitry Baryshkov wrote:
On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote:
Commit f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins")
fails to consider the case where adv7511->i2c_main->irq is zero, i.e.,
no interrupt requested at all.
Without interr
, as the PCIe device has already been created by the time the
etnaviv.ko is loaded. Hence, bind all of the virtual child to the real
master, this design reflects the hardware layout perfectly and is
extensible.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/Kconfig | 9
that works
for ARM-SoC can also works for PCIe cards.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 33 +++
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 9
2 files changed, 37 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv
In the etnaviv_pdev_probe(), etnaviv_gpu_platform_probe() function, the
value of '&pdev->dev' has been cached to the 'dev' local auto variable.
But part of callers use 'dev' as argument, while the rest use '&pdev->dev'.
To keep it consist
userspace know.
Please note that write-combine mapping out of scope of the discussion
and therefore is not being addressed.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 3 +++
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 9 +
drivers/gpu/drm/etnaviv/etnaviv_gpu.c |
when trying to vmap a
DMABUF")
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index aa95a5e98374..eed98bb9e
containing structure.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c| 65
drivers/gpu/drm/etnaviv/etnaviv_drv.h| 7 +++
drivers/gpu/drm/etnaviv/etnaviv_gem.c| 6 +-
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +-
drivers/gpu/d
dedicated helpers introduced, etnaviv_bind() and
etnaviv_unbind() gets simplified. Another potential benefit is that
we could put the struct drm_device into struct etnaviv_drm_private
in the future, which made them share the same life time.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etn
1 - 100 of 1102 matches
Mail list logo
