On Tue, 17 Jul 2018 10:38:58 +0200,
Lukas Wunner wrote:
>
> On Tue, Jul 17, 2018 at 04:20:50PM +0800, Jim Qu wrote:
> > On modern laptop, there are more and more platforms
> > have two GPUs, and each of them maybe have audio codec
> > for HDMP/DP output. For some dGPU which is no output,
> >
On Mon, 16 Jul 2018 19:50:48 +0200,
Takashi Iwai wrote:
>
> On Mon, 16 Jul 2018 19:22:17 +0200,
> Rodrigo Vivi wrote:
> >
> > > --- /dev/null
> > > +++ b/include/drm/drm_audio_component.h
> > > @@ -0,0 +1,115 @@
> > &g
On Mon, 16 Jul 2018 15:48:15 +0200,
Takashi Iwai wrote:
>
> +static int hdac_component_master_bind(struct device *dev)
> +{
> + struct drm_audio_component *acomp = hdac_get_acomp(dev);
> + int ret;
> +
> + ret = component_bind_all(dev, acomp)
On Mon, 16 Jul 2018 19:22:17 +0200,
Rodrigo Vivi wrote:
>
> > --- /dev/null
> > +++ b/include/drm/drm_audio_component.h
> > @@ -0,0 +1,115 @@
> > +/*
> > + * Copyright © 2014 Intel Corporation
> > + *
> > + * Permission is hereby granted, free of charge, to any person obtaining a
> > + * copy of
On Mon, 16 Jul 2018 17:10:43 +0200,
Harry Wentland wrote:
>
>
>
> On 2018-07-15 10:36 AM, Alex Deucher wrote:
> > On Sat, Jul 14, 2018 at 12:31 PM, Takashi Iwai wrote:
> >> On Sat, 14 Jul 2018 14:03:26 +0200,
> >> jimqu wrote:
> >>>
>
On Mon, 16 Jul 2018 16:43:42 +0200,
Lukas Wunner wrote:
>
> On Mon, Jul 16, 2018 at 02:06:35PM +0800, Jim Qu wrote:
> > +
> > + list_for_each_entry(client, _priv.clients, list) {
> > + if (!client_is_audio(client) || client_id(client) !=
> > +
.
This is a preliminary change for further development, and no
functional changes by this patch itself, merely code-split and
renames.
Signed-off-by: Takashi Iwai
---
drivers/gpu/drm/i915/intel_audio.c | 22 +++---
include/drm/drm_audio_component.h | 115 +
include/drm
-off-by: Takashi Iwai
---
drivers/gpu/drm/i915/Kconfig | 1 +
include/drm/drm_audio_component.h | 23 ++
include/sound/hda_component.h | 61 ++
include/sound/hda_i915.h | 39 +---
sound/hda/Kconfig | 7 +-
sound/hda/Makefile| 1 +
sound
, the corresponding code is removed
by passing hdac_bus object to the function, too.
Signed-off-by: Takashi Iwai
---
include/sound/hda_i915.h | 6 --
sound/hda/hdac_i915.c| 34 +-
sound/pci/hda/patch_hdmi.c | 5 +++--
sound/soc/codecs/hdac_hdmi.c | 2 +-
4
know if anyone has concerns.
Thanks!
Takashi
===
Takashi Iwai (3):
drm/i915: Split audio component to a generic type
ALSA: hda/i915: Associate audio component with devres
ALSA: hda: Make audio component support more generic
drivers/gpu/drm/i915/Kconfig | 1 +
drivers/gpu/drm
nts this through another tree inevitably, let me know. In
that case, fell free to take my reviewed-by tag:
Reviewed-by: Takashi Iwai
thanks,
Takashi
> ---
> drivers/gpu/vga/vga_switcheroo.c | 39 +--
> include/linux/vga_switcheroo.h
On Mon, 16 Jul 2018 08:06:34 +0200,
Jim Qu wrote:
>
> Except PCI_CLASS_DISPLAY_VGA, some PCI class is sometimes
> PCI_CLASS_DISPLAY_3D or PCI_CLASS_DISPLAY_OTHER.
>
> Signed-off-by: Jim Qu
Applied this one now, as it's basically an individual fix.
thanks,
Takashi
On Sat, 14 Jul 2018 14:03:26 +0200,
jimqu wrote:
>
>
>
> 在 2018/7/13 23:07, Takashi Iwai 写道:
> > On Wed, 11 Jul 2018 13:12:01 +0200,
> > Takashi Iwai wrote:
> >> And the forced runtime PM is still an issue, and this would need the
> >> other notificati
On Fri, 13 Jul 2018 17:25:39 +0200,
jimqu wrote:
>
>
>
> 在 2018/7/13 16:46, Takashi Iwai 写道:
> > On Fri, 13 Jul 2018 10:06:02 +0200,
> > Jim Qu wrote:
> >> On modern laptop, there are more and more platforms
> >> have two GPUs, and each of them mayb
On Wed, 11 Jul 2018 13:12:01 +0200,
Takashi Iwai wrote:
>
> And the forced runtime PM is still an issue, and this would need the
> other notification mechanism than the HD-audio unsolicited event as
> AMD HDMI controller doesn't honor the HD-audio WAKEEN bit.
Since we had a nic
On Fri, 13 Jul 2018 10:06:02 +0200,
Jim Qu wrote:
>
> On modern laptop, there are more and more platforms
> have two GPUs, and each of them maybe have audio codec
> for HDMP/DP output. For some dGPU which is no output,
> audio codec usually is disabled.
>
> In currect HDA audio driver, it will
On Fri, 13 Jul 2018 10:06:01 +0200,
Jim Qu wrote:
>
> Signed-off-by: Jim Qu
More explanations please. e.g. why is this needed?
The code change itself looks good, but ...
> @@ -31,7 +31,7 @@
> * CHANGES:
> *
> * 2004.12.01 Major rewrite by tiwai, merged the work of pshou
> - *
On Wed, 11 Jul 2018 12:21:03 +0200,
jimqu wrote:
>
>
>
> On 2018年07月11日 17:53, Takashi Iwai wrote:
> > On Wed, 11 Jul 2018 11:26:11 +0200,
> > jimqu wrote:
> >>
> >>
> >> On 2018年07月11日 17:04, Takashi Iwai wrote:
> >>> On Wed, 11 Ju
On Wed, 11 Jul 2018 11:26:11 +0200,
jimqu wrote:
>
>
>
> On 2018年07月11日 17:04, Takashi Iwai wrote:
> > On Wed, 11 Jul 2018 10:41:38 +0200,
> > jimqu wrote:
> >>
> >>
> >> On 2018年07月11日 15:19, Takashi Iwai wrote:
> >>> On Tue, 10 Ju
On Wed, 11 Jul 2018 10:41:38 +0200,
jimqu wrote:
>
>
>
> On 2018年07月11日 15:19, Takashi Iwai wrote:
> > On Tue, 10 Jul 2018 13:21:00 +0200,
> > Takashi Iwai wrote:
> >>> revert the fix of amdgpu suspend issue, audio issue also can be observed.
> >> D
On Tue, 10 Jul 2018 13:21:00 +0200,
Takashi Iwai wrote:
>
> > revert the fix of amdgpu suspend issue, audio issue also can be observed.
>
> Did you check the behavior with the single AMD GPU hardware?
> If confirmed, we can forget about vga_switcheroo.
... and taking a look
On Tue, 10 Jul 2018 13:11:20 +0200,
jimqu wrote:
>
>
>
> On 2018年07月10日 17:50, Takashi Iwai wrote:
> > On Tue, 10 Jul 2018 11:13:27 +0200,
> > jimqu wrote:
> >>
> >>
> >> On 2018年07月10日 16:01, Takashi Iwai wrote:
> >>> On Tue, 10
On Tue, 10 Jul 2018 11:13:27 +0200,
jimqu wrote:
>
>
>
> On 2018年07月10日 16:01, Takashi Iwai wrote:
> > On Tue, 10 Jul 2018 09:44:42 +0200,
> > Qu, Jim wrote:
> >> Hi Takashi,
> >>
> >> I am not expert in audio driver, so I just update s
performed at the end
of codec resume, hence it'll be covered there.
So in theory, ELD information should be passed from the GPU to
HD-audio no matter whether runtime PM is enabled or not.
BTW, please stop top-posting. It makes the thread readability awfully
worse.
thanks,
Takashi
>
> Th
ice? Does the driver give the proper ELD bytes as well as the jack
state?
Takashi
>
> Thanks
> JimQu
>
> -邮件原件-
> 发件人: Takashi Iwai
> 发送时间: 2018年7月9日 23:58
> 收件人: Daniel Vetter
> 抄送: Alex Deucher ; alsa-de...@alsa-project.org;
> amd-...@lists.freedesktop.or
On Mon, 09 Jul 2018 18:03:48 +0200,
Alex Deucher wrote:
>
> On Mon, Jul 9, 2018 at 11:57 AM, Takashi Iwai wrote:
> > On Mon, 09 Jul 2018 17:53:19 +0200,
> > Qu, Jim wrote:
> >>
> >> Hi All,
> >>
> >> Here, I want to clarify the audio
On Mon, 09 Jul 2018 18:15:32 +0200,
Alex Deucher wrote:
>
> On Mon, Jul 9, 2018 at 12:06 PM, Lukas Wunner wrote:
> > On Mon, Jul 09, 2018 at 05:52:49PM +0200, Takashi Iwai wrote:
> >> On Mon, 09 Jul 2018 17:47:34 +0200, Lukas Wunner wrote:
> >> > Since v4.17,
On Mon, 09 Jul 2018 17:59:00 +0200,
Alex Deucher wrote:
>
> On Mon, Jul 9, 2018 at 11:52 AM, Takashi Iwai wrote:
> > On Mon, 09 Jul 2018 17:47:34 +0200,
> > Lukas Wunner wrote:
> >>
> >> On Mon, Jul 09, 2018 at 05:04:22PM +0200, Takashi Iwai wrote:
> >&g
On Mon, 09 Jul 2018 17:56:43 +0200,
Daniel Vetter wrote:
>
> On Mon, Jul 09, 2018 at 05:04:22PM +0200, Takashi Iwai wrote:
> > On Mon, 09 Jul 2018 15:58:51 +0200,
> > Alex Deucher wrote:
> > >
> > > On Mon, Jul 9, 2018 at 6:16 AM, Qu, Jim wrote:
> > &g
dec on discrete
GPU...? Why do we need vga_switcheroo at all, then?
Takashi
>
> Thanks
> JimQu
>
> -邮件原件-
> 发件人: Lukas Wunner
> 发送时间: 2018年7月9日 23:48
> 收件人: Takashi Iwai
> 抄送: Alex Deucher ; alsa-de...@alsa-project.org;
> amd-...@
On Mon, 09 Jul 2018 17:47:34 +0200,
Lukas Wunner wrote:
>
> On Mon, Jul 09, 2018 at 05:04:22PM +0200, Takashi Iwai wrote:
> > On Mon, 09 Jul 2018 15:58:51 +0200, Alex Deucher wrote:
> > > On Mon, Jul 9, 2018 at 6:16 AM, Qu, Jim wrote:
> > > > > You're saying
On Mon, 09 Jul 2018 16:02:48 +0200,
Alex Deucher wrote:
>
> On Mon, Jul 9, 2018 at 6:16 AM, Qu, Jim wrote:
> > Hi Lukas,
> >
> > Thanks to your explanation, and see comments in line.
> >
> >
> > Do you need to runtime resume the HDA controller even if user space isn't
> > streaming audio? Why,
On Mon, 09 Jul 2018 15:58:51 +0200,
Alex Deucher wrote:
>
> On Mon, Jul 9, 2018 at 6:16 AM, Qu, Jim wrote:
> > Hi Lukas,
> >
> > Thanks to your explanation, and see comments in line.
> >
> >
> > Do you need to runtime resume the HDA controller even if user space isn't
> > streaming audio? Why,
gt; Signed-off-by: Mauro Carvalho Chehab
For the sound bits:
Acked-by: Takashi Iwai
thanks,
Takashi
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
ving a few
> false-positives.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org>
For sound stuff, feel free to take my ack (if it's not too late):
Acked-by: Takashi Iwai <ti...@suse.de>
thanks,
Takashi
_
On Tue, 03 Apr 2018 11:18:34 +0200,
Michel D4nzer wrote:
>
> On 2018-04-03 11:02 AM, Takashi Iwai wrote:
> > On Tue, 03 Apr 2018 10:57:56 +0200,
> > Christian K6nig wrote:
> >>
> >> Am 03.04.2018 um 10:36 schrieb Michel Dänzer:
> >>> On 2018-04-01 0
On Tue, 03 Apr 2018 10:57:56 +0200,
Christian K6nig wrote:
>
> Am 03.04.2018 um 10:36 schrieb Michel Dänzer:
> > On 2018-04-01 07:45 PM, Ilia Mirkin wrote:
> >> On Sun, Apr 1, 2018 at 1:39 PM, Christian König
> >> <christian.koe...@amd.com> wrote:
> >>
On Sun, 01 Apr 2018 19:58:11 +0200,
Christian K6nig wrote:
>
> Am 01.04.2018 um 19:45 schrieb Ilia Mirkin:
> > On Sun, Apr 1, 2018 at 1:39 PM, Christian König
> > <christian.koe...@amd.com> wrote:
> >> Am 30.03.2018 um 22:45 schrieb Takashi Iwai:
> >>>
piece.
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index e55792d3cd12..029d95ecd26b
amdgpu driver checks vgacon_text_force() after some initializations
but without cleaning up. This will result in leaks.
Move the check of vgacon_text_force() to the beginning of
amdgpu_init() for fixing it and also for optimization.
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drive
07f4f97d7b4b ("vga_switcheroo: Use device link for HDA controller")
> Cc: Takashi Iwai <ti...@suse.com>
> Reported-by: Arnd Bergmann <a...@arndb.de>
> Signed-off-by: Lukas Wunner <lu...@wunner.de>
Reviewed-by: Takashi Iwai <ti...@suse.de>
Can this go throu
On Wed, 14 Mar 2018 07:38:01 +0100,
Lukas Wunner wrote:
>
> Dear Stephen,
>
> when rebuilding linux-next you're going to see a merge conflict in:
>
> sound/pci/hda/hda_intel.c
>
> betwen commit:
>
> 1ba8f9d30817 ("ALSA: hda: Add a power_save blacklist")
>
> from the sound tree and
On Mon, 12 Mar 2018 21:55:50 +0100,
Lukas Wunner wrote:
>
> On Mon, Mar 12, 2018 at 05:54:47PM +0100, Daniel Vetter wrote:
> > On Sun, Mar 11, 2018 at 04:55:49PM +0100, Lukas Wunner wrote:
> > > > On Sat, Mar 03, 2018 at 10:53:24AM +0100, Lukas Wunner wrote:
> > > > > Modernize vga_switcheroo by
p to
straighten the code as well. Unfortunately I have no hardware to test
right now, but feel free to take my ack for HD-audio related patches:
Reviewed-by: Takashi Iwai <ti...@suse.de>
thanks,
Takashi
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
| 6 +++---
> kernel/trace/trace_printk.c | 4 ++--
> lib/raid6/sse2.c | 14 +++---
> sound/soc/fsl/fsl_dma.c | 2 +-
For sound bits,
Acked-by: Ta
On Tue, 01 Aug 2017 21:25:11 +0200,
Mathieu Larouche wrote:
>
> On 18/07/2017 10:43 AM, Takashi Iwai wrote:
> > Hi,
> >
> > this is a summer cleanup sale, a patchset containing various fixes for
> > mgag200 driver taken from openSUSE / SUSE kernels. They have been i
On Thu, 27 Jul 2017 10:25:24 +0200,
Daniel Vetter wrote:
>
> On Thu, Jul 27, 2017 at 10:22 AM, Takashi Iwai <ti...@suse.de> wrote:
> > On Thu, 27 Jul 2017 08:52:48 +0200,
> > Daniel Vetter wrote:
> >>
> >> On Wed, Jul 26, 2017 at 10:56:34PM +0200, Takash
On Thu, 27 Jul 2017 08:52:48 +0200,
Daniel Vetter wrote:
>
> On Wed, Jul 26, 2017 at 10:56:34PM +0200, Takashi Iwai wrote:
> > The virtio drm driver doesn't treat with DPMS, so we should return an
> > error from the connector dpms callback so that the fbcon can fall back
> &
The qxl drm driver doesn't treat with DPMS, so we should return an
error from the connector dpms callback so that the fbcon can fall back
to the generic blank mode.
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/qxl/qxl_display.c | 9 -
1 file changed, 8 insertions
needs just to return an error to fall back to the generic fbcon
blank mode.
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/drm_fb_helper.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/d
The virtio drm driver doesn't treat with DPMS, so we should return an
error from the connector dpms callback so that the fbcon can fall back
to the generic blank mode.
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/virtio/virtgpu_display.c | 9 -
1 file chan
The bochs drm driver doesn't treat with DPMS, so we should return an
error from the connector dpms callback so that the fbcon can fall back
to the generic blank mode.
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/bochs/bochs_kms.c | 9 -
1 file changed, 8 inse
.
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/cirrus/cirrus_mode.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c
b/drivers/gpu/drm/cirrus/cirrus_mode.c
index 53f6f0f84206..7412660bb014 100644
--- a/drivers/g
DPMS properly.
Takashi
===
Takashi Iwai (5):
drm: Propagate error from connector dpms function in
drm_fb_helper_blank()
drm/bochs: Return an error from connector dpms callback
drm/virtio: Return an error from connector dpms callback
drm/qxl: Return an error from connector dpms
On Thu, 20 Jul 2017 13:58:14 +0200,
Paul Menzel wrote:
>
> Dear Takashi,
>
>
> Thank you for posting these patches for review.
>
>
> Am Dienstag, den 18.07.2017, 16:43 +0200 schrieb Takashi Iwai:
> > From: Egbert Eich <e...@suse.de>
> >
> &g
On Thu, 20 Jul 2017 06:17:58 +0200,
Dave Airlie wrote:
>
> On 19 July 2017 at 00:43, Takashi Iwai <ti...@suse.de> wrote:
> > From: Egbert Eich <e...@suse.de>
> >
> > Add two more models G200_PCI and G200 for PCI device IDs 0x520 and
> > 0x521, respecti
dan...@ffwll.ch>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/ast/ast_mode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index aaef0a652f10..d7bfe45b5884 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/dri
On Tue, 18 Jul 2017 22:53:48 +0200,
Michel D4nzer wrote:
>
> On 18/07/17 11:20 AM, Takashi Iwai wrote:
> > From: Egbert Eich <e...@suse.de>
> >
> > The radeon driver reduces the framebuffer resolution to 8bpp if a
> > device with less than 32MB VRAM is
On Tue, 18 Jul 2017 16:43:15 +0200,
Takashi Iwai wrote:
>
> From: Egbert Eich <e...@suse.de>
>
> When destroying connector unregister it.
>
> Signed-off-by: Egbert Eich <e...@suse.de>
> Signed-off-by: Takashi Iwai <ti...@suse.de>
This one shoul
On Wed, 19 Jul 2017 08:35:08 +0200,
Daniel Vetter wrote:
>
> On Tue, Jul 18, 2017 at 04:49:33PM +0200, Takashi Iwai wrote:
> > From: Egbert Eich <e...@suse.de>
> >
> > When destroying connector unregister it.
> >
> > Signed-off-by: Egbert Eich <e...
ed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
This has been included in SUSE kernel for quite some time, and I'm
trying to upstream this. The 16bpp looks more reasonable nowadays,
but I know this is a matter of taste, too. It'd be great if yo
From: Egbert Eich <e...@suse.de>
When destroying connector unregister it.
Signed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/cirrus/cirrus_mode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/cirru
From: Egbert Eich <e...@suse.de>
Just a code refactoring, no functional change.
Signed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/ast/ast_ttm.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/d
From: Egbert Eich <e...@suse.de>
Implement the proper CRTC disablement, just like done in mgag200
driver.
Signed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/ast/ast_mode.c | 16
1 file changed, 16 inserti
ctions
static.
Signed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/ast/ast_dp501.c | 25 -
drivers/gpu/drm/ast/ast_drv.h | 3 +--
drivers/gpu/drm/ast/ast_main.c | 1 +
3 files changed, 18 insertion
Hi,
here is another clearance sale, a patchset containing fixes for ast
driver, dug from openSUSE / SUSE kernels. All fixes came from
Egbert.
thanks,
Takashi
===
Egbert Eich (5):
drm/ast: Simplify function ast_bo_unpin()
drm/ast: Free container instead of member in
From: Egbert Eich <e...@suse.de>
Technically freeing ast_fb->base is the same as freeing ast_fb as 'base'
the first member of the data structure.
Still this makes it cleaner.
Signed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/g
From: Egbert Eich <e...@suse.de>
The allocated struct ast_bo was not freed in all error paths.
This patch consolidates error handling and fixes this.
Signed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/ast/ast_ttm.c | 11 +
Add a basic PM support to mgag200 driver.
As there is no hardware specific init codes for this device, the
callbacks are written in a fairly simple way.
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/mgag200/mgag200_drv.c | 41 +++
1 file c
From: Egbert Eich <e...@suse.de>
When destroying connector unregister it.
Signed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mgag
ng, adds it to mode validation
and moves the code which reads the command line specified depth
into the correct location.
Fixes: 918be888d613 ("drm/mgag200: on cards with < 2MB VRAM default to 16-bit")
Signed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti
et around the shortcomings of the mode setting
model for older hardware.
Signed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/mgag200/mgag200_drv.c | 11 +++
drivers/gpu/drm/mgag200/mgag200_drv.h | 2 ++
drivers/gpu/drm/mgag20
From: Egbert Eich <e...@suse.de>
Cursor BOs should be cleaned up properly on error or when unloading
the driver.
Signed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/mgag200/mgag200_main.c | 11 +--
1 file changed,
From: Egbert Eich <e...@suse.de>
Add two more models G200_PCI and G200 for PCI device IDs 0x520 and
0x521, respectively. They need to retrieve the reference clock and
pclk min/max values from BIOS, and set up the PLLs accordingly.
Signed-off-by: Egbert Eich <e...@suse.de>
Signed-off
From: Egbert Eich <e...@suse.de>
The crtc_* are wrong references as the mode parameters to validate,
use the ones without crtc_ prefix instead.
Signed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/mgag200/mgag200_mode.c |
From: Egbert Eich <e...@suse.de>
The allocated struct mgag200_bo was not freed in all error paths.
This patch consolidates error handling and fixes this.
Signed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/mgag200/
From: Egbert Eich <e...@suse.de>
According to the use UMS X.Org driver G200 WB chips don't support
doublescan
Signed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 3 ++-
1 file changed, 2 inserti
ed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/mgag200/mgag200_drv.h | 1 +
drivers/gpu/drm/mgag200/mgag200_fb.c | 7 +++
drivers/gpu/drm/mgag200/mgag200_mode.c | 3 ++-
3 files changed, 10 insertions(+), 1 deletion(-)
diff -
From: Egbert Eich <e...@suse.de>
Technically freeing mga_fb->base is the same as freeing mga_fb as 'base'
the first member of the data structure.
Still this makes it cleaner.
Signed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
dr
From: Egbert Eich <e...@suse.de>
Just a code refactoring, no functional change.
Signed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/mgag200/mgag200_drv.h | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
di
From: Egbert Eich <e...@suse.de>
Give more verbose debug message at mode bandwidth checks.
Signed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 51 +-
1 file chan
drm_connector_unregister()
drm/mgag200: Don't use crtc_* parameters for validation
drm/mgag200: Consolidate depth/bpp handling
drm/mgag200: Add command line option to specify preferred depth
drm/mgag200: Add mode validation debugging code
Takashi Iwai (1):
drm/mgag200: Implement basic PM support
From: Egbert Eich <e...@suse.de>
This code was ported from the xorg mga driver.
The doublescreen_allowed and interlace_allowed flags are set
unconditionally for all models for now.
Signed-off-by: Egbert Eich <e...@suse.de>
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
drive
On Tue, 11 Jul 2017 19:35:36 +0200,
Daniel Vetter wrote:
>
> On Mon, Jul 10, 2017 at 4:56 PM, Daniel Vetter <dan...@ffwll.ch> wrote:
> > On Mon, Jul 10, 2017 at 11:37 AM, Takashi Iwai <ti...@suse.de> wrote:
> >>> DPMS should be an error anyway, we want that
.
>
> Sounds good to me.
>
> I've seen this on real hardware too btw (arm board with non-working
> dpms).
So something like below?
(Adding Bartlomiej to Cc, as it's fbcon stuff)
Takashi
-- 8< --
From: Takashi Iwai <ti...@suse.de>
Subject: [PATCH] fbcon: Perform generic
On Mon, 10 Jul 2017 11:27:01 +0200,
Daniel Vetter wrote:
>
> On Mon, Jul 10, 2017 at 10:53 AM, Takashi Iwai <ti...@suse.de> wrote:
> > we've casually found a weird behavior of DRM drivers on QEMU (cirrus,
> > bochs, virtio) via openQA: namely, VT console blank is ign
Hi,
we've casually found a weird behavior of DRM drivers on QEMU (cirrus,
bochs, virtio) via openQA: namely, VT console blank is ignored on such
drivers. The whole screen is kept shown while the cursor blinking
stops.
I took a closer look, and it seems that drm_fb_helper_blank() just
calls
This is just a cleanup, no functional change.
The fixup code for 1366x768 in drm_mode_create_from_cmdline_mode() is
basically a copy of the existing code in drm_edid.c. Make the latter
code public so that it can be called from the former function.
Signed-off-by: Takashi Iwai <ti...@suse
On Mon, 16 Jan 2017 20:16:04 +0100,
Gustavo Padovan wrote:
>
> Hi Takashi,
>
> 2017-01-16 Takashi Iwai <ti...@suse.de>:
>
> > This is just a cleanup, no functional change.
> >
> > The fixup code for 1366x768 in drm_mode_create_from_cmdline_mode() is
&g
This is just a cleanup, no functional change.
The fixup code for 1366x768 in drm_mode_create_from_cmdline_mode() is
basically a copy of the existing code in drm_edid.c. Make the latter
code public so that it can be called from the former function.
Signed-off-by: Takashi Iwai <ti...@suse
On Wed, 11 Jan 2017 18:05:12 +0100,
Ville Syrjälä wrote:
>
> On Tue, Jan 10, 2017 at 01:41:42PM +0100, Daniel Vetter wrote:
> > On Tue, Jan 10, 2017 at 12:36:50PM +0100, Takashi Iwai wrote:
> > > On Tue, 10 Jan 2017 12:28:36 +0100,
> > > Ville Syrjälä wrote:
> &g
On Tue, 10 Jan 2017 13:41:42 +0100,
Daniel Vetter wrote:
>
> On Tue, Jan 10, 2017 at 12:36:50PM +0100, Takashi Iwai wrote:
> > On Tue, 10 Jan 2017 12:28:36 +0100,
> > Ville Syrjälä wrote:
> > >
> > > On Mon, Jan 09, 2017 at 03:56:14PM +0100, Takashi Iwai
On Tue, 10 Jan 2017 12:28:36 +0100,
Ville Syrjälä wrote:
>
> On Mon, Jan 09, 2017 at 03:56:14PM +0100, Takashi Iwai wrote:
> > I noticed that the VT switch doesn't work any longer with a Dell
> > laptop with 1366x768 eDP when the machine is connected with a DP
> > monit
width
when the expected size is 1366 while we get 1368 instead.
Fixes: eaf99c749d43 ("drm: Perform cmdline mode parsing during...")
Cc:
Signed-off-by: Takashi Iwai
---
drivers/gpu/drm/drm_modes.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/d
On Thu, 05 Jan 2017 17:47:06 +0100,
Ville Syrjälä wrote:
>
> On Thu, Jan 05, 2017 at 05:19:58PM +0100, Takashi Iwai wrote:
> > On Thu, 05 Jan 2017 16:59:31 +0100,
> > Ville Syrjälä wrote:
> > >
> > > On Thu, Jan 05, 2017 at 04:37:27PM +
On Thu, 05 Jan 2017 16:59:31 +0100,
Ville Syrjälä wrote:
>
> On Thu, Jan 05, 2017 at 04:37:27PM +0100, Takashi Iwai wrote:
> > Hi,
> >
> > recently I noticed that VT console doesn't work any longer when I dock
> > a Dell E7270 laptop with a DP mo
Hi,
recently I noticed that VT console doesn't work any longer when I dock
a Dell E7270 laptop with a DP monitor. The bug detail is like this:
At first, I boot the laptop without dock. I can switch between X and
VT via ctrl-alt-F1, so far. Then I dock it to a docking station
connected with a
On Mon, 19 Dec 2016 10:42:28 +0100,
Daniel Vetter wrote:
>
> On Mon, Dec 19, 2016 at 11:09:55AM +0200, Jani Nikula wrote:
> > On Wed, 14 Dec 2016, Arnaud Pouliquen wrote:
> > > Add helper to allow users to retrieve the speaker allocations without
> > > knowledge of the ELD structure.
> > >
> > >
On Mon, 12 Dec 2016 13:12:16 +0100,
Takashi Sakamoto wrote:
>
> On Dec 12 2016 18:54, Takashi Iwai wrote:
> >>>> +enum hdmi_codec_cea_spk_placement {
> >>>> +FL = (1 << 0),/* Front Left */
> >>
On Mon, 12 Dec 2016 10:38:45 +0100,
Arnaud Pouliquen wrote:
>
>
>
> On 12/11/2016 07:09 AM, Takashi Sakamoto wrote:
> > On Dec 9 2016 01:37, Arnaud Pouliquen wrote:
> >> Add user interface to provide channel mapping.
> >> In a first step this control is read only.
> >>
> >> As TLV type, the
201 - 300 of 612 matches
Mail list logo