RE: [PATCH 9/9] drm/verisilicon: Add starfive hdmi driver

2023-06-22 Thread Hoegeun Kwon
Hi Keith, There is a problem with stopping when changing modes. Below test log root:~> modetest -Mstarfive -c Connectors: id encoder status namesize (mm) modes encoders 116 115 connected HDMI-A-1320x180 51 115 modes:

RE: [PATCH libdrm] vbltest: add option to use high pipe

2023-02-07 Thread Hoegeun Kwon
Could you please check this patch. Best regards Hoegeun > -Original Message- > From: dri-devel On Behalf Of > Hoegeun Kwon > Sent: Monday, January 16, 2023 6:44 PM > To: dri-devel@lists.freedesktop.org; hoegeun.k...@samsung.com > Subject: [PATCH libdrm] vbltest: add

[PATCH libdrm] vbltest: add option to use high pipe

2023-01-16 Thread Hoegeun Kwon
Add option to use high pipe. Signed-off-by: Hoegeun Kwon --- tests/vbltest/vbltest.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/tests/vbltest/vbltest.c b/tests/vbltest/vbltest.c index 1c2b519eec4a..1be77b81c560 100644 --- a/tests/vbltest/vbltest.c

Re: [PATCH v2 7/7] drm/vc4: kms: Don't disable the muxing of an active CRTC

2020-11-03 Thread Hoegeun Kwon
Assign output to channel automatically") > Signed-off-by: Maxime Ripard I checked all patches well works. All patches: Reviewed-by: Hoegeun Kwon Tested-by: Hoegeun Kwon Best regards, Hoegeun > --- > drivers/gpu/drm/vc4/vc4_drv.h | 1 +- > drivers/gpu/drm/vc4/vc4_kms.

Re: [PATCH v2 7/7] drm/vc4: kms: Don't disable the muxing of an active CRTC

2020-11-02 Thread Hoegeun Kwon
Hi Maxime, Thanks for V2 patch. On 10/28/20 9:41 PM, Maxime Ripard wrote: > The current HVS muxing code will consider the CRTCs in a given state to > setup their muxing in the HVS, and disable the other CRTCs muxes. > > However, it's valid to only update a single CRTC with a state, and in this

[PATCH 0/1] drm/vc4: drv: Add error handding for bind

2020-10-26 Thread Hoegeun Kwon
lt;41d69f98>] try_to_bring_up_master+0x180/0x1e8 [<d1e1caae>] component_master_add_with_match+0xbc/0x108 [<85cea46d>] vc4_platform_drm_probe+0xd8/0x108 [<eacabf20>] platform_drv_probe+0x58/0xa8 [<3822d094>] really_probe+0x10c/0x350 Best regards,

[PATCH 1/1] drm/vc4: drv: Add error handding for bind

2020-10-26 Thread Hoegeun Kwon
There is a problem that if vc4_drm bind fails, a memory leak occurs on the drm_property_create side. Add error handding for drm_mode_config. Signed-off-by: Hoegeun Kwon --- drivers/gpu/drm/vc4/vc4_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers

Re: [PATCH 1/4] drm/vc4: kms: Split the HVS muxing check in a separate function

2020-10-12 Thread Hoegeun Kwon
All patches: Reviewed-by: Hoegeun Kwon Tested-by: Hoegeun Kwon Best regards, Hoegeun > --- > drivers/gpu/drm/vc4/vc4_kms.c | 18 +++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4

Re: [PATCH 1/2] drm/vc4: kms: Assign a FIFO to enabled CRTCs instead of active

2020-09-24 Thread Hoegeun Kwon
Hi Maxime, On 9/18/20 11:59 PM, Maxime Ripard wrote: > The HVS has three FIFOs that can be assigned to a number of PixelValves > through a mux. > > However, changing that FIFO requires that we disable and then enable the > pixelvalve, so we want to assign FIFOs to all the enabled CRTCs, and not >

Re: [PATCH] drm/vc4: hvs: Pull the state of all the CRTCs prior to PV muxing

2020-09-18 Thread Hoegeun Kwon
nning > unmodified, and will thus unassign its associated FIFO, and later disable > it. > > In order to make the code work as expected, let's pull the CRTC state of > all the enabled CRTC in our atomic_check so that we can operate on all the > running CRTCs, no matter whether the

Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline

2020-09-14 Thread Hoegeun Kwon
Hi Maxime, On 9/8/20 9:00 PM, Maxime Ripard wrote: > Hi Hoegeun, > > On Mon, Sep 07, 2020 at 08:49:12PM +0900, Hoegeun Kwon wrote: >> On 9/3/20 5:00 PM, Maxime Ripard wrote: >>> Hi everyone, >>> >>> Here's a (pretty long) series to introduce support

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-09-07 Thread Hoegeun Kwon
e Stevenson > Tested-by: Chanwoo Choi > Tested-by: Hoegeun Kwon > Tested-by: Stefan Wahren > Signed-off-by: Maxime Ripard Thanks for your v5 patch Reviewed-by: Hoegeun Kwon Best regards, Hoegeun > --- > arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 48 +++- > a

Re: [PATCH v5 77/80] dt-bindings: display: vc4: hdmi: Add BCM2711 HDMI controllers bindings

2020-09-07 Thread Hoegeun Kwon
woo Choi > Tested-by: Hoegeun Kwon > Tested-by: Stefan Wahren > Signed-off-by: Maxime Ripard Thanks for your v5 patch Reviewed-by: Hoegeun Kwon Best regards, Hoegeun > --- > Documentation/devicetree/bindings/dis

Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline

2020-09-07 Thread Hoegeun Kwon
Hi Maxime, On 9/3/20 5:00 PM, Maxime Ripard wrote: > Hi everyone, > > Here's a (pretty long) series to introduce support in the VC4 DRM driver > for the display pipeline found in the BCM2711 (and thus the RaspberryPi 4). > > The main differences are that there's two HDMI controllers and that

Re: [PATCH v2 2/4] drm/vc4: hdmi: Add pixel bvb clock control

2020-09-01 Thread Hoegeun Kwon
Hi Chanwoo, On 9/1/20 1:27 PM, Chanwoo Choi wrote: > Hi Hoegeun, > > It looks good to me. But, just one comment. > > On 9/1/20 1:07 PM, Hoegeun Kwon wrote: >> There is a problem that the output does not work at a resolution >> exceeding FHD. To solve this, we n

[PATCH v2 2/4] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-31 Thread Hoegeun Kwon
There is a problem that the output does not work at a resolution exceeding FHD. To solve this, we need to adjust the bvb clock at a resolution exceeding FHD. Signed-off-by: Hoegeun Kwon --- drivers/gpu/drm/vc4/vc4_hdmi.c | 25 + drivers/gpu/drm/vc4/vc4_hdmi.h | 1 + 2

[PATCH v2 3/4] dt-bindings: display: vc4: hdmi: Add bvb clock-names property

2020-08-31 Thread Hoegeun Kwon
When using a resolution exceeding FHD, bvb clock is required. Add bvb clock-names property. Signed-off-by: Hoegeun Kwon --- .../bindings/display/brcm,bcm2711-hdmi.yaml | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings

[PATCH v2 0/4] drm/vc4: Support HDMI QHD or higher output

2020-08-31 Thread Hoegeun Kwon
patchset) Changes from v1: - Added dt-bindings documents - Change patch order, first fix driver and then device tree Hoegeun Kwon (4): clk: bcm: rpi: Add register to control pixel bvb clk drm/vc4: hdmi: Add pixel bvb clock control dt-bindings: display: vc4: hdmi: Add bvb clock-names property

[PATCH v2 1/4] clk: bcm: rpi: Add register to control pixel bvb clk

2020-08-31 Thread Hoegeun Kwon
To use QHD or higher, we need to modify the pixel_bvb_clk value. So add register to control this clock. Signed-off-by: Hoegeun Kwon --- drivers/clk/bcm/clk-raspberrypi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c

[PATCH v2 4/4] ARM: dts: bcm2711: Add bvb clock for hdmi-pixel

2020-08-31 Thread Hoegeun Kwon
It is necessary to control the hdmi pixel bvb clock. Add bvb clock. Signed-off-by: Hoegeun Kwon --- arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts

Re: [PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-31 Thread Hoegeun Kwon
Am 28.08.20 um 08:30 schrieb Hoegeun Kwon: >>>> On 8/27/20 6:49 PM, Stefan Wahren wrote: >>>>> Am 27.08.20 um 06:35 schrieb Hoegeun Kwon: >>>>>> Hi Stefan, >>>>>> >>>>>> Thank you for your review. >>>>>&g

Re: [PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-28 Thread Hoegeun Kwon
On 8/27/20 6:49 PM, Stefan Wahren wrote: > Am 27.08.20 um 06:35 schrieb Hoegeun Kwon: >> Hi Stefan, >> >> Thank you for your review. >> >> >> On 8/26/20 7:04 PM, Stefan Wahren wrote: >>> Hi Hoeguen, >>> >>> Am 21.08.20 um 09:10

Re: [PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-26 Thread Hoegeun Kwon
Hi Stefan, Thank you for your review. On 8/26/20 7:04 PM, Stefan Wahren wrote: > Hi Hoeguen, > > Am 21.08.20 um 09:10 schrieb Hoegeun Kwon: >> There is a problem that the output does not work at a resolution >> exceeding FHD. To solve this, we need to adjust the bvb clo

Re: [PATCH v4 00/78] drm/vc4: Support BCM2711 Display Pipeline

2020-08-21 Thread Hoegeun Kwon
not outputting... So this problem worked as I fixed it like patches[1]. [1] [PATCH 0/3] drm/vc4: Support HDMI QHD or higher output "[PATCH v4 00/78] drm/vc4: Support BCM2711 Display Pipeline" all patches. Tested-by: Hoegeun Kwon Best regards, Hoegeun > Hi everyone, > > Here's a (

[PATCH 2/3] ARM: dts: bcm2711: Add bvb clock for hdmi-pixel

2020-08-21 Thread Hoegeun Kwon
It is necessary to control the hdmi pixel bvb clock. Add bvb clock. Signed-off-by: Hoegeun Kwon --- arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts

[PATCH 1/3] clk: bcm: rpi: Add register to control pixel bvb clk

2020-08-21 Thread Hoegeun Kwon
To use QHD or higher, we need to modify the pixel_bvb_clk value. So add register to control this clock. Signed-off-by: Hoegeun Kwon --- drivers/clk/bcm/clk-raspberrypi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c

[PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-21 Thread Hoegeun Kwon
There is a problem that the output does not work at a resolution exceeding FHD. To solve this, we need to adjust the bvb clock at a resolution exceeding FHD. Signed-off-by: Hoegeun Kwon --- drivers/gpu/drm/vc4/vc4_hdmi.c | 25 + drivers/gpu/drm/vc4/vc4_hdmi.h | 1 + 2

[PATCH 0/3] drm/vc4: Support HDMI QHD or higher output

2020-08-21 Thread Hoegeun Kwon
patchset) Hoegeun Kwon (3): clk: bcm: rpi: Add register to control pixel bvb clk ARM: dts: bcm2711: Add bvb clock for hdmi-pixel drm/vc4: hdmi: Add pixel bvb clock control arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 6 -- drivers/clk/bcm/clk-raspberrypi.c | 1 + drivers/gpu/drm/vc4

Re: [PATCH] drm/vc4: Fix with pm_runtime synchronization on DSI

2019-05-22 Thread Hoegeun Kwon
On 4/10/19 1:24 AM, Eric Anholt wrote: > Hoegeun Kwon writes: > >> On 4/2/19 2:48 AM, Eric Anholt wrote: >>> Hoegeun Kwon writes: >>> >>>> There is a problem when often dpms goes from off to on. pm idle is not >>>> in sync and the proble

Re: [PATCH] drm/vc4: Fix with pm_runtime synchronization on DSI

2019-04-07 Thread Hoegeun Kwon
On 4/2/19 2:48 AM, Eric Anholt wrote: > Hoegeun Kwon writes: > >> There is a problem when often dpms goes from off to on. pm idle is not >> in sync and the problem occurs. Modify pm_runtime_put from >> asynchronous to synchronous. > Why would we need the power domain

[PATCH] drm/vc4: Fix with pm_runtime synchronization on DSI

2019-03-28 Thread Hoegeun Kwon
There is a problem when often dpms goes from off to on. pm idle is not in sync and the problem occurs. Modify pm_runtime_put from asynchronous to synchronous. Signed-off-by: Hoegeun Kwon --- drivers/gpu/drm/vc4/vc4_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] drm/crtc-helper: Add store the property value

2019-01-17 Thread Hoegeun Kwon
On 1/17/19 9:15 PM, Daniel Vetter wrote: > On Thu, Jan 17, 2019 at 10:57 AM Hoegeun Kwon > wrote: >> >> On 1/17/19 6:20 PM, Daniel Vetter wrote: >>> On Thu, Jan 17, 2019 at 05:50:44PM +0900, Hoegeun Kwon wrote: >>>> There is a problem in crtc_helper that

Re: [PATCH] drm/crtc-helper: Add store the property value

2019-01-17 Thread Hoegeun Kwon
On 1/17/19 6:20 PM, Daniel Vetter wrote: > On Thu, Jan 17, 2019 at 05:50:44PM +0900, Hoegeun Kwon wrote: >> There is a problem in crtc_helper that property value is not updated >> when dpms is turned on or off. So modify the property value when dpms >> is on. >> >

[PATCH] drm/crtc-helper: Add store the property value

2019-01-17 Thread Hoegeun Kwon
There is a problem in crtc_helper that property value is not updated when dpms is turned on or off. So modify the property value when dpms is on. Signed-off-by: Hoegeun Kwon --- drivers/gpu/drm/drm_crtc_helper.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm

Re: [PATCH v2 2/9] drm/exynos: ipp: Add IPP v2 framework

2017-10-10 Thread Hoegeun Kwon
. Stateless nature of DRM_IOCTL_EXYNOS_IPP_COMMIT ioctl simplifies the driver API. Minimal driver needs to provide a single callback for starting processing and an array with supported image formats. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> Tested-by: Hoegeun Kwon <

Re: [PATCH v2 4/9] drm/exynos: gsc: Convert driver to IPP v2 core API

2017-10-10 Thread Hoegeun Kwon
row...@samsung.com> Tested-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- drivers/gpu/drm/exynos/Kconfig | 3 +- drivers/gpu/drm/exynos/exynos_drm_drv.c | 1 + drivers/gpu/drm/exynos/exynos_drm_gsc.c | 853 drivers/gpu/drm/exynos/exynos_drm_gsc.h

Re: [PATCH 2/6] drm/exynos: ipp: Add IPP v2 framework

2017-09-20 Thread Hoegeun Kwon
Hi Marek, Tested-by: Hoegeun Kwon <hoegeun.k...@samsung.com> Best regards, Hoegeun On 09/12/2017 05:08 PM, Marek Szyprowski wrote: This patch adds Exynos IPP v2 subsystem and userspace API. New userspace API is focused ONLY on memory-to-memory image processing. The two remaingi

Re: [PATCH 1/6] drm/exynos: ipp: Remove Exynos DRM IPP subsystem

2017-09-20 Thread Hoegeun Kwon
Hi Marek, Tested-by: Hoegeun Kwon <hoegeun.k...@samsung.com> Best regards, Hoegeun On 09/12/2017 05:08 PM, Marek Szyprowski wrote: Exynos IPP will be rewritten, so remove current IPP core code and mark existing drivers as BROKEN. Signed-off-by: Marek Szyprowski <m.szyprow...@sa

Re: [PATCH 4/6] drm/exynos: gsc: Convert driver to IPP v2 core API

2017-09-20 Thread Hoegeun Kwon
Hi Marek, Tested-by: Hoegeun Kwon <hoegeun.k...@samsung.com> Best regards, Hoegeun On 09/12/2017 05:08 PM, Marek Szyprowski wrote: This patch adapts Exynos DRM rotator driver to new IPP v2 core API. The side effect of this conversion is a switch to driver component API to register pr

[RESEND PATCH v4 3/3] ARM: dts: exynos: Remove the display-timing and delay from rinato dts

2017-09-17 Thread Hoegeun Kwon
The display-timing and delay are included in the panel driver. So it should be removed in dts. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- Hi Krzysztof, This patch was rebased to the mainline (v4.14-rc1). Best regards, Hoegeun arch/arm/boot/dts/exynos3250-rinato.dt

Re: [PATCH v4 4/4] [media] exynos-gsc: Add hardware rotation limits

2017-09-13 Thread Hoegeun Kwon
On 09/13/2017 09:13 PM, Sylwester Nawrocki wrote: On 09/13/2017 01:41 PM, Hoegeun Kwon wrote: @@ -1004,11 +1088,33 @@ static irqreturn_t gsc_irq_handler(int irq, void *priv) .num_clocks = 1, }; +static struct gsc_driverdata gsc_v_5250_drvdata = { +.variant = { +[0

[PATCH v4 0/4] Exynos-gsc: Support the hardware rotation limits

2017-09-13 Thread Hoegeun Kwon
driver. Best regards, Hoegeun Hoegeun Kwon (4): [media] exynos-gsc: Add compatible for Exynos 5250 and 5420 specific version ARM: dts: exynos: Add clean name of compatible. drm/exynos/gsc: Add hardware rotation limits [media] exynos-gsc: Add hardware rotation limits .../devicetree/

[PATCH v4 4/4] [media] exynos-gsc: Add hardware rotation limits

2017-09-13 Thread Hoegeun Kwon
The hardware rotation limits of gsc depends on SOC (Exynos 5250/5420/5433). Distinguish them and add them to the driver data. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- drivers/media/platform/exynos-gsc/gsc-core.c | 127 +-- 1 file changed, 122 inse

[PATCH v4 3/4] drm/exynos/gsc: Add hardware rotation limits

2017-09-13 Thread Hoegeun Kwon
are related to pos size, use pos size to check the limits. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 104 +++- include/uapi/drm/exynos_drm.h | 2 + 2 files changed, 77 insertions(+), 29 deletions(-)

[PATCH v4 1/4] [media] exynos-gsc: Add compatible for Exynos 5250 and 5420 specific version

2017-09-13 Thread Hoegeun Kwon
Exynos 5250 and 5420 have different hardware rotation limits. Since we have to distinguish between these two, we add different compatible(samsung,exynos5250-gsc and samsung,exynos5420-gsc). Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- Documentation/devicetree/bindings/media/e

[PATCH v4 2/4] ARM: dts: exynos: Add clean name of compatible.

2017-09-13 Thread Hoegeun Kwon
Exynos 5250 and 5420 have different hardware rotation limits. However, currently it uses only one compatible - "exynos5-gsc". Since we have to distinguish between these two, we add different compatible. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- arch/arm/boot/dts

Re: [PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits

2017-09-13 Thread Hoegeun Kwon
On 09/13/2017 06:11 PM, Sylwester Nawrocki wrote: Hi Hoegeun, On 09/13/2017 04:33 AM, Hoegeun Kwon wrote: @@ -1017,8 +1083,12 @@ static irqreturn_t gsc_irq_handler(int irq, void *priv) static const struct of_device_id exynos_gsc_match[] = { { -.compatible = "sa

Re: [PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits

2017-09-12 Thread Hoegeun Kwon
Hi Sylwester, On 09/11/2017 06:35 PM, Sylwester Nawrocki wrote: On 09/08/2017 08:02 AM, Hoegeun Kwon wrote: The hardware rotation limits of gsc depends on SOC (Exynos 5250/5420/5433). Distinguish them and add them to the driver data. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.

Re: [PATCH v2 2/3] ARM: dts: exynos: Add clean name of compatible.

2017-09-12 Thread Hoegeun Kwon
the system] url: https://github.com/0day-ci/linux/commits/Hoegeun-Kwon/drm-exynos-gsc-Support-the-hardware-rotation-limits/20170910-015155 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: arm-at91_dt_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc

[PATCH v3 6/6] ARM: dts: exynos: Remove unnecessary compatible

2017-09-08 Thread Hoegeun Kwon
Currently, the compatible('samsung,exynos5-gsc') is not used. Remove unnecessary compatible. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- arch/arm/boot/dts/exynos5250.dtsi | 8 arch/arm/boot/dts/exynos5420.dtsi | 4 ++-- 2 files changed, 6 insertions(+), 6 del

[PATCH v3 5/6] [media] exynos-gsc: Remove unnecessary compatible

2017-09-08 Thread Hoegeun Kwon
Currently, the compatible('samsung,exynos5-gsc') is not used. Remove unnecessary compatible. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- Documentation/devicetree/bindings/media/exynos5-gsc.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH v3 1/6] [media] exynos-gsc: Add compatible for Exynos 5250 and 5420 specific version

2017-09-08 Thread Hoegeun Kwon
Exynos 5250 and 5420 have different hardware rotation limits. Since we have to distinguish between these two, we add different compatible(samsung,exynos5250-gsc and samsung,exynos5420-gsc). Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- Documentation/devicetree/bindings/media/e

[PATCH v3 0/6] Exynos-gsc: Support the hardware rotation limits

2017-09-08 Thread Hoegeun Kwon
into driver. Best regards, Hoegeun Hoegeun Kwon (6): [media] exynos-gsc: Add compatible for Exynos 5250 and 5420 specific version ARM: dts: exynos: Add clean name of compatible. drm/exynos/gsc: Add hardware rotation limits [media] exynos-gsc: Add hardware rotation limits [media] exynos-gsc

[PATCH v3 2/6] ARM: dts: exynos: Add clean name of compatible.

2017-09-08 Thread Hoegeun Kwon
Exynos 5250 and 5420 have different hardware rotation limits. However, currently it uses only one compatible - "exynos5-gsc". Since we have to distinguish between these two, we add different compatible. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- arch/arm/boot/dts

[PATCH v3 3/6] drm/exynos/gsc: Add hardware rotation limits

2017-09-08 Thread Hoegeun Kwon
are related to pos size, use pos size to check the limits. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 93 +++-- include/uapi/drm/exynos_drm.h | 2 + 2 files changed, 66 insertions(+), 29 deletions(-) diff

[PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits

2017-09-08 Thread Hoegeun Kwon
The hardware rotation limits of gsc depends on SOC (Exynos 5250/5420/5433). Distinguish them and add them to the driver data. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- drivers/media/platform/exynos-gsc/gsc-core.c | 96 1 file changed, 83 inse

Re: [PATCH v2 2/3] ARM: dts: exynos: Add clean name of compatible.

2017-09-07 Thread Hoegeun Kwon
On 09/07/2017 08:27 PM, Marek Szyprowski wrote: Hi Hoegeun, On 2017-09-07 11:39, Hoegeun Kwon wrote: Exynos 5250 and 5420 have different hardware rotation limits. However, currently it uses only one compatible - "exynos5-gsc". Since we have to distinguish between these two, we add

Re: [PATCH 3/3] drm/exynos/gsc: Add rotation hardware limits of gscaler

2017-09-07 Thread Hoegeun Kwon
On 09/07/2017 08:25 PM, Marek Szyprowski wrote: Hi Hoegeun, On 2017-09-07 07:16, Hoegeun Kwon wrote: On 09/04/2017 03:19 PM, Hoegeun Kwon wrote: On 09/01/2017 04:31 PM, Marek Szyprowski wrote: Hi Hoegeun, On 2017-09-01 03:47, Hoegeun Kwon wrote: The gscaler has hardware rotation limits

[PATCH v2 1/3] [media] exynos-gsc: Add compatible for Exynos 5250 and 5420 specific version

2017-09-07 Thread Hoegeun Kwon
Exynos 5250 and 5420 have different hardware rotation limits. Since we have to distinguish between these two, we add different compatible(samsung,exynos5250-gsc and samsung,exynos5420-gsc). Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- Documentation/devicetree/bindings/media/e

[PATCH v2 0/3] drm/exynos/gsc: Support the hardware rotation limits

2017-09-07 Thread Hoegeun Kwon
regards, Hoegeun Hoegeun Kwon (3): [media] exynos-gsc: Add compatible for Exynos 5250 and 5420 specific version ARM: dts: exynos: Add clean name of compatible. drm/exynos/gsc: Add hardware rotation limits .../devicetree/bindings/media/exynos5-gsc.txt | 1 + arch/arm/boot/dts

[PATCH v2 2/3] ARM: dts: exynos: Add clean name of compatible.

2017-09-07 Thread Hoegeun Kwon
Exynos 5250 and 5420 have different hardware rotation limits. However, currently it uses only one compatible - "exynos5-gsc". Since we have to distinguish between these two, we add different compatible. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- arch/arm/boot/dts

[PATCH v2 3/3] drm/exynos/gsc: Add hardware rotation limits

2017-09-07 Thread Hoegeun Kwon
are related to pos size, use pos size to check the limits. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 100 +++- include/uapi/drm/exynos_drm.h | 2 + 2 files changed, 73 insertions(+), 29 deletions(-)

Re: [PATCH 3/3] drm/exynos/gsc: Add rotation hardware limits of gscaler

2017-09-06 Thread Hoegeun Kwon
On 09/04/2017 03:19 PM, Hoegeun Kwon wrote: On 09/01/2017 04:31 PM, Marek Szyprowski wrote: Hi Hoegeun, On 2017-09-01 03:47, Hoegeun Kwon wrote: The gscaler has hardware rotation limits that need to be imported from dts. Parse them and add them to the property list. The rotation hardware

Re: [PATCH] drm/vblank: Fix delta_ns to an absolute value

2017-09-05 Thread Hoegeun Kwon
On 09/04/2017 04:36 PM, Daniel Vetter wrote: On Fri, Sep 01, 2017 at 04:36:25PM +0300, Ville Syrjälä wrote: On Fri, Sep 01, 2017 at 04:07:16PM +0900, Hoegeun Kwon wrote: If scanout started, we should reduce etime by delta_ns. But delta_ns is negative if scanout has not started. If delta_ns

Re: [PATCH 3/3] drm/exynos/gsc: Add rotation hardware limits of gscaler

2017-09-04 Thread Hoegeun Kwon
On 09/01/2017 04:31 PM, Marek Szyprowski wrote: Hi Hoegeun, On 2017-09-01 03:47, Hoegeun Kwon wrote: The gscaler has hardware rotation limits that need to be imported from dts. Parse them and add them to the property list. The rotation hardware limits are related to the cropped source size

[PATCH] drm/vblank: Fix delta_ns to an absolute value

2017-09-01 Thread Hoegeun Kwon
-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- Hello all, I think that the etime should not be increased. In cases where delta_ns is negative, if you get time again after an interrupt call, there is a problem that the time obtained from the interrupt becomes the future time instead of the pas

[PATCH 0/3] drm/exynos/gsc: Support the rotate hardware limits of gsc

2017-08-31 Thread Hoegeun Kwon
Hello all, The gscaler has hardware rotation limits. So this patch set support the rotate hardware limits of gsc. Best regards, Hoegeun Hoegeun Kwon (3): ARM: dts: exynos: Add the hardware rotation limits for gsc arm64: dts: exynos: Add the hardware rotation limits for gsc drm/exynos/gsc

[PATCH 3/3] drm/exynos/gsc: Add rotation hardware limits of gscaler

2017-08-31 Thread Hoegeun Kwon
size, use pos size to check the limits. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 63 + include/uapi/drm/exynos_drm.h | 2 ++ 2 files changed, 42 insertions(+), 23 deletions(-) diff

[PATCH 1/3] ARM: dts: exynos: Add the hardware rotation limits for gsc

2017-08-31 Thread Hoegeun Kwon
The gscaler has maximum size of input or output rotation. Add the hardware limits property for the gscaler rotation in the exynos5250 and exynos5420 dts. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- arch/arm/boot/dts/exynos5250.dtsi | 8 arch/arm/boot/dts/exynos542

[PATCH 2/3] arm64: dts: exynos: Add the hardware rotation limits for gsc

2017-08-31 Thread Hoegeun Kwon
The gscaler has maximum size of input or output rotation. Add the hardware limits property for the gscaler rotation in the exynos5433 dts. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff

Re: [PATCH v4 3/3] ARM: dts: exynos: Remove the display-timing and delay from rinato dts

2017-08-28 Thread Hoegeun Kwon
Hi Krzysztof, The driver has been merged into exynos-drm-misc. Could you please check this patch(3/3). Best regards, Hoegeun On 07/13/2017 11:20 AM, Hoegeun Kwon wrote: The display-timing and delay are included in the panel driver. So it should be removed in dts. Signed-off-by: Hoegeun Kwon

Re: [PATCH v4 0/3] Add support for the s6e63j0x03 panel on Rinato board

2017-07-31 Thread Hoegeun Kwon
Dear Thierry, Could you please check these patches. Best regards, Hoegeun On 07/13/2017 11:20 AM, Hoegeun Kwon wrote: Hi Andrzej, Thank you for your review. The purpose of this patch is add support for s6e63j0x03 AMOLED panel on the rinato board(Samsung Galaxy Gear 2). Changes for V4

[PATCH v4 2/3] drm/panel: Add support for s6e63j0x03 panel driver

2017-07-12 Thread Hoegeun Kwon
ngwon Hwang <human.hw...@samsung.com> Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> --- drivers/gpu/drm/panel/Kconfig| 7 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/pan

[PATCH v4 1/3] dt-bindings: Add support for samsung s6e63j0x03 panel binding

2017-07-12 Thread Hoegeun Kwon
The Samsung s6e63j0x03 is a 1.63" 320x320 AMOLED panel connected using MIPI-DSI interfaces. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Acked-by: Rob Herring <r...@kernel.org> --- .../bindings/display/panel/samsu

[PATCH v4 0/3] Add support for the s6e63j0x03 panel on Rinato board

2017-07-12 Thread Hoegeun Kwon
reflect Andrzej's review. Best regards, Hoegeun Hoegeun Kwon (3): dt-bindings: Add support for samsung s6e63j0x03 panel binding drm/panel: Add support for s6e63j0x03 panel driver ARM: dts: exynos: Remove the display-timing and delay from rinato dts .../bindings/display/panel/samsung,s6e

[PATCH v4 3/3] ARM: dts: exynos: Remove the display-timing and delay from rinato dts

2017-07-12 Thread Hoegeun Kwon
The display-timing and delay are included in the panel driver. So it should be removed in dts. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- arch/arm/boot/dts/exynos3250-rinato.dts | 22 -- 1 file changed, 22 deletions(-) diff --git a/arch/arm/bo

Re: [PATCH v3 2/3] drm/panel: Add support for s6e63j0x03 panel driver

2017-07-12 Thread Hoegeun Kwon
Hi Andrzej, Could you please check this patch? Best regards, Hoegeun On 06/27/2017 11:11 AM, Hoegeun Kwon wrote: This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver which uses mipi_dsi bus to communicate with panel. The panel has 320×320 resolution in 1.63" physical

Re: [PATCH v2] drm/exynos: mic: add a bridge at probe

2017-07-05 Thread Hoegeun Kwon
.ha...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Signed-off-by: Inki Dae <inki@samsung.com> Reviewed-by: Hoegeun Kwon <hoegeun.k...@samsung.com> Best regards, Hoegeun ___ dri-devel mailing list dri-devel@lis

Re: [PATCH v4] drm/exynos/dsi: Remove error handling for bridge_node DT parsing

2017-07-05 Thread Hoegeun Kwon
Hi Inki, Could you check this patch? :D Best regards, Hoegeun On 06/21/2017 07:51 PM, Hoegeun Kwon wrote: Remove the error handling of bridge_node because the bridge_node is optional. For example, In case of Exynos SoC, a bridge device such as mDNIe and MIC could be placed between Display

Re: [PATCH 2/2] drm/exynos: mic: add a bridge at probe

2017-07-05 Thread Hoegeun Kwon
; Reviewed-by: Hoegeun Kwon <hoegeun.k...@samsung.com> Best regards, Hoegeun ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v3 1/3] dt-bindings: Add support for samsung s6e63j0x03 panel binding

2017-06-26 Thread Hoegeun Kwon
The Samsung s6e63j0x03 is a 1.63" 320x320 AMOLED panel connected using MIPI-DSI interfaces. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Acked-by: Rob Herring <r...@kernel.org> --- .../bindings/display/panel/samsu

[PATCH v3 3/3] ARM: dts: exynos: Remove the display-timing and delay from rinato dts

2017-06-26 Thread Hoegeun Kwon
The display-timing and delay are included in the panel driver. So it should be removed in dts. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- arch/arm/boot/dts/exynos3250-rinato.dts | 22 -- 1 file changed, 22 deletions(-) diff --git a/arch/arm/bo

[PATCH v3 2/3] drm/panel: Add support for s6e63j0x03 panel driver

2017-06-26 Thread Hoegeun Kwon
ngwon Hwang <human.hw...@samsung.com> Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- drivers/gpu/drm/panel/Kconfig| 7 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-samsung-s6e63j0x03.c | 540 +

[PATCH v3 0/3] Add support for the s6e63j0x03 panel on Rinato board

2017-06-26 Thread Hoegeun Kwon
m video mode to command mode. - Fixed the reset gpios from active high to low from rinato dts. - Fixed a lot of things in panel driver, reflect Andrzej's review. Best regards, Hoegeun Hoegeun Kwon (3): dt-bindings: Add support for samsung s6e63j0x03 panel binding drm/panel: Add support for s6e6

[PATCH v4] drm/exynos/dsi: Remove error handling for bridge_node DT parsing

2017-06-21 Thread Hoegeun Kwon
Remove the error handling of bridge_node because the bridge_node is optional. For example, In case of Exynos SoC, a bridge device such as mDNIe and MIC could be placed between Display Controller and MIPI DSI device but the bridge device is optional. Signed-off-by: Hoegeun Kwon <hoegeu

[PATCH v3] drm/exynos/dsi: Remove error handling for bridge_node DT parsing

2017-06-21 Thread Hoegeun Kwon
Remove the error handling of bridge_node because the bridge_node is optionally. For example, In case of Exynos SoC, a bridge device such as mDNIe and MIC could be placed between Display Controller and MIPI DSI device but the bridge device is optionally. Signed-off-by: Hoegeun Kwon <hoegeu

Re: [PATCH v2] drm/exynos/dsi: Remove error handling for bridge_node DT parsing

2017-06-19 Thread Hoegeun Kwon
Hello Tobias, Sorry for late reply. On 06/14/2017 09:30 PM, Tobias Jakobi wrote: Hello Hoegeun, my last question (does this regress the case "node required, but absent") still stands. Hoegeun Kwon wrote: Remove the error handling of bridge_node because the bridge_node i

Re: [PATCH v2 2/4] drm/panel: Add support for s6e63j0x03 panel driver

2017-06-19 Thread Hoegeun Kwon
On 06/19/2017 06:14 PM, Andrzej Hajda wrote: On 15.06.2017 12:03, Hoegeun Kwon wrote: This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver which uses mipi_dsi bus to communicate with panel. The panel has 320×320 resolution in 1.63" physical panel. This panel is used in Sa

[PATCH v2 1/4] dt-bindings: Add support for samsung s6e63j0x03 panel binding

2017-06-15 Thread Hoegeun Kwon
The Samsung s6e63j0x03 is a 1.63" 320x320 AMOLED panel connected using MIPI-DSI interfaces. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Acked-by: Rob Herring <r...@kernel.org> --- .../bindings/display/panel/samsu

[PATCH v2 2/4] drm/panel: Add support for s6e63j0x03 panel driver

2017-06-15 Thread Hoegeun Kwon
ngwon Hwang <human.hw...@samsung.com> Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- drivers/gpu/drm/panel/Kconfig| 7 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-samsung-s6e63j0x03.c | 476 +

[PATCH v2 4/4] ARM: dts: exynos: Remove the display-timing and delay from rinato dts

2017-06-15 Thread Hoegeun Kwon
The display-timing and delay are included in the panel driver. So it should be removed in dts. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- arch/arm/boot/dts/exynos3250-rinato.dts | 22 -- 1 file changed, 22 deletions(-) diff --git a/arch/arm/bo

[PATCH v2 0/4] Add support for the s6e63j0x03 panel on Rinato board

2017-06-15 Thread Hoegeun Kwon
ing <r...@kernel.org> (1/3 patch). - Fixed the tristate of config from video mode to command mode. - Fixed the reset gpios from active high to low from rinato dts. - Fixed a lot of things in panel driver, reflect Andrzej's review. Best regards, Hoegeun Hoegeun Kwon (4): dt-bindings: Add support

[PATCH v2 3/4] ARM: dts: exynos: Fix the active of reset gpios from rinato dts

2017-06-15 Thread Hoegeun Kwon
This reset gpios is active low, therefore fix from active high to low. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- arch/arm/boot/dts/exynos3250-rinato.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/ar

Re: [PATCH 2/3] drm/panel: Add support for s6e63j0x03 panel driver

2017-06-14 Thread Hoegeun Kwon
Hi Andrzej, Thanks for your review. On 06/12/2017 10:16 PM, Andrzej Hajda wrote: Hi Hoegeun, Nice to see patches completing support for mainlined platforms. On 09.06.2017 06:59, Hoegeun Kwon wrote: This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver which uses mipi_dsi bus

[PATCH v2] drm/exynos/dsi: Remove error handling for bridge_node DT parsing

2017-06-14 Thread Hoegeun Kwon
Remove the error handling of bridge_node because the bridge_node is required optionally. For example, In case of Exynos SoC, a bridge device such as mDNIe and MIC could be placed between Display Controller and MIPI DSI device but the bridge device is required optionally. Signed-off-by: Hoegeun

Re: [PATCH] drm/exynos/dsi: Remove error handling for bridge_node DT parsing

2017-06-13 Thread Hoegeun Kwon
On 06/13/2017 06:25 PM, Inki Dae wrote: 2017년 06월 09일 18:23에 Hoegeun Kwon 이(가) 쓴 글: The bridge_node is unnecessary between FIMD and DSIM. If don't remove error handling, it will not work between FIMD and DSIM. So remove error handling. Please make sure to describe why bridge_node

[PATCH] drm/exynos/dsi: Remove error handling for bridge_node DT parsing

2017-06-09 Thread Hoegeun Kwon
The bridge_node is unnecessary between FIMD and DSIM. If don't remove error handling, it will not work between FIMD and DSIM. So remove error handling. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 -- 1 file changed, 2 deletions(-)

Re: [PATCH 3/3] ARM: dts: exynos: Remove the display-timing and delay from rinato dts

2017-06-09 Thread Hoegeun Kwon
On 06/09/2017 04:45 PM, Krzysztof Kozlowski wrote: On Fri, Jun 09, 2017 at 01:59:14PM +0900, Hoegeun Kwon wrote: The display-timing and delay are included in the panel driver. So it should be removed in dts. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- arch/arm/bo

Re: [PATCH] ARM: dts: exynos: Add the OF graph between fimd and dsi

2017-06-09 Thread Hoegeun Kwon
On 06/09/2017 04:27 PM, Krzysztof Kozlowski wrote: On Fri, Jun 09, 2017 at 11:59:33AM +0900, Hoegeun Kwon wrote: It should be connected to OF graph between fimd and dsi. Add the OF graph between fimd and dsi. I need more explanation why this is needed. What happens without this? What issue

[PATCH 1/3] dt-bindings: Add support for samsung s6e63j0x03 panel binding

2017-06-08 Thread Hoegeun Kwon
The Samsung s6e63j0x03 is a 1.63" 320x320 AMOLED panel connected using MIPI-DSI interfaces. Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> --- .../bindings/display/panel/samsung,s6e63j0x03.txt | 24 ++ 1 file changed, 24 insertions(+) create

  1   2   3   >