Re: [PATCH 2/2] drm/bridge: ti-sn65dsi86: Allow DT to set "HPD delay"

On 2018-10-20 01:49, Douglas Anderson wrote: Let's solve the mystery of commit bf1178c98930 ("drm/bridge: ti-sn65dsi86: Add mystery delay to enable()"). Specifically the reason we needed that mystery delay is that we weren't paying attention to HPD. Looking at the datasheet for the same panel

Re: [PATCH v3 7/7] drm/bridge: ti-sn65dsi86: Add mystery delay to enable()

On 2018-08-14 03:00, Sean Paul wrote: From: Sean Paul This patch adds a 70ms mystery delay to the bridge driver in enable. By experimentation, it seems like it can go anywhere up until we initiate semi-auto link training. If we don't have the delay, link training fails. I tried to root cause

Re: [PATCH v3 7/7] drm/bridge: ti-sn65dsi86: Add mystery delay to enable()

On 2018-08-23 19:55, Sean Paul wrote: On Tue, Aug 14, 2018 at 10:01:45AM -0400, Sean Paul wrote: On Tue, Aug 14, 2018 at 10:00:33AM -0400, Sean Paul wrote: > On Tue, Aug 14, 2018 at 04:59:31PM +0530, spa...@codeaurora.org wrote: > > On 2018-08-14 03:00, Sean Paul wrote: > > > From: Sean Paul >

Re: [PATCH v3 7/7] drm/bridge: ti-sn65dsi86: Add mystery delay to enable()

On 2018-08-14 03:00, Sean Paul wrote: From: Sean Paul This patch adds a 70ms mystery delay to the bridge driver in enable. By experimentation, it seems like it can go anywhere up until we initiate semi-auto link training. If we don't have the delay, link training fails. I tried to root cause

Re: [PATCH v3 6/7] drm/bridge: ti-sn65dsi86: Poll for training complete

On 2018-08-14 03:00, Sean Paul wrote: From: Sean Paul Instead of just waiting 20ms for training to complete, actually poll the status to ensure training is finished. Changes in v3: - Added to the set Cc: Sandeep Panda Signed-off-by: Sean Paul --- drivers/gpu/drm/bridge/ti-sn65dsi86.c |

Re: [PATCH v3 3/7] drm/bridge: ti-sn65dsi86: Implement AUX channel

On 2018-08-14 03:00, Sean Paul wrote: From: Sean Paul This was hand-rolled in the first version, and will surely be useful as we expand the driver to support more varied use cases. Changes in v2: - Change subject prefix s/panel/bridge/ - Downgrade warning in poll function to error message -

Re: [PATCH v3 5/7] drm/bridge: ti-sn65dsi86: Poll for DP PLL Lock

On 2018-08-14 03:00, Sean Paul wrote: From: Sean Paul Instead of just waiting and hoping, actually poll for the pll lock to be acquired. As a bonus, this should be significantly faster than the sleep. Changes in v3: - Added to the set Cc: Sandeep Panda Signed-off-by: Sean Paul ---

Re: [PATCH v3 2/7] drm/bridge: ti-sn65dsi86: Fixup register names

On 2018-08-14 03:00, Sean Paul wrote: From: Sean Paul Order registers by offset and rename bits & masks to match the datasheet. This makes the driver a bit easier to grok and cross-reference with the datasheet. Changes in v3: - Added to the set Cc: Sandeep Panda Signed-off-by: Sean Paul

Re: [PATCH v3 4/7] drm/bridge: ti-sn65dsi86: Move panel_prepare() to pre_enable()

On 2018-08-14 03:00, Sean Paul wrote: From: Sean Paul prepare() is the old-timey way to say pre_enable(). It should be called before modeset. This fixes an issue where the panel on cheza must have the regulator always-on/boot-on for it to work. Changes in v3: - Added to the set Cc: Sandeep

Re: [PATCH v3 1/7] drm/panel: simple: tv123wam: Add unprepare delay

On 2018-08-14 03:00, Sean Paul wrote: From: Sean Paul The panel datasheet specifies a 500ms delay after power-down before re-enabling. Changes in v2: - None Changes in v3: - Added to the set Cc: Sandeep Panda Signed-off-by: Sean Paul --- drivers/gpu/drm/panel/panel-simple.c | 3 +++ 1

Re: [PATCH] drm/panel: sn65dsi86: Implement AUX channel

Hi Sean, Thanks for your patch. I also made this similar change as part of my PSR support changes (yet to be posted for review). But since this patch is posted now, i will pick this for my PSR changes. On 2018-08-09 03:23, Sean Paul wrote: This was hand-rolled in the first version, and will

Re: [PATCH] drm/bridge/ti-sn65dsi86: Fix implicit declaration to drm_mode_connector_attach_encoder

On 2018-07-30 23:12, Sean Paul wrote: This function name was changed to drm_connector_attach_encoder(). Unfortunately this driver was posted on the list before that change, and applied after Fixes: a095f15c00e2 ("drm/bridge: add support for sn65dsi86 bridge driver") Cc: Sandeep Panda Cc:

Re: [PATCH v14 1/2] drm/bridge: add support for sn65dsi86 bridge driver

On 2018-07-19 10:57, Andrzej Hajda wrote: On 16-Jul-18 17:43, Sandeep Panda wrote: Add support for TI's sn65dsi86 dsi2edp bridge chip. The chip converts DSI transmitted signal to eDP signal, which is fed to the connected eDP panel. This chip can be controlled via either i2c interface or dsi

Re: [PATCH v13 3/3] dt-bindings: drm/bridge: Document sn65dsi86 bridge bindings

On 2018-06-29 17:31, Andrzej Hajda wrote: On 27.06.2018 11:57, Sandeep Panda wrote: Document the bindings used for the sn65dsi86 DSI to eDP bridge. Changes in v1: - Rephrase the dt-binding descriptions to be more inline with existing bindings (Andrzej Hajda). - Add missing dt-binding

Re: [PATCH v12 5/5] dt-bindings: drm/panel: Document Innolux TV123WAM panel bindings

On 2018-07-05 15:48, Andrzej Hajda wrote: On 05.07.2018 08:38, spa...@codeaurora.org wrote: On 2018-06-29 17:44, Andrzej Hajda wrote: On 21.06.2018 14:32, Sandeep Panda wrote: Innolux TV123WAM is a 12.3" eDP display panel with 2160x1440 resolution, which can be supported by simple panel

Re: [PATCH v12 5/5] dt-bindings: drm/panel: Document Innolux TV123WAM panel bindings

On 2018-06-29 17:44, Andrzej Hajda wrote: On 21.06.2018 14:32, Sandeep Panda wrote: Innolux TV123WAM is a 12.3" eDP display panel with 2160x1440 resolution, which can be supported by simple panel driver. Are you sure this is Innolux? Quick grep on Internet finds only BOE panel with this

Re: [PATCH v12 3/5] dt-bindings: drm/bridge: Document sn65dsi86 bridge bindings

On 2018-06-22 06:42, Stephen Boyd wrote: Quoting Sandeep Panda (2018-06-21 05:32:07) diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt new file mode 100644 index ..c8b8f018356f ---

Re: [PATCH v11 2/5] drm/bridge: add support for sn65dsi86 bridge driver

On 2018-06-15 16:59, Andrzej Hajda wrote: Hi Sandeep, Thanks for the patch, I hope it will be merged soon. On 15.06.2018 08:43, Sandeep Panda wrote: Add support for TI's sn65dsi86 dsi2edp bridge chip. The chip converts DSI transmitted signal to eDP signal, which is fed to the connected eDP

Re: [PATCH v11 3/5] dt-bindings: drm/bridge: Document sn65dsi86 bridge bindings

On 2018-06-15 12:53, Andrzej Hajda wrote: On 15.06.2018 08:43, Sandeep Panda wrote: Document the bindings used for the sn65dsi86 DSI to eDP bridge. Changes in v1: - Rephrase the dt-binding descriptions to be more inline with existing bindings (Andrzej Hajda). - Add missing dt-binding

Re: [PATCH v8 1/4] drm/bridge: add support for sn65dsi86 bridge driver

On 2018-06-06 04:29, Sean Paul wrote: On Tue, Jun 05, 2018 at 11:10:15AM +0530, Sandeep Panda wrote: Add support for TI's sn65dsi86 dsi2edp bridge chip. The chip converts DSI transmitted signal to eDP signal, which is fed to the connected eDP panel. This chip can be controlled via either i2c

Re: [PATCH v8 2/4] dt-bindings: drm/bridge: Document sn65dsi86 bridge bindings

On 2018-06-05 20:50, Rob Herring wrote: On Tue, Jun 05, 2018 at 11:10:16AM +0530, Sandeep Panda wrote: Document the bindings used for the sn65dsi86 DSI to eDP bridge. Changes in v1: - Rephrase the dt-binding descriptions to be more inline with existing bindings (Andrzej Hajda). - Add

Re: [PATCH v8 2/4] dt-bindings: drm/bridge: Document sn65dsi86 bridge bindings

On 2018-06-12 14:01, Stephen Boyd wrote: Quoting spa...@codeaurora.org (2018-06-05 21:50:16) On 2018-06-05 20:50, Rob Herring wrote: > On Tue, Jun 05, 2018 at 11:10:16AM +0530, Sandeep Panda wrote: >> Document the bindings used for the sn65dsi86 DSI to eDP bridge. [...] >> and >> +

Re: [PATCH v8 1/4] drm/bridge: add support for sn65dsi86 bridge driver

On 2018-06-12 05:05, Stephen Boyd wrote: Quoting Sandeep Panda (2018-06-04 22:40:15) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c new file mode 100644 index 000..add6e0f --- /dev/null +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -0,0 +1,666

Re: [PATCH v8 2/4] dt-bindings: drm/bridge: Document sn65dsi86 bridge bindings

On 2018-06-05 20:50, Rob Herring wrote: On Tue, Jun 05, 2018 at 11:10:16AM +0530, Sandeep Panda wrote: Document the bindings used for the sn65dsi86 DSI to eDP bridge. Changes in v1: - Rephrase the dt-binding descriptions to be more inline with existing bindings (Andrzej Hajda). - Add

Re: [PATCH v6 2/4] dt-bindings: drm/bridge: Document sn65dsi86 bridge bindings

On 2018-05-16 21:57, Stephen Boyd wrote: Quoting Sandeep Panda (2018-05-14 22:52:42) diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt new file mode 100644 index 000..b82bb56 --- /dev/null +++

Re: [PATCH v6 1/4] drm/bridge: add support for sn65dsi86 bridge driver

On 2018-05-16 12:56, Andrzej Hajda wrote: I suppose you wanted to respond on the list, so I have added back all recipients. On 16.05.2018 06:39, spa...@codeaurora.org wrote: On 2018-05-15 19:23, Andrzej Hajda wrote: On 15.05.2018 07:52, Sandeep Panda wrote: Add support for TI's sn65dsi86

Re: [PATCH v5 3/4] drm/panel: add Innolux TV123WAM panel driver support

On 2018-05-03 00:35, Sean Paul wrote: On Wed, May 02, 2018 at 10:02:01AM +0530, Sandeep Panda wrote: Add support for Innolux TV123WAM, which is a 12.3" eDP display panel with 2160x1440 resolution. Signed-off-by: Sandeep Panda --- drivers/gpu/drm/panel/panel-simple.c |

Re: [PATCH v5 1/4] drm/bridge: add support for sn65dsi86 bridge driver

On 2018-05-03 00:33, Sean Paul wrote: On Wed, May 02, 2018 at 10:01:59AM +0530, Sandeep Panda wrote: Add support for TI's sn65dsi86 dsi2edp bridge chip. The chip converts DSI transmitted signal to eDP signal, which is fed to the connected eDP panel. This chip can be controlled via either i2c

Re: [PATCH v5 2/4] dt-bindings: drm/bridge: Document sn65dsi86 bridge bindings

On 2018-05-08 03:48, Stephen Boyd wrote: Quoting spa...@codeaurora.org (2018-05-03 02:41:29) On 2018-05-02 22:31, Stephen Boyd wrote: > Quoting Sandeep Panda (2018-05-01 21:32:00) >> diff --git >> a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt >>

Re: [PATCH v5 1/4] drm/bridge: add support for sn65dsi86 bridge driver

On 2018-05-08 03:50, Stephen Boyd wrote: Quoting Sean Paul (2018-05-02 12:03:16) On Wed, May 02, 2018 at 10:01:59AM +0530, Sandeep Panda wrote: > + struct drm_display_mode curr_mode; > + struct mutex lock; > + unsigned int ctrl_ref_count; > +}; > + > +static const struct

Re: [PATCH v5 2/4] dt-bindings: drm/bridge: Document sn65dsi86 bridge bindings

On 2018-05-02 22:31, Stephen Boyd wrote: Quoting Sandeep Panda (2018-05-01 21:32:00) diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt new file mode 100644 index 000..0d042ce --- /dev/null +++

Re: [[RFC]DPU PATCH 2/4] dt-bindings: drm/bridge: Document sn65dsi86 bridge bindings

On 2018-04-27 08:43, Rob Herring wrote: On Wed, Apr 25, 2018 at 08:46:13PM -0400, Rob Clark wrote: On Wed, Apr 25, 2018 at 7:45 PM, Stephen Boyd wrote: > Quoting Sandeep Panda (2018-04-19 10:56:06) >> Document the bindings used for the sn65dsi86 DSI to eDP bridge. >> >>

Re: [[RFC]DPU PATCH 4/4] dt-bindings: Add Innolux TV123WAM panel bindings

On 2018-04-24 20:13, Rob Herring wrote: On Wed, Apr 18, 2018 at 05:50:02PM +0530, Sandeep Panda wrote: The Innolux TV123WAM is a 12.3" eDP display panel with 2160x1440 resolution. Why don't you just submit this for upstream? Sean Paul has suggested to reuse simple panel driver instead of

Re: [[RFC]DPU PATCH 1/4] drm/bridge: add support for sn65dsi86 bridge driver

On 2018-04-21 01:06, Sean Paul wrote: On Thu, Apr 19, 2018 at 11:26:05PM +0530, Sandeep Panda wrote: Add support for TI's sn65dsi86 dsi2edp bridge chip. The chip converts DSI transmitted signal to eDP signal, which is fed to the connected eDP panel. This chip can be controlled via either i2c

Re: [[RFC]DPU PATCH 3/4] drm/panel: add Innolux TV123WAM eDP panel driver

On 2018-04-21 01:13, Sean Paul wrote: On Thu, Apr 19, 2018 at 11:26:07PM +0530, Sandeep Panda wrote: Add support for Innolux TV123WAM 12.3" panel which is an eDP panel. It seems like you could just use the panel-simple driver, no? Given that this driver doesn't have any power timing, that

Re: [[RFC]DPU PATCH 1/4] drm/bridge: add support for sn65dsi86 bridge driver

On 2018-04-19 20:44, Jordan Crouse wrote: On Wed, Apr 18, 2018 at 05:49:59PM +0530, Sandeep Panda wrote: Add support for TI's sn65dsi86 dsi2edp bridge chip. The chip converts DSI transmitted signal to eDP signal, which is fed to the connected eDP panel. This chip can be controlled via either

Re: [[RFC]DPU PATCH 0/4] Add suppport for sn65dsi86 bridge chip and Innolux 2k edp panel driver

On 2018-04-18 19:42, Sean Paul wrote: On Wed, Apr 18, 2018 at 05:49:58PM +0530, Sandeep Panda wrote: Changelog: v3 -> v4: I didn't really bother to do a thorough review given that there are obvious mistakes and ignored feedback, it's a waste of time, tbh. Please go through the previous

Re: [[RFC]DPU PATCH 1/4] drm/bridge: add support for sn65dsi86 bridge driver

On 2018-04-18 19:41, Sean Paul wrote: On Wed, Apr 18, 2018 at 05:49:59PM +0530, Sandeep Panda wrote: Add support for TI's sn65dsi86 dsi2edp bridge chip. The chip converts DSI transmitted signal to eDP signal, which is fed to the connected eDP panel. This chip can be controlled via either i2c

Re: [[RFC]DPU PATCH 2/4] dt-bindings: drm/bridge: Document sn65dsi86 bridge bindings

On 2018-04-18 19:28, Sean Paul wrote: On Wed, Apr 18, 2018 at 05:50:00PM +0530, Sandeep Panda wrote: Document the bindings used for the sn65dsi86 DSI to eDP bridge. Please add a changelog to your patches so reviewers know what has changed between patch versions. I will update the change

Re: [[RFC]DPU PATCH 1/4] drm/bridge: add support for sn65dsi86 bridge driver

On 2018-04-18 19:41, Sean Paul wrote: On Wed, Apr 18, 2018 at 05:49:59PM +0530, Sandeep Panda wrote: Add support for TI's sn65dsi86 dsi2edp bridge chip. The chip converts DSI transmitted signal to eDP signal, which is fed to the connected eDP panel. This chip can be controlled via either i2c

Re: [[RFC]DPU PATCH 1/2] drm/bridge: add support for sn65dsi86 bridge driver

On 2018-04-14 00:59, Sean Paul wrote: On Fri, Apr 13, 2018 at 10:53:00AM +0530, Sandeep Panda wrote: Add support for TI's sn65dsi86 dsi2edp bridge chip. The chip converts DSI transmitted signal to eDP signal, which is fed to the connected eDP panel. This chip can be controlled via either i2c