Re: [PATCH v6 3/3] drm/stm: ltdc: add lvds pixel clock

2024-06-21 Thread Yannick FERTRE
for a complete update of the clock framework, this would allow to use the LVDS. Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- Changes in v2: - Fixed my address - Fixed smatch warning --- drivers/gpu/drm/stm/ltdc.c | 19 +++ drivers/gpu/drm/stm/ltdc.h

Re: [PATCH RESEND v3 1/3] drm/stm: dsi: use new SYSTEM_SLEEP_PM_OPS() macro

2024-06-21 Thread Yannick FERTRE
Hi Raphael, thanks for the patch. Acked-by: Yannick Fertre Tested-by: Yannick Fertre BR Le 29/01/2024 à 11:41, Raphael Gallais-Pou a écrit : Use RUNTIME_PM_OPS() instead of the old SET_SYSTEM_SLEEP_PM_OPS(). This means we don't need __maybe_unused on the functions. Signed-off

Re: [PATCH RESEND v3 2/3] drm/stm: dsi: add pm runtime ops

2024-06-21 Thread Yannick FERTRE
Hi Raphael, thanks for the patch. Acked-by: Yannick Fertre Tested-by: Yannick Fertre BR Le 29/01/2024 à 11:41, Raphael Gallais-Pou a écrit : From: Yannick Fertre Update control of clocks and supply thanks to the PM runtime mechanism to avoid kernel crash during a system suspend

Re: TR: [PATCH v4] drm/stm: Avoid use-after-free issues with crtc and plane

2024-06-21 Thread Yannick FERTRE
Hi Katya, thanks for the patch. Tested-by: Yannick Fertre BR Le 19/03/2024 à 14:47, Philippe CORNU - foss a écrit : zut, déjà un acked-by de RGA... tu confirmes que je prends? Philippe De : Raphael GALLAIS-POU - foss Envoyé : lundi 26 février 2024 14

Re: [PATCH RESEND v3 3/3] drm/stm: dsi: expose DSI PHY internal clock

2024-06-21 Thread Yannick FERTRE
Hi Raphael, thanks for the patch. Acked-by: Yannick Fertre Tested-by: Yannick Fertre BR Le 29/01/2024 à 11:41, Raphael Gallais-Pou a écrit : DSISRC __ __\_ |\ pll4_p_ck ->| 1 |dsi_k ck_dsi_

Re: [PATCH] drm/stm: dsi: relax mode_valid clock tolerance

2024-05-15 Thread Yannick FERTRE
Hi Sean, thanks for your patch. Tested-by: Yannick Fertre I think that a helper could be useful in simplifying this part. This might be reworked when a new helper will be implemented. Best regards On 4/22/24 16:05, Sean Nyekjaer wrote: On Fri, Mar 22, 2024 at 11:47:31AM +0100, Sean

Re: [PATCH v6 1/3] dt-bindings: display: add STM32 LVDS device

2024-03-18 Thread Yannick FERTRE
Hi Raphael, thanks for the patch. Acked-by: Yannick Fertre Best regards On 2/26/24 11:48, Raphael Gallais-Pou wrote: Add "st,stm32mp25-lvds" compatible. Signed-off-by: Raphael Gallais-Pou Reviewed-by: Conor Dooley --- Depends on: "dt-bindings: stm32: add clocks an

Re: [PATCH v6 2/3] drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver

2024-03-18 Thread Yannick FERTRE
Hi Raphael, thanks for the patch. Acked-by: Yannick Fertre Best regards On 2/26/24 11:48, Raphael Gallais-Pou wrote: The Low-Voltage Differential Signaling (LVDS) Display Interface Transmitter handles the LVDS protocol: it maps the pixels received from the upstream Pixel-DMA LCD-TFT Display

Re: [PATCH] drm/stm: ltdc: fix late dereference check

2023-04-13 Thread Yannick FERTRE
Hi Raphael, thanks for the patch. Reviewed-by: Yannick Fertre On 4/12/23 11:25, Raphael GALLAIS-POU wrote: Attention: Sender not authenticated -- In ltdc_crtc_set_crc_source(), struct drm_crtc was dereferenced in a container_of() before

Re: [PATCH] drm/stm: Fix resolution bitmasks

2022-10-14 Thread Yannick FERTRE
gned on 16bits. I would like to know if you use a display which resolution exceed 2048. Best regards Yannick Fertré On 10/14/22 14:17, Yannick FERTRE wrote: Hi Marek, thanks for the patch. Reviewed-by: Yannick Fertre On 10/12/22 01:10, Marek Vasut wrote: STM32MP15xx RM0436 Rev 6 "35

Re: [PATCH] drm/stm: Fix resolution bitmasks

2022-10-14 Thread Yannick FERTRE
Hi Marek, thanks for the patch. Reviewed-by: Yannick Fertre On 10/12/22 01:10, Marek Vasut wrote: STM32MP15xx RM0436 Rev 6 "35.7.3 LTDC synchronization size configuration register (LTDC_SSCR)" on page 1784 and onward indicates VSH and similar bits are all [11:0] instead of [10:0]

[PATCH] drm/stm: ltdc: remove error message about scaling

2022-06-03 Thread Yannick Fertre
Remove error message about scaling & replace it by a debug message to avoid too much error. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c i

[PATCH] drm/stm: ltdc: add support of the dynamic z-order

2022-06-03 Thread Yannick Fertre
Zpos property is immutable for all hardware versions except the last version (0x40100) which support the blending order feature (dynamic z-order). Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/drv.c | 1 + drivers/gpu/drm/stm/ltdc.c | 23 --- drivers/gpu/drm/stm

[PATCH] drm/stm: ltdc: disable all layers before crtc shutdown

2022-06-03 Thread Yannick Fertre
All plans must be disabled before the CRTC shutdown helping the crtc to restart from a clean situation (without unwanted planes already enable). Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/stm/ltdc.c b

[PATCH] drm/stm: ltdc: fix various coding-style warnings

2022-06-03 Thread Yannick Fertre
Fix issues reported by checkpatch.pl: - Braces {} should be used on all arms - Blank lines Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index

[PATCH] drm/stm: ltdc: add support of horizontal & vertical mirroring

2022-06-03 Thread Yannick Fertre
Support of vertical & horizontal mirroring features thanks to the plane rotation property. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 163 - drivers/gpu/drm/stm/ltdc.h | 1 + 2 files changed, 108 insertions(+), 56 deletions(-)

[PATCH] drm/stm: ltdc: update hardware error management

2022-06-03 Thread Yannick Fertre
The latest hardware version (0x40100) supports a hardware threshold register (aka FUTR) to trigger a fifo underrun interrupt. A software threshold has been implemented for other hardware versions. The threshold is set to 128 by default. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm

Re: [PATCH] drm/stm: ltdc: add support for CRC hashing feature

2022-02-22 Thread yannick Fertre
Hi Raphael, thanks for the patch. Acked-by: Yannick Fertre Best regards On 2/11/22 11:46, Raphaël Gallais-Pou wrote: From: Raphael Gallais-Pou This patch adds the CRC hashing feature supported by some recent hardware versions of the LTDC. This is useful for test suite such as IGT-GPU

Re: [PATCH] drm/stm: Avoid using val uninitialized in ltdc_set_ycbcr_config()

2022-02-08 Thread yannick Fertre
Hi Nathan, Thenks for the patch. Acked-by: Yannick Fertre Best regards On 2/7/22 17:53, Nathan Chancellor wrote: Clang warns: drivers/gpu/drm/stm/ltdc.c:625:2: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized] default

Re: [PATCH 5/5] drm/stm: ltdc: add support of ycbcr pixel formats

2022-02-07 Thread yannick Fertre
Hi Nathan, On 2/2/22 17:54, Nathan Chancellor wrote: Hi Yannick, On Wed, Dec 15, 2021 at 10:48:43PM +0100, Yannick Fertre wrote: This patch adds the following YCbCr input pixel formats on the latest LTDC hardware version: 1 plane (co-planar) : YUYV, YVYU, UYVY, VYUY 2 planes (semi-planar

Re: [PATCH v2 6/6] drm/stm: ltdc: Drop format_mod_supported function

2022-01-12 Thread yannick Fertre
Hello José, thanks for your patch. Reviewed-by: Yannick Fertre Tested-by: Yannick Fertre On 12/22/21 10:05 AM, José Expósito wrote: The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/g

[PATCH 5/5] drm/stm: ltdc: add support of ycbcr pixel formats

2021-12-15 Thread Yannick Fertre
This patch adds the following YCbCr input pixel formats on the latest LTDC hardware version: 1 plane (co-planar) : YUYV, YVYU, UYVY, VYUY 2 planes (semi-planar): NV12, NV21 3 planes (full-planar): YU12=I420=DRM YUV420, YV12=DRM YVU420 Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm

[PATCH 4/5] drm/stm: ltdc: add support of flexible pixel formats

2021-12-15 Thread Yannick Fertre
This feature allows the generation of any RGB pixel format. The list of supported formats is no longer linked to the register LXPFCR_PF, that the reason why a list of drm formats is defined for each display controller version. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 196

[PATCH 3/5] drm/stm: ltdc: add per plane update support

2021-12-15 Thread Yannick Fertre
Recent ltdc hardware versions offer the ability to update a plane independently of others planes. This is could be useful especially if a plane is assigned to another OS. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 26 +++--- drivers/gpu/drm/stm/ltdc.h

[PATCH 2/5] drm/stm: ltdc: add YCbCr 422 output support

2021-12-15 Thread Yannick Fertre
Y0Cb, then Y1Cr, Y2Cb and so on). * Cr is output first (Y0Cr, then Y1Cb, Y2Cr and so on). Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 44 +- drivers/gpu/drm/stm/ltdc.h | 1 + 2 files changed, 44 insertions(+), 1 deletion(-) diff --git a/dri

[PATCH 1/5] drm/stm: ltdc: switch to regmap

2021-12-15 Thread Yannick Fertre
Replace the legacy register access by regmap API. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 138 ++--- drivers/gpu/drm/stm/ltdc.h | 1 + 2 files changed, 68 insertions(+), 71 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers

[PATCH 0/5] drm/stm: new features to display controller

2021-12-15 Thread Yannick Fertre
link to patch"drm/stm: ltdc: support of new hardware version" (https://patchwork.freedesktop.org/patch/465207). Yannick Fertre (5): drm/stm: ltdc: switch to regmap drm/stm: ltdc: add YCbCr 422 output support drm/stm: ltdc: add per plane update support drm/stm: ltdc: add support of

[PATCH] drm/stm: remove conflicting framebuffers

2021-12-06 Thread Yannick Fertre
In case of using simplefb or another conflicting framebuffer, call drm_aperture_remove_framebuffers() to remove memory allocated. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/drv.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm

Re: [PATCH] drm/stm: remove conflicting framebuffers

2021-12-06 Thread yannick Fertre
Hi Thomas, On 12/3/21 10:35 AM, Thomas Zimmermann wrote: Hi Am 03.12.21 um 09:55 schrieb Yannick Fertre: In case of using simplefb or another conflicting framebuffer, call drm_aperture_remove_framebuffers() to remove memory allocated. Signed-off-by: Yannick Fertre ---   drivers/gpu/drm/stm

[PATCH] drm/stm: ltdc: support of new hardware version

2021-12-03 Thread Yannick Fertre
Add support of new hardware version 0x40100. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 172 ++--- drivers/gpu/drm/stm/ltdc.h | 3 +- 2 files changed, 145 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu

[PATCH] drm/stm: remove conflicting framebuffers

2021-12-03 Thread Yannick Fertre
In case of using simplefb or another conflicting framebuffer, call drm_aperture_remove_framebuffers() to remove memory allocated. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/drv.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm

[PATCH] drm: bridge: remove error message for EPROBE_DEFER in bridge_attach

2021-12-03 Thread Yannick Fertre
Probe deferred is not an error, don't print it. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/drm_bridge.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index c96847fc0ebc..cef0a62ef5d0 100644

Re: [PATCH] drm/stm: ltdc: attach immutable zpos property to planes

2021-09-07 Thread yannick Fertre
Hi Raphael, thanks for the patch. Acked-by: Yannick Fertre Reviewed-by: Yannick Fertre On 9/2/21 5:30 PM, Raphael GALLAIS-POU - foss wrote: Defines plane ordering by hard-coding an immutable Z position from the first plane, used as primary layer, to the next ones as overlay in order

Re: [PATCH] drm/stm: ltdc: add layer alpha support

2021-09-07 Thread yannick Fertre
Hi Raphael, thanks for the patch. Acked-by: Yannick Fertre Reviewed-by: Yannick Fertre On 9/3/21 10:58 AM, Raphael GALLAIS-POU - foss wrote: Android Hardware Composer supports alpha values applied to layers. Enabling non-opaque layers for the STM CRTC could help offload GPU resources

Re: [PATCH] drm/bridge: dw-mipi-dsi: Find the possible DSI devices

2021-07-07 Thread yannick Fertre
Hi Jagan, Sorry for the delay. Thanks for the patch. Tested-by: Yannick Fertre On 7/4/21 4:03 PM, Jagan Teki wrote: Finding panel_or_bridge might vary based on associated DSI devices like DSI panel, bridge, and I2C based DSI bridge. 1. DSI panels and bridges will invoke the host attach

Re: [PATCH] drm/stm: ltdc: Silence -EPROBE_DEFER till bridge attached

2021-07-07 Thread yannick Fertre
Hi Jagan, thanks for the patch. Tested-by: Yannick Fertre On 7/4/21 3:59 PM, Jagan Teki wrote: As dw-mipi-dsi supported all possible ways to find the DSI devices. It can take multiple iterations for ltdc to find all components attached to the DSI bridge. The current ltdc driver failed

Re: [PATCH] drm/stm: ltdc: improve pm_runtime to stop clocks

2021-07-06 Thread yannick Fertre
Hi Raphaël, thanks for the patch. Tested-by: Yannick Fertre On 6/29/21 1:58 PM, Raphael GALLAIS-POU - foss wrote: Bugzilla ticket: https://intbugzilla.st.com/show_bug.cgi?id=60620 Gerrit patch: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/208093/ In the LTDC driver, pm_runtime_get_sync

Re: [PATCH v4 19/27] drm/stm: Don't set struct drm_device.irq_enabled

2021-06-29 Thread yannick Fertre
Hello Thomas, thanks for the patch. Tested-by: Yannick Fertre Best regards On 6/25/21 10:22 AM, Thomas Zimmermann wrote: The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in stm. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent

Re: [PATCH] drm/stm: Remove usage of drm_display_mode_to_videomode()

2021-05-28 Thread yannick Fertre
Hi Philippe, I have already reviewed this patch on January 7, 2020. (https://lore.kernel.org/dri-devel/0ab4ee45-4437-3b02-cf63-0e3b1b539...@st.com/) Could you please review it and merge it? Best regards Yannick On 5/28/21 10:05 AM, Yannick Fertre wrote: There is not much value in the extra

[PATCH] drm/stm: Remove usage of drm_display_mode_to_videomode()

2021-05-28 Thread Yannick Fertre
There is not much value in the extra conversion step, the calculations required for the LTDC IP are different than what is used in the drm_display_mode_to_videomode(), so just do the right ones in the LTDC driver right away. Signed-off-by: Marek Vasut Signed-off-by: Yannick Fertre --- drivers

Re: [PATCH 2/2] drm/stm: dsi: Use dev_ based logging

2021-03-08 Thread yannick Fertre
Tested-by: Yannick Fertre On 2/22/21 10:23 AM, Raphael GALLAIS-POU - foss wrote: From: Yannick Fertre Standardize on the dev_ based logging. Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 49 ++- 1

Re: [PATCH 1/2] drm/stm: dsi: Avoid printing errors for -EPROBE_DEFER

2021-03-08 Thread yannick Fertre
Tested-by: Yannick Fertre On 2/22/21 10:22 AM, Raphael GALLAIS-POU - foss wrote: From: Yannick Fertre Don't print error when probe deferred error is returned. Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 9 +++-- 1

Re: [PATCH] drm/stm: ltdc: Use simple encoder

2021-03-04 Thread yannick Fertre
Hi Thomas, I wait a few days before merging it. Thank you for your help. Best regards Yannick On 3/4/21 9:21 AM, Thomas Zimmermann wrote: Hi, shall I merge this patch? Am 02.03.21 um 18:57 schrieb Jagan Teki: STM ltdc driver uses an empty implementation for its encoder. Replace the code

Re: [PATCH] drm/stm: ltdc: Use simple encoder

2021-03-03 Thread yannick Fertre
Thanks Jagan for the patch. Tested-by: Yannick Fertre On 3/2/21 6:57 PM, Jagan Teki wrote: STM ltdc driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by: Jagan Teki --- drivers/gpu/drm/stm/ltdc.c | 12 ++-- 1 file

Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

2021-02-15 Thread yannick Fertre
Hello Jagan, I tested your patch on the stm32mp1 board. Unfortunately, the dsi panel does not probe well with this patch. The problem is due to the panel which is placed in the node of the dsi bridge (no problem with i2c devices). Regarding component bindings for stm drivers, I am currently

Re: [PATCH V4] drm/stm: Fix bus_flags handling

2021-01-28 Thread yannick Fertre
Hi Marek, Thanks for the patch. Tested-by: Yannick Fertre On 1/27/21 12:07 PM, Marek Vasut wrote: The drm_display_mode_to_videomode() does not populate DISPLAY_FLAGS_DE_LOW or DISPLAY_FLAGS_PIXDATA_NEGEDGE flags in struct videomode. Therefore, no matter what polarity the next bridge

[PATCH] ARM: multi_v7_defconfig: add STM32 CEC support

2021-01-15 Thread Yannick Fertre
Enable CEC support for STMicroelectronics as loadable module. Signed-off-by: Yannick Fertre --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index c5f25710fedc..05cc0607a9ad

Re: [PATCH] drm/stm: Remove usage of drm_display_mode_to_videomode()

2021-01-07 Thread Yannick FERTRE
nu > Cc: Sam Ravnborg > Cc: Vincent Abriou > Cc: Yannick Fertre > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-st...@st-md-mailman.stormreply.com > To: dri-devel@lists.freedesktop.org > --- > drivers/gpu/drm/stm/ltdc.c | 33 + &g

Re: [PATCH V2] drm/stm: Fix bus_flags handling

2021-01-07 Thread Yannick FERTRE
on. Otherwise, extract bus_flags from the connector, > which is the display. > > Fixes: b759012c5fa7 ("drm/stm: Add STM32 LTDC driver") > Signed-off-by: Marek Vasut > Cc: Alexandre Torgue > Cc: Antonio Borneo > Cc: Benjamin Gaignard > Cc: Maxime Coquelin > Cc: Phil

Re: [PATCH] drm/stm: Enable RPM during fbdev registration

2020-11-06 Thread Yannick FERTRE
Hi Marek, On 11/5/20 10:45 AM, Marek Vasut wrote: > On 11/5/20 10:39 AM, Daniel Vetter wrote: >> On Wed, Nov 04, 2020 at 01:52:00PM +0100, Marek Vasut wrote: >>> Enable runtime PM before registering the fbdev emulation and disable it >>> afterward, otherwise register access to the LTDC IP during

[PATCH v2] drm/stm: dsi: Use dev_ based logging

2020-10-13 Thread Yannick Fertre
Standardize on the dev_ based logging. Signed-off-by: Yannick Fertre --- Changes in v2: - restore function dsi_color_from_mipi. - reword commit. drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 55 ++- 1 file changed, 29 insertions(+), 26 deletions(-) diff --git

Re: [PATCH] drm/stm: dsi: Use dev_ based logging

2020-10-13 Thread Yannick FERTRE
Hi Sam, thanks for the review. I'll send a new patch with the revert of function dsi_color_from_mipi. Best regards Yannick On 9/25/20 4:51 PM, Sam Ravnborg wrote: > Hi Yannick. > > On Fri, Sep 25, 2020 at 12:22:33PM +0200, Yannick Fertre wrote: >> Standardize on the dev

Re: [PATCH] drm/stm: dsi: Use dev_ based logging

2020-09-28 Thread Yannick FERTRE
On 9/25/20 4:51 PM, Sam Ravnborg wrote: > Hi Yannick. > > On Fri, Sep 25, 2020 at 12:22:33PM +0200, Yannick Fertre wrote: >> Standardize on the dev_ based logging and drop the include of drm_print.h. > The patchs filas to drop the include mentioned here. &g

Re: [PATCH] drm/stm: dsi: Use dev_ based logging

2020-09-28 Thread Yannick FERTRE
On 9/25/20 2:02 PM, Joe Perches wrote: > On Fri, 2020-09-25 at 12:22 +0200, Yannick Fertre wrote: >> Standardize on the dev_ based logging and drop the include of drm_print.h. >> Remove useless dsi_color_from_mipi function. > [] >> diff --git a/drivers/gpu/drm/stm

[PATCH] drm/panel: rm68200: fix mode to 50fps

2020-09-25 Thread Yannick Fertre
Compute new timings to get a framerate of 50fps with a pixel clock @54Mhz. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/panel/panel-raydium-rm68200.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-raydium-rm68200.c b/drivers

[PATCH] drm/stm: dsi: Use dev_ based logging

2020-09-25 Thread Yannick Fertre
Standardize on the dev_ based logging and drop the include of drm_print.h. Remove useless dsi_color_from_mipi function. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 87 ++- 1 file changed, 45 insertions(+), 42 deletions(-) diff --git

[PATCH v2] drm/panel: otm8009a: allow using non-continuous dsi clock

2020-09-22 Thread Yannick Fertre
-by: Yannick Fertre --- drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c index b6e377aa1131..6ac1accade80 100644 --- a/drivers/gpu/drm

[PATCH v2] drm/panel: otm8009a: remove hack to force commands in HS

2020-09-22 Thread Yannick Fertre
in v2: - Added my signed-off Signed-off-by: Antonio Borneo Signed-off-by: Yannick Fertre --- .../gpu/drm/panel/panel-orisetech-otm8009a.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm

[PATCH] drm/panel: rm68200: allow using non-continuous dsi clock

2020-09-18 Thread Yannick Fertre
The panel is able to work when dsi clock is non-continuous, thus the system power consumption can be reduced using such feature. Add MIPI_DSI_CLOCK_NON_CONTINUOUS to panel's mode_flags. Signed-off-by: Antonio Borneo Signed-off-by: Yannick Fertre --- drivers/gpu/drm/panel/panel-raydium-rm68200

[PATCH] drm/bridge/synopsys: dsi: fix initialization sequence

2020-09-18 Thread Yannick Fertre
-by: Antonio Borneo Signed-off-by: Yannick Fertre --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 73 --- 1 file changed, 48 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 6b268f9445b3

[PATCH] drm/panel: otm8009a: remove hack to force commands in HS

2020-09-18 Thread Yannick Fertre
From: Antonio Borneo The panel is able to receive commands in LP. The current hack to force backlight commands in HS was due to workaround an incorrect settings on DSI controller that prevents sending LP commands while video out was active. Remove the hack that forces HS commands.

[PATCH] drm/panel: otm8009a: allow using non-continuous dsi clock

2020-09-18 Thread Yannick Fertre
From: Antonio Borneo The panel is able to work when dsi clock is non-continuous, thus the system power consumption can be reduced using such feature. Add MIPI_DSI_CLOCK_NON_CONTINUOUS to panel's mode_flags. Signed-off-by: Antonio Borneo --- drivers/gpu/drm/panel/panel-orisetech-otm8009a.c |

[PATCH] drm/stm: dsi: Avoid printing errors for -EPROBE_DEFER

2020-09-18 Thread Yannick Fertre
Don't print error when probe deferred error is returned. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c index

[PATCH v2] drm/bridge/synopsys: dsi: allow LP commands in video mode

2020-07-08 Thread Yannick Fertre
From: Antonio Borneo Current code only sends LP commands in command mode. Allows sending LP commands also in video mode by setting the proper flag in DSI_VID_MODE_CFG. Signed-off-by: Antonio Borneo --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 8 1 file changed, 8

[PATCH] drm/bridge/synopsys: dsi: add support for non-continuous HS clock

2020-07-01 Thread Yannick Fertre
From: Antonio Borneo Current code enables the HS clock when video mode is started or to send out a HS command, and disables the HS clock to send out a LP command. This is not what DSI spec specify. Enable HS clock either in command and in video mode. Set automatic HS clock management for panels

[PATCH] drm/bridge/synopsys: dsi: allow LP commands in video mode

2020-07-01 Thread Yannick Fertre
From: Antonio Borneo Current code only sends LP commands in command mode. Allows sending LP commands also in video mode by setting the proper flag in DSI_VID_MODE_CFG. Signed-off-by: Antonio Borneo --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 7 +++ 1 file changed, 7 insertions(+)

[PATCH] drm/bridge/synopsys: dsi: allows LP commands in video mode

2020-07-01 Thread Yannick Fertre
/oe/st/linux-stm32/+/153242 Reviewed-by: CITOOLS Reviewed-by: CIBUILD Reviewed-by: Yannick FERTRE Reviewed-by: Philippe CORNU Tested-by: Yannick FERTRE --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw

[PATCH] drm/bridge/synopsys: dsi: allows LP commands in video mode

2020-07-01 Thread Yannick Fertre
/oe/st/linux-stm32/+/153242 Reviewed-by: CITOOLS Reviewed-by: CIBUILD Reviewed-by: Yannick FERTRE Reviewed-by: Philippe CORNU Tested-by: Yannick FERTRE --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw

[PATCH] drm/bridge/synopsys: dsi: allow sending longer LP commands

2020-07-01 Thread Yannick Fertre
From: Antonio Borneo Current code does not properly computes the max length of LP commands that can be send during H or V sync, and rely on static values. Limiting the max LP length to 4 byte during the V-sync is overly conservative. Relax the limit and allows longer LP commands (16 bytes) to

Re: [PATCH] drm/stm: repair runtime power management

2020-07-01 Thread Yannick FERTRE
On 3/9/20 12:57 PM, Marek Vasut wrote: > On 3/9/20 11:35 AM, Yannick FERTRE wrote: >> Hello Marek, > > Hi, > > (please stop top-posting) > >> Thank for your patch. Pm_runtime_put_sync is also done into function >> ltdc_crtc_mode_fixup. >> To

[PATCH] drm/stm: ltdc: remove call of pm-runtime functions

2020-07-01 Thread Yannick Fertre
It is not necessary to suspend or stop the ltdc clocks to modify the pixel clock. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 3f590d916e91

Re: [PATCH v2] drm/bridge: dw-mipi-dsi.c: Add VPG runtime config through debugfs

2020-06-24 Thread Yannick FERTRE
Hello Angelo, thanks for the patch. Tested-by: Yannick Fertre Tested OK on STM32MP1-DISCO, DSI v1.31 Best regards On 4/6/20 3:49 PM, Angelo Ribeiro wrote: > Add support for the video pattern generator (VPG) BER pattern mode and > configuration in runtime. > > This enables using

Re: [PATCH] drm/bridge: dw-mipi-dsi.c: remove unused header file

2020-06-24 Thread Yannick FERTRE
Hello Angelo, thank for patch. Reviewed-by: Yannick Fertre On 4/3/20 3:30 PM, Angelo Ribeiro wrote: > dw-mipi-dsi does not use any definition from drm_probe_helper. > > Coverity output: > Event unnecessary_header: > Including .../include/drm/drm_probe_helper.h does not provi

Re: [PATCH v9 03/11] drm: bridge: dw_mipi_dsi: add dsi v1.01 support

2020-06-10 Thread Yannick FERTRE
Hi Adrian, thanks for the pach: tested on stm32mp1. Tested-by: Yannick Fertré On 6/9/20 7:49 PM, Adrian Ratiu wrote: > The Synopsis MIPI DSI v1.01 host controller is quite widely used > on platforms like i.mx6 and is not very different from the other > versions like the 1.31/1.30 used on

Re: [PATCH v9 09/11] drm: bridge: dw-mipi-dsi: split low power cfg register into fields

2020-06-10 Thread Yannick FERTRE
Hi Adrian, thanks for the pach: tested on stm32mp1. Tested-by: Yannick Fertré On 6/9/20 7:49 PM, Adrian Ratiu wrote: > According to the Host Registers documentation for IMX, STM and RK > the LP cfg register should not be written entirely in one go because > some bits are reserved and should be

Re: [PATCH v9 10/11] drm: bridge: dw-mipi-dsi: fix bad register field offsets

2020-06-10 Thread Yannick FERTRE
Hi Adrian, thanks for the pach: tested on stm32mp1. Tested-by: Yannick Fertré On 6/9/20 7:49 PM, Adrian Ratiu wrote: > According to the DSI Host Registers sections available in the IMX, > STM and RK ref manuals for 1.01, 1.30 and 1.31, the register fields > are smaller or bigger than what's

Re: [PATCH v9 04/11] drm: bridge: dw_mipi_dsi: remove bind/unbind API

2020-06-10 Thread Yannick FERTRE
Hi Adrian, thanks for the pach: tested on stm32mp1. Tested-by: Yannick Fertré On 6/9/20 7:49 PM, Adrian Ratiu wrote: > The DW mipi-dsi bind/unbind API was only used to attach the bridge to > the encoder in the Rockchip driver, but with the addition of i.MX6 it > gets more complicated because

RE: [PATCH] drm/stm: repair runtime power management

2020-03-09 Thread Yannick FERTRE
l Message- From: Marek Vasut Sent: samedi 29 février 2020 23:17 To: dri-devel@lists.freedesktop.org Cc: Marek Vasut ; Yannick FERTRE ; Philippe CORNU ; Benjamin Gaignard ; Vincent ABRIOU ; Maxime Coquelin ; Alexandre TORGUE ; linux-st...@st-md-mailman.stormreply.com; linux-arm-ker...@lists.inf

[PATCH] drm/stm: ltdc: check number of endpoints

2020-02-28 Thread Yannick Fertre
. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 102 +++-- 1 file changed, 52 insertions(+), 50 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index df585fe..f894968 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b

[PATCH] drm/bridge/synopsys: dsi: missing post disable

2020-01-21 Thread Yannick Fertre
From: Yannick Fertré Sometime the post_disable function is missing (not registered). Signed-off-by: Yannick Fertré --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c

[PATCH] drm/stm: dsi: stm mipi dsi doesn't print error on probe deferral

2020-01-21 Thread Yannick Fertre
From: Etienne Carriere Change DSI driver to not print an error trace when probe is deferred for a clock resource. Signed-off-by: Etienne Carriere --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH] drm/stm: ltdc: check number of endpoints

2020-01-21 Thread Yannick Fertre
Number of endpoints could exceed the fix value MAX_ENDPOINTS(2). Instead of increase simply this value, the number of endpoint could be read from device tree. Load sequence has been a little rework to take care of several panel or bridge which can be connected/disconnected or enable/disable.

[PATCH] drm/stm: ltdc: add number of interrupts

2020-01-21 Thread Yannick Fertre
The number of interrupts depends on the ltdc version. Don't try to get interrupt which not exist, avoiding kernel warning messages. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 30 +++--- drivers/gpu/drm/stm/ltdc.h | 1 + 2 files changed, 16 insertions

[PATCH] drm/stm: ltdc: check crtc state before enabling LIE

2020-01-21 Thread Yannick Fertre
Following investigations of a hardware bug, the LIE interrupt can occur while the display controller is not activated. LIE interrupt (vblank) don't have to be set if the CRTC is not enabled. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 7 ++- 1 file changed, 6 insertions

[PATCH] drm/stm: ltdc: enable/disable depends on encoder

2020-01-20 Thread Yannick Fertre
From: Yannick Fertré When connected to a dsi host, the ltdc display controller must send frames only after the end of the dsi panel initialization to avoid errors when the dsi host sends commands to the dsi panel (dsi px fifo full). To avoid this issue, the display controller must be

Re: [PATCH 23/23] drm: Cleanup VBLANK callbacks in struct drm_driver

2020-01-14 Thread Yannick FERTRE
Thanks for the patch. Tested-by: Yannick Fertré BR Yannick Fertré On 1/10/20 10:21 AM, Thomas Zimmermann wrote: All non-legacy users of VBLANK functions in struct drm_driver have been converted to use the respective interfaces in struct drm_crtc_funcs. The

Re: [PATCH 19/23] drm/stm: Convert to CRTC VBLANK callbacks

2020-01-14 Thread Yannick FERTRE
Thanks for the patch. Tested-by: Yannick Fertré BR Yannick Fertré On 1/10/20 10:21 AM, Thomas Zimmermann wrote: VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert stm over. Signed-off-by: Thomas

Re: [PATCH 08/23] drm/stm: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-14 Thread Yannick FERTRE
Thanks for the patch. Tested-by: Yannick Fertré BR Yannick Fertré On 1/10/20 10:21 AM, Thomas Zimmermann wrote: The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert stm over.

Re: [PATCH 09/23] drm: Remove struct drm_driver.get_scanout_position()

2020-01-14 Thread Yannick FERTRE
Thanks for the patch. Tested-by: Yannick Fertré BR Yannick Fertré On 1/10/20 10:21 AM, Thomas Zimmermann wrote: All users of struct drm_driver.get_scanout_position() have been covnerted to the respective CRTC helper function. Remove the callback from struct

Re: [PATCH 01/23] drm: Add get_scanout_position() to struct drm_crtc_helper_funcs

2020-01-14 Thread Yannick FERTRE
Thanks for the patch. Tested-by: Yannick Fertré BR Yannick Fertré On 1/10/20 10:21 AM, Thomas Zimmermann wrote: The new callback get_scanout_position() reads the current location of the scanout process. The operation is currentyl located in struct drm_driver,

Re: [PATCH] drm/bridge/synopsys: dsi: use mipi_dsi_device to find panel or bridge

2019-12-20 Thread Yannick FERTRE
Hello Heiko, I test with success your patch on a board stm32mp1 with a panel raydium rm68200. I need more time to test with a HDMI bridge  like ad7533. Best regards Yannick Fertré On 12/17/19 11:41 PM, Heiko Stuebner wrote: > From: Heiko Stuebner > > Right now the dsi driver uses

[PATCH] dt-bindings: display: Convert raydium, rm68200 panel to DT schema

2019-12-20 Thread Yannick Fertre
From: Yannick Fertré Convert the raydium,rm68200 panel binding to DT schema. Signed-off-by: Yannick Fertre --- .../bindings/display/panel/raydium,rm68200.txt | 25 - .../bindings/display/panel/raydium,rm68200.yaml| 61 ++ 2 files changed, 61 insertions

[PATCH] dt-bindings: display: Convert orisetech, otm8009a panel to DT schema

2019-12-20 Thread Yannick Fertre
From: Yannick Fertré Convert the orisetech,otm8009a panel binding to DT schema. Signed-off-by: Yannick Fertre --- .../bindings/display/panel/orisetech,otm8009a.txt | 23 .../bindings/display/panel/orisetech,otm8009a.yaml | 62 ++ 2 files changed, 62 insertions

[PATCH] Input: goodix - support gt9147 touchpanel

2019-11-27 Thread Yannick Fertre
From: Yannick Fertré Add support for it by adding compatible and supported chip data (default settings used). The chip data on GT9147 is similar to GT912, like - config data register has 0x8047 address - config data register max len is 240 - config data checksum has 8-bit Signed-off-by: Yannick

[PATCH] Input: goodix: request_irq: convert gpio to irq

2019-11-27 Thread Yannick Fertre
From: Yannick Fertré Convert gpio to irq if not already done by gpio lib. Signed-off-by: Yannick Fertré #include #include +#include #include #include #include @@ -392,6 +393,13 @@ static void goodix_free_irq(struct goodix_ts_data *ts) static int goodix_request_irq(struct

[PATCH] drm/stm: ltdc: move pinctrl to encoder mode set

2019-11-27 Thread Yannick Fertre
From: Yannick Fertré The pin control must be set to default as soon as possible to establish a good video link between tv & bridge hdmi (encoder mode set is call before encoder enable). Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 24 ++-- 1 file cha

[PATCH] drm/bridge/synopsys: dsi: read status error during transfer

2019-11-27 Thread Yannick Fertre
From: Yannick Fertré Read the DSI_INT_ST1 status register to check if errors occur while reading/writing a command to panel. In case of error, the transfer is retried 3 times. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 99 +++ 1

[PATCH] drm/bridge/synopsys: dsi: check post disable

2019-11-27 Thread Yannick Fertre
From: Yannick Fertré Some bridges did not registered the post_disable function. To avoid a crash, check it before calling. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

Re: [PATCH] drm/bridge/synopsys: dsi: Use devm_platform_ioremap_resource() in __dw_mipi_dsi_probe()

2019-09-23 Thread Yannick FERTRE
Reviewed-by: Yannick Fertré Tested-by: Yannick Fertré Best regards -- Yannick Fertré | TINA: 166 7152 | Tel: +33 244027152 | Mobile: +33 620600270 Microcontrollers and Digital ICs Group | Microcontrolleurs Division On 9/21/19 8:20

Re: [PATCH v2 5/5] ARM: dts: stm32: remove phy-dsi-supply property on stm32mp157c-dk2 board

2019-08-02 Thread Yannick FERTRE
Hi Alexandre, this patch can be abandoned. BR -- Yannick Fertré | TINA: 166 7152 | Tel: +33 244027152 | Mobile: +33 620600270 Microcontrollers and Digital ICs Group | Microcontrolleurs Division On 5/10/19 4:20 PM, Yannick Fertré wrote: > This property is already defined into stm32mp157c.dtsi

  1   2   3   >