Re: [PATCH] [v2] drm/i915: use static const array for PICK macro

2018-01-16 Thread Arnd Bergmann
On Mon, Dec 11, 2017 at 7:40 PM, Chris Wilson wrote: > Quoting Chris Wilson (2017-12-11 12:51:42) >> Quoting Arnd Bergmann (2017-12-11 12:46:22) >> > v2: rebased after a1986f4174a4 ("drm/i915: Remove unnecessary PORT3 >> > definition.") >> > --- >> >

Re: [PATCH] [v2] drm/i915: use static const array for PICK macro

2017-12-11 Thread Chris Wilson
Quoting Chris Wilson (2017-12-11 12:51:42) > Quoting Arnd Bergmann (2017-12-11 12:46:22) > > The varargs macro trick in _PIPE3/_PHY3/_PORT3 was meant as an optimization > > to shrink the i915 kernel module by around 1000 bytes. However, the > > downside is a size regression with CONFIG_KASAN, as I

[PATCH] [v2] drm/i915: use static const array for PICK macro

2017-12-11 Thread Arnd Bergmann
The varargs macro trick in _PIPE3/_PHY3/_PORT3 was meant as an optimization to shrink the i915 kernel module by around 1000 bytes. However, the downside is a size regression with CONFIG_KASAN, as I found from stack size warnings with gcc-7.0.1: before: drivers/gpu/drm/i915/intel_dpll_mgr.c: In