[PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-15 Thread Inki Dae
com [mailto:robdclark at gmail.com] On Behalf Of > >> Rob > >> Clark > >> Sent: Thursday, September 08, 2011 3:44 AM > >> To: Inki Dae > >> Cc: linaro-dev at lists.linaro.org; dri-devel at lists.freedesktop.org > >> Subject: Re: [PATCH] RFC

RE: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-14 Thread Inki Dae
:robdcl...@gmail.com] On Behalf Of Rob > >> Clark > >> Sent: Thursday, September 08, 2011 3:44 AM > >> To: Inki Dae > >> Cc: linaro-...@lists.linaro.org; dri-devel@lists.freedesktop.org > >> Subject: Re: [PATCH] RFC: omapdrm DRM/KMS driver for

[PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-14 Thread Inki Dae
.org; dri-devel at lists.freedesktop.org > Subject: Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms > > On Wed, Sep 7, 2011 at 1:00 AM, Inki Dae wrote: > > Hello, Rob. > > > [snip] > >> >> +static void page_flip_cb(void *arg) > >> >

[PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-14 Thread Rob Clark
ptember 08, 2011 3:44 AM >> To: Inki Dae >> Cc: linaro-dev at lists.linaro.org; dri-devel at lists.freedesktop.org >> Subject: Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms >> >> On Wed, Sep 7, 2011 at 1:00 AM, Inki Dae wrote: >> &

Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-14 Thread Rob Clark
ber 08, 2011 3:44 AM >> To: Inki Dae >> Cc: linaro-...@lists.linaro.org; dri-devel@lists.freedesktop.org >> Subject: Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms >> >> On Wed, Sep 7, 2011 at 1:00 AM, Inki Dae wrote: >> &

RE: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-13 Thread Inki Dae
aro.org; dri-devel@lists.freedesktop.org > Subject: Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms > > On Wed, Sep 7, 2011 at 1:00 AM, Inki Dae wrote: > > Hello, Rob. > > > [snip] > >> >> +static void page_flip_cb(void *arg) > >> >> +{ > &g

[PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-07 Thread Inki Dae
n, Tomi > Subject: Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms > > On Mon, Sep 5, 2011 at 4:58 AM, Inki Dae wrote: > > Hello, Rob. > > I didn't look into any comments from other develops yet , so my comments > > could be duplicated with other ones.

[PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-07 Thread Rob Clark
On Wed, Sep 7, 2011 at 1:00 AM, Inki Dae wrote: > Hello, Rob. > [snip] >> >> +static void page_flip_cb(void *arg) >> >> +{ >> >> + ? ? struct drm_crtc *crtc = arg; >> >> + ? ? struct drm_device *dev = crtc->dev; >> >> + ? ? struct omap_crtc *omap_crtc = to_omap_crtc(crtc); >> >> + ? ? struct drm_p

Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-07 Thread Rob Clark
On Wed, Sep 7, 2011 at 1:00 AM, Inki Dae wrote: > Hello, Rob. > [snip] >> >> +static void page_flip_cb(void *arg) >> >> +{ >> >> +     struct drm_crtc *crtc = arg; >> >> +     struct drm_device *dev = crtc->dev; >> >> +     struct omap_crtc *omap_crtc = to_omap_crtc(crtc); >> >> +     struct drm_p

[PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-07 Thread Tomi Valkeinen
gt; > To: Inki Dae > > Cc: dri-devel at lists.freedesktop.org; linaro-dev at lists.linaro.org; > > Valkeinen, Tomi > > Subject: Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms > > > > On Mon, Sep 5, 2011 at 4:58 AM, Inki Dae wrote: > > > How about moving co

RE: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-06 Thread Tomi Valkeinen
c: dri-devel@lists.freedesktop.org; linaro-...@lists.linaro.org; > > Valkeinen, Tomi > > Subject: Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms > > > > On Mon, Sep 5, 2011 at 4:58 AM, Inki Dae wrote: > > > How about moving codes above into interrup

RE: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-06 Thread Inki Dae
Subject: Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms > > On Mon, Sep 5, 2011 at 4:58 AM, Inki Dae wrote: > > Hello, Rob. > > I didn't look into any comments from other develops yet , so my comments > > could be duplicated with other ones. below

[PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-05 Thread Inki Dae
at lists.freedesktop.org > Cc: linaro-dev at lists.linaro.org; inki.dae at samsung.com; Rob Clark > Subject: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms > > From: Rob Clark > > A DRM display driver for TI OMAP platform. Similar to omapfb (fbdev) > and omap_v

[PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-05 Thread Rob Clark
On Mon, Sep 5, 2011 at 4:58 AM, Inki Dae wrote: > Hello, Rob. > I didn't look into any comments from other develops yet , so my comments > could be duplicated with other ones. below is my opinions and I commented > your codes also. > > We can discuss crtc, encoder and connector. in x86 world, my u

Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-05 Thread Rob Clark
On Mon, Sep 5, 2011 at 4:58 AM, Inki Dae wrote: > Hello, Rob. > I didn't look into any comments from other develops yet , so my comments > could be duplicated with other ones. below is my opinions and I commented > your codes also. > > We can discuss crtc, encoder and connector. in x86 world, my u

[PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-04 Thread Daniel Vetter
On Sun, Sep 04, 2011 at 11:29:43AM -0500, Rob Clark wrote: > > Above set of get/put functions seem to do very little. Drop them for the > > first round? > > The intention is to do attach/detach_pages here.. and in case of > get/put_paddr do remapping into TILER if the buffer isn't physically > con

[PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-04 Thread Rob Clark
On Sun, Sep 4, 2011 at 2:49 PM, Daniel Vetter wrote: > On Sun, Sep 04, 2011 at 11:29:43AM -0500, Rob Clark wrote: >> > Above set of get/put functions seem to do very little. Drop them for the >> > first round? >> >> The intention is to do attach/detach_pages here.. and in case of >> get/put_paddr

Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-04 Thread Rob Clark
On Sun, Sep 4, 2011 at 2:49 PM, Daniel Vetter wrote: > On Sun, Sep 04, 2011 at 11:29:43AM -0500, Rob Clark wrote: >> > Above set of get/put functions seem to do very little. Drop them for the >> > first round? >> >> The intention is to do attach/detach_pages here.. and in case of >> get/put_paddr

Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-04 Thread Daniel Vetter
On Sun, Sep 04, 2011 at 11:29:43AM -0500, Rob Clark wrote: > > Above set of get/put functions seem to do very little. Drop them for the > > first round? > > The intention is to do attach/detach_pages here.. and in case of > get/put_paddr do remapping into TILER if the buffer isn't physically > con

[PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-04 Thread Rob Clark
On Sat, Sep 3, 2011 at 1:53 PM, Daniel Vetter wrote: > Hi Rob, > > I've taken a look at your driver, some comments inline. Can't really > comment much on the kms side because of lack of expertise in that area. > > I think most can be trivially addressed by dropping the plugin layer ;-) > > Cheers,

Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-04 Thread Rob Clark
On Sat, Sep 3, 2011 at 1:53 PM, Daniel Vetter wrote: > Hi Rob, > > I've taken a look at your driver, some comments inline. Can't really > comment much on the kms side because of lack of expertise in that area. > > I think most can be trivially addressed by dropping the plugin layer ;-) > > Cheers,

[PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-03 Thread Daniel Vetter
Hi Rob, I've taken a look at your driver, some comments inline. Can't really comment much on the kms side because of lack of expertise in that area. I think most can be trivially addressed by dropping the plugin layer ;-) Cheers, Daniel On Fri, Sep 02, 2011 at 03:07:27PM -0500, Rob Clark wrote:

Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-03 Thread Daniel Vetter
Hi Rob, I've taken a look at your driver, some comments inline. Can't really comment much on the kms side because of lack of expertise in that area. I think most can be trivially addressed by dropping the plugin layer ;-) Cheers, Daniel On Fri, Sep 02, 2011 at 03:07:27PM -0500, Rob Clark wrote:

[PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-03 Thread Rob Clark
On Sat, Sep 3, 2011 at 1:57 AM, Dave Airlie wrote: >> >> A simple "plugin" mechanism is provided to allow integration with >> external kernel modules (*cough* PVR), but also to keep the code more >> modular as support is added for various other accelerator blocks that >> exist in various different

[PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-03 Thread Dave Airlie
> > A simple "plugin" mechanism is provided to allow integration with > external kernel modules (*cough* PVR), but also to keep the code more > modular as support is added for various other accelerator blocks that > exist in various different OMAP variants. ?(2D accel, video encode/ > decode, etc.)

Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-03 Thread Rob Clark
On Sat, Sep 3, 2011 at 1:57 AM, Dave Airlie wrote: >> >> A simple "plugin" mechanism is provided to allow integration with >> external kernel modules (*cough* PVR), but also to keep the code more >> modular as support is added for various other accelerator blocks that >> exist in various different

Re: [PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-02 Thread Dave Airlie
> > A simple "plugin" mechanism is provided to allow integration with > external kernel modules (*cough* PVR), but also to keep the code more > modular as support is added for various other accelerator blocks that > exist in various different OMAP variants.  (2D accel, video encode/ > decode, etc.)

[PATCH] RFC: omapdrm DRM/KMS driver for TI OMAP platforms

2011-09-02 Thread Rob Clark
From: Rob Clark A DRM display driver for TI OMAP platform. Similar to omapfb (fbdev) and omap_vout (v4l2 display) drivers in the past, this driver uses the DSS2 driver to access the display hardware, including support for HDMI, DVI, and various types of LCD panels. And it implements GEM support