On Sat, Nov 26, 2011 at 10:53 PM, Chris Wilson
wrote:
> On Sat, 26 Nov 2011 22:29:12 +0600, Rakib Mullick gmail.com> wrote:
>> Yes, no real problem with current code. I was just thinking from code
>> cleanup's pov. Is BUG_ON really needed in i915_add_request() ?
>
> No, just documentation as a
On Sat, Nov 26, 2011 at 10:53 PM, Chris Wilson ch...@chris-wilson.co.uk wrote:
On Sat, 26 Nov 2011 22:29:12 +0600, Rakib Mullick rakib.mull...@gmail.com
wrote:
Yes, no real problem with current code. I was just thinking from code
cleanup's pov. Is BUG_ON really needed in i915_add_request() ?
On Sat, Nov 26, 2011 at 4:57 PM, Chris Wilson
wrote:
> On Sat, 26 Nov 2011 10:44:17 +0600, Rakib Mullick gmail.com> wrote:
>> On Mon, Nov 21, 2011 at 11:16 PM, Keith Packard wrote:
>> > On Mon, 21 Nov 2011 17:23:06 +0100, Daniel Vetter
>> > wrote:
>> >
>> >> Indeed, nice catch (albeit
On Sat, 26 Nov 2011 22:29:12 +0600, Rakib Mullick
wrote:
> Yes, no real problem with current code. I was just thinking from code
> cleanup's pov. Is BUG_ON really needed in i915_add_request() ?
No, just documentation as a reminder that the request should be
preallocated, ideally so that we can
On Sat, 26 Nov 2011 10:44:17 +0600, Rakib Mullick
wrote:
> On Mon, Nov 21, 2011 at 11:16 PM, Keith Packard wrote:
> > On Mon, 21 Nov 2011 17:23:06 +0100, Daniel Vetter
> > wrote:
> >
> >> Indeed, nice catch (albeit totally unlikely to be hit, because the error
> >> only happens when the gpu
On Mon, Nov 21, 2011 at 11:16 PM, Keith Packard wrote:
> On Mon, 21 Nov 2011 17:23:06 +0100, Daniel Vetter wrote:
>
>> Indeed, nice catch (albeit totally unlikely to be hit, because the error
>> only happens when the gpu ceases to progress in the ring, so imo not
>> stable material). Keith,
On Sat, 26 Nov 2011 10:44:17 +0600, Rakib Mullick rakib.mull...@gmail.com
wrote:
On Mon, Nov 21, 2011 at 11:16 PM, Keith Packard kei...@keithp.com wrote:
On Mon, 21 Nov 2011 17:23:06 +0100, Daniel Vetter dan...@ffwll.ch wrote:
Indeed, nice catch (albeit totally unlikely to be hit, because
On Sat, Nov 26, 2011 at 4:57 PM, Chris Wilson ch...@chris-wilson.co.uk wrote:
On Sat, 26 Nov 2011 10:44:17 +0600, Rakib Mullick rakib.mull...@gmail.com
wrote:
On Mon, Nov 21, 2011 at 11:16 PM, Keith Packard kei...@keithp.com wrote:
On Mon, 21 Nov 2011 17:23:06 +0100, Daniel Vetter
On Sat, 26 Nov 2011 22:29:12 +0600, Rakib Mullick rakib.mull...@gmail.com
wrote:
Yes, no real problem with current code. I was just thinking from code
cleanup's pov. Is BUG_ON really needed in i915_add_request() ?
No, just documentation as a reminder that the request should be
preallocated,
On Mon, Nov 21, 2011 at 11:16 PM, Keith Packard kei...@keithp.com wrote:
On Mon, 21 Nov 2011 17:23:06 +0100, Daniel Vetter dan...@ffwll.ch wrote:
Indeed, nice catch (albeit totally unlikely to be hit, because the error
only happens when the gpu ceases to progress in the ring, so imo not
On Wed, Nov 16, 2011 at 12:49:28AM +0600, Rakib Mullick wrote:
>
> A call to i915_add_request() has been made in function i915_gem_busy_ioctl().
> i915_add_request can fail,
> so in it's exit path previously allocated memory needs to be freed.
>
> Signed-off-by: Rakib Mullick
Indeed, nice
On Mon, 21 Nov 2011 17:23:06 +0100, Daniel Vetter wrote:
> Indeed, nice catch (albeit totally unlikely to be hit, because the error
> only happens when the gpu ceases to progress in the ring, so imo not
> stable material). Keith, please pick this up for fixes, thanks.
It's already there and
On Wed, Nov 16, 2011 at 12:49:28AM +0600, Rakib Mullick wrote:
A call to i915_add_request() has been made in function i915_gem_busy_ioctl().
i915_add_request can fail,
so in it's exit path previously allocated memory needs to be freed.
Signed-off-by: Rakib Mullick rakib.mull...@gmail.com
On Mon, 21 Nov 2011 17:23:06 +0100, Daniel Vetter dan...@ffwll.ch wrote:
Indeed, nice catch (albeit totally unlikely to be hit, because the error
only happens when the gpu ceases to progress in the ring, so imo not
stable material). Keith, please pick this up for fixes, thanks.
It's already
A call to i915_add_request() has been made in function i915_gem_busy_ioctl().
i915_add_request can fail,
so in it's exit path previously allocated memory needs to be freed.
Signed-off-by: Rakib Mullick
---
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index
A call to i915_add_request() has been made in function i915_gem_busy_ioctl().
i915_add_request can fail,
so in it's exit path previously allocated memory needs to be freed.
Signed-off-by: Rakib Mullick rakib.mull...@gmail.com
---
diff --git a/drivers/gpu/drm/i915/i915_gem.c
16 matches
Mail list logo
