2023년 5월 19일 (금) 오후 6:21, Andi Shyti 님이 작성:
> Hi Inki,
>
> > > > @@ -469,8 +469,6 @@ static int vidi_remove(struct platform_device
> *pdev)
> > > > if (ctx->raw_edid != (struct edid *)fake_edid_info) {
> > > > kfree(ctx->raw_edid);
> > > > ctx->raw_edid = NULL;
> > > > -
> >
Hi Inki,
> > > @@ -469,8 +469,6 @@ static int vidi_remove(struct platform_device *pdev)
> > > if (ctx->raw_edid != (struct edid *)fake_edid_info) {
> > > kfree(ctx->raw_edid);
> > > ctx->raw_edid = NULL;
> > > -
> > > - return -EINVAL;
> >
> > It doesn't look right
Hi Andi, :)
> -Original Message-
> From: Andi Shyti
> Sent: Friday, May 19, 2023 9:27 AM
> To: Inki Dae
> Cc: dri-devel@lists.freedesktop.org; linux-samsung-...@vger.kernel.org; Andi
> Shyti
> Subject: Re: [PATCH] drm/exynos: vidi: fix a wrong error return
>
Hi Inki,
On Fri, May 19, 2023 at 02:26:40AM +0200, Andi Shyti wrote:
> Hi Inki,
>
> On Fri, May 19, 2023 at 09:04:07AM +0900, Inki Dae wrote:
> > Fix a wrong error return by dropping an error return.
> >
> > When vidi driver is remvoed, if ctx->raw_edid isn't same as fake_edid_info
> > then
Hi Inki,
On Fri, May 19, 2023 at 09:04:07AM +0900, Inki Dae wrote:
> Fix a wrong error return by dropping an error return.
>
> When vidi driver is remvoed, if ctx->raw_edid isn't same as fake_edid_info
> then only what we have to is to free ctx->raw_edid so that driver removing
> can work
Fix a wrong error return by dropping an error return.
When vidi driver is remvoed, if ctx->raw_edid isn't same as fake_edid_info
then only what we have to is to free ctx->raw_edid so that driver removing
can work correctly - it's not an error case.
Signed-off-by: Inki Dae
---