Re: [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete() (fwd)

2017-09-27 Thread Julia Lawall
Unlock missing on failure of the new call to idr_remove. julia -- Forwarded message -- Date: Wed, 27 Sep 2017 15:14:54 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH] drm/gem: use new idr deletion interface to cleanup

Re: [Outreachy kernel] [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete()

2017-09-26 Thread Aishwarya Pant
On Tue, Sep 26, 2017 at 10:20:47AM +0200, Daniel Vetter wrote: > On Tue, Sep 26, 2017 at 12:17:28AM +0530, Aishwarya Pant wrote: > > The IDR deletion interface now returns the deleted entry or NULL if it was > > not > > present. So we don't have to do the extra work of checking if we have a > > re

Re: [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete()

2017-09-26 Thread Aishwarya Pant
On Tue, Sep 26, 2017 at 10:12:12AM +0100, Chris Wilson wrote: > Quoting Aishwarya Pant (2017-09-25 19:47:28) > > The IDR deletion interface now returns the deleted entry or NULL if it was > > not > > present. So we don't have to do the extra work of checking if we have a > > reference on the drm_g

Re: [Outreachy kernel] [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete()

2017-09-26 Thread Julia Lawall
On Tue, 26 Sep 2017, Daniel Vetter wrote: > On Tue, Sep 26, 2017 at 10:47 AM, Daniel Vetter wrote: > > On Tue, Sep 26, 2017 at 10:38 AM, Julia Lawall wrote: > >> > >> > >> On Tue, 26 Sep 2017, Daniel Vetter wrote: > >> > >>> On Tue, Sep 26, 2017 at 12:17:28AM +0530, Aishwarya Pant wrote: > >>>

Re: [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete()

2017-09-26 Thread Chris Wilson
Quoting Aishwarya Pant (2017-09-25 19:47:28) > The IDR deletion interface now returns the deleted entry or NULL if it was not > present. So we don't have to do the extra work of checking if we have a > reference on the drm_gem_object, this can be handled by checking the return > value from idr_remo

Re: [Outreachy kernel] [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete()

2017-09-26 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 10:47 AM, Daniel Vetter wrote: > On Tue, Sep 26, 2017 at 10:38 AM, Julia Lawall wrote: >> >> >> On Tue, 26 Sep 2017, Daniel Vetter wrote: >> >>> On Tue, Sep 26, 2017 at 12:17:28AM +0530, Aishwarya Pant wrote: >>> > The IDR deletion interface now returns the deleted entry o

Re: [Outreachy kernel] [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete()

2017-09-26 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 10:38 AM, Julia Lawall wrote: > > > On Tue, 26 Sep 2017, Daniel Vetter wrote: > >> On Tue, Sep 26, 2017 at 12:17:28AM +0530, Aishwarya Pant wrote: >> > The IDR deletion interface now returns the deleted entry or NULL if it was >> > not >> > present. So we don't have to do

Re: [Outreachy kernel] [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete()

2017-09-26 Thread Julia Lawall
On Tue, 26 Sep 2017, Daniel Vetter wrote: > On Tue, Sep 26, 2017 at 12:17:28AM +0530, Aishwarya Pant wrote: > > The IDR deletion interface now returns the deleted entry or NULL if it was > > not > > present. So we don't have to do the extra work of checking if we have a > > reference on the drm

Re: [Outreachy kernel] [PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete()

2017-09-26 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 12:17:28AM +0530, Aishwarya Pant wrote: > The IDR deletion interface now returns the deleted entry or NULL if it was not > present. So we don't have to do the extra work of checking if we have a > reference on the drm_gem_object, this can be handled by checking the return >

[PATCH] drm/gem: use new idr deletion interface to cleanup drm_gem_handle_delete()

2017-09-26 Thread Aishwarya Pant
The IDR deletion interface now returns the deleted entry or NULL if it was not present. So we don't have to do the extra work of checking if we have a reference on the drm_gem_object, this can be handled by checking the return value from idr_remove() and the extra locks can be dropped. Signed-off-