Re: [Intel-gfx] [PATCH] drm/i915: use static const array for PICK macro

2017-12-11 Thread Arnd Bergmann
On Tue, Mar 21, 2017 at 12:23 PM, Jani Nikula wrote: > On Tue, 21 Mar 2017, Daniel Vetter wrote: >> On Tue, Mar 21, 2017 at 09:44:07AM +0100, Arnd Bergmann wrote: >>> On Tue, Mar 21, 2017 at 9:26 AM, Jani Nikula >>> wrote: >>> > On Mon, 20 Mar 2017, Arnd Bergmann wrote: >>> >> The varargs macro

Re: [Intel-gfx] [PATCH] drm/i915: use static const array for PICK macro

2017-03-31 Thread Arnd Bergmann
On Tue, Mar 21, 2017 at 12:23 PM, Jani Nikula wrote: > On Tue, 21 Mar 2017, Daniel Vetter wrote: >> On Tue, Mar 21, 2017 at 09:44:07AM +0100, Arnd Bergmann wrote: > Arnd, can you check that with kasan please? (I don't have gcc 7.) For me > the size diff against current git is > > text

Re: [Intel-gfx] [PATCH] drm/i915: use static const array for PICK macro

2017-03-21 Thread Jani Nikula
On Tue, 21 Mar 2017, Daniel Vetter wrote: > On Tue, Mar 21, 2017 at 09:44:07AM +0100, Arnd Bergmann wrote: >> On Tue, Mar 21, 2017 at 9:26 AM, Jani Nikula >> wrote: >> > On Mon, 20 Mar 2017, Arnd Bergmann wrote: >> >> The varargs macro trick in _PIPE3/_PHY3/_PORT3 was meant as an >> >> optimiza

Re: [Intel-gfx] [PATCH] drm/i915: use static const array for PICK macro

2017-03-21 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 09:44:07AM +0100, Arnd Bergmann wrote: > On Tue, Mar 21, 2017 at 9:26 AM, Jani Nikula > wrote: > > On Mon, 20 Mar 2017, Arnd Bergmann wrote: > >> The varargs macro trick in _PIPE3/_PHY3/_PORT3 was meant as an optimization > >> to shrink the i915 kernel module by around 100

Re: [PATCH] drm/i915: use static const array for PICK macro

2017-03-21 Thread Arnd Bergmann
On Tue, Mar 21, 2017 at 9:26 AM, Jani Nikula wrote: > On Mon, 20 Mar 2017, Arnd Bergmann wrote: >> The varargs macro trick in _PIPE3/_PHY3/_PORT3 was meant as an optimization >> to shrink the i915 kernel module by around 1000 bytes. > > Really, I didn't care one bit about the size shrink, I only

Re: [PATCH] drm/i915: use static const array for PICK macro

2017-03-21 Thread Jani Nikula
On Mon, 20 Mar 2017, Arnd Bergmann wrote: > The varargs macro trick in _PIPE3/_PHY3/_PORT3 was meant as an optimization > to shrink the i915 kernel module by around 1000 bytes. Really, I didn't care one bit about the size shrink, I only cared about making it easier and less error prone to increas

[PATCH] drm/i915: use static const array for PICK macro

2017-03-20 Thread Arnd Bergmann
The varargs macro trick in _PIPE3/_PHY3/_PORT3 was meant as an optimization to shrink the i915 kernel module by around 1000 bytes. However, the downside is a size regression with CONFIG_KASAN, as I found from stack size warnings with gcc-7.0.1: before: drivers/gpu/drm/i915/intel_dpll_mgr.c: In fun