Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output

2019-11-10 Thread Wambui Karuga
On Fri, 8 Nov 2019, Sean Paul wrote: On Fri, Nov 08, 2019 at 03:06:44PM +0100, Heiko Stübner wrote: Hi, [it seems your Reply-To mail header is set strangely as Reply-To: 20191107133851.GF63329@art_vandelay which confuses my MTA] Am Freitag, 8. November 2019, 13:46:30 CET schrieb Wambui

Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output

2019-11-10 Thread Wambui Karuga
On Thu, Nov 07, 2019 at 08:38:51AM -0500, Sean Paul wrote: > On Thu, Nov 07, 2019 at 01:54:22AM -0800, Joe Perches wrote: > > On Thu, 2019-11-07 at 12:29 +0300, Wambui Karuga wrote: > > > Replace the use of the dev_err macro with the DRM_DEV_ERROR > > > DRM helper macro. > > > > The commit

Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output

2019-11-08 Thread Joe Perches
On Thu, 2019-11-07 at 08:38 -0500, Sean Paul wrote: > On Thu, Nov 07, 2019 at 01:54:22AM -0800, Joe Perches wrote: > > On Thu, 2019-11-07 at 12:29 +0300, Wambui Karuga wrote: > > > Replace the use of the dev_err macro with the DRM_DEV_ERROR > > > DRM helper macro. > > > > The commit message

Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output

2019-11-08 Thread Sean Paul
On Fri, Nov 08, 2019 at 03:06:44PM +0100, Heiko Stübner wrote: > Hi, > > [it seems your Reply-To mail header is set strangely as > Reply-To: 20191107133851.GF63329@art_vandelay > which confuses my MTA] > > Am Freitag, 8. November 2019, 13:46:30 CET schrieb Wambui Karuga: > > On Thu, Nov 07, 2019

Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output

2019-11-08 Thread Heiko Stübner
Hi, [it seems your Reply-To mail header is set strangely as Reply-To: 20191107133851.GF63329@art_vandelay which confuses my MTA] Am Freitag, 8. November 2019, 13:46:30 CET schrieb Wambui Karuga: > On Thu, Nov 07, 2019 at 08:38:51AM -0500, Sean Paul wrote: > > On Thu, Nov 07, 2019 at 01:54:22AM

Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output

2019-11-08 Thread Wambui Karuga
On Thu, Nov 07, 2019 at 08:38:51AM -0500, Sean Paul wrote: > On Thu, Nov 07, 2019 at 01:54:22AM -0800, Joe Perches wrote: > > On Thu, 2019-11-07 at 12:29 +0300, Wambui Karuga wrote: > > > Replace the use of the dev_err macro with the DRM_DEV_ERROR > > > DRM helper macro. > > > > The commit

[PATCH] drm/rockchip: use DRM_DEV_ERROR for log output

2019-11-08 Thread Wambui Karuga
Replace the use of the dev_err macro with the DRM_DEV_ERROR DRM helper macro. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c

Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output

2019-11-07 Thread Sean Paul
On Thu, Nov 07, 2019 at 01:54:22AM -0800, Joe Perches wrote: > On Thu, 2019-11-07 at 12:29 +0300, Wambui Karuga wrote: > > Replace the use of the dev_err macro with the DRM_DEV_ERROR > > DRM helper macro. > > The commit message should show the reason _why_ you are doing > this instead of just

Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output

2019-11-07 Thread Joe Perches
On Thu, 2019-11-07 at 12:29 +0300, Wambui Karuga wrote: > Replace the use of the dev_err macro with the DRM_DEV_ERROR > DRM helper macro. The commit message should show the reason _why_ you are doing this instead of just stating that you are doing this. It's not that dev_err is uncommon in