Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS

2019-11-04 Thread Patrik Jakobsson
On Tue, Oct 22, 2019 at 5:53 PM Patrik Jakobsson wrote: > > On Tue, Oct 22, 2019 at 11:51 AM Jani Nikula > wrote: > > > > On Tue, 22 Oct 2019, Thierry Reding wrote: > > > On Tue, Oct 22, 2019 at 11:16:51AM +0300, Jani Nikula wrote: > > >> On Wed, 16 Oct 2019, Patrik Jakobsson > > >> wrote: >

Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS

2019-10-22 Thread Patrik Jakobsson
On Tue, Oct 22, 2019 at 11:51 AM Jani Nikula wrote: > > On Tue, 22 Oct 2019, Thierry Reding wrote: > > On Tue, Oct 22, 2019 at 11:16:51AM +0300, Jani Nikula wrote: > >> On Wed, 16 Oct 2019, Patrik Jakobsson wrote: > >> > Fix typo where bits got compared (x < y) instead of shifted (x << y). > >>

Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS

2019-10-22 Thread Jani Nikula
On Tue, 22 Oct 2019, Thierry Reding wrote: > On Tue, Oct 22, 2019 at 11:16:51AM +0300, Jani Nikula wrote: >> On Wed, 16 Oct 2019, Patrik Jakobsson wrote: >> > Fix typo where bits got compared (x < y) instead of shifted (x << y). >> >> Fixes: 3ad33ae2bc80 ("drm: Add SCDC helpers") >> Cc: Thierry

Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS

2019-10-22 Thread Thierry Reding
On Tue, Oct 22, 2019 at 11:16:51AM +0300, Jani Nikula wrote: > On Wed, 16 Oct 2019, Patrik Jakobsson wrote: > > Fix typo where bits got compared (x < y) instead of shifted (x << y). > > Fixes: 3ad33ae2bc80 ("drm: Add SCDC helpers") > Cc: Thierry Reding I'm not sure we really need the Fixes:

Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS

2019-10-22 Thread Thierry Reding
On Wed, Oct 16, 2019 at 02:33:42PM +0200, Patrik Jakobsson wrote: > Fix typo where bits got compared (x < y) instead of shifted (x << y). > > Signed-off-by: Patrik Jakobsson > --- > include/drm/drm_scdc_helper.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Oh my...

Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS

2019-10-22 Thread Jani Nikula
On Wed, 16 Oct 2019, Patrik Jakobsson wrote: > Fix typo where bits got compared (x < y) instead of shifted (x << y). Fixes: 3ad33ae2bc80 ("drm: Add SCDC helpers") Cc: Thierry Reding > Signed-off-by: Patrik Jakobsson > --- > include/drm/drm_scdc_helper.h | 6 +++--- > 1 file changed, 3

[PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS

2019-10-16 Thread Patrik Jakobsson
Fix typo where bits got compared (x < y) instead of shifted (x << y). Signed-off-by: Patrik Jakobsson --- include/drm/drm_scdc_helper.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h index