Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

On Tue, Oct 31, 2023 at 02:00:06PM +0100, Geert Uytterhoeven wrote: > Hi Maxime, > > On Tue, Oct 31, 2023 at 12:53 PM Maxime Ripard wrote: > > On Tue, Oct 31, 2023 at 12:27:05PM +0100, Javier Martinez Canillas wrote: > > > Geert Uytterhoeven writes: > > > >> >> Pushed to drm-misc (drm-misc-next)

Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

Hi Maxime, On Tue, Oct 31, 2023 at 12:53 PM Maxime Ripard wrote: > On Tue, Oct 31, 2023 at 12:27:05PM +0100, Javier Martinez Canillas wrote: > > Geert Uytterhoeven writes: > > >> >> Pushed to drm-misc (drm-misc-next). Thanks! > > >> > > > >> > Looks like you introduced an unintended > > >> > > >

Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

On Tue, Oct 31, 2023 at 12:27:05PM +0100, Javier Martinez Canillas wrote: > Geert Uytterhoeven writes: > > > Hi Javier, > > [...] > > >> >> Pushed to drm-misc (drm-misc-next). Thanks! > >> > > >> > Looks like you introduced an unintended > >> > > >> > (cherry picked from commit 9e4db199e66d

Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

Geert Uytterhoeven writes: > Hi Javier, [...] >> >> Pushed to drm-misc (drm-misc-next). Thanks! >> > >> > Looks like you introduced an unintended >> > >> > (cherry picked from commit 9e4db199e66d427c50458f4d72734cc4f0b92948) >> > >> > ? >> > >> >> No, that's intended. It's added by the `dim

Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

Hi Javier, On Tue, Oct 31, 2023 at 11:11 AM Javier Martinez Canillas wrote: > Geert Uytterhoeven writes: > > On Fri, Oct 27, 2023 at 11:33 AM Javier Martinez Canillas > > wrote: > >> Jocelyn Falempe writes: > >> > On 21/10/2023 00:52, Javier Martinez Canillas wrote: > >> >> Avoid a possible un

Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

Geert Uytterhoeven writes: Hello Geert, > Hi Javier, > > On Fri, Oct 27, 2023 at 11:33 AM Javier Martinez Canillas > wrote: >> Jocelyn Falempe writes: >> > On 21/10/2023 00:52, Javier Martinez Canillas wrote: >> >> Avoid a possible uninitialized use of the crtc_state variable in function >> >>

Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

Hi Javier, On Fri, Oct 27, 2023 at 11:33 AM Javier Martinez Canillas wrote: > Jocelyn Falempe writes: > > On 21/10/2023 00:52, Javier Martinez Canillas wrote: > >> Avoid a possible uninitialized use of the crtc_state variable in function > >> ssd132x_primary_plane_atomic_check() and avoid the fo

Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

Jocelyn Falempe writes: > Hi, > > On 21/10/2023 00:52, Javier Martinez Canillas wrote: >> Avoid a possible uninitialized use of the crtc_state variable in function >> ssd132x_primary_plane_atomic_check() and avoid the following Smatch warn: >> >> drivers/gpu/drm/solomon/ssd130x.c:921 >> ss

Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

Hi, On 21/10/2023 00:52, Javier Martinez Canillas wrote: Avoid a possible uninitialized use of the crtc_state variable in function ssd132x_primary_plane_atomic_check() and avoid the following Smatch warn: drivers/gpu/drm/solomon/ssd130x.c:921 ssd132x_primary_plane_atomic_check() error

[PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

Avoid a possible uninitialized use of the crtc_state variable in function ssd132x_primary_plane_atomic_check() and avoid the following Smatch warn: drivers/gpu/drm/solomon/ssd130x.c:921 ssd132x_primary_plane_atomic_check() error: uninitialized symbol 'crtc_state'. Fixes: fdd591e00a9c ("dr