Re: [PATCH] drm/udl: Refactor edid retreiving in UDL driver

2019-03-15 Thread Jani Nikula
On Fri, 15 Mar 2019, Dave Airlie wrote: > On Thu, 14 Mar 2019 at 18:25, Robert Tarasov wrote: >> >> Now drm/udl driver uses drm_do_get_edid() function to retreive and >> validate all blocks of EDID data. Old approach had insufficient >> validation routine and had problems with retreiving of

[PATCH] drm/udl: Refactor edid retreiving in UDL driver (v2)

2019-03-15 Thread Robert Tarasov
Now drm/udl driver uses drm_do_get_edid() function to retreive and validate all blocks of EDID data. Old approach had insufficient validation routine and had problems with retreiving of extra blocks Signed-off-by: Robert Tarasov --- drivers/gpu/drm/udl/udl_connector.c | 72

Re: [PATCH] drm/udl: Refactor edid retreiving in UDL driver

2019-03-14 Thread Dave Airlie
On Thu, 14 Mar 2019 at 18:25, Robert Tarasov wrote: > > Now drm/udl driver uses drm_do_get_edid() function to retreive and > validate all blocks of EDID data. Old approach had insufficient > validation routine and had problems with retreiving of extra blocks > > Signed-off-by: Robert Tarasov

Re: [PATCH] drm/udl: Refactor edid retreiving in UDL driver

2019-03-14 Thread Hans de Goede
Hi, On 14-03-19 11:00, Jani Nikula wrote: On Wed, 13 Mar 2019, Robert Tarasov wrote: On Wed, Mar 13, 2019 at 2:26 AM Jani Nikula wrote: read_buff = kmalloc(2, GFP_KERNEL); A follow-up cleanup might be to switch to using "u8 read_buff[2];" instead of kmallocing it. I don't claim to

Re: [PATCH] drm/udl: Refactor edid retreiving in UDL driver

2019-03-14 Thread Jani Nikula
On Wed, 13 Mar 2019, Robert Tarasov wrote: > On Wed, Mar 13, 2019 at 2:26 AM Jani Nikula > wrote: > read_buff = kmalloc(2, GFP_KERNEL); >> >> A follow-up cleanup might be to switch to using "u8 read_buff[2];" >> instead of kmallocing it. >> >> I don't claim to understand how the usb stuff

[PATCH] drm/udl: Refactor edid retreiving in UDL driver

2019-03-14 Thread Robert Tarasov
Now drm/udl driver uses drm_do_get_edid() function to retreive and validate all blocks of EDID data. Old approach had insufficient validation routine and had problems with retreiving of extra blocks Signed-off-by: Robert Tarasov --- drivers/gpu/drm/udl/udl_connector.c | 72

Re: [PATCH] drm/udl: Refactor edid retreiving in UDL driver

2019-03-14 Thread Robert Tarasov
On Wed, Mar 13, 2019 at 2:26 AM Jani Nikula wrote: > You'll also get support for debugfs and firmware loader EDID override > mechanisms for free. > Yep :) > Signed-off-by missing! > Fixed. read_buff = kmalloc(2, GFP_KERNEL); > > A follow-up cleanup might be to switch to using "u8

Re: [PATCH] drm/udl: Refactor edid retreiving in UDL driver

2019-03-13 Thread Jani Nikula
On Tue, 12 Mar 2019, Robert Tarasov wrote: > Now drm/udl driver uses drm_do_get_edid() function to retreive and > validate all blocks of EDID data. Old approach had insufficient > validation routine and had problems with retreiving of extra blocks You'll also get support for debugfs and firmware

[PATCH] drm/udl: Refactor edid retreiving in UDL driver

2019-03-13 Thread Robert Tarasov
Now drm/udl driver uses drm_do_get_edid() function to retreive and validate all blocks of EDID data. Old approach had insufficient validation routine and had problems with retreiving of extra blocks --- drivers/gpu/drm/udl/udl_connector.c | 72 + 1 file changed, 11