Re: [PATCH] drm: Fix EDID firmware load on resume

On Mon, 12 Sep 2022, Matthieu CHARETTE wrote: > Hi, > > Sorry for late reply. > > How do you propose to go then? > Can we still use a persistent platform device to load the firmware and > cache it? But, in this case the system will still crash in case the > user change drm.edid_firmware then,

Re: [PATCH] drm: Fix EDID firmware load on resume

Hi, Sorry for late reply. How do you propose to go then? Can we still use a persistent platform device to load the firmware and cache it? But, in this case the system will still crash in case the user change drm.edid_firmware then, without replugging the device, he suspends and resumes the

Re: [PATCH] drm: Fix EDID firmware load on resume

On Mon, 08 Aug 2022, Matthieu CHARETTE wrote: > Sorry, What do you mean? You cache with one name at connector init time, but the name specified using drm.edid_firmware may be changed whenever, to cause the next EDID read to use a different EDID firmware. BR, Jani. > > Matthieu > > On Tue, Aug

Re: [PATCH] drm: Fix EDID firmware load on resume

Sorry, What do you mean? Matthieu On Tue, Aug 2 2022 at 05:29:12 PM +0300, Jani Nikula wrote: On Wed, 27 Jul 2022, Matthieu CHARETTE wrote: Loading an EDID using drm.edid_firmware parameter makes resume to fail after firmware cache is being cleaned. This is because edid_load() use a

Re: [PATCH] drm: Fix EDID firmware load on resume

Sorry, What do you mean? Matthieu On Tue, Aug 2 2022 at 05:29:12 PM +0300, Jani Nikula wrote: On Wed, 27 Jul 2022, Matthieu CHARETTE > wrote: Loading an EDID using drm.edid_firmware parameter makes resume to fail after firmware cache is being cleaned.

Re: [PATCH] drm: Fix EDID firmware load on resume

On Wed, 27 Jul 2022, Matthieu CHARETTE wrote: > Loading an EDID using drm.edid_firmware parameter makes resume to fail > after firmware cache is being cleaned. This is because edid_load() use a > temporary device to request the firmware. This cause the EDID firmware > not to be cached from

Re: [PATCH] drm: Fix EDID firmware load on resume

Hi, Caching the EDID via the firmware API makes the kernel able to reclaim the memory in case it's needed. And eventually, the kernel will load it again before suspending. But for 128 bytes, even if we have many monitors it will not make any difference. I don't know if storing a platform

Re: [PATCH] drm: Fix EDID firmware load on resume

On Wed, 27 Jul 2022 09:41:52 +0200, Matthieu CHARETTE wrote: > > Loading an EDID using drm.edid_firmware parameter makes resume to fail > after firmware cache is being cleaned. This is because edid_load() use a > temporary device to request the firmware. This cause the EDID firmware > not to be

[PATCH] drm: Fix EDID firmware load on resume

Loading an EDID using drm.edid_firmware parameter makes resume to fail after firmware cache is being cleaned. This is because edid_load() use a temporary device to request the firmware. This cause the EDID firmware not to be cached from suspend. And, requesting the EDID firmware return an error

Re: [PATCH] drm: Fix EDID firmware load on resume

Hi Matthieu, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v5.19-rc6] [also build test WARNING on linus/master] [cannot apply to drm-misc/drm-misc-next next-20220715] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH] drm: Fix EDID firmware load on resume

Hi Matthieu, Thank you for the patch! Yet something to improve: [auto build test ERROR on v5.19-rc6] [also build test ERROR on linus/master] [cannot apply to drm-misc/drm-misc-next next-20220715] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch,

Re: [PATCH] drm: Fix EDID firmware load on resume

Hi Matthieu, Thank you for the patch! Yet something to improve: [auto build test ERROR on v5.19-rc6] [also build test ERROR on linus/master] [cannot apply to drm-misc/drm-misc-next next-20220715] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch,

Re: [PATCH] drm: Fix EDID firmware load on resume

Hi Matthieu, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v5.19-rc6] [also build test WARNING on linus/master] [cannot apply to drm-misc/drm-misc-next next-20220715] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

[PATCH] drm: Fix EDID firmware load on resume

Loading an EDID using drm.edid_firmware parameter makes resume to fail after firmware cache is being cleaned. This is because edid_load() use a temporary device to request the firmware. This cause the EDID firmware not to be cached from suspend. And, requesting the EDID firmware return an error

Re: [PATCH] drm: Fix EDID firmware load on resume

Hi, Sorry, my email client removed every tab. I will send the v2 in a new thread. Thanks. Matthieu On Thu, Jul 14 2022 at 11:23:10 AM -0300, André Almeida wrote: Hi Matthieu, Thanks for your patch. Às 11:58 de 06/07/22, Matthieu CHARETTE escreveu: Loading an EDID using

Re: [PATCH] drm: Fix EDID firmware load on resume

Hi Matthieu, Thanks for your patch. Às 11:58 de 06/07/22, Matthieu CHARETTE escreveu: > Loading an EDID using drm.edid_firmware parameter makes resume to fail > after firmware cache is being cleaned. This is because edid_load() use a > temporary device to request the firmware. This cause the

Re: [PATCH] drm: Fix EDID firmware load on resume

Sorry, I forgot to add a tag. --- Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2061 On Wed, Jul 6 2022 at 04:58:08 PM +0200, Matthieu CHARETTE wrote: Loading an EDID using drm.edid_firmware parameter makes resume to fail after firmware cache is being cleaned. This is because

[PATCH] drm: Fix EDID firmware load on resume

Loading an EDID using drm.edid_firmware parameter makes resume to fail after firmware cache is being cleaned. This is because edid_load() use a temporary device to request the firmware. This cause the EDID firmware not to be cached from suspend. And, requesting the EDID firmware return an error