On Tue, 9 Oct 2012 16:56:58 -0300, Rodrigo Vivi
wrote:
> When cmd isn't IOC_IN | IOC_OUT a null "kdata" goes to "memset", which
> dereferences it.
>
> v2: simpler version just using usize = 0 instead of allocating useless memory
>
> Signed-off-by: Rodrigo Vivi
Presuming that coverity is
On Tue, 9 Oct 2012 16:56:58 -0300, Rodrigo Vivi rodrigo.v...@gmail.com wrote:
When cmd isn't IOC_IN | IOC_OUT a null kdata goes to memset, which
dereferences it.
v2: simpler version just using usize = 0 instead of allocating useless memory
Signed-off-by: Rodrigo Vivi
On Tue, 9 Oct 2012 14:50:46 -0300, Rodrigo Vivi
wrote:
> When cmd isn't IOC_IN | IOC_OUT a null "kdata" goes to "memset", which
> dereferences it.
>
usize should be 0 in that case, since the ioctl is neither copying data
in or out, for example I915_GEM_THROTTLE. To be on the safe side:
if
When cmd isn't IOC_IN | IOC_OUT a null "kdata" goes to "memset", which
dereferences it.
v2: simpler version just using usize = 0 instead of allocating useless memory
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/drm_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
When cmd isn't IOC_IN | IOC_OUT a null "kdata" goes to "memset", which
dereferences it.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/drm_drv.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index
When cmd isn't IOC_IN | IOC_OUT a null kdata goes to memset, which
dereferences it.
Signed-off-by: Rodrigo Vivi rodrigo.v...@gmail.com
---
drivers/gpu/drm/drm_drv.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_drv.c
On Tue, 9 Oct 2012 14:50:46 -0300, Rodrigo Vivi rodrigo.v...@gmail.com wrote:
When cmd isn't IOC_IN | IOC_OUT a null kdata goes to memset, which
dereferences it.
usize should be 0 in that case, since the ioctl is neither copying data
in or out, for example I915_GEM_THROTTLE. To be on the
When cmd isn't IOC_IN | IOC_OUT a null kdata goes to memset, which
dereferences it.
v2: simpler version just using usize = 0 instead of allocating useless memory
Signed-off-by: Rodrigo Vivi rodrigo.v...@gmail.com
---
drivers/gpu/drm/drm_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1
