Re: [PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-20 Thread Sui Jingfeng
On 2024/3/19 23:49, Neil Armstrong wrote: On 18/03/2024 20:23, Sui Jingfeng wrote: Hi, On 2024/3/19 02:04, Laurent Pinchart wrote: Improving core helpers is certainly a good idea, and if we do so, we can simplify drivers. What I'm concerned is that commit 00084f0c01bf creates a silent

Re: [PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-19 Thread Neil Armstrong
Hi, On Mon, 18 Mar 2024 18:06:01 +0200, Laurent Pinchart wrote: > Commit 00084f0c01bf ("drm: bridge: thc63lvd1024: Switch to use > of_graph_get_remote_node()") simplified the thc63lvd1024 driver by > replacing hand-rolled code with a helper function. While doing so, it > created an error code

Re: [PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-19 Thread Neil Armstrong
On 18/03/2024 20:23, Sui Jingfeng wrote: Hi, On 2024/3/19 02:04, Laurent Pinchart wrote: Improving core helpers is certainly a good idea, and if we do so, we can simplify drivers. What I'm concerned is that commit 00084f0c01bf creates a silent probe failure path, No, I can't agree here. It

Re: [PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-19 Thread Neil Armstrong
On 18/03/2024 17:06, Laurent Pinchart wrote: Commit 00084f0c01bf ("drm: bridge: thc63lvd1024: Switch to use of_graph_get_remote_node()") simplified the thc63lvd1024 driver by replacing hand-rolled code with a helper function. While doing so, it created an error code path at probe time without

Re: [PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-18 Thread Sui Jingfeng
On 2024/3/19 03:23, Sui Jingfeng wrote: 2) It should be exist at product level kernel. It should NOT be exist at product level kernel. -- Best regards, Sui

Re: [PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-18 Thread Sui Jingfeng
Hi, On 2024/3/19 02:04, Laurent Pinchart wrote: Improving core helpers is certainly a good idea, and if we do so, we can simplify drivers. What I'm concerned is that commit 00084f0c01bf creates a silent probe failure path, No, I can't agree here. It doesn't creates a silent probe failure

Re: [PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-18 Thread Sui Jingfeng
Hi, On 2024/3/19 02:04, Laurent Pinchart wrote: Hi Sui, On Tue, Mar 19, 2024 at 12:42:41AM +0800, Sui Jingfeng wrote: On 2024/3/19 00:06, Laurent Pinchart wrote: Commit 00084f0c01bf ("drm: bridge: thc63lvd1024: Switch to use of_graph_get_remote_node()") simplified the thc63lvd1024 driver by

Re: [PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-18 Thread Laurent Pinchart
Hi Sui, On Tue, Mar 19, 2024 at 12:42:41AM +0800, Sui Jingfeng wrote: > On 2024/3/19 00:06, Laurent Pinchart wrote: > > Commit 00084f0c01bf ("drm: bridge: thc63lvd1024: Switch to use > > of_graph_get_remote_node()") simplified the thc63lvd1024 driver by > > replacing hand-rolled code with a

Re: [PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-18 Thread Sui Jingfeng
Hi, On 2024/3/19 00:06, Laurent Pinchart wrote: Commit 00084f0c01bf ("drm: bridge: thc63lvd1024: Switch to use of_graph_get_remote_node()") simplified the thc63lvd1024 driver by replacing hand-rolled code with a helper function. [...] While doing so, it created an error code path at

[PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-18 Thread Laurent Pinchart
Commit 00084f0c01bf ("drm: bridge: thc63lvd1024: Switch to use of_graph_get_remote_node()") simplified the thc63lvd1024 driver by replacing hand-rolled code with a helper function. While doing so, it created an error code path at probe time without any error message, potentially causing probe