[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-09-08 Thread Andrea Arcangeli
On Thu, Sep 08, 2016 at 01:09:23PM +0200, Martin van Es wrote: > On donderdag 8 september 2016 13:18:41 CEST Ville Syrjälä wrote: > > On Thu, Sep 08, 2016 at 12:04:39PM +0200, Martin van Es wrote: > > > On dinsdag 6 september 2016 21:40:48 CEST Ville Syrjälä wrote: > > > > On Tue, Sep 06, 2016

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-09-08 Thread Ville Syrjälä
On Thu, Sep 08, 2016 at 12:04:39PM +0200, Martin van Es wrote: > On dinsdag 6 september 2016 21:40:48 CEST Ville Syrjälä wrote: > > On Tue, Sep 06, 2016 at 01:56:20PM +0300, Ville Syrjälä wrote: > > > Actually I just cooked up another branch [2]. It just throws in some > > > memory barriers to

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-09-08 Thread Martin van Es
On donderdag 8 september 2016 13:18:41 CEST Ville Syrjälä wrote: > On Thu, Sep 08, 2016 at 12:04:39PM +0200, Martin van Es wrote: > > On dinsdag 6 september 2016 21:40:48 CEST Ville Syrjälä wrote: > > > On Tue, Sep 06, 2016 at 01:56:20PM +0300, Ville Syrjälä wrote: > > > > Actually I just

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-09-08 Thread Martin van Es
On dinsdag 6 september 2016 21:40:48 CEST Ville Syrjälä wrote: > On Tue, Sep 06, 2016 at 01:56:20PM +0300, Ville Syrjälä wrote: > > Actually I just cooked up another branch [2]. It just throws in some > > memory barriers to the opregion code, and adds a a new debug print so > > to show the

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-09-06 Thread Ville Syrjälä
On Tue, Sep 06, 2016 at 01:56:20PM +0300, Ville Syrjälä wrote: > On Tue, Sep 06, 2016 at 12:20:51PM +0300, Ville Syrjälä wrote: > > On Sun, Aug 28, 2016 at 05:28:46PM +0200, Andrea Arcangeli wrote: > > > Skylake was already singled out, but it doesn't cover the XPS 13 L332X > > > model which

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-09-06 Thread Ville Syrjälä
On Tue, Sep 06, 2016 at 12:20:51PM +0300, Ville Syrjälä wrote: > On Sun, Aug 28, 2016 at 05:28:46PM +0200, Andrea Arcangeli wrote: > > Skylake was already singled out, but it doesn't cover the XPS 13 L332X > > model which is based on IvyBridge. > > > > The commit that introduced the regression

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-09-06 Thread Ville Syrjälä
On Sun, Aug 28, 2016 at 05:28:46PM +0200, Andrea Arcangeli wrote: > Skylake was already singled out, but it doesn't cover the XPS 13 L332X > model which is based on IvyBridge. > > The commit that introduced the regression is > 1d6da87a3241deb13d073c4125d19ed0e5a0c62c > > The Skylake workaround

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-08-30 Thread Jani Nikula
On Tue, 30 Aug 2016, Martin van Es wrote: > Hi Andrea, > > I'd be happy to test, but what am I testing when applying these boot > parameters? In other words: what should I report? The point is, for an ivybridge setting those parameters should not make *any* difference. BR, Jani. > > And just

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-08-30 Thread Martin van Es
On dinsdag 30 augustus 2016 11:13:40 CEST Jani Nikula wrote: > On Tue, 30 Aug 2016, Martin van Es wrote: > > Hi Andrea, > > > > I'd be happy to test, but what am I testing when applying these boot > > parameters? In other words: what should I report? > > The point is, for an ivybridge setting

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-08-30 Thread Jani Nikula
On Mon, 29 Aug 2016, Andrea Arcangeli wrote: > On Mon, Aug 29, 2016 at 10:24:38AM +0300, Jani Nikula wrote: >> If it's an Iybridge, there's no low vswing, and that explanation is >> false. You can verify by trying i915.edp_vswing=1 or i915.edp_vswing=2 >> on an unpatched kernel. > > CC'ed Martin

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-08-30 Thread Martin van Es
Hi Andrea, I'd be happy to test, but what am I testing when applying these boot parameters? In other words: what should I report? And just to be sure, I THINK I own an IVB but intel is not very vocal about it when searching for familyname. I have a vendor_id : GenuineIntel cpu family

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-08-29 Thread Andrea Arcangeli
On Mon, Aug 29, 2016 at 10:24:38AM +0300, Jani Nikula wrote: > If it's an Iybridge, there's no low vswing, and that explanation is > false. You can verify by trying i915.edp_vswing=1 or i915.edp_vswing=2 > on an unpatched kernel. CC'ed Martin who filed the bz, he can reproduce too

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-08-29 Thread Jani Nikula
On Mon, 29 Aug 2016, Andrea Arcangeli wrote: > On Mon, Aug 29, 2016 at 10:24:38AM +0300, Jani Nikula wrote: >> If it's an Iybridge, there's no low vswing, and that explanation is >> false. You can verify by trying i915.edp_vswing=1 or i915.edp_vswing=2 >> on an unpatched kernel. > > What I should

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-08-29 Thread Andrea Arcangeli
On Mon, Aug 29, 2016 at 10:24:38AM +0300, Jani Nikula wrote: > If it's an Iybridge, there's no low vswing, and that explanation is > false. You can verify by trying i915.edp_vswing=1 or i915.edp_vswing=2 > on an unpatched kernel. What I should look for when trying those two settings? Will they

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-08-29 Thread Jani Nikula
On Sun, 28 Aug 2016, Andrea Arcangeli wrote: > Skylake was already singled out, but it doesn't cover the XPS 13 L332X > model which is based on IvyBridge. > > The commit that introduced the regression is > 1d6da87a3241deb13d073c4125d19ed0e5a0c62c That's a merge commit, the real one is commit

[PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge

2016-08-28 Thread Andrea Arcangeli
Skylake was already singled out, but it doesn't cover the XPS 13 L332X model which is based on IvyBridge. The commit that introduced the regression is 1d6da87a3241deb13d073c4125d19ed0e5a0c62c The Skylake workaround for the regression was introduced in commit