Re: [PATCH 1/2] drm/i915: Fix GEN8_MISCCPCTL

2023-02-03 Thread Matt Roper
On Fri, Feb 03, 2023 at 10:03:49AM -0800, Lucas De Marchi wrote: > On Thu, Feb 02, 2023 at 05:12:10PM -0800, Matt Roper wrote: > > On Thu, Feb 02, 2023 at 04:57:08PM -0800, Lucas De Marchi wrote: > > > Register 0x9424 is not replicated on any platform, so it shouldn't be > > > declared with REG_MCR

Re: [PATCH 1/2] drm/i915: Fix GEN8_MISCCPCTL

2023-02-03 Thread Lucas De Marchi
On Thu, Feb 02, 2023 at 05:12:10PM -0800, Matt Roper wrote: On Thu, Feb 02, 2023 at 04:57:08PM -0800, Lucas De Marchi wrote: Register 0x9424 is not replicated on any platform, so it shouldn't be declared with REG_MCR(). Declaring it with _MMIO() is basically duplicate of the GEN7 version, so jus

Re: [PATCH 1/2] drm/i915: Fix GEN8_MISCCPCTL

2023-02-02 Thread Matt Roper
On Thu, Feb 02, 2023 at 04:57:08PM -0800, Lucas De Marchi wrote: > Register 0x9424 is not replicated on any platform, so it shouldn't be > declared with REG_MCR(). Declaring it with _MMIO() is basically > duplicate of the GEN7 version, so just remove the GEN8 and change all > the callers to use the

[PATCH 1/2] drm/i915: Fix GEN8_MISCCPCTL

2023-02-02 Thread Lucas De Marchi
Register 0x9424 is not replicated on any platform, so it shouldn't be declared with REG_MCR(). Declaring it with _MMIO() is basically duplicate of the GEN7 version, so just remove the GEN8 and change all the callers to use the right functions. Also use intel_uncore_rmw() rather than a read + write