Re: [PATCH 2/2] drm/msm: Fix duplicate gpu node in icc summary

2020-10-20 Thread Akhil P Oommen
On 10/19/2020 8:29 PM, Jordan Crouse wrote: On Mon, Oct 19, 2020 at 06:49:18PM +0530, Akhil P Oommen wrote: On targets with a6xx gpu, there is a duplicate gpu icc node listed in the interconnect summary. On these targets, calling This first sentence is confusing to me. I think the following

Re: [PATCH 2/2] drm/msm: Fix duplicate gpu node in icc summary

2020-10-19 Thread Jordan Crouse
On Mon, Oct 19, 2020 at 06:49:18PM +0530, Akhil P Oommen wrote: > On targets with a6xx gpu, there is a duplicate gpu icc node listed in > the interconnect summary. On these targets, calling This first sentence is confusing to me. I think the following few sentences do a better job of explaining

[PATCH 2/2] drm/msm: Fix duplicate gpu node in icc summary

2020-10-19 Thread Akhil P Oommen
On targets with a6xx gpu, there is a duplicate gpu icc node listed in the interconnect summary. On these targets, calling dev_pm_opp_of_add_table() api initializes the icc nodes for gpu indirectly. So we should avoid using of_icc_get() api in the common probe path. To fix this, we can move