[PATCH 3/3] drm/exynos: Add device tree support for fimc ipp driver

2013-04-22 Thread Sylwester Nawrocki
On 04/19/2013 01:38 PM, Eunchul Kim wrote: >> static void fimc_set_type_ctrl(struct fimc_context *ctx, enum fimc_wb wb) >> @@ -1628,7 +1617,9 @@ static int fimc_ippdrv_start(struct device *dev, enum >> drm_exynos_ipp_cmd cmd) >> fimc_handle_lastend(ctx, true); >> >> /* setup F

[PATCH 3/3] drm/exynos: Add device tree support for fimc ipp driver

2013-04-22 Thread Sylwester Nawrocki
On 04/20/2013 06:21 PM, Inki Dae wrote: > +static int fimc_parse_dt(struct fimc_context *ctx) > +{ > + struct device_node *node = ctx->dev->of_node; > + > + if (!of_property_read_bool(node, "samsung,lcd-wb")) > + return -ENODEV; > > > > Isn't the

Re: [PATCH 3/3] drm/exynos: Add device tree support for fimc ipp driver

2013-04-22 Thread Sylwester Nawrocki
On 04/19/2013 01:38 PM, Eunchul Kim wrote: >> static void fimc_set_type_ctrl(struct fimc_context *ctx, enum fimc_wb wb) >> @@ -1628,7 +1617,9 @@ static int fimc_ippdrv_start(struct device *dev, enum >> drm_exynos_ipp_cmd cmd) >> fimc_handle_lastend(ctx, true); >> >> /* setup F

Re: [PATCH 3/3] drm/exynos: Add device tree support for fimc ipp driver

2013-04-22 Thread Sylwester Nawrocki
On 04/20/2013 06:21 PM, Inki Dae wrote: > +static int fimc_parse_dt(struct fimc_context *ctx) > +{ > + struct device_node *node = ctx->dev->of_node; > + > + if (!of_property_read_bool(node, "samsung,lcd-wb")) > + return -ENODEV; > > > > Isn't the

[PATCH 3/3] drm/exynos: Add device tree support for fimc ipp driver

2013-04-21 Thread Inki Dae
2013/4/17 Sylwester Nawrocki > This patch adds OF initialization support for the FIMC driver. > The binding documentation can be found at Documentation/devicetree/ > bindings/media/samsung-fimc.txt. > > The syscon regmap interface is used to serialize access to the > shared CAMBLK registers from

Re: [PATCH 3/3] drm/exynos: Add device tree support for fimc ipp driver

2013-04-20 Thread Inki Dae
2013/4/17 Sylwester Nawrocki > This patch adds OF initialization support for the FIMC driver. > The binding documentation can be found at Documentation/devicetree/ > bindings/media/samsung-fimc.txt. > > The syscon regmap interface is used to serialize access to the > shared CAMBLK registers from

[PATCH 3/3] drm/exynos: Add device tree support for fimc ipp driver

2013-04-19 Thread Eunchul Kim
Dear Sylwester Nawrocki. Sorry. I didn't check your third patch. I understand the "mux", "parent" meaning. please ignore my comment of "mux", "parent" and please check below comments. Thank's BR Eunchul Kim. On 04/17/2013 02:31 AM, Sylwester Nawrocki wrote: > This patch adds OF initialization

Re: [PATCH 3/3] drm/exynos: Add device tree support for fimc ipp driver

2013-04-19 Thread Eunchul Kim
Dear Sylwester Nawrocki. Sorry. I didn't check your third patch. I understand the "mux", "parent" meaning. please ignore my comment of "mux", "parent" and please check below comments. Thank's BR Eunchul Kim. On 04/17/2013 02:31 AM, Sylwester Nawrocki wrote: This patch adds OF initialization

[PATCH 3/3] drm/exynos: Add device tree support for fimc ipp driver

2013-04-16 Thread Sylwester Nawrocki
This patch adds OF initialization support for the FIMC driver. The binding documentation can be found at Documentation/devicetree/ bindings/media/samsung-fimc.txt. The syscon regmap interface is used to serialize access to the shared CAMBLK registers from within the V4L2 FIMC-IS and the DRM FIMC d

[PATCH 3/3] drm/exynos: Add device tree support for fimc ipp driver

2013-04-16 Thread Sylwester Nawrocki
This patch adds OF initialization support for the FIMC driver. The binding documentation can be found at Documentation/devicetree/ bindings/media/samsung-fimc.txt. The syscon regmap interface is used to serialize access to the shared CAMBLK registers from within the V4L2 FIMC-IS and the DRM FIMC d