Re: [PATCH 3/3] drm/omap: remove unused function

Hi, On Thu, Mar 29, 2018 at 02:24:40PM +0100, Emil Velikov wrote: > On 29 March 2018 at 13:31, Sebastian Reichel > wrote: > > Hi, > > > > On Thu, Mar 29, 2018 at 12:00:18PM +0100, Emil Velikov wrote: > >> On 29 March 2018 at 11:40, Tomi Valkeinen

Re: [PATCH 3/3] drm/omap: remove unused function

Hi, On Thu, Mar 29, 2018 at 03:49:08PM +0300, Tomi Valkeinen wrote: > On 29/03/18 15:31, Sebastian Reichel wrote: > > Hi, > > > > On Thu, Mar 29, 2018 at 12:00:18PM +0100, Emil Velikov wrote: > >> On 29 March 2018 at 11:40, Tomi Valkeinen wrote: > >>>

Re: [PATCH 3/3] drm/omap: remove unused function

Hi, On Thu, Mar 29, 2018 at 12:00:18PM +0100, Emil Velikov wrote: > On 29 March 2018 at 11:40, Tomi Valkeinen wrote: > > omap_framebuffer_get_next_connector() is not used, remove it. > > > Seems to have been unused for a few years now. > Namely since commit

Re: [PATCH 3/3] drm/omap: remove unused function

On 29/03/18 17:44, Sebastian Reichel wrote: >> * omap_fb.c:326: condition 0 is always false >> * omap_fb.c:326: condition 0 is always false >> * omap_fb.c:327: condition connector!=from is always false > > Looks like list_for_each_entry_from() is not properly understood > by the static

Re: [PATCH 3/3] drm/omap: remove unused function

On 29 March 2018 at 13:31, Sebastian Reichel wrote: > Hi, > > On Thu, Mar 29, 2018 at 12:00:18PM +0100, Emil Velikov wrote: >> On 29 March 2018 at 11:40, Tomi Valkeinen wrote: >> > omap_framebuffer_get_next_connector() is not used, remove

Re: [PATCH 3/3] drm/omap: remove unused function

On 29/03/18 15:31, Sebastian Reichel wrote: > Hi, > > On Thu, Mar 29, 2018 at 12:00:18PM +0100, Emil Velikov wrote: >> On 29 March 2018 at 11:40, Tomi Valkeinen wrote: >>> omap_framebuffer_get_next_connector() is not used, remove it. >>> >> Seems to have been unused for a

Re: [PATCH 3/3] drm/omap: remove unused function

On 29 March 2018 at 11:40, Tomi Valkeinen wrote: > omap_framebuffer_get_next_connector() is not used, remove it. > Seems to have been unused for a few years now. Namely since commit 5a35876e2830511cb8110667fc426c6a6165a593 Reviewed-by: Emil Velikov

[PATCH 3/3] drm/omap: remove unused function

omap_framebuffer_get_next_connector() is not used, remove it. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_fb.c | 27 --- drivers/gpu/drm/omapdrm/omap_fb.h | 2 -- 2 files changed, 29 deletions(-) diff --git