Re: [PATCH V4 2/3] drm/panel: Add Samsung AMS495QA01 MIPI-DSI LCD panel

2022-12-06 Thread Linus Walleij
On Sat, Dec 3, 2022 at 8:01 PM Chris Morgan wrote: > Will do. I'll make the changes and resubmit. For what it's worth the > documentation says this one is a Samsung AMS495QA01 panel on a > Magnachip D53E6EA8966 controller IC. I would name the driver panel-magnachip-d53e6ea8966.c and KConfig PANE

Re: [PATCH V4 2/3] drm/panel: Add Samsung AMS495QA01 MIPI-DSI LCD panel

2022-12-06 Thread Linus Walleij
On Sat, Dec 3, 2022 at 11:18 AM Heiko Stübner wrote: > Though in past projects I've seen the same display-controller used with > different panels (and different dsi-init-sequences). In one project the > display manufacturer even EOL'ed the first panel and provided a replacement > with said same d

Re: [PATCH V4 2/3] drm/panel: Add Samsung AMS495QA01 MIPI-DSI LCD panel

2022-12-03 Thread Chris Morgan
On Sat, Dec 03, 2022 at 10:03:42AM +0100, Linus Walleij wrote: > Hi Chris, > > thanks for your patch! > > overall this looks very good. Just some nitpicks. > > On Tue, Nov 29, 2022 at 6:29 PM Chris Morgan wrote: > > > From: Chris Morgan > > > > Support Samsung AMS495QA01 panel as found on the

Re: [PATCH V4 2/3] drm/panel: Add Samsung AMS495QA01 MIPI-DSI LCD panel

2022-12-03 Thread Heiko Stübner
Hi Linus, Am Samstag, 3. Dezember 2022, 10:03:42 CET schrieb Linus Walleij: > On Tue, Nov 29, 2022 at 6:29 PM Chris Morgan wrote: > > > From: Chris Morgan > > > > Support Samsung AMS495QA01 panel as found on the Anbernic RG503. Note > > This panel receives video signals via DSI, however it rece

Re: [PATCH V4 2/3] drm/panel: Add Samsung AMS495QA01 MIPI-DSI LCD panel

2022-12-03 Thread Linus Walleij
Hi Chris, thanks for your patch! overall this looks very good. Just some nitpicks. On Tue, Nov 29, 2022 at 6:29 PM Chris Morgan wrote: > From: Chris Morgan > > Support Samsung AMS495QA01 panel as found on the Anbernic RG503. Note > This panel receives video signals via DSI, however it receive

[PATCH V4 2/3] drm/panel: Add Samsung AMS495QA01 MIPI-DSI LCD panel

2022-11-29 Thread Chris Morgan
From: Chris Morgan Support Samsung AMS495QA01 panel as found on the Anbernic RG503. Note This panel receives video signals via DSI, however it receives commands via 3-wire SPI. Signed-off-by: Chris Morgan Signed-off-by: Maya Matuszczyk --- drivers/gpu/drm/panel/Kconfig | 10 +