Re: [PATCH v1 6/8] drm/print: add drm_dev_* logging functions

2019-12-31 Thread Jani Nikula
On Mon, 23 Dec 2019, Sam Ravnborg wrote: > Hi Jani. > > On Mon, Dec 23, 2019 at 01:29:19PM +0200, Jani Nikula wrote: >> On Sat, 21 Dec 2019, Sam Ravnborg wrote: >> > There are a lot of cases where we have a device * but no drm_device *. >> > Add drm_dev_* variants of the logging functions to

Re: [PATCH v1 6/8] drm/print: add drm_dev_* logging functions

2019-12-23 Thread Sam Ravnborg
Hi Jani. On Mon, Dec 23, 2019 at 01:29:19PM +0200, Jani Nikula wrote: > On Sat, 21 Dec 2019, Sam Ravnborg wrote: > > There are a lot of cases where we have a device * but no drm_device *. > > Add drm_dev_* variants of the logging functions to cover these cases. > > So I know there are some

Re: [PATCH v1 6/8] drm/print: add drm_dev_* logging functions

2019-12-23 Thread Jani Nikula
On Sat, 21 Dec 2019, Sam Ravnborg wrote: > There are a lot of cases where we have a device * but no drm_device *. > Add drm_dev_* variants of the logging functions to cover these cases. So I know there are some valid cases where we only have struct device *, and instead of passing struct

Re: [PATCH v1 6/8] drm/print: add drm_dev_* logging functions

2019-12-23 Thread Jani Nikula
On Sat, 21 Dec 2019, Sam Ravnborg wrote: > Hi Joe. > >> > +#define __drm_dev_cat_printk(dev, cat, type, fmt, ...) >> > \ >> > +({ >> > \ >> > + if (drm_debug_enabled(cat))

Re: [PATCH v1 6/8] drm/print: add drm_dev_* logging functions

2019-12-21 Thread Sam Ravnborg
Hi Joe. > > +#define __drm_dev_cat_printk(dev, cat, type, fmt, ...) > > \ > > +({ \ > > + if (drm_debug_enabled(cat)) \ > > + dev_dbg##type((dev), "[drm] " fmt,

Re: [PATCH v1 6/8] drm/print: add drm_dev_* logging functions

2019-12-21 Thread Joe Perches
On Sat, 2019-12-21 at 10:55 +0100, Sam Ravnborg wrote: > There are a lot of cases where we have a device * but no drm_device *. > Add drm_dev_* variants of the logging functions to cover these cases. [] > diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h [] > @@ -468,6 +511,60 @@

[PATCH v1 6/8] drm/print: add drm_dev_* logging functions

2019-12-21 Thread Sam Ravnborg
There are a lot of cases where we have a device * but no drm_device *. Add drm_dev_* variants of the logging functions to cover these cases. Include brief documentation. Signed-off-by: Sam Ravnborg Cc: Jani Nikula Cc: Sean Paul Cc: Daniel Vetter --- include/drm/drm_print.h | 99