Re: [PATCH v2] drm/exynos: use atomic helper commit

2017-01-23 Thread Inki Dae
2017년 01월 23일 23:55에 Sean Paul 이(가) 쓴 글: > > > As of now, I don't see any case. even without Maarten's patch set, it > works well - actually, I had a test with atomic test app more than 10 > hours.. Can you provide this test application? In particular I'm asking this beca

Re: [PATCH v2] drm/exynos: use atomic helper commit

2017-01-23 Thread Daniel Vetter
On Mon, Jan 23, 2017 at 11:20:42AM -0500, Sean Paul wrote: > On Mon, Jan 23, 2017 at 05:01:56PM +0100, Tobias Jakobi wrote: > > Sean Paul wrote: > > > > > > > > > As of now, I don't see any case. even without Maarten's patch set, it > > > works well - actually, I had a test with atomic t

Re: [PATCH v2] drm/exynos: use atomic helper commit

2017-01-23 Thread Sean Paul
On Mon, Jan 23, 2017 at 05:01:56PM +0100, Tobias Jakobi wrote: > Sean Paul wrote: > > > > > > As of now, I don't see any case. even without Maarten's patch set, it > > works well - actually, I had a test with atomic test app more than 10 > > hours.. > Can you provide this test

Re: [PATCH v2] drm/exynos: use atomic helper commit

2017-01-23 Thread Tobias Jakobi
Sean Paul wrote: > > > As of now, I don't see any case. even without Maarten's patch set, it > works well - actually, I had a test with atomic test app more than 10 > hours.. Can you provide this test application? In particular I'm asking this because libdrm currently does

Re: [PATCH v2] drm/exynos: use atomic helper commit

2017-01-23 Thread Sean Paul
> >>> As of now, I don't see any case. even without Maarten's patch set, it > >>> works well - actually, I had a test with atomic test app more than 10 > >>> hours.. > >> Can you provide this test application? In particular I'm asking this > >> because libdrm currently doesn't provide any tests

Re: [PATCH v2] drm/exynos: use atomic helper commit

2017-01-23 Thread Tobias Jakobi
Inki Dae wrote: > > > 2017년 01월 20일 22:05에 Tobias Jakobi 이(가) 쓴 글: >> Inki Dae wrote: >>> Hi Tobias, >>> >>> 2017년 01월 19일 21:49에 Tobias Jakobi 이(가) 쓴 글: What about Laurent's comment stating that drm_atomic_helper_commit() is broken at the moment? Shouldn't there be some kind of warning

Re: [PATCH v2] drm/exynos: use atomic helper commit

2017-01-23 Thread Inki Dae
2017년 01월 20일 22:05에 Tobias Jakobi 이(가) 쓴 글: > Inki Dae wrote: >> Hi Tobias, >> >> 2017년 01월 19일 21:49에 Tobias Jakobi 이(가) 쓴 글: >>> What about Laurent's comment stating that drm_atomic_helper_commit() is >>> broken at the moment? Shouldn't there be some kind of warning in the >>> commit message t

Re: [PATCH v2] drm/exynos: use atomic helper commit

2017-01-20 Thread Tobias Jakobi
Inki Dae wrote: > Hi Tobias, > > 2017년 01월 19일 21:49에 Tobias Jakobi 이(가) 쓴 글: >> What about Laurent's comment stating that drm_atomic_helper_commit() is >> broken at the moment? Shouldn't there be some kind of warning in the >> commit message that this patch is only safe to apply once the fixes fo

Re: [PATCH v2] drm/exynos: use atomic helper commit

2017-01-19 Thread Inki Dae
Hi Tobias, 2017년 01월 19일 21:49에 Tobias Jakobi 이(가) 쓴 글: > What about Laurent's comment stating that drm_atomic_helper_commit() is > broken at the moment? Shouldn't there be some kind of warning in the > commit message that this patch is only safe to apply once the fixes for > drm_atomic_helper_com

Re: [PATCH v2] drm/exynos: use atomic helper commit

2017-01-19 Thread Inki Dae
2017년 01월 19일 20:53에 Gustavo Padovan 이(가) 쓴 글: > Hi Inki, > > 2017-01-19 Inki Dae : > >> This patch replaces specific atomic commit function >> with atomic helper commit one. >> >> For this, it removes existing atomic commit function >> and relevant code specific to Exynos DRM and makes >> atom

Re: [PATCH v2] drm/exynos: use atomic helper commit

2017-01-19 Thread Tobias Jakobi
What about Laurent's comment stating that drm_atomic_helper_commit() is broken at the moment? Shouldn't there be some kind of warning in the commit message that this patch is only safe to apply once the fixes for drm_atomic_helper_commit() have landed? I'm already seeing this getting merged by acci

Re: [PATCH v2] drm/exynos: use atomic helper commit

2017-01-19 Thread Gustavo Padovan
Hi Inki, 2017-01-19 Inki Dae : > This patch replaces specific atomic commit function > with atomic helper commit one. > > For this, it removes existing atomic commit function > and relevant code specific to Exynos DRM and makes > atomic helper commit to be used instead. > > Below are changes fo

[PATCH v2] drm/exynos: use atomic helper commit

2017-01-19 Thread Inki Dae
This patch replaces specific atomic commit function with atomic helper commit one. For this, it removes existing atomic commit function and relevant code specific to Exynos DRM and makes atomic helper commit to be used instead. Below are changes for the use of atomic helper commit: - add atomic_c