On 5/2/2020 10:00 AM, Chris Wilson wrote:
Quoting Nirmoy (2020-04-30 11:30:43)
On 4/30/20 12:15 PM, Chris Wilson wrote:
Quoting Nirmoy Das (2020-04-30 10:58:39)
+void insert_hole_addr(struct rb_root *root, struct drm_mm_node *node)
^ static
Ah I forgot!
(sparse [make C=1] or make W=1
Quoting Nirmoy (2020-04-30 11:30:43)
>
> On 4/30/20 12:15 PM, Chris Wilson wrote:
> > Quoting Nirmoy Das (2020-04-30 10:58:39)
> >> +void insert_hole_addr(struct rb_root *root, struct drm_mm_node *node)
> > ^ static
>
>
> Ah I forgot!
>
> >
> > (sparse [make C=1] or make W=1 will spot this)
>
Hi Nirmoy,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-exynos/exynos-drm-next
tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master v5.7-rc3
next-20200501]
[if your patch is applied to the
Userspace can severely fragment rb_hole_addr rbtree by manipulating
alignment while allocating buffers. Fragmented rb_hole_addr rbtree
would result in large delays while allocating buffer object for a
userspace application. It takes long time to find suitable hole
because if we fail to find a
On 4/30/20 12:15 PM, Chris Wilson wrote:
Quoting Nirmoy Das (2020-04-30 10:58:39)
+void insert_hole_addr(struct rb_root *root, struct drm_mm_node *node)
^ static
Ah I forgot!
(sparse [make C=1] or make W=1 will spot this)
Thanks for the tip :)
Nirmoy
Looks good, I'll check more
Quoting Nirmoy Das (2020-04-30 10:58:39)
> +void insert_hole_addr(struct rb_root *root, struct drm_mm_node *node)
^ static
(sparse [make C=1] or make W=1 will spot this)
Looks good, I'll check more carefully later.
-Chris
___
dri-devel mailing list
