Re: [PATCH v2 2/6] drm/msm/a6xx: Remove duplicate irq disable from remove

2019-05-23 Thread Jordan Crouse
On Thu, May 23, 2019 at 01:16:41PM -0400, Sean Paul wrote: > From: Sean Paul > > a6xx_gmu_stop() already calls this function via shutdown or force_stop, > so it's not necessary to call it twice. Previously this would have > knocked the irq refcount out of sync, but now with the irqs_enabled flag

[PATCH v2 2/6] drm/msm/a6xx: Remove duplicate irq disable from remove

2019-05-23 Thread Sean Paul
From: Sean Paul a6xx_gmu_stop() already calls this function via shutdown or force_stop, so it's not necessary to call it twice. Previously this would have knocked the irq refcount out of sync, but now with the irqs_enabled flag it's just housekeeping. Changes in v2: - None Cc: Jordan Crouse Si