Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

Den 05.10.2017 05.53, skrev Meghana Madhyastha: On Tue, Oct 03, 2017 at 07:38:29PM +0200, Noralf Trønnes wrote: Den 03.10.2017 18.02, skrev Noralf Trønnes: Den 03.10.2017 16.58, skrev Noralf Trønnes: Den 02.10.2017 10.13, skrev Jani Nikula: On Mon, 02 Oct 2017, Daniel Vetter

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Tue, Oct 03, 2017 at 07:38:29PM +0200, Noralf Trønnes wrote: > > Den 03.10.2017 18.02, skrev Noralf Trønnes: > > > >Den 03.10.2017 16.58, skrev Noralf Trønnes: > >> > >>Den 02.10.2017 10.13, skrev Jani Nikula: > >>>On Mon, 02 Oct 2017, Daniel Vetter wrote: > Also adding

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

Den 03.10.2017 18.02, skrev Noralf Trønnes: Den 03.10.2017 16.58, skrev Noralf Trønnes: Den 02.10.2017 10.13, skrev Jani Nikula: On Mon, 02 Oct 2017, Daniel Vetter wrote: Also adding Jani, who looked at the backlight Kconfig mess in the past. I've even sent patches to

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

Den 03.10.2017 16.58, skrev Noralf Trønnes: Den 02.10.2017 10.13, skrev Jani Nikula: On Mon, 02 Oct 2017, Daniel Vetter wrote: Also adding Jani, who looked at the backlight Kconfig mess in the past. I've even sent patches to fix some of the dependency mess, but the problem

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

Den 02.10.2017 10.13, skrev Jani Nikula: On Mon, 02 Oct 2017, Daniel Vetter wrote: Also adding Jani, who looked at the backlight Kconfig mess in the past. I've even sent patches to fix some of the dependency mess, but the problem is social not technical. The problem is that

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Mon, 02 Oct 2017, Daniel Vetter wrote: > Also adding Jani, who looked at the backlight Kconfig mess in the past. I've even sent patches to fix some of the dependency mess, but the problem is social not technical. The problem is that people think "select" is more convenient

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Fri, Sep 29, 2017 at 05:41:04PM +0200, Noralf Trønnes wrote: > > Den 29.09.2017 16.13, skrev Meghana Madhyastha: > > On Fri, Sep 29, 2017 at 02:33:12PM +0200, Noralf Trønnes wrote: > > > Den 29.09.2017 14.20, skrev Meghana Madhyastha: > > > > On Fri, Sep 29, 2017 at 02:10:31PM +0200, Noralf

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Fri, Sep 29, 2017 at 05:41:04PM +0200, Noralf Trønnes wrote: > > Den 29.09.2017 16.13, skrev Meghana Madhyastha: > >On Fri, Sep 29, 2017 at 02:33:12PM +0200, Noralf Trønnes wrote: > >>Den 29.09.2017 14.20, skrev Meghana Madhyastha: > >>>On Fri, Sep 29, 2017 at 02:10:31PM +0200, Noralf Trønnes

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

Hi Meghana, [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.14-rc2 next-20170929] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

Den 29.09.2017 16.13, skrev Meghana Madhyastha: On Fri, Sep 29, 2017 at 02:33:12PM +0200, Noralf Trønnes wrote: Den 29.09.2017 14.20, skrev Meghana Madhyastha: On Fri, Sep 29, 2017 at 02:10:31PM +0200, Noralf Trønnes wrote: Den 29.09.2017 05.22, skrev Meghana Madhyastha: On Thu, Sep 28,

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Fri, Sep 29, 2017 at 02:33:12PM +0200, Noralf Trønnes wrote: > > Den 29.09.2017 14.20, skrev Meghana Madhyastha: > >On Fri, Sep 29, 2017 at 02:10:31PM +0200, Noralf Trønnes wrote: > >>Den 29.09.2017 05.22, skrev Meghana Madhyastha: > >>>On Thu, Sep 28, 2017 at 06:02:27PM +0200, Noralf Trønnes

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

Den 29.09.2017 14.20, skrev Meghana Madhyastha: On Fri, Sep 29, 2017 at 02:10:31PM +0200, Noralf Trønnes wrote: Den 29.09.2017 05.22, skrev Meghana Madhyastha: On Thu, Sep 28, 2017 at 06:02:27PM +0200, Noralf Trønnes wrote: Den 28.09.2017 16.08, skrev Daniel Vetter: On Thu, Sep 28, 2017 at

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Fri, Sep 29, 2017 at 02:10:31PM +0200, Noralf Trønnes wrote: > > Den 29.09.2017 05.22, skrev Meghana Madhyastha: > >On Thu, Sep 28, 2017 at 06:02:27PM +0200, Noralf Trønnes wrote: > >>Den 28.09.2017 16.08, skrev Daniel Vetter: > >>>On Thu, Sep 28, 2017 at 02:44:34PM +0530, Meghana Madhyastha

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

Den 29.09.2017 05.22, skrev Meghana Madhyastha: On Thu, Sep 28, 2017 at 06:02:27PM +0200, Noralf Trønnes wrote: Den 28.09.2017 16.08, skrev Daniel Vetter: On Thu, Sep 28, 2017 at 02:44:34PM +0530, Meghana Madhyastha wrote: Rename tinydrm_of_find_backlight to drm_of_find_backlight and move it

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Thu, Sep 28, 2017 at 06:02:27PM +0200, Noralf Trønnes wrote: > > Den 28.09.2017 16.08, skrev Daniel Vetter: > > On Thu, Sep 28, 2017 at 02:44:34PM +0530, Meghana Madhyastha wrote: > > > Rename tinydrm_of_find_backlight to drm_of_find_backlight > > > and move it into drm_of.c from

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Thu, Sep 28, 2017 at 06:02:27PM +0200, Noralf Trønnes wrote: > > Den 28.09.2017 16.08, skrev Daniel Vetter: > >On Thu, Sep 28, 2017 at 02:44:34PM +0530, Meghana Madhyastha wrote: > >>Rename tinydrm_of_find_backlight to drm_of_find_backlight > >>and move it into drm_of.c from tinydrm-helpers.c.

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

Den 28.09.2017 16.08, skrev Daniel Vetter: On Thu, Sep 28, 2017 at 02:44:34PM +0530, Meghana Madhyastha wrote: Rename tinydrm_of_find_backlight to drm_of_find_backlight and move it into drm_of.c from tinydrm-helpers.c. This is because other drivers in the drm subsystem might need to call this

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Thu, Sep 28, 2017 at 02:44:34PM +0530, Meghana Madhyastha wrote: > Rename tinydrm_of_find_backlight to drm_of_find_backlight > and move it into drm_of.c from tinydrm-helpers.c. This is > because other drivers in the drm subsystem might need to call > this function. In that case and otherwise,

[PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

Rename tinydrm_of_find_backlight to drm_of_find_backlight and move it into drm_of.c from tinydrm-helpers.c. This is because other drivers in the drm subsystem might need to call this function. In that case and otherwise, it is better from an organizational point of view to move it into drm_of.c