Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Tue, Dec 05, 2017 at 03:01:42PM -0800, Laura Abbott wrote: > On 12/02/2017 07:53 AM, Greg KH wrote: > > > This is one of the item in the TODO list before been able to unstage ION > > > which is my real need. > > Why does it matter where in the tree this code is? Don't go adding new > > things

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On 12/02/2017 07:53 AM, Greg KH wrote: This is one of the item in the TODO list before been able to unstage ION which is my real need. Why does it matter where in the tree this code is? Don't go adding new things to it that are not needed. Who needs this? What userspace code wants this type

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Wed, Nov 29, 2017 at 03:00:56PM +0100, Benjamin Gaignard wrote: > 2017-11-28 14:32 GMT+01:00 Greg KH : > > On Mon, Nov 06, 2017 at 04:59:45PM +0100, Benjamin Gaignard wrote: > >> Instead a getting only one common device "/dev/ion" for > >> all the heaps this patch

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-28 14:32 GMT+01:00 Greg KH : > On Mon, Nov 06, 2017 at 04:59:45PM +0100, Benjamin Gaignard wrote: >> Instead a getting only one common device "/dev/ion" for >> all the heaps this patch allow to create one device >> entry ("/dev/ionX") per heap. >> Getting an

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Tue, Nov 28, 2017 at 05:37:53PM +, Mark Brown wrote: > On Tue, Nov 28, 2017 at 06:28:38PM +0100, Greg KH wrote: > > On Tue, Nov 28, 2017 at 05:12:23PM +, Mark Brown wrote: > > > > I think it's reasonable to ask for userspace, I'm querying why it needs > > > to specifically be Android.

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Tue, Nov 28, 2017 at 06:28:38PM +0100, Greg KH wrote: > On Tue, Nov 28, 2017 at 05:12:23PM +, Mark Brown wrote: > > I think it's reasonable to ask for userspace, I'm querying why it needs > > to specifically be Android. > Does anyone other than Android use this interface? There's plenty

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Tue, Nov 28, 2017 at 05:12:23PM +, Mark Brown wrote: > On Tue, Nov 28, 2017 at 06:08:22PM +0100, Greg KH wrote: > > On Tue, Nov 28, 2017 at 04:26:20PM +, Mark Brown wrote: > > > On Tue, Nov 28, 2017 at 02:32:17PM +0100, Greg KH wrote: > > > > > call you added? What did you do to test

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Tue, Nov 28, 2017 at 06:08:22PM +0100, Greg KH wrote: > On Tue, Nov 28, 2017 at 04:26:20PM +, Mark Brown wrote: > > On Tue, Nov 28, 2017 at 02:32:17PM +0100, Greg KH wrote: > > > call you added? What did you do to test this out? Where are the AOSP > > > patches to use this? Happen to

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Tue, Nov 28, 2017 at 04:26:20PM +, Mark Brown wrote: > On Tue, Nov 28, 2017 at 02:32:17PM +0100, Greg KH wrote: > > > Where is the documentation for the new sysfs files and the new ioctl > > Didn't see any sysfs files in there? New struct devices were created and registered. Why would

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Tue, Nov 28, 2017 at 02:32:17PM +0100, Greg KH wrote: > Where is the documentation for the new sysfs files and the new ioctl Didn't see any sysfs files in there? > call you added? What did you do to test this out? Where are the AOSP > patches to use this? Happen to have a VTS test for it?

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Mon, Nov 06, 2017 at 04:59:45PM +0100, Benjamin Gaignard wrote: > Instead a getting only one common device "/dev/ion" for > all the heaps this patch allow to create one device > entry ("/dev/ionX") per heap. > Getting an entry per heap could allow to set security rules > per heap and global

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Mon, Nov 27, 2017 at 05:12:23PM +0100, Daniel Vetter wrote: > commit model ftw, we have 400+ patches for 4.16 already merged and tested > and all ready, right when -rc1 gets tagged. Makes the merge window the > most relaxed time of all, because all the other maintainers are drowning > and wont

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Mon, Nov 27, 2017 at 12:43:57PM +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 27, 2017 at 11:46:18AM +0100, Benjamin Gaignard wrote: > > 2017-11-09 22:17 GMT+01:00 Laura Abbott : > > > On 11/06/2017 07:59 AM, Benjamin Gaignard wrote: > > >> > > >> Instead a getting only one

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Mon, Nov 27, 2017 at 11:46:18AM +0100, Benjamin Gaignard wrote: > 2017-11-09 22:17 GMT+01:00 Laura Abbott : > > On 11/06/2017 07:59 AM, Benjamin Gaignard wrote: > >> > >> Instead a getting only one common device "/dev/ion" for > >> all the heaps this patch allow to create

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-09 22:17 GMT+01:00 Laura Abbott : > On 11/06/2017 07:59 AM, Benjamin Gaignard wrote: >> >> Instead a getting only one common device "/dev/ion" for >> all the heaps this patch allow to create one device >> entry ("/dev/ionX") per heap. >> Getting an entry per heap could

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On 11/06/2017 07:59 AM, Benjamin Gaignard wrote: Instead a getting only one common device "/dev/ion" for all the heaps this patch allow to create one device entry ("/dev/ionX") per heap. Getting an entry per heap could allow to set security rules per heap and global ones for all heaps.

[PATCH v6 2/2] staging: ion: create one device entry per heap

Instead a getting only one common device "/dev/ion" for all the heaps this patch allow to create one device entry ("/dev/ionX") per heap. Getting an entry per heap could allow to set security rules per heap and global ones for all heaps. Allocation requests will be only allowed if the mask_id

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Mon, Nov 06, 2017 at 03:42:04PM +0100, Benjamin Gaignard wrote: > 2017-11-02 12:10 GMT+01:00 Mark Brown : > > On Thu, Nov 02, 2017 at 11:44:07AM +0100, Greg KH wrote: > >> On Tue, Oct 31, 2017 at 07:11:53PM +, Mark Brown wrote: > > > >> > There was a discussion a while

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-02 12:10 GMT+01:00 Mark Brown : > On Thu, Nov 02, 2017 at 11:44:07AM +0100, Greg KH wrote: >> On Tue, Oct 31, 2017 at 07:11:53PM +, Mark Brown wrote: > >> > There was a discussion a while ago in the context of I2C/SPI MFDs >> > which concluded that if you need a bus

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Thu, Nov 02, 2017 at 11:44:07AM +0100, Greg KH wrote: > On Tue, Oct 31, 2017 at 07:11:53PM +, Mark Brown wrote: > > There was a discussion a while ago in the context of I2C/SPI MFDs > > which concluded that if you need a bus and it's going to be effectively > > noop then you should just

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Tue, Oct 31, 2017 at 07:11:53PM +, Mark Brown wrote: > On Tue, Oct 31, 2017 at 12:03:35PM -0700, Laura Abbott wrote: > > > I'm not a fan of the platform bus but I have mixed feelings about > > creating a dedicated bus type. I guess if we really need a bus > > type we can do it later? > >

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On 10/31/2017 12:11 PM, Mark Brown wrote: > On Tue, Oct 31, 2017 at 12:03:35PM -0700, Laura Abbott wrote: > >> I'm not a fan of the platform bus but I have mixed feelings about >> creating a dedicated bus type. I guess if we really need a bus >> type we can do it later? > > There was a

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Tue, Oct 31, 2017 at 12:03:35PM -0700, Laura Abbott wrote: > I'm not a fan of the platform bus but I have mixed feelings about > creating a dedicated bus type. I guess if we really need a bus > type we can do it later? There was a discussion a while ago in the context of I2C/SPI MFDs which

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On 10/23/2017 08:55 AM, Benjamin Gaignard wrote: > Instead a getting only one common device "/dev/ion" for > all the heaps this patch allow to create one device > entry ("/dev/ionX") per heap. > Getting an entry per heap could allow to set security rules > per heap and global ones for all heaps. >

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Mon, Oct 23, 2017 at 05:55:37PM +0200, Benjamin Gaignard wrote: > Instead a getting only one common device "/dev/ion" for > all the heaps this patch allow to create one device > entry ("/dev/ionX") per heap. > Getting an entry per heap could allow to set security rules > per heap and global

[PATCH v6 2/2] staging: ion: create one device entry per heap

Instead a getting only one common device "/dev/ion" for all the heaps this patch allow to create one device entry ("/dev/ionX") per heap. Getting an entry per heap could allow to set security rules per heap and global ones for all heaps. Allocation requests will be only allowed if the mask_id