Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-17 Thread Jason Gunthorpe
On Thu, Apr 16, 2020 at 11:12:56AM -0400, Nicolas Pitre wrote: > On Thu, 16 Apr 2020, Arnd Bergmann wrote: > > > On Thu, Apr 16, 2020 at 12:17 PM Jani Nikula > > wrote: > > > > > > On Thu, 16 Apr 2020, Arnd Bergmann wrote: > > > > On Thu, Apr 16, 2020 at 5:25 AM Saeed Mahameed > > > > wrote:

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-17 Thread Saeed Mahameed
On Thu, 2020-04-16 at 11:52 -0300, Jason Gunthorpe wrote: > On Thu, Apr 16, 2020 at 02:38:50PM +0200, Arnd Bergmann wrote: > > On Thu, Apr 16, 2020 at 12:17 PM Jani Nikula > > wrote: > > > On Thu, 16 Apr 2020, Arnd Bergmann wrote: > > > > On Thu, Apr 16, 2020 at 5:25 AM Saeed Mahameed < > > > >

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-17 Thread Jason Gunthorpe
On Thu, Apr 16, 2020 at 05:58:31PM +0200, Arnd Bergmann wrote: > On Thu, Apr 16, 2020 at 4:52 PM Jason Gunthorpe wrote: > > On Thu, Apr 16, 2020 at 02:38:50PM +0200, Arnd Bergmann wrote: > > > On Thu, Apr 16, 2020 at 12:17 PM Jani Nikula > > > wrote: > > > > Of course, this is all just talk

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-17 Thread Jason Gunthorpe
On Thu, Apr 16, 2020 at 02:38:50PM +0200, Arnd Bergmann wrote: > On Thu, Apr 16, 2020 at 12:17 PM Jani Nikula > wrote: > > > > On Thu, 16 Apr 2020, Arnd Bergmann wrote: > > > On Thu, Apr 16, 2020 at 5:25 AM Saeed Mahameed > > > wrote: > > >> BTW how about adding a new Kconfig option to hide

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-17 Thread Nicolas Pitre
On Thu, 16 Apr 2020, Arnd Bergmann wrote: > On Thu, Apr 16, 2020 at 12:17 PM Jani Nikula > wrote: > > > > On Thu, 16 Apr 2020, Arnd Bergmann wrote: > > > On Thu, Apr 16, 2020 at 5:25 AM Saeed Mahameed > > > wrote: > > >> BTW how about adding a new Kconfig option to hide the details of > > >>

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-16 Thread Andrzej Hajda
On 16.04.2020 20:21, Jason Gunthorpe wrote: > On Thu, Apr 16, 2020 at 11:12:56AM -0400, Nicolas Pitre wrote: >> On Thu, 16 Apr 2020, Arnd Bergmann wrote: >> >>> On Thu, Apr 16, 2020 at 12:17 PM Jani Nikula >>> wrote: On Thu, 16 Apr 2020, Arnd Bergmann wrote: > On Thu, Apr 16, 2020 at

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-16 Thread Arnd Bergmann
On Thu, Apr 16, 2020 at 4:52 PM Jason Gunthorpe wrote: > On Thu, Apr 16, 2020 at 02:38:50PM +0200, Arnd Bergmann wrote: > > On Thu, Apr 16, 2020 at 12:17 PM Jani Nikula > > wrote: > > > Of course, this is all just talk until someone(tm) posts a patch > > > actually making the change. I've

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-16 Thread Arnd Bergmann
On Thu, Apr 16, 2020 at 12:17 PM Jani Nikula wrote: > > On Thu, 16 Apr 2020, Arnd Bergmann wrote: > > On Thu, Apr 16, 2020 at 5:25 AM Saeed Mahameed wrote: > >> BTW how about adding a new Kconfig option to hide the details of > >> ( BAR || !BAR) ? as Jason already explained and suggested, this

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-16 Thread Jani Nikula
On Thu, 16 Apr 2020, Arnd Bergmann wrote: > On Thu, Apr 16, 2020 at 5:25 AM Saeed Mahameed wrote: >> BTW how about adding a new Kconfig option to hide the details of >> ( BAR || !BAR) ? as Jason already explained and suggested, this will >> make it easier for the users and developers to

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-16 Thread Arnd Bergmann
On Thu, Apr 16, 2020 at 5:25 AM Saeed Mahameed wrote: > > On Tue, 2020-04-14 at 20:47 +0200, Arnd Bergmann wrote: > > On Tue, Apr 14, 2020 at 7:49 PM Saeed Mahameed > > wrote: > > > On Tue, 2020-04-14 at 17:25 +0200, Arnd Bergmann wrote: > > > > On Tue, Apr 14, 2020 at 5:23 PM Jason Gunthorpe >

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-16 Thread Saeed Mahameed
On Tue, 2020-04-14 at 20:47 +0200, Arnd Bergmann wrote: > On Tue, Apr 14, 2020 at 7:49 PM Saeed Mahameed > wrote: > > On Tue, 2020-04-14 at 17:25 +0200, Arnd Bergmann wrote: > > > On Tue, Apr 14, 2020 at 5:23 PM Jason Gunthorpe > > > wrote: > > > Correct. > > > > > > > Great ! > > > > Then

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-15 Thread Saeed Mahameed
On Tue, 2020-04-14 at 17:25 +0200, Arnd Bergmann wrote: > On Tue, Apr 14, 2020 at 5:23 PM Jason Gunthorpe wrote: > > On Tue, Apr 14, 2020 at 04:27:41PM +0200, Arnd Bergmann wrote: > > > On Tue, Apr 14, 2020 at 3:29 PM Jason Gunthorpe > > > wrote: > > > > On Fri, Apr 10, 2020 at 07:04:27PM +,

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-15 Thread Jason Gunthorpe
On Fri, Apr 10, 2020 at 07:04:27PM +, Saeed Mahameed wrote: > On Fri, 2020-04-10 at 14:13 -0300, Jason Gunthorpe wrote: > > On Fri, Apr 10, 2020 at 02:40:42AM +, Saeed Mahameed wrote: > > > > > This assumes that the module using FOO has its own flag > > > representing > > > FOO which is

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-15 Thread Jason Gunthorpe
On Tue, Apr 14, 2020 at 04:27:41PM +0200, Arnd Bergmann wrote: > On Tue, Apr 14, 2020 at 3:29 PM Jason Gunthorpe wrote: > > On Fri, Apr 10, 2020 at 07:04:27PM +, Saeed Mahameed wrote: > > > On Fri, 2020-04-10 at 14:13 -0300, Jason Gunthorpe wrote: > > > > On Fri, Apr 10, 2020 at 02:40:42AM

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-14 Thread Arnd Bergmann
On Tue, Apr 14, 2020 at 7:49 PM Saeed Mahameed wrote: > On Tue, 2020-04-14 at 17:25 +0200, Arnd Bergmann wrote: > > On Tue, Apr 14, 2020 at 5:23 PM Jason Gunthorpe wrote: > > Correct. > > > > Great ! > > Then bottom line we will change mlx5/Kconfig: to > > depends on VXLAN || !VXLAN Ok > This

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-14 Thread Arnd Bergmann
On Tue, Apr 14, 2020 at 5:23 PM Jason Gunthorpe wrote: > > On Tue, Apr 14, 2020 at 04:27:41PM +0200, Arnd Bergmann wrote: > > On Tue, Apr 14, 2020 at 3:29 PM Jason Gunthorpe wrote: > > > On Fri, Apr 10, 2020 at 07:04:27PM +, Saeed Mahameed wrote: > > which in turn leads to mlx5_core.ko *not*

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-14 Thread Arnd Bergmann
On Tue, Apr 14, 2020 at 3:29 PM Jason Gunthorpe wrote: > On Fri, Apr 10, 2020 at 07:04:27PM +, Saeed Mahameed wrote: > > On Fri, 2020-04-10 at 14:13 -0300, Jason Gunthorpe wrote: > > > On Fri, Apr 10, 2020 at 02:40:42AM +, Saeed Mahameed wrote: > > > > > > > This assumes that the module

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-11 Thread Saeed Mahameed
On Fri, 2020-04-10 at 14:13 -0300, Jason Gunthorpe wrote: > On Fri, Apr 10, 2020 at 02:40:42AM +, Saeed Mahameed wrote: > > > This assumes that the module using FOO has its own flag > > representing > > FOO which is not always the case. > > > > for example in mlx5 we use VXLAN config flag

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-11 Thread Jason Gunthorpe
On Fri, Apr 10, 2020 at 02:40:42AM +, Saeed Mahameed wrote: > This assumes that the module using FOO has its own flag representing > FOO which is not always the case. > > for example in mlx5 we use VXLAN config flag directly to compile VXLAN > related files: > > mlx5/core/Makefile: > >

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-10 Thread Saeed Mahameed
On Thu, 2020-04-09 at 11:41 +0300, Jani Nikula wrote: > On Wed, 08 Apr 2020, Jason Gunthorpe wrote: > > On Wed, Apr 08, 2020 at 10:49:48PM +0200, Arnd Bergmann wrote: > > > On Wed, Apr 8, 2020 at 10:38 PM Nicolas Pitre > > > wrote: > > > > On Wed, 8 Apr 2020, Arnd Bergmann wrote: > > > > > I

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-10 Thread Geert Uytterhoeven
Hi Saeed, On Fri, Apr 10, 2020 at 4:41 AM Saeed Mahameed wrote: > On Thu, 2020-04-09 at 11:41 +0300, Jani Nikula wrote: > > For example, you have two graphics drivers, one builtin and another > > module. Then you have backlight as a module. Using IS_REACHABLE(), > > backlight would work in one

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-09 Thread Jani Nikula
On Wed, 08 Apr 2020, Jason Gunthorpe wrote: > On Wed, Apr 08, 2020 at 10:49:48PM +0200, Arnd Bergmann wrote: >> On Wed, Apr 8, 2020 at 10:38 PM Nicolas Pitre wrote: >> > On Wed, 8 Apr 2020, Arnd Bergmann wrote: >> > > I have created workarounds for the Kconfig files, which now stop using >> > >

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-09 Thread Saeed Mahameed
On Wed, 2020-04-08 at 16:38 -0400, Nicolas Pitre wrote: > On Wed, 8 Apr 2020, Arnd Bergmann wrote: > > > Hi everyone, > > > > I've just restarted doing randconfig builds on top of mainline > > Linux and > > found a couple of regressions with missing dependency from the > > recent > > change in

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-09 Thread Jason Gunthorpe
On Wed, Apr 08, 2020 at 10:49:48PM +0200, Arnd Bergmann wrote: > On Wed, Apr 8, 2020 at 10:38 PM Nicolas Pitre wrote: > > On Wed, 8 Apr 2020, Arnd Bergmann wrote: > > > I have created workarounds for the Kconfig files, which now stop using > > > imply and do something else in each case. I don't

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-09 Thread Nicolas Pitre
On Wed, 8 Apr 2020, Arnd Bergmann wrote: > On Wed, Apr 8, 2020 at 10:38 PM Nicolas Pitre wrote: > > On Wed, 8 Apr 2020, Arnd Bergmann wrote: > > > I have created workarounds for the Kconfig files, which now stop using > > > imply and do something else in each case. I don't know whether there was

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-09 Thread Nicolas Pitre
On Wed, 8 Apr 2020, Arnd Bergmann wrote: > Hi everyone, > > I've just restarted doing randconfig builds on top of mainline Linux and > found a couple of regressions with missing dependency from the recent > change in the "imply" keyword in Kconfig, presumably these two patches: > > 3a9dd3ecb207

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-08 Thread Arnd Bergmann
On Wed, Apr 8, 2020 at 10:38 PM Nicolas Pitre wrote: > On Wed, 8 Apr 2020, Arnd Bergmann wrote: > > I have created workarounds for the Kconfig files, which now stop using > > imply and do something else in each case. I don't know whether there was > > a bug in the kconfig changes that has led to

[RFC 0/6] Regressions for "imply" behavior change

2020-04-08 Thread Arnd Bergmann
Hi everyone, I've just restarted doing randconfig builds on top of mainline Linux and found a couple of regressions with missing dependency from the recent change in the "imply" keyword in Kconfig, presumably these two patches: 3a9dd3ecb207 kconfig: make 'imply' obey the direct dependency