Re: New sysfs interface for privacy screens

2019-10-23 Thread Daniel Vetter
On Tue, Oct 08, 2019 at 09:13:51AM +0300, Jani Nikula wrote: > On Mon, 07 Oct 2019, Mat King wrote: > > That makes sense; just to confirm can a property be added or removed > > after the connector is registered? > > You need to create the property before registering the drm device. You > can

Re: New sysfs interface for privacy screens

2019-10-23 Thread Rajat Jain
Hi Folks, On Mon, Oct 7, 2019 at 11:13 PM Jani Nikula wrote: > On Mon, 07 Oct 2019, Mat King wrote: > > That makes sense; just to confirm can a property be added or removed > > after the connector is registered? > > You need to create the property before registering the drm device. You > can

Re: New sysfs interface for privacy screens

2019-10-22 Thread Rajat Jain
On Tue, Oct 22, 2019 at 5:14 PM Rajat Jain wrote: > > Hi Folks, > > On Mon, Oct 7, 2019 at 11:13 PM Jani Nikula > wrote: >> >> On Mon, 07 Oct 2019, Mat King wrote: >> > That makes sense; just to confirm can a property be added or removed >> > after the connector is registered? >> >> You need

Re: New sysfs interface for privacy screens

2019-10-08 Thread Jani Nikula
On Mon, 07 Oct 2019, Mat King wrote: > That makes sense; just to confirm can a property be added or removed > after the connector is registered? You need to create the property before registering the drm device. You can attach/detach the property later, but I should think you know by the time

Re: New sysfs interface for privacy screens

2019-10-07 Thread Sean Paul
On Mon, Oct 07, 2019 at 12:31:08PM -0700, Rajat Jain wrote: > On Mon, Oct 7, 2019 at 9:19 AM Mat King wrote: > > > > On Mon, Oct 7, 2019 at 7:09 AM Sean Paul wrote: > > > > > > On Thu, Oct 3, 2019 at 3:57 PM Mat King wrote: > > > > > > > > On Thu, Oct 3, 2019 at 2:59 AM Jani Nikula > > > >

Re: New sysfs interface for privacy screens

2019-10-07 Thread Rajat Jain
On Mon, Oct 7, 2019 at 9:19 AM Mat King wrote: > > On Mon, Oct 7, 2019 at 7:09 AM Sean Paul wrote: > > > > On Thu, Oct 3, 2019 at 3:57 PM Mat King wrote: > > > > > > On Thu, Oct 3, 2019 at 2:59 AM Jani Nikula > > > wrote: > > > > > > > > On Wed, 02 Oct 2019, Mat King wrote: > > > > > On Wed,

Re: New sysfs interface for privacy screens

2019-10-07 Thread Mat King
On Mon, Oct 7, 2019 at 7:09 AM Sean Paul wrote: > > On Thu, Oct 3, 2019 at 3:57 PM Mat King wrote: > > > > On Thu, Oct 3, 2019 at 2:59 AM Jani Nikula > > wrote: > > > > > > On Wed, 02 Oct 2019, Mat King wrote: > > > > On Wed, Oct 2, 2019 at 4:46 AM Jani Nikula > > > > wrote: > > > >> > > >

Re: New sysfs interface for privacy screens

2019-10-07 Thread Sean Paul
On Thu, Oct 3, 2019 at 3:57 PM Mat King wrote: > > On Thu, Oct 3, 2019 at 2:59 AM Jani Nikula > wrote: > > > > On Wed, 02 Oct 2019, Mat King wrote: > > > On Wed, Oct 2, 2019 at 4:46 AM Jani Nikula > > > wrote: > > >> > > >> On Wed, 02 Oct 2019, Daniel Thompson wrote: > > >> > On Wed, Oct

Re: New sysfs interface for privacy screens

2019-10-07 Thread Jani Nikula
On Sun, 06 Oct 2019, Rajat Jain wrote: > Hi, > > Me and Mat are working on this together, and I had a followup to > something Mat asked earlier. > > On Thu, Oct 3, 2019 at 12:57 PM Mat King wrote: >> >> On Thu, Oct 3, 2019 at 2:59 AM Jani Nikula >> wrote: >> > >> > On Wed, 02 Oct 2019, Mat

Re: New sysfs interface for privacy screens

2019-10-06 Thread Rajat Jain
Hi, Me and Mat are working on this together, and I had a followup to something Mat asked earlier. On Thu, Oct 3, 2019 at 12:57 PM Mat King wrote: > > On Thu, Oct 3, 2019 at 2:59 AM Jani Nikula > wrote: > > > > On Wed, 02 Oct 2019, Mat King wrote: > > > On Wed, Oct 2, 2019 at 4:46 AM Jani

Re: New sysfs interface for privacy screens

2019-10-06 Thread Henrique de Moraes Holschuh
On Thu, 03 Oct 2019, Daniel Thompson wrote: > I guess... although the Thinkpad code hasn't added any standard > interfaces (no other laptop should be placing controls for a privacy > screen in /proc/acpi/ibm/... ). Maybe its not too late. As far as I am concerned, it is *not* too late. And you

Re: New sysfs interface for privacy screens

2019-10-06 Thread Jingoo Han
> On 10/6/19, 7:04 AM, Pavel Machek wrote: > > Hi! > > > > >> I have been looking into adding Linux support for electronic privacy > > > >> screens which is a feature on some new laptops which is built into the > > > >> display and allows users to turn it on instead of needing to use a > > > >>

Re: New sysfs interface for privacy screens

2019-10-06 Thread Pavel Machek
Hi! > > >> I have been looking into adding Linux support for electronic privacy > > >> screens which is a feature on some new laptops which is built into the > > >> display and allows users to turn it on instead of needing to use a > > >> physical privacy filter. In discussions with my colleagues

Re: New sysfs interface for privacy screens

2019-10-06 Thread Pavel Machek
On Wed 2019-10-02 09:46:50, Jonathan Corbet wrote: > On Tue, 1 Oct 2019 10:09:46 -0600 > Mat King wrote: > > > I have been looking into adding Linux support for electronic privacy > > screens which is a feature on some new laptops which is built into the > > display and allows users to turn it

Re: New sysfs interface for privacy screens

2019-10-06 Thread Pavel Machek
On Tue 2019-10-01 10:09:46, Mat King wrote: > Resending in plain text mode > > I have been looking into adding Linux support for electronic privacy > screens which is a feature on some new laptops which is built into the > display and allows users to turn it on instead of needing to use a >

Re: New sysfs interface for privacy screens

2019-10-03 Thread Mat King
On Thu, Oct 3, 2019 at 2:59 AM Jani Nikula wrote: > > On Wed, 02 Oct 2019, Mat King wrote: > > On Wed, Oct 2, 2019 at 4:46 AM Jani Nikula > > wrote: > >> > >> On Wed, 02 Oct 2019, Daniel Thompson wrote: > >> > On Wed, Oct 02, 2019 at 12:30:05PM +0300, Jani Nikula wrote: > >> >> On Tue, 01 Oct

Re: New sysfs interface for privacy screens

2019-10-03 Thread Daniel Thompson
On Thu, Oct 03, 2019 at 11:19:13AM +0300, Jani Nikula wrote: > On Wed, 02 Oct 2019, Jonathan Corbet wrote: > > On Tue, 1 Oct 2019 10:09:46 -0600 > > Mat King wrote: > > > >> I have been looking into adding Linux support for electronic privacy > >> screens which is a feature on some new laptops

Re: New sysfs interface for privacy screens

2019-10-03 Thread Jani Nikula
On Wed, 02 Oct 2019, Mat King wrote: > On Wed, Oct 2, 2019 at 4:46 AM Jani Nikula > wrote: >> >> On Wed, 02 Oct 2019, Daniel Thompson wrote: >> > On Wed, Oct 02, 2019 at 12:30:05PM +0300, Jani Nikula wrote: >> >> On Tue, 01 Oct 2019, Mat King wrote: >> >> > Resending in plain text mode >> >>

Re: New sysfs interface for privacy screens

2019-10-03 Thread Jani Nikula
On Wed, 02 Oct 2019, Jonathan Corbet wrote: > On Tue, 1 Oct 2019 10:09:46 -0600 > Mat King wrote: > >> I have been looking into adding Linux support for electronic privacy >> screens which is a feature on some new laptops which is built into the >> display and allows users to turn it on instead

Re: New sysfs interface for privacy screens

2019-10-02 Thread Mat King
On Wed, Oct 2, 2019 at 9:46 AM Jonathan Corbet wrote: > > On Tue, 1 Oct 2019 10:09:46 -0600 > Mat King wrote: > > > I have been looking into adding Linux support for electronic privacy > > screens which is a feature on some new laptops which is built into the > > display and allows users to turn

Re: New sysfs interface for privacy screens

2019-10-02 Thread Jonathan Corbet
On Tue, 1 Oct 2019 10:09:46 -0600 Mat King wrote: > I have been looking into adding Linux support for electronic privacy > screens which is a feature on some new laptops which is built into the > display and allows users to turn it on instead of needing to use a > physical privacy filter. In

Re: New sysfs interface for privacy screens

2019-10-02 Thread Mat King
On Wed, Oct 2, 2019 at 4:46 AM Jani Nikula wrote: > > On Wed, 02 Oct 2019, Daniel Thompson wrote: > > On Wed, Oct 02, 2019 at 12:30:05PM +0300, Jani Nikula wrote: > >> On Tue, 01 Oct 2019, Mat King wrote: > >> > Resending in plain text mode > >> > > >> > I have been looking into adding Linux

Re: New sysfs interface for privacy screens

2019-10-02 Thread Jani Nikula
On Wed, 02 Oct 2019, Daniel Thompson wrote: > On Wed, Oct 02, 2019 at 12:30:05PM +0300, Jani Nikula wrote: >> On Tue, 01 Oct 2019, Mat King wrote: >> > Resending in plain text mode >> > >> > I have been looking into adding Linux support for electronic privacy >> > screens which is a feature on

Re: New sysfs interface for privacy screens

2019-10-02 Thread Daniel Thompson
On Wed, Oct 02, 2019 at 12:30:05PM +0300, Jani Nikula wrote: > On Tue, 01 Oct 2019, Mat King wrote: > > Resending in plain text mode > > > > I have been looking into adding Linux support for electronic privacy > > screens which is a feature on some new laptops which is built into the > > display

Re: New sysfs interface for privacy screens

2019-10-02 Thread Jani Nikula
On Tue, 01 Oct 2019, Mat King wrote: > Resending in plain text mode > > I have been looking into adding Linux support for electronic privacy > screens which is a feature on some new laptops which is built into the > display and allows users to turn it on instead of needing to use a > physical

Re: New sysfs interface for privacy screens

2019-10-02 Thread Mat King
On Tue, Oct 1, 2019 at 10:27 AM Greg KH wrote: > > On Tue, Oct 01, 2019 at 10:09:46AM -0600, Mat King wrote: > > Resending in plain text mode > > > > I have been looking into adding Linux support for electronic privacy > > screens which is a feature on some new laptops which is built into the > >

Re: New sysfs interface for privacy screens

2019-10-01 Thread Greg KH
On Tue, Oct 01, 2019 at 10:09:46AM -0600, Mat King wrote: > Resending in plain text mode > > I have been looking into adding Linux support for electronic privacy > screens which is a feature on some new laptops which is built into the > display and allows users to turn it on instead of needing to

New sysfs interface for privacy screens

2019-10-01 Thread Mat King
Resending in plain text mode I have been looking into adding Linux support for electronic privacy screens which is a feature on some new laptops which is built into the display and allows users to turn it on instead of needing to use a physical privacy filter. In discussions with my colleagues