Re: OLED panel brightness support

2019-07-30 Thread Kai-Heng Feng
at 16:26, Jani Nikula wrote: On Tue, 23 Jul 2019, Kai-Heng Feng wrote: Hi, Currently, OLED panel brightness [1] is not supported. As a general statement this is not true, and not backed up by the referenced bug. We just don't know how brightness is controlled on that particular laptop,

Re: OLED panel brightness support

2019-07-29 Thread Jani Nikula
On Mon, 29 Jul 2019, Kai-Heng Feng wrote: > at 16:26, Jani Nikula wrote: > >> On Tue, 23 Jul 2019, Kai-Heng Feng wrote: >>> Hi, >>> >>> Currently, OLED panel brightness [1] is not supported. >> >> As a general statement this is not true, and not backed up by the >> referenced bug. We just don't

Re: OLED panel brightness support

2019-07-29 Thread Jani Nikula
On Thu, 25 Jul 2019, Daniel Vetter wrote: > On Thu, Jul 25, 2019 at 03:35:40PM +0800, Kai-Heng Feng wrote: >> The next question is, how do we change the brightness level for OLED >> displays? Is changing gamma value a good way to do it? > > There's no overall amplifier knob to set general

Re: OLED panel brightness support

2019-07-29 Thread Jani Nikula
On Tue, 23 Jul 2019, Kai-Heng Feng wrote: > Hi, > > Currently, OLED panel brightness [1] is not supported. As a general statement this is not true, and not backed up by the referenced bug. We just don't know how brightness is controlled on that particular laptop, because it apparently uses a

Re: OLED panel brightness support

2019-07-26 Thread Kai-Heng Feng
at 00:03, wrote: -Original Message- From: Daniel Vetter On Behalf Of Daniel Vetter Sent: Wednesday, July 24, 2019 6:49 AM To: Kai-Heng Feng Cc: dri-devel@lists.freedesktop.org; Anthony Wong; Limonciello, Mario Subject: Re: OLED panel brightness support [EXTERNAL EMAIL] On Tue, Jul

Re: OLED panel brightness support

2019-07-25 Thread Sam Ravnborg
Hi Daniel. > > > > Hmm... browsing backlight code I see that FB_EARLY_EVENT_BLANK and > > FB_R_EARLY_EVENT_BLANK > > are not used - time to delete some code... > > 5.3-rc1 has patches from me to fix that, it's gone already. These two > events are gone from the backlight code. They're still used

Re: OLED panel brightness support

2019-07-25 Thread Daniel Vetter
On Thu, Jul 25, 2019 at 3:12 PM Sam Ravnborg wrote: > > Hi Daniel. > > > > > > The next question is, how do we change the brightness level for OLED > > > displays? Is changing gamma value a good way to do it? > > > > There's no overall amplifier knob to set general brightness on these? > > I just

Re: OLED panel brightness support

2019-07-25 Thread Sam Ravnborg
Hi Daniel. > > > The next question is, how do we change the brightness level for OLED > > displays? Is changing gamma value a good way to do it? > > There's no overall amplifier knob to set general brightness on these? I just looked up two random OLED controllers. They have a "Contrast" -

Re: OLED panel brightness support

2019-07-25 Thread Daniel Vetter
; Cc: dri-devel@lists.freedesktop.org; Anthony Wong; Limonciello, Mario > > > Subject: Re: OLED panel brightness support > > > > > > > > > [EXTERNAL EMAIL] > > > > > > On Tue, Jul 23, 2019 at 06:46:55PM +0800, Kai-Heng Feng wrote: > >

Re: OLED panel brightness support

2019-07-24 Thread Daniel Vetter
On Tue, Jul 23, 2019 at 06:46:55PM +0800, Kai-Heng Feng wrote: > Hi, > > Currently, OLED panel brightness [1] is not supported. > We have a similar Dell system that also affect by lack of OLED brightness > support. > > I’ve investigated both kernel and user space but I haven’t found a good >

OLED panel brightness support

2019-07-23 Thread Kai-Heng Feng
Hi, Currently, OLED panel brightness [1] is not supported. We have a similar Dell system that also affect by lack of OLED brightness support. I’ve investigated both kernel and user space but I haven’t found a good general solution yet. Dell systems use EDID descriptor 4 as Dell specific