...@vger.kernel.org; yanmin_zh...@linux.intel.com; He, Bo
Subject: Re: [PATCH V3] drm_crtc: check if fb_create return NULL
Ah, sorry, never mind, I missed Daniel's comment. The benefit of the
BUG_ON() is making it clear what's expected of the drivers.
Reviewed-by: Jani Nikula jani.nik...@intel.com
Do you think
-Original Message-
From: Jani Nikula [mailto:jani.nik...@linux.intel.com]
Sent: Thursday, January 24, 2013 5:05 PM
To: Su, Xuemin
Cc: airl...@linux.ie; dri-devel@lists.freedesktop.org;
linux-ker...@vger.kernel.org; yanmin_zh...@linux.intel.com; He, Bo
Subject: Re: [PATCH V3] drm_crtc
On Thu, 24 Jan 2013, Su, Xuemin xuemin...@intel.com wrote:
On Thu, 2013-01-24 at 10:31 +0200, Jani Nikula wrote:
}
+ /* some buggy driver may return NULL here, which may cause panic */
+ BUG_ON(!fb);
I fail to see the benefit of this compared to just letting it oops...
On Thu, 2013-01-24 at 10:31 +0200, Jani Nikula wrote:
}
+ /* some buggy driver may return NULL here, which may cause panic */
+ BUG_ON(!fb);
I fail to see the benefit of this compared to just letting it oops...
or-fb_id = fb-base.id;
...right here.
For PATCH V3, I
