Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

2021-11-17 Thread jim . cromie
On Mon, Nov 15, 2021 at 12:40 PM Claudio Suarez wrote: > > On Mon, Nov 15, 2021 at 12:24:26PM +0200, Jani Nikula wrote: > > On Sun, 14 Nov 2021, Claudio Suarez wrote: > > > On Sat, Nov 13, 2021 at 09:39:46PM +0100, Sam Ravnborg wrote: > > >> Hi Claudio, > > >> > > >> On Sat, Nov 13, 2021 at

Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

2021-11-16 Thread Claudio Suarez
On Mon, Nov 15, 2021 at 10:17:58PM +0200, Jani Nikula wrote: > On Mon, 15 Nov 2021, Claudio Suarez wrote: > > On Mon, Nov 15, 2021 at 12:24:26PM +0200, Jani Nikula wrote: > >> On Sun, 14 Nov 2021, Claudio Suarez wrote: > >> > On Sat, Nov 13, 2021 at 09:39:46PM +0100, Sam Ravnborg wrote: > >> >>

Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

2021-11-15 Thread Jani Nikula
On Mon, 15 Nov 2021, Claudio Suarez wrote: > On Mon, Nov 15, 2021 at 12:24:26PM +0200, Jani Nikula wrote: >> On Sun, 14 Nov 2021, Claudio Suarez wrote: >> > On Sat, Nov 13, 2021 at 09:39:46PM +0100, Sam Ravnborg wrote: >> >> Hi Claudio, >> >> >> >> On Sat, Nov 13, 2021 at 08:27:30PM +0100,

Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

2021-11-15 Thread Claudio Suarez
On Mon, Nov 15, 2021 at 12:24:26PM +0200, Jani Nikula wrote: > On Sun, 14 Nov 2021, Claudio Suarez wrote: > > On Sat, Nov 13, 2021 at 09:39:46PM +0100, Sam Ravnborg wrote: > >> Hi Claudio, > >> > >> On Sat, Nov 13, 2021 at 08:27:30PM +0100, Claudio Suarez wrote: > >> > The prefered way to log

Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

2021-11-15 Thread Claudio Suarez
On Mon, Nov 15, 2021 at 12:22:08PM +0200, Jani Nikula wrote: > On Sat, 13 Nov 2021, Claudio Suarez wrote: > > The prefered way to log connectors is [CONNECTOR:id:name]. Change it in > > drm core programs. > > > > Suggested-by: Ville Syrjälä > > Signed-off-by: Claudio Suarez > > --- > >

Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

2021-11-15 Thread Jani Nikula
On Mon, 15 Nov 2021, Simon Ser wrote: > On Monday, November 15th, 2021 at 11:22, Jani Nikula > wrote: > >> - Adding drm_dbg_connector() which would take drm_connector as context, >> and do drm_dbg_kms() with the above prefix. > > This wouldn't work great in case multiple connectors/planes/etc

Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

2021-11-15 Thread Simon Ser
On Monday, November 15th, 2021 at 11:22, Jani Nikula wrote: > - Adding drm_dbg_connector() which would take drm_connector as context, > and do drm_dbg_kms() with the above prefix. This wouldn't work great in case multiple connectors/planes/etc are involved, or when drm_dbg_atomic() is used.

Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

2021-11-15 Thread Jani Nikula
On Sun, 14 Nov 2021, Claudio Suarez wrote: > On Sat, Nov 13, 2021 at 09:39:46PM +0100, Sam Ravnborg wrote: >> Hi Claudio, >> >> On Sat, Nov 13, 2021 at 08:27:30PM +0100, Claudio Suarez wrote: >> > The prefered way to log connectors is [CONNECTOR:id:name]. Change it in >> > drm core programs. >>

Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

2021-11-15 Thread Jani Nikula
On Sat, 13 Nov 2021, Claudio Suarez wrote: > The prefered way to log connectors is [CONNECTOR:id:name]. Change it in > drm core programs. > > Suggested-by: Ville Syrjälä > Signed-off-by: Claudio Suarez > --- > drivers/gpu/drm/drm_client_modeset.c | 51 ++-- >

Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

2021-11-14 Thread Claudio Suarez
On Sat, Nov 13, 2021 at 09:39:46PM +0100, Sam Ravnborg wrote: > Hi Claudio, > > On Sat, Nov 13, 2021 at 08:27:30PM +0100, Claudio Suarez wrote: > > The prefered way to log connectors is [CONNECTOR:id:name]. Change it in > > drm core programs. > > > > Suggested-by: Ville Syrjälä > >

Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

2021-11-14 Thread Claudio Suarez
On Sat, Nov 13, 2021 at 08:27:30PM +0100, Claudio Suarez wrote: > The prefered way to log connectors is [CONNECTOR:id:name]. Change it in > drm core programs. > > Suggested-by: Ville Syrjälä > Signed-off-by: Claudio Suarez > --- > drivers/gpu/drm/drm_client_modeset.c | 51

Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

2021-11-14 Thread Claudio Suarez
+CC: Ville Syrjälä +CC: Daniel Vetter On Sat, Nov 13, 2021 at 08:27:30PM +0100, Claudio Suarez wrote: > The prefered way to log connectors is [CONNECTOR:id:name]. Change it in > drm core programs. > > Suggested-by: Ville Syrjälä > Signed-off-by: Claudio Suarez > --- >

Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

2021-11-13 Thread Sam Ravnborg
Hi Claudio, On Sat, Nov 13, 2021 at 08:27:30PM +0100, Claudio Suarez wrote: > The prefered way to log connectors is [CONNECTOR:id:name]. Change it in > drm core programs. > > Suggested-by: Ville Syrjälä > Signed-off-by: Claudio Suarez While touching all these logging calls, could you convernt