Re: How should "max bpc" KMS property work?

2022-05-31 Thread Ville Syrjälä
On Wed, May 25, 2022 at 01:36:47PM +0300, Pekka Paalanen wrote: > On Wed, 25 May 2022 09:23:51 + > Simon Ser wrote: > > > On Wednesday, May 25th, 2022 at 10:35, Michel Dänzer > > wrote: > > > > > > Mind that "max bpc" is always in auto. It's only an upper limit, with > > > > the

Re: How should "max bpc" KMS property work?

2022-05-30 Thread Jani Nikula
On Wed, 25 May 2022, Pekka Paalanen wrote: > Use two separate KMS properties for reporting current vs. > programming desired. The KMS property reporting the current value > must be read-only (immutable). This preserves the difference between > what userspace wanted and what it got, making it

Re: How should "max bpc" KMS property work?

2022-05-25 Thread Pekka Paalanen
On Wed, 25 May 2022 09:23:51 + Simon Ser wrote: > On Wednesday, May 25th, 2022 at 10:35, Michel Dänzer > wrote: > > > > Mind that "max bpc" is always in auto. It's only an upper limit, with > > > the assumption that the driver can choose less. > > > > It seems to me like the "max bpc"

Re: How should "max bpc" KMS property work?

2022-05-25 Thread Simon Ser
On Wednesday, May 25th, 2022 at 10:35, Michel Dänzer wrote: > > Mind that "max bpc" is always in auto. It's only an upper limit, with > > the assumption that the driver can choose less. > > It seems to me like the "max bpc" property is just kind of bad API, > and trying to tweak it to cater to

Re: How should "max bpc" KMS property work?

2022-05-25 Thread Michel Dänzer
On 2022-05-25 00:03, Alex Deucher wrote: > On Tue, May 24, 2022 at 11:43 AM Ville Syrjälä > wrote: >> On Tue, May 24, 2022 at 11:36:22AM +0200, Hans de Goede wrote: >>> Hi, >>> On 5/23/22 13:54, Sebastian Wick wrote: On Mon, May 23, 2022 at 10:23 AM Pekka Paalanen wrote: > >

Re: How should "max bpc" KMS property work?

2022-05-25 Thread Pekka Paalanen
On Mon, 23 May 2022 13:54:50 +0200 Sebastian Wick wrote: > I was always under the impression that if you do an atomic commit > without changing any properties that it won't result in a mode set > which would clearly make the current behavior a bug. This is a very good point. If one does an

Re: How should "max bpc" KMS property work?

2022-05-25 Thread Pekka Paalanen
On Wed, 25 May 2022 06:04:44 + Simon Ser wrote: > On Wednesday, May 25th, 2022 at 00:03, Alex Deucher > wrote: > > > > Why would anyone want to run at 8bpc when they have a panel with > > > higher color depth? So I think someone is going to be doing that > > > modeset eventually anyway.

Re: How should "max bpc" KMS property work?

2022-05-25 Thread Simon Ser
On Wednesday, May 25th, 2022 at 00:03, Alex Deucher wrote: > > Why would anyone want to run at 8bpc when they have a panel with > > higher color depth? So I think someone is going to be doing that > > modeset eventually anyway. > > We used to do something similar, but then got piles of bug

Re: How should "max bpc" KMS property work?

2022-05-24 Thread Alex Deucher
On Tue, May 24, 2022 at 11:43 AM Ville Syrjälä wrote: > > On Tue, May 24, 2022 at 11:36:22AM +0200, Hans de Goede wrote: > > Hi, > > > > On 5/23/22 13:54, Sebastian Wick wrote: > > > On Mon, May 23, 2022 at 10:23 AM Pekka Paalanen > > > wrote: > > >> > > >> On Fri, 20 May 2022 17:20:50 +0200 >

Re: How should "max bpc" KMS property work?

2022-05-24 Thread Ville Syrjälä
On Tue, May 24, 2022 at 11:36:22AM +0200, Hans de Goede wrote: > Hi, > > On 5/23/22 13:54, Sebastian Wick wrote: > > On Mon, May 23, 2022 at 10:23 AM Pekka Paalanen wrote: > >> > >> On Fri, 20 May 2022 17:20:50 +0200 > >> Hans de Goede wrote: > >> > >>> I got pointed to this thread by Jonas

Re: How should "max bpc" KMS property work?

2022-05-24 Thread Hans de Goede
Hi, On 5/23/22 13:54, Sebastian Wick wrote: > On Mon, May 23, 2022 at 10:23 AM Pekka Paalanen wrote: >> >> On Fri, 20 May 2022 17:20:50 +0200 >> Hans de Goede wrote: >> >>> I got pointed to this thread by Jonas Ådahl while asking some questions >>> the "max bpc" property related to: >>> >>>

Re: How should "max bpc" KMS property work?

2022-05-23 Thread Sebastian Wick
On Mon, May 23, 2022 at 10:23 AM Pekka Paalanen wrote: > > On Fri, 20 May 2022 17:20:50 +0200 > Hans de Goede wrote: > > > I got pointed to this thread by Jonas Ådahl while asking some questions > > the "max bpc" property related to: > > > >

Re: How should "max bpc" KMS property work?

2022-05-23 Thread Pekka Paalanen
On Fri, 20 May 2022 17:20:50 +0200 Hans de Goede wrote: > I got pointed to this thread by Jonas Ådahl while asking some questions > the "max bpc" property related to: > > https://gitlab.freedesktop.org/plymouth/plymouth/-/issues/102#note_1382328 > > The current i915 behavior which you describe

Re: How should "max bpc" KMS property work?

2022-05-20 Thread Hans de Goede
Hi, On 4/26/22 19:55, Ville Syrjälä wrote: > On Tue, Apr 26, 2022 at 11:35:02AM +0300, Pekka Paalanen wrote: >> Hi all, >> >> I'm working on setting HDR & WCG video modes in Weston, and I thought >> setting "max bpc" KMS property on the connector would be a good idea. >> I'm confused about how it

Re: How should "max bpc" KMS property work?

2022-04-28 Thread Sebastian Wick
On Thu, Apr 28, 2022 at 4:50 PM Ville Syrjälä wrote: > > On Thu, Apr 28, 2022 at 07:52:58AM +, Simon Ser wrote: > > On Thursday, April 28th, 2022 at 09:50, Pekka Paalanen > > wrote: > > > > > > > > Also like Alex said, the kernel does not know if the user prefers > > > > > > high > > > > >

Re: How should "max bpc" KMS property work?

2022-04-28 Thread Ville Syrjälä
On Thu, Apr 28, 2022 at 07:52:58AM +, Simon Ser wrote: > On Thursday, April 28th, 2022 at 09:50, Pekka Paalanen > wrote: > > > > > > Also like Alex said, the kernel does not know if the user prefers high > > > > > color depth or high refresh rate either. One way to solve that is to > > > >

Re: How should "max bpc" KMS property work?

2022-04-28 Thread Simon Ser
On Thursday, April 28th, 2022 at 09:50, Pekka Paalanen wrote: > > > > Also like Alex said, the kernel does not know if the user prefers high > > > > color depth or high refresh rate either. One way to solve that is to > > > > light up the requested video mode any way the kernel can, and then >

Re: How should "max bpc" KMS property work?

2022-04-28 Thread Pekka Paalanen
On Wed, 27 Apr 2022 23:29:02 +0200 Sebastian Wick wrote: > On Wed, Apr 27, 2022 at 5:41 PM Harry Wentland wrote: > > > > > > > > On 2022-04-27 06:52, Pekka Paalanen wrote: > > > Hi Ville and Alex, > > > > > > thanks for the replies. More below. > > > > > > TL;DR: > > > > > > My take-away from

Re: How should "max bpc" KMS property work?

2022-04-27 Thread Sebastian Wick
On Wed, Apr 27, 2022 at 5:41 PM Harry Wentland wrote: > > > > On 2022-04-27 06:52, Pekka Paalanen wrote: > > Hi Ville and Alex, > > > > thanks for the replies. More below. > > > > TL;DR: > > > > My take-away from this is that I should slam 'max bpc' to the max by > > default, and offer a knob for

Re: How should "max bpc" KMS property work?

2022-04-27 Thread Harry Wentland
On 2022-04-27 06:52, Pekka Paalanen wrote: > Hi Ville and Alex, > > thanks for the replies. More below. > > TL;DR: > > My take-away from this is that I should slam 'max bpc' to the max by > default, and offer a knob for the user in case they want to lower it. > > > On Tue, 26 Apr 2022

Re: How should "max bpc" KMS property work?

2022-04-27 Thread Pekka Paalanen
Hi Ville and Alex, thanks for the replies. More below. TL;DR: My take-away from this is that I should slam 'max bpc' to the max by default, and offer a knob for the user in case they want to lower it. On Tue, 26 Apr 2022 20:55:14 +0300 Ville Syrjälä wrote: > On Tue, Apr 26, 2022 at

Re: How should "max bpc" KMS property work?

2022-04-26 Thread Ville Syrjälä
On Tue, Apr 26, 2022 at 03:38:25PM -0400, Alex Deucher wrote: > On Tue, Apr 26, 2022 at 4:35 AM Pekka Paalanen wrote: > > > > Hi all, > > > > I'm working on setting HDR & WCG video modes in Weston, and I thought > > setting "max bpc" KMS property on the connector would be a good idea. > > I'm

Re: How should "max bpc" KMS property work?

2022-04-26 Thread Alex Deucher
On Tue, Apr 26, 2022 at 4:35 AM Pekka Paalanen wrote: > > Hi all, > > I'm working on setting HDR & WCG video modes in Weston, and I thought > setting "max bpc" KMS property on the connector would be a good idea. > I'm confused about how it works though. > > I did some digging in >

Re: How should "max bpc" KMS property work?

2022-04-26 Thread Ville Syrjälä
On Tue, Apr 26, 2022 at 11:35:02AM +0300, Pekka Paalanen wrote: > Hi all, > > I'm working on setting HDR & WCG video modes in Weston, and I thought > setting "max bpc" KMS property on the connector would be a good idea. > I'm confused about how it works though. > > I did some digging in >